[GitHub] incubator-quickstep pull request #19: Improve text scan operator

2016-06-09 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/19 Improve text scan operator This PR updates the `TextScanOperator` to improve its performance. There are three main changes: (1) Pass `text_offset` and `text_segment_size

[GitHub] incubator-quickstep pull request #19: Improve text scan operator

2016-06-09 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/19#discussion_r66470811 --- Diff: relational_operators/TextScanOperator.cpp --- @@ -155,116 +63,50 @@ bool TextScanOperator::getAllWorkOrders( InsertDestination

[GitHub] incubator-quickstep pull request #18: Fix a potential segfault in Compressed...

2016-06-09 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/18 Fix a potential segfault in CompressedBlockBuilder This PR fixes a potential bug in `CompressedBlockBuilder`. This fix is necessary for a subsequent PR on `TextScanOperator` where each

[GitHub] incubator-quickstep issue #35: QUICKSTEP-20: Added Parser support for SQL Wi...

2016-06-17 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/35 LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #35: QUICKSTEP-20: Added Parser support for...

2016-06-17 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/35#discussion_r67582107 --- Diff: parser/SqlParser.ypp --- @@ -1332,6 +1369,83 @@ opt_limit_clause: } } +opt_window_clause

[GitHub] incubator-quickstep issue #34: Bug fixed in \analyze command and reuse code.

2016-06-15 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/34 LGTM! Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #40: Minor Change: Added move constructor i...

2016-06-27 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/40#discussion_r68642507 --- Diff: query_optimizer/logical/Sort.hpp --- @@ -137,6 +150,19 @@ class Sort : public Logical { addChild(input_

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

2016-08-03 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73290304 --- Diff: query_optimizer/rules/BottomUpRule.hpp --- @@ -80,6 +81,14 @@ class BottomUpRule : public Rule { */ virtual TreeNodePtr

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

2016-08-01 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73078969 --- Diff: query_optimizer/rules/SwapProbeBuild.cpp --- @@ -0,0 +1,72 @@ +#include "query_optimizer/rules/SwapProbeBuil

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

2016-08-01 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73078148 --- Diff: query_optimizer/physical/HashJoin.hpp --- @@ -172,18 +192,21 @@ class HashJoin : public BinaryJoin { const std::vector

[GitHub] incubator-quickstep issue #76: Visualize execution plan DAGs annotated with ...

2016-08-03 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/76 Thanks Harshad! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #76: Visualize execution plan DAGs annotate...

2016-08-03 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/76 Visualize execution plan DAGs annotated with profiling stats This PR adds support for visualization of execution plan DAGs. Each relational operator in the DAG is also annotated

[GitHub] incubator-quickstep issue #74: Removed the redundant query id in the optimiz...

2016-08-03 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/74 This change looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-quickstep pull request #51: Minor changes in profiling work order ...

2016-07-06 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/51#discussion_r69846306 --- Diff: query_execution/Foreman.cpp --- @@ -238,16 +238,17 @@ void Foreman::printWorkOrderProfilingResults(const std::size_t query_id

[GitHub] incubator-quickstep issue #51: Minor changes in profiling work order output.

2016-07-06 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/51 LGTM except for one minor typo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-quickstep issue #79: Constructed Generators once in the optimizer.

2016-08-04 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/79 @zuyu The `Generator`'s can be stateless (need some refactoring), but each query should have its own `OptimizerContext`. --- If your project is set up for it, you can reply

[GitHub] incubator-quickstep issue #81: Refactored QueryProcessor.

2016-08-06 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/81 LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

2016-08-02 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73208331 --- Diff: query_optimizer/rules/SwapProbeBuild.hpp --- @@ -0,0 +1,47 @@ +#ifndef QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

2016-08-02 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73204750 --- Diff: query_optimizer/rules/BottomUpRule.hpp --- @@ -80,6 +81,8 @@ class BottomUpRule : public Rule { */ virtual TreeNodePtr

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

2016-08-02 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73207435 --- Diff: query_optimizer/rules/SwapProbeBuild.cpp --- @@ -0,0 +1,64 @@ +#include "query_optimizer/rules/SwapProbeBuil

[GitHub] incubator-quickstep issue #73: Move hash join's probe and build node decisio...

2016-08-02 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/73 LGTM except for some minor places. Also fix the style check issue then we're good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

2016-08-01 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73079256 --- Diff: query_optimizer/rules/SwapProbeBuild.hpp --- @@ -0,0 +1,46 @@ +#ifndef QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_

[GitHub] incubator-quickstep pull request #95: Fix IWYU for ExecutionDAGVisualizer

2016-08-16 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/95 Fix IWYU for ExecutionDAGVisualizer This PR is to fix the IWYU issues as commented in PR #76. @zuyu You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-quickstep issue #92: Refactor Generators in Optimizer

2016-08-16 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/92 LGTM. Could you add a brief paragraph in this PR's top comment to describe the purpose of this change? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-quickstep issue #92: Refactor Generators in Optimizer

2016-08-16 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/92 Just squashed and rebased the commits. Will merge it once travis-ci returns green. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-quickstep pull request #177: Reduce the number of group-by attribu...

2017-02-02 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/177 Reduce the number of group-by attributes by pulling tables up aggregation. This PR implements an optimization (physical plan transformation) that pulls a table up an aggregation

[GitHub] incubator-quickstep pull request #:

2017-02-03 Thread jianqiao
Github user jianqiao commented on the pull request: https://github.com/apache/incubator-quickstep/commit/4f8fdbe8451aed1ad1c07a8badb5be85bee1ff57#commitcomment-20738519 In relational_operators/TextScanOperator.cpp: In relational_operators/TextScanOperator.cpp on line 129: Yes

[GitHub] incubator-quickstep pull request #:

2017-02-03 Thread jianqiao
Github user jianqiao commented on the pull request: https://github.com/apache/incubator-quickstep/commit/4f8fdbe8451aed1ad1c07a8badb5be85bee1ff57#commitcomment-20738416 In relational_operators/TextScanOperator.cpp: In relational_operators/TextScanOperator.cpp on line 129: Did

[GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...

2017-01-31 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/174#discussion_r98716718 --- Diff: query_optimizer/PhysicalGenerator.cpp --- @@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan( P

[GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...

2017-01-31 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/174#discussion_r98714161 --- Diff: query_optimizer/PhysicalGenerator.cpp --- @@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan( P

[GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...

2017-01-31 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/174#discussion_r98708919 --- Diff: query_optimizer/PhysicalGenerator.cpp --- @@ -27,6 +27,7 @@ #include "query_optimizer/logical/Logical.hpp"

[GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...

2017-01-31 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/174#discussion_r98708887 --- Diff: query_optimizer/PhysicalGenerator.cpp --- @@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan( P

[GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...

2017-01-31 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/174#discussion_r98710981 --- Diff: query_optimizer/rules/PushDownLowCostDisjunctivePredicate.cpp --- @@ -0,0 +1,218 @@ +/** + * Licensed to the Apache Software

[GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...

2017-01-31 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/174#discussion_r98710964 --- Diff: query_optimizer/rules/PushDownLowCostDisjunctivePredicate.hpp --- @@ -0,0 +1,118 @@ +/** + * Licensed to the Apache Software

[GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...

2017-01-31 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/174#discussion_r98710865 --- Diff: query_optimizer/rules/PushDownLowCostDisjunctivePredicate.cpp --- @@ -0,0 +1,218 @@ +/** + * Licensed to the Apache Software

[GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...

2017-01-31 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/174#discussion_r98711958 --- Diff: query_optimizer/PhysicalGenerator.cpp --- @@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan( P

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-04 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/179 QUICKSTEP-70-71 Improve aggregation performance This PR implements two features that improve aggregation performance: 1. Adds `CollisionFreeVectorTable` to support specialized high

[GitHub] incubator-quickstep pull request #180: Fix the bug with SingleIdentityHashFi...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/180#discussion_r99859847 --- Diff: query_optimizer/rules/AttachLIPFilters.cpp --- @@ -128,7 +129,7 @@ void AttachLIPFilters::attachLIPFilters

[GitHub] incubator-quickstep pull request #177: Reduce the number of group-by attribu...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/177#discussion_r99865183 --- Diff: query_optimizer/Optimizer.cpp --- @@ -30,10 +30,11 @@ void Optimizer::generateQueryHandle(const ParseStatement _statement

[GitHub] incubator-quickstep pull request #177: Reduce the number of group-by attribu...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/177#discussion_r99865239 --- Diff: query_optimizer/rules/ReduceGroupByAttributes.cpp --- @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99867160 --- Diff: expressions/aggregation/AggregationConcreteHandle.hpp --- @@ -61,7 +61,7 @@ class HashTableStateUpserterFast { *table

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99867096 --- Diff: query_optimizer/ExecutionGenerator.cpp --- @@ -371,6 +378,109 @@ void ExecutionGenerator::dropAllTemporaryRelations

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99882605 --- Diff: query_optimizer/ExecutionGenerator.cpp --- @@ -371,6 +378,109 @@ void ExecutionGenerator::dropAllTemporaryRelations

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99883469 --- Diff: query_optimizer/ExecutionGenerator.hpp --- @@ -427,7 +445,7 @@ class ExecutionGenerator { /** * @brief The cost model

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99874032 --- Diff: query_optimizer/ExecutionGenerator.cpp --- @@ -371,6 +378,109 @@ void ExecutionGenerator::dropAllTemporaryRelations

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99882633 --- Diff: query_optimizer/ExecutionGenerator.cpp --- @@ -371,6 +378,109 @@ void ExecutionGenerator::dropAllTemporaryRelations

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99897008 --- Diff: storage/PackedPayloadHashTable.cpp --- @@ -0,0 +1,463 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99897239 --- Diff: storage/AggregationOperationState.hpp --- @@ -156,6 +152,29 @@ class AggregationOperationState { const CatalogDatabaseLite

[GitHub] incubator-quickstep issue #179: QUICKSTEP-70-71 Improve aggregation performa...

2017-02-07 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/179 For the question about `PartitionedHashTablePool` and `HashTablePool`. Note that their use patterns are different so perhaps it is not natural to merge them into one class

[GitHub] incubator-quickstep issue #179: QUICKSTEP-70-71 Improve aggregation performa...

2017-02-07 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/179 Just rebased on master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-quickstep issue #179: QUICKSTEP-70-71 Improve aggregation performa...

2017-02-07 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/179 Updated, and tested locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99914989 --- Diff: storage/AggregationOperationState.cpp --- @@ -353,187 +353,286 @@ bool AggregationOperationState::ProtoIsValid( return true

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99928307 --- Diff: storage/AggregationOperationState.cpp --- @@ -353,187 +353,286 @@ bool AggregationOperationState::ProtoIsValid( return true

[GitHub] incubator-quickstep issue #179: QUICKSTEP-70-71 Improve aggregation performa...

2017-02-07 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/179 There is a `CMakeLists` to be updated -- do not merge at this moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99927064 --- Diff: relational_operators/InitializeAggregationOperator.cpp --- @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99918342 --- Diff: storage/AggregationOperationState.hpp --- @@ -156,6 +152,29 @@ class AggregationOperationState { const CatalogDatabaseLite

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99929968 --- Diff: relational_operators/WorkOrderFactory.cpp --- @@ -186,6 +186,7 @@ WorkOrder* WorkOrderFactory::ReconstructFromProto(const

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99930761 --- Diff: storage/AggregationOperationState.cpp --- @@ -556,80 +655,83 @@ void AggregationOperationState::finalizeSingleState

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99915265 --- Diff: storage/AggregationOperationState.cpp --- @@ -353,187 +353,286 @@ bool AggregationOperationState::ProtoIsValid( return true

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99922836 --- Diff: relational_operators/InitializeAggregationOperator.cpp --- @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software

[GitHub] incubator-quickstep pull request #177: Reduce the number of group-by attribu...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/177#discussion_r99963866 --- Diff: query_optimizer/rules/ReduceGroupByAttributes.hpp --- @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] incubator-quickstep pull request #177: Reduce the number of group-by attribu...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/177#discussion_r99964422 --- Diff: query_optimizer/rules/ReduceGroupByAttributes.hpp --- @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] incubator-quickstep issue #173: Simplified the SelectOperator w/ partitions.

2017-02-02 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/173 Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-quickstep issue #179: QUICKSTEP-70-71 Improve aggregation performa...

2017-02-05 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/179 Currently there is a gflag for setting the range upbound: https://github.com/apache/incubator-quickstep/pull/179/files#diff-3d4b5df01ed8edbe255e096eefbfc342R440 --- If your

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99916086 --- Diff: storage/AggregationOperationState.cpp --- @@ -80,148 +83,145 @@ AggregationOperationState::AggregationOperationState( const

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99916031 --- Diff: storage/AggregationOperationState.cpp --- @@ -353,187 +353,286 @@ bool AggregationOperationState::ProtoIsValid( return true

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99901875 --- Diff: storage/AggregationOperationState.hpp --- @@ -156,6 +152,29 @@ class AggregationOperationState { const CatalogDatabaseLite

[GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...

2017-02-07 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/179#discussion_r99884619 --- Diff: query_optimizer/ExecutionGenerator.cpp --- @@ -1495,9 +1607,28 @@ void ExecutionGenerator::convertAggregate

[GitHub] incubator-quickstep issue #180: Fix the bug with SingleIdentityHashFilter wh...

2017-02-05 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/180 Assigned to @zuyu. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #180: Fix the bug with SingleIdentityHashFi...

2017-02-05 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/180 Fix the bug with SingleIdentityHashFilter when filter_cardinality is 0. This PR fixes the problem with `SingleIdentityHashFilter` when the estimated filter cardinality is 0

[GitHub] incubator-quickstep issue #177: Reduce the number of group-by attributes by ...

2017-02-05 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/177 This optimization is somehow different from `AggregatePushDown`. I updated the example in this PR's description. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-quickstep issue #172: QUICKSTEP-69 Query optimization with ExactFi...

2017-01-31 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/172 Comments addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...

2017-01-30 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/174 Push down disjunctive predicates to filter small-cardinality stored relation early. This PR implements an optimization (physical plan transformation) that pushes down disjunctive

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98543218 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -504,123 +616,61 @@ void HashInnerJoinWorkOrder::execute() { // hash join

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98546082 --- Diff: query_optimizer/rules/ReorderColumns.cpp --- @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98542168 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -20,6 +20,7 @@ #include "relational_operators/HashJoinOperato

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98543122 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -504,123 +616,61 @@ void HashInnerJoinWorkOrder::execute() { // hash join

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98543855 --- Diff: storage/ValueAccessor.hpp --- @@ -305,6 +305,21 @@ class ValueAccessor { const TupleIdSequence _sequence) = 0

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98544439 --- Diff: storage/ValueAccessor.hpp --- @@ -305,6 +305,21 @@ class ValueAccessor { const TupleIdSequence _sequence) = 0

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98544534 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -484,7 +565,38 @@ void HashInnerJoinWorkOrder::execute() { const relation_id

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98544852 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -484,7 +565,38 @@ void HashInnerJoinWorkOrder::execute() { const relation_id

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98545487 --- Diff: query_optimizer/PhysicalGenerator.cpp --- @@ -109,6 +114,13 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() { } else

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98542466 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -63,6 +65,9 @@ namespace quickstep { namespace { +typedef std

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98543320 --- Diff: query_optimizer/rules/ReorderColumns.hpp --- @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98541113 --- Diff: query_optimizer/rules/ReorderColumns.cpp --- @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98538859 --- Diff: query_optimizer/rules/ReorderColumns.cpp --- @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98541098 --- Diff: query_optimizer/rules/ReorderColumns.cpp --- @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98538359 --- Diff: query_optimizer/rules/ReorderColumns.cpp --- @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-30 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98541504 --- Diff: query_optimizer/rules/ReorderColumns.cpp --- @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-quickstep pull request #170: Add unit test for CatalogRelationStat...

2017-01-29 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/170 Add unit test for CatalogRelationStatistics This PR adds unit tests for CatalogRelationStatistics. It tests that the `\analyze` command can produce correct stats

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/171 QUICKSTEP-68 Reorder intermediate relations' attributes to improve copy performance. Currently, all the intermediate relations (i.e. temporary relations created during query

[GitHub] incubator-quickstep issue #170: Add unit test for CatalogRelationStatistics

2017-01-29 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/170 Assigned to @zuyu. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread jianqiao
Github user jianqiao closed the pull request at: https://github.com/apache/incubator-quickstep/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-quickstep pull request #172: Query optimization with ExactFilter

2017-01-29 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/172 Query optimization with ExactFilter This is a follow-up optimization based on the facility provided by LIPFilters. Note that LIP (lookahead information passing) is an optimization

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread jianqiao
GitHub user jianqiao reopened a pull request: https://github.com/apache/incubator-quickstep/pull/171 QUICKSTEP-68 Reorder intermediate relations' attributes to improve copy performance. Currently, all the intermediate relations (i.e. temporary relations created during query

[GitHub] incubator-quickstep pull request #170: Add unit test for CatalogRelationStat...

2017-01-29 Thread jianqiao
Github user jianqiao closed the pull request at: https://github.com/apache/incubator-quickstep/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-quickstep issue #170: Add unit test for CatalogRelationStatistics

2017-01-29 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/170 Updated. Now closing and reopening the PR to restart travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-quickstep pull request #170: Add unit test for CatalogRelationStat...

2017-01-29 Thread jianqiao
GitHub user jianqiao reopened a pull request: https://github.com/apache/incubator-quickstep/pull/170 Add unit test for CatalogRelationStatistics This PR adds unit tests for CatalogRelationStatistics. It tests that the `\analyze` command can produce correct stats

[GitHub] incubator-quickstep issue #165: Added Operator support for Partitioned HashJ...

2017-01-20 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/165 LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #165: Added Operator support for Partitione...

2017-01-20 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/165#discussion_r97168067 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -207,49 +207,43 @@ bool HashJoinOperator::getAllNonOuterJoinWorkOrders

  1   2   3   >