GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/19
Improve text scan operator
This PR updates the `TextScanOperator` to improve its performance.
There are three main changes:
(1) Pass `text_offset` and `text_segment_size
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/19#discussion_r66470811
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -155,116 +63,50 @@ bool TextScanOperator::getAllWorkOrders(
InsertDestination
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/18
Fix a potential segfault in CompressedBlockBuilder
This PR fixes a potential bug in `CompressedBlockBuilder`. This fix is
necessary for a subsequent PR on `TextScanOperator` where each
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/34
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/40#discussion_r68642507
--- Diff: query_optimizer/logical/Sort.hpp ---
@@ -137,6 +150,19 @@ class Sort : public Logical {
addChild(input_
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/73#discussion_r73290304
--- Diff: query_optimizer/rules/BottomUpRule.hpp ---
@@ -80,6 +81,14 @@ class BottomUpRule : public Rule {
*/
virtual TreeNodePtr
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/76
Thanks Harshad!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/74
This change looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/51#discussion_r69846306
--- Diff: query_execution/Foreman.cpp ---
@@ -238,16 +238,17 @@ void Foreman::printWorkOrderProfilingResults(const
std::size_t query_id
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/51
LGTM except for one minor typo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/79
@zuyu The `Generator`'s can be stateless (need some refactoring), but each
query should have its own `OptimizerContext`.
---
If your project is set up for it, you can reply
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/81
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/73#discussion_r73208331
--- Diff: query_optimizer/rules/SwapProbeBuild.hpp ---
@@ -0,0 +1,47 @@
+#ifndef QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/73#discussion_r73204750
--- Diff: query_optimizer/rules/BottomUpRule.hpp ---
@@ -80,6 +81,8 @@ class BottomUpRule : public Rule {
*/
virtual TreeNodePtr
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/73#discussion_r73207435
--- Diff: query_optimizer/rules/SwapProbeBuild.cpp ---
@@ -0,0 +1,64 @@
+#include "query_optimizer/rules/SwapProbeBuil
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/73
LGTM except for some minor places. Also fix the style check issue then
we're good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/73#discussion_r73079256
--- Diff: query_optimizer/rules/SwapProbeBuild.hpp ---
@@ -0,0 +1,46 @@
+#ifndef QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/177
Reduce the number of group-by attributes by pulling tables up aggregation.
This PR implements an optimization (physical plan transformation) that
pulls a table up an aggregation
Github user jianqiao commented on the pull request:
https://github.com/apache/incubator-quickstep/commit/4f8fdbe8451aed1ad1c07a8badb5be85bee1ff57#commitcomment-20738519
In relational_operators/TextScanOperator.cpp:
In relational_operators/TextScanOperator.cpp on line 129:
Yes
Github user jianqiao commented on the pull request:
https://github.com/apache/incubator-quickstep/commit/4f8fdbe8451aed1ad1c07a8badb5be85bee1ff57#commitcomment-20738416
In relational_operators/TextScanOperator.cpp:
In relational_operators/TextScanOperator.cpp on line 129:
Did
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/174#discussion_r98716718
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan(
P
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/174#discussion_r98714161
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan(
P
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/174#discussion_r98708919
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -27,6 +27,7 @@
#include "query_optimizer/logical/Logical.hpp"
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/174#discussion_r98708887
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan(
P
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/174#discussion_r98710981
--- Diff: query_optimizer/rules/PushDownLowCostDisjunctivePredicate.cpp ---
@@ -0,0 +1,218 @@
+/**
+ * Licensed to the Apache Software
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/174#discussion_r98710964
--- Diff: query_optimizer/rules/PushDownLowCostDisjunctivePredicate.hpp ---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/174#discussion_r98710865
--- Diff: query_optimizer/rules/PushDownLowCostDisjunctivePredicate.cpp ---
@@ -0,0 +1,218 @@
+/**
+ * Licensed to the Apache Software
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/174#discussion_r98711958
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan(
P
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/180#discussion_r99859847
--- Diff: query_optimizer/rules/AttachLIPFilters.cpp ---
@@ -128,7 +129,7 @@ void AttachLIPFilters::attachLIPFilters
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/177#discussion_r99865183
--- Diff: query_optimizer/Optimizer.cpp ---
@@ -30,10 +30,11 @@ void Optimizer::generateQueryHandle(const
ParseStatement _statement
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/177#discussion_r99865239
--- Diff: query_optimizer/rules/ReduceGroupByAttributes.cpp ---
@@ -0,0 +1,217 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99867096
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -371,6 +378,109 @@ void ExecutionGenerator::dropAllTemporaryRelations
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99882605
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -371,6 +378,109 @@ void ExecutionGenerator::dropAllTemporaryRelations
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99883469
--- Diff: query_optimizer/ExecutionGenerator.hpp ---
@@ -427,7 +445,7 @@ class ExecutionGenerator {
/**
* @brief The cost model
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99874032
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -371,6 +378,109 @@ void ExecutionGenerator::dropAllTemporaryRelations
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99882633
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -371,6 +378,109 @@ void ExecutionGenerator::dropAllTemporaryRelations
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99897008
--- Diff: storage/PackedPayloadHashTable.cpp ---
@@ -0,0 +1,463 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99897239
--- Diff: storage/AggregationOperationState.hpp ---
@@ -156,6 +152,29 @@ class AggregationOperationState {
const CatalogDatabaseLite
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/179
For the question about `PartitionedHashTablePool` and `HashTablePool`. Note
that their use patterns are different so perhaps it is not natural to merge
them into one class
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/179
Updated, and tested locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99914989
--- Diff: storage/AggregationOperationState.cpp ---
@@ -353,187 +353,286 @@ bool AggregationOperationState::ProtoIsValid(
return true
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99928307
--- Diff: storage/AggregationOperationState.cpp ---
@@ -353,187 +353,286 @@ bool AggregationOperationState::ProtoIsValid(
return true
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/179
There is a `CMakeLists` to be updated -- do not merge at this moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99918342
--- Diff: storage/AggregationOperationState.hpp ---
@@ -156,6 +152,29 @@ class AggregationOperationState {
const CatalogDatabaseLite
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99929968
--- Diff: relational_operators/WorkOrderFactory.cpp ---
@@ -186,6 +186,7 @@ WorkOrder* WorkOrderFactory::ReconstructFromProto(const
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99930761
--- Diff: storage/AggregationOperationState.cpp ---
@@ -556,80 +655,83 @@ void AggregationOperationState::finalizeSingleState
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99915265
--- Diff: storage/AggregationOperationState.cpp ---
@@ -353,187 +353,286 @@ bool AggregationOperationState::ProtoIsValid(
return true
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99922836
--- Diff: relational_operators/InitializeAggregationOperator.cpp ---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/177#discussion_r99963866
--- Diff: query_optimizer/rules/ReduceGroupByAttributes.hpp ---
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/177#discussion_r99964422
--- Diff: query_optimizer/rules/ReduceGroupByAttributes.hpp ---
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/173
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/179
Currently there is a gflag for setting the range upbound:
https://github.com/apache/incubator-quickstep/pull/179/files#diff-3d4b5df01ed8edbe255e096eefbfc342R440
---
If your
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99916031
--- Diff: storage/AggregationOperationState.cpp ---
@@ -353,187 +353,286 @@ bool AggregationOperationState::ProtoIsValid(
return true
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99901875
--- Diff: storage/AggregationOperationState.hpp ---
@@ -156,6 +152,29 @@ class AggregationOperationState {
const CatalogDatabaseLite
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99884619
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -1495,9 +1607,28 @@ void ExecutionGenerator::convertAggregate
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/180
Assigned to @zuyu.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/177
This optimization is somehow different from `AggregatePushDown`. I updated
the example in this PR's description.
---
If your project is set up for it, you can reply to this email
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/174
Push down disjunctive predicates to filter small-cardinality stored
relation early.
This PR implements an optimization (physical plan transformation) that
pushes down disjunctive
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98543218
--- Diff: relational_operators/HashJoinOperator.cpp ---
@@ -504,123 +616,61 @@ void HashInnerJoinWorkOrder::execute() {
// hash join
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98546082
--- Diff: query_optimizer/rules/ReorderColumns.cpp ---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98543122
--- Diff: relational_operators/HashJoinOperator.cpp ---
@@ -504,123 +616,61 @@ void HashInnerJoinWorkOrder::execute() {
// hash join
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98544439
--- Diff: storage/ValueAccessor.hpp ---
@@ -305,6 +305,21 @@ class ValueAccessor {
const TupleIdSequence _sequence) = 0
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98544534
--- Diff: relational_operators/HashJoinOperator.cpp ---
@@ -484,7 +565,38 @@ void HashInnerJoinWorkOrder::execute() {
const relation_id
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98544852
--- Diff: relational_operators/HashJoinOperator.cpp ---
@@ -484,7 +565,38 @@ void HashInnerJoinWorkOrder::execute() {
const relation_id
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98545487
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -109,6 +114,13 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {
} else
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98542466
--- Diff: relational_operators/HashJoinOperator.cpp ---
@@ -63,6 +65,9 @@ namespace quickstep {
namespace {
+typedef std
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98543320
--- Diff: query_optimizer/rules/ReorderColumns.hpp ---
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98541113
--- Diff: query_optimizer/rules/ReorderColumns.cpp ---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98538859
--- Diff: query_optimizer/rules/ReorderColumns.cpp ---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98541098
--- Diff: query_optimizer/rules/ReorderColumns.cpp ---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98538359
--- Diff: query_optimizer/rules/ReorderColumns.cpp ---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/171#discussion_r98541504
--- Diff: query_optimizer/rules/ReorderColumns.cpp ---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/170
Add unit test for CatalogRelationStatistics
This PR adds unit tests for CatalogRelationStatistics. It tests that the
`\analyze` command can produce correct stats
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/171
QUICKSTEP-68 Reorder intermediate relations' attributes to improve copy
performance.
Currently, all the intermediate relations (i.e. temporary relations created
during query
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/170
Assigned to @zuyu.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/172
Query optimization with ExactFilter
This is a follow-up optimization based on the facility provided by
LIPFilters. Note that LIP (lookahead information passing) is an optimization
GitHub user jianqiao reopened a pull request:
https://github.com/apache/incubator-quickstep/pull/171
QUICKSTEP-68 Reorder intermediate relations' attributes to improve copy
performance.
Currently, all the intermediate relations (i.e. temporary relations created
during query
Github user jianqiao closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/170
Updated. Now closing and reopening the PR to restart travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jianqiao reopened a pull request:
https://github.com/apache/incubator-quickstep/pull/170
Add unit test for CatalogRelationStatistics
This PR adds unit tests for CatalogRelationStatistics. It tests that the
`\analyze` command can produce correct stats
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/165#discussion_r97168067
--- Diff: relational_operators/HashJoinOperator.cpp ---
@@ -207,49 +207,43 @@ bool HashJoinOperator::getAllNonOuterJoinWorkOrders
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/165#discussion_r97169709
--- Diff: relational_operators/HashJoinOperator.cpp ---
@@ -207,49 +207,43 @@ bool HashJoinOperator::getAllNonOuterJoinWorkOrders
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/165#discussion_r97165573
--- Diff: storage/StorageBlockInfo.hpp ---
@@ -49,6 +50,8 @@ static constexpr int kBlockIdDomainLengthInDigits =
std::numeric_limits::digits10
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/167
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/190
Use BitVectorExactFilter as LIPFilter implementation when applicable
In the previous exact-filter PR, it was not by default use
`BitVectorExactFilter` as the LIPFilter implementation
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/191
Fix the problem in the "Fuse Aggregate with HashLeftOuterJoin" PR.
This PR addresses the bugs as pointed out in #185 as well as a few style
issues.
You can merge this pu
Github user jianqiao closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/193
Use partitioned aggregation for single-function DISTINCT aggregation.
This PR uses the partitioned aggregation routine for parallelizing DISTINCT
aggregation. It improves
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
LGTM. Thanks @cramja for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/185
Fuse Aggregate with HashLeftOuterJoin to accelerate evaluation
This PR fuses `Aggregate` with `HashJoin` (left outer) into the
`CrossReferenceCoalesceAggregate` node to enable fast
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/163
LGTM. Is there some special reason for doing this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/160
LGTM except some minor style issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/160#discussion_r96450595
--- Diff: query_optimizer/physical/CreateTable.hpp ---
@@ -107,8 +115,9 @@ class CreateTable : public Physical {
static CreateTablePtr
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/160#discussion_r96445324
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -478,9 +484,32 @@ L::LogicalPtr Resolver::resolveCreateTable(
std::shared_ptr
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/160#discussion_r96449905
--- Diff: query_optimizer/logical/CreateTable.hpp ---
@@ -100,8 +108,9 @@ class CreateTable : public Logical {
static CreateTablePtr
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/198
Great! Thanks Marc @cramja.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
+1. I'm good with the release.
Best,
Jianqiao
2017-03-01 17:21 GMT-06:00 HAKAN MEMISOGLU <memiso...@cs.wisc.edu>:
> Hi Marc,
>
> +1 from me. It works with Docker.
>
> However I also get an error when I try to build it with Mac.
> The linker cannot find some
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/196
Fix gcc build error with PackedPayloadHashTable
This PR fixes the gcc build error (missing `this` pointer for calling a
method in a capture-all-by-reference lambda function
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/106
Improve StarSchemaSimpleCostModel to provide better group cardinality
estimation for aggregations.
This PR revises `StarSchemaSimpleCostModel` to provide better group
cardinality
1 - 100 of 233 matches
Mail list logo
