Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113071179
--- Diff: query_optimizer/expressions/Scalar.hpp ---
@@ -65,10 +67,49 @@ class Scalar : public Expression {
const std::unordered_map&
su
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113070938
--- Diff: query_optimizer/expressions/Scalar.hpp ---
@@ -65,10 +67,49 @@ class Scalar : public Expression {
const std::unordered_map&
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113070668
--- Diff: query_optimizer/expressions/Scalar.hpp ---
@@ -65,10 +67,49 @@ class Scalar : public Expression {
const std::unordered_map&
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113070383
--- Diff: query_optimizer/expressions/CommonSubexpression.hpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113066931
--- Diff: expressions/scalar/ScalarCaseExpression.cpp ---
@@ -420,15 +429,15 @@ void
ScalarCaseExpression::MultiplexNativeColumnVector(
vo
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112848246
--- Diff: query_optimizer/rules/ReuseAggregateExpressions.cpp ---
@@ -0,0 +1,349 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112848329
--- Diff: query_optimizer/rules/ReuseAggregateExpressions.cpp ---
@@ -0,0 +1,349 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112847625
--- Diff: query_optimizer/expressions/CommonSubexpression.hpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112847605
--- Diff: query_optimizer/expressions/CommonSubexpression.hpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112848590
--- Diff: query_optimizer/rules/ReuseAggregateExpressions.cpp ---
@@ -0,0 +1,349 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112847895
--- Diff: query_optimizer/rules/CollapseSelection.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112847881
--- Diff: query_optimizer/rules/CollapseSelection.cpp ---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112848194
--- Diff: query_optimizer/rules/ExtractCommonSubexpression.hpp ---
@@ -0,0 +1,179 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112847711
--- Diff: query_optimizer/expressions/SimpleCase.cpp ---
@@ -161,6 +163,50 @@ ::quickstep::Scalar* SimpleCase::concretize(
else_result_ex
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112847577
--- Diff: query_optimizer/expressions/CommonSubexpression.hpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112848219
--- Diff: query_optimizer/rules/ExtractCommonSubexpression.hpp ---
@@ -0,0 +1,179 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112848647
--- Diff: query_optimizer/rules/ReuseAggregateExpressions.hpp ---
@@ -0,0 +1,154 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112848427
--- Diff: query_optimizer/rules/ReuseAggregateExpressions.cpp ---
@@ -0,0 +1,349 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112828010
--- Diff: expressions/scalar/ScalarSharedExpression.hpp ---
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112827764
--- Diff: expressions/scalar/ScalarCaseExpression.cpp ---
@@ -420,15 +429,15 @@ void
ScalarCaseExpression::MultiplexNativeColumnVector(
void S
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112826967
--- Diff: expressions/scalar/ScalarAttribute.cpp ---
@@ -139,25 +142,26 @@ ColumnVector*
ScalarAttribute::getAllValues(ValueAccessor *accessor,
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112827855
--- Diff: expressions/scalar/ScalarSharedExpression.cpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112826746
--- Diff: expressions/predicate/Predicate.hpp ---
@@ -67,6 +72,11 @@ class Predicate {
virtual ~Predicate() {
--- End diff --
Ne
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112845784
--- Diff: query_optimizer/expressions/AttributeReference.cpp ---
@@ -57,6 +60,22 @@ ::quickstep::Scalar *AttributeReference::concretize(
retu
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112826924
--- Diff: expressions/scalar/Scalar.hpp ---
@@ -70,6 +75,11 @@ class Scalar {
virtual ~Scalar() {
--- End diff --
Change to `~Sc
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112827868
--- Diff: expressions/scalar/ScalarSharedExpression.cpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112827934
--- Diff: expressions/scalar/ScalarSharedExpression.cpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112826903
--- Diff: expressions/scalar/Scalar.hpp ---
@@ -55,6 +59,7 @@ class Scalar {
kUnaryExpression,
kBinaryExpression,
kCaseEx
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112828368
--- Diff: query_optimizer/expressions/Scalar.hpp ---
@@ -65,10 +67,49 @@ class Scalar : public Expression {
const std::unordered_map&
su
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112828399
--- Diff: query_optimizer/expressions/Scalar.hpp ---
@@ -65,10 +67,49 @@ class Scalar : public Expression {
const std::unordered_map&
su
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r112828079
--- Diff: expressions/scalar/tests/ScalarCaseExpression_unittest.cpp ---
@@ -223,8 +223,8 @@ TEST_F(ScalarCaseExpressionTest,
BasicComparisonAndLit
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/237
QUICKSTEP-89 Add support for common subexpression.
This PR adds support for common subexpression elimination in Quickstep. In
summary we apply two kinds of optimizations:
**(1)** Q
33 matches
Mail list logo
