Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/240#discussion_r113066825
--- Diff: query_optimizer/rules/ExtractCommonSubexpression.hpp ---
@@ -111,7 +111,7 @@ class ExtractCommonSubexpression : public
Rule {
bool
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/240#discussion_r113066280
--- Diff: query_optimizer/rules/ExtractCommonSubexpression.hpp ---
@@ -111,7 +111,7 @@ class ExtractCommonSubexpression : public
Rule {
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/240#discussion_r113044397
--- Diff: query_optimizer/rules/ExtractCommonSubexpression.hpp ---
@@ -111,7 +111,7 @@ class ExtractCommonSubexpression : public
Rule {
bool
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/240#discussion_r113042124
--- Diff: query_optimizer/rules/ReuseAggregateExpressions.cpp ---
@@ -194,7 +194,7 @@ P::PhysicalPtr ReuseAggregateExpressions::applyToNode(
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/240#discussion_r113038771
--- Diff: query_optimizer/rules/ReuseAggregateExpressions.cpp ---
@@ -194,7 +194,7 @@ P::PhysicalPtr ReuseAggregateExpressions::applyToNode(
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/240
Fix the issues with the common subexpression feature
This PR fixes the issues in #237.
You can merge this pull request into a Git repository by running:
$ git pull https://github.
