Re: [racket-dev] [racket] Implementing contracts for async channels

2015-01-19 Thread Robby Findler
Ah: one other note. When you do something like this: ((contract (- (list/c (box/c integer?)) any) (λ (x) (unbox (car x))) 'pos 'neg) (list (box not an integer))) you get an error message that has this text in the middle: in: the content of the 1st element of

Re: [racket-dev] [racket] Implementing contracts for async channels

2015-01-19 Thread Robby Findler
Oh, sorry I missed that. Robby On Mon, Jan 19, 2015 at 6:40 PM, Alexis King lexi.lam...@gmail.com wrote: I already used blame-add-context, but the message I used wasn’t very good, so I’ve improved it. If everything else looks good, feel free to merge this whenever you get the chance! On

Re: [racket-dev] [racket] Implementing contracts for async channels

2015-01-19 Thread Alexis King
Yes, there are tests, and you can see them here https://github.com/plt/racket/pull/860/files#diff-9383600c097f090324382317068c6187R1. On Jan 19, 2015, at 13:29, Robby Findler ro...@eecs.northwestern.edu wrote: This seemed okay, but just a quick read of the code. But did I miss the test

Re: [racket-dev] [racket] Implementing contracts for async channels

2015-01-19 Thread Alexis King
I already used blame-add-context, but the message I used wasn’t very good, so I’ve improved it. If everything else looks good, feel free to merge this whenever you get the chance! On Jan 19, 2015, at 15:52, Robby Findler ro...@eecs.northwestern.edu wrote: Ah: one other note. When you do

Re: [racket-dev] [racket] Implementing contracts for async channels

2015-01-19 Thread Alexis King
Any update on this? If there’s anything that still needs to be changed, let me know—otherwise, I’ll patiently wait for the process to run its course. Just checking in. On Jan 16, 2015, at 10:15, Alexis King lexi.lam...@gmail.com wrote: Ah, that makes sense, fixed. On Jan 16, 2015, at

Re: [racket-dev] [racket] Implementing contracts for async channels

2015-01-19 Thread Robby Findler
This seemed okay, but just a quick read of the code. But did I miss the test cases? (I just followed the link upthread -- sorry if I need to look somewhere else too.) Robby On Mon, Jan 19, 2015 at 3:15 PM, Alexis King lexi.lam...@gmail.com wrote: Any update on this? If there’s anything that

Re: [racket-dev] [racket] Implementing contracts for async channels

2015-01-16 Thread Alexis King
Ah, that makes sense, fixed. On Jan 16, 2015, at 05:37, Robby Findler ro...@eecs.northwestern.edu wrote: One comment. The contract combinators are curried so that you can do work on the partial applications. So don't write this: (define ho-val-first-projection