Re: [VOTE]Release Apache RocketMQ Client CPP 2.1.0 RC1.

[heng du]

+1 (binding)

checked:

-Checksums and PGP signatures are valid for the Source package.
-Checksums and PGP signatures are valid for the Binary package.
-Hash and Tag in GitHub repo are matching the current artifacts.
-Source code artifacts have correct names matching the current release.
-All necessary files have license headers


ShannonDing  于2020年3月25日周三 上午11:08写道：

>
>
> Hi,
> +1(binding)
> As the release manager, I checked the RC1 following the checklist.
> And any other check point is welcomed and please feel free to reply to
> this email, I sincerely hope to your feedback.
> On 03/23/2020 22:31，ShannonDing wrote：
>
>
>
> Hello RocketMQ Community,
>
> This is the vote for version 2.1.0 of Apache RocketMQ Client CPP.
>
> This release is a major upgrade, mainly including message tracing for pub
> and sub and support for higher version of GCC and add asan/lsan to check
> memories. The stability of the core is further improved.
>
> The artifacts:
>
>
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-cpp/2.1.0-rc1/
>
> Git tag for the release:
>
> https://github.com/apache/rocketmq-client-cpp/releases/tag/2.1.0
>
> Hash for the release tag:
>
> aee285fa1948d15cc1c6a70109a151bd044bc51a
>
> Release Notes:
>
>
> http://rocketmq.apache.org/release_notes/release-notes-rocketmq-client-cpp-2.1.0/
>
> The artifacts have been signed with Key :
>
> BC9E172DE1BA5B24EBB4A628177B55985D75751B, which can be found in the keys
>
> file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
>
>
>
>
> Checklist for reference,
>
> Note that this is not official policy but may help with checking releases.
>
> Fill in the following:
>
> []  Checksums and PGP signatures are valid for Source package.
>
> []  Checksums and PGP signatures are valid for Binary package.
>
> []  Source code artifacts have correct names matching the current release.
>
> []  Binary artifacts have correct names matching the current release.
>
> []  License and Notice are correct in source package.
>
> []  License and Notice are correct in binary package.
>
> []  All files have license headers in source package if necessary.
>
> []  No compiled archives bundled in source archive.
>
> []  Hash and Tag in GitHub repo is matching the current artifacts.
>
> []  The code can be built success in the source package.
>
> And any other check point is welcomed and please feel free to reply to
> this email, we sincerely hope to your feedback.
>
>
>
>
> The vote will be open for at least 72 hours or until necessary number of
>
> votes are reached.
>
> Please vote accordingly:
>
>
>
>
> [] +1 approve
>
> [] +0 no opinion
>
> [] -1 disapprove with the reason
>
>
>
>
> Thanks,
>
> The Apache RocketMQ Team
>
>
>
>
>

Re:[VOTE]Release Apache RocketMQ Client CPP 2.1.0 RC1.

[ShannonDing]

Hi,
+1(binding)
As the release manager, I checked the RC1 following the checklist.
And any other check point is welcomed and please feel free to reply to this 
email, I sincerely hope to your feedback.
On 03/23/2020 22:31，ShannonDing wrote：



Hello RocketMQ Community,

This is the vote for version 2.1.0 of Apache RocketMQ Client CPP.

This release is a major upgrade, mainly including message tracing for pub and 
sub and support for higher version of GCC and add asan/lsan to check memories. 
The stability of the core is further improved.

The artifacts:

https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-cpp/2.1.0-rc1/

Git tag for the release:

https://github.com/apache/rocketmq-client-cpp/releases/tag/2.1.0

Hash for the release tag:

aee285fa1948d15cc1c6a70109a151bd044bc51a

Release Notes:

http://rocketmq.apache.org/release_notes/release-notes-rocketmq-client-cpp-2.1.0/

The artifacts have been signed with Key :

BC9E172DE1BA5B24EBB4A628177B55985D75751B, which can be found in the keys

file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS




Checklist for reference,

Note that this is not official policy but may help with checking releases.

Fill in the following:

[]  Checksums and PGP signatures are valid for Source package.

[]  Checksums and PGP signatures are valid for Binary package.

[]  Source code artifacts have correct names matching the current release.

[]  Binary artifacts have correct names matching the current release.

[]  License and Notice are correct in source package.

[]  License and Notice are correct in binary package.

[]  All files have license headers in source package if necessary.

[]  No compiled archives bundled in source archive.

[]  Hash and Tag in GitHub repo is matching the current artifacts.

[]  The code can be built success in the source package.

And any other check point is welcomed and please feel free to reply to this 
email, we sincerely hope to your feedback.




The vote will be open for at least 72 hours or until necessary number of

votes are reached.

Please vote accordingly:




[] +1 approve

[] +0 no opinion

[] -1 disapprove with the reason




Thanks,

The Apache RocketMQ Team

Re: [VOTE]Release Apache RocketMQ Client CPP 2.1.0 RC1.

[Rongtong Jin]

+1

I checked:

-Checksums and PGP signatures are valid for Source package.
-Checksums and PGP signatures are valid for Binary package.
-Hash and Tag in GitHub repo is matching the current artifacts.
-Source code artifacts have correct names matching the current release.

ShannonDing 写道：
> 
> 
> 
> Hello RocketMQ Community,
> 
> This is the vote for version 2.1.0 of Apache RocketMQ Client CPP.
> 
> This release is a major upgrade, mainly including message tracing for pub and 
> sub and support for higher version of GCC and add asan/lsan to check 
> memories. The stability of the core is further improved.
> 
> The artifacts:
> 
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-cpp/2.1.0-rc1/
> 
> Git tag for the release:
> 
> https://github.com/apache/rocketmq-client-cpp/releases/tag/2.1.0
> 
> Hash for the release tag:
> 
> aee285fa1948d15cc1c6a70109a151bd044bc51a
> 
> Release Notes:
> 
> http://rocketmq.apache.org/release_notes/release-notes-rocketmq-client-cpp-2.1.0/
> 
> The artifacts have been signed with Key :
> 
> BC9E172DE1BA5B24EBB4A628177B55985D75751B, which can be found in the keys
> 
> file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
> 
> 
> 
> 
> Checklist for reference,
> 
> Note that this is not official policy but may help with checking releases.
> 
> Fill in the following:
> 
> []  Checksums and PGP signatures are valid for Source package.
> 
> []  Checksums and PGP signatures are valid for Binary package.
> 
> []  Source code artifacts have correct names matching the current release.
> 
> []  Binary artifacts have correct names matching the current release.
> 
> []  License and Notice are correct in source package.
> 
> []  License and Notice are correct in binary package.
> 
> []  All files have license headers in source package if necessary.
> 
> []  No compiled archives bundled in source archive.
> 
> []  Hash and Tag in GitHub repo is matching the current artifacts.
> 
> []  The code can be built success in the source package.
> 
> And any other check point is welcomed and please feel free to reply to this 
> email, we sincerely hope to your feedback.
> 
> 
> 
> 
> The vote will be open for at least 72 hours or until necessary number of
> 
> votes are reached.
> 
> Please vote accordingly:
> 
> 
> 
> 
> [] +1 approve
> 
> [] +0 no opinion
> 
> [] -1 disapprove with the reason
> 
> 
> 
> 
> Thanks,
> 
> The Apache RocketMQ Team
> 
> 
> 
> 

Re: [VOTE]Release Apache RocketMQ Client CPP 2.1.0 RC1.

[Gosling Von]

Hi,


+1 (binding)

I checked:
- signatures and hashes fine
- LICENSE and NOTICE looks OK
- All necessary files have license headers
- No compiled archives bundled in source archive
- Release note seems clear for me

@Justin, I also checked Chromium code[1][2], header license’ year really differ 
from the license file from the origin codebase.


[1] https://github.com/chromium/chromium/blob/master/base/big_endian.h 

[2] https://github.com/chromium/chromium/blob/master/LICENSE 



Best Regards,
Von Gosling

> On Mar 23, 2020, at 10:31 PM, ShannonDing  wrote:
> 
> 
> 
> 
> Hello RocketMQ Community,
> 
> This is the vote for version 2.1.0 of Apache RocketMQ Client CPP.
> 
> This release is a major upgrade, mainly including message tracing for pub and 
> sub and support for higher version of GCC and add asan/lsan to check 
> memories. The stability of the core is further improved.
> 
> The artifacts:
> 
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-cpp/2.1.0-rc1/
> 
> Git tag for the release:
> 
> https://github.com/apache/rocketmq-client-cpp/releases/tag/2.1.0
> 
> Hash for the release tag:
> 
> aee285fa1948d15cc1c6a70109a151bd044bc51a
> 
> Release Notes:
> 
> http://rocketmq.apache.org/release_notes/release-notes-rocketmq-client-cpp-2.1.0/
> 
> The artifacts have been signed with Key :
> 
> BC9E172DE1BA5B24EBB4A628177B55985D75751B, which can be found in the keys
> 
> file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
> 
> 
> 
> 
> Checklist for reference,
> 
> Note that this is not official policy but may help with checking releases.
> 
> Fill in the following:
> 
> []  Checksums and PGP signatures are valid for Source package.
> 
> []  Checksums and PGP signatures are valid for Binary package.
> 
> []  Source code artifacts have correct names matching the current release.
> 
> []  Binary artifacts have correct names matching the current release.
> 
> []  License and Notice are correct in source package.
> 
> []  License and Notice are correct in binary package.
> 
> []  All files have license headers in source package if necessary.
> 
> []  No compiled archives bundled in source archive.
> 
> []  Hash and Tag in GitHub repo is matching the current artifacts.
> 
> []  The code can be built success in the source package.
> 
> And any other check point is welcomed and please feel free to reply to this 
> email, we sincerely hope to your feedback.
> 
> 
> 
> 
> The vote will be open for at least 72 hours or until necessary number of
> 
> votes are reached.
> 
> Please vote accordingly:
> 
> 
> 
> 
> [] +1 approve
> 
> [] +0 no opinion
> 
> [] -1 disapprove with the reason
> 
> 
> 
> 
> Thanks,
> 
> The Apache RocketMQ Team
> 
> 
> 
> 

Re: [VOTE]Release Apache RocketMQ Client CPP 2.1.0 RC1.

[Justin Mclean]

Hi,

And I should have mentioned I only checked the source package.

Thanks,
Justin

Re: [VOTE]Release Apache RocketMQ Client CPP 2.1.0 RC1.

[Justin Mclean]

Hi,

+1 (binding)

I checked:
- signature and hash correct
- LICENSE and NOTICE are fine
- No unexpected binary files
- All source files have ASF headers
- Can compile from source

A very minor thing the copyright year for the Chromium author in LICENSE 
doesn’t match the header files.

I also noticed this in the build output - but it still finished successfully
md5sum: command not found

Thanks,
Justin