Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/21
@zhouxinyu This PR introduces grammar of Java 7, say diamond. Do you plan
to upgrade the language compatible version?
---
If your project is set up for it, you can reply to this email
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/22
[ROCKETMQ-25] Possible data race while query msg by key
Refer to JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-25
You can merge this pull request into a Git repository by
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94729360
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,40 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94730295
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,40 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94730662
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,40 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/3
Overall, I love this PR. Separating contributors and committers is really
good to have.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94734427
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,45 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/28
[ROCKETMQ-27]Add store commitlog path online
RocketMQ broker stores all messages before they are expired, which requires
pretty much storage for a high load system. For now, the
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94743138
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,45 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
@shroman Please use parameterized template formatting way. See
http://slf4j.org/faq.html section "What is the fastest way of (not) logging?"
---
If your project is set up f
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/34
The extracted shutdown hook misses required license header and causes
check-style failure. Please fix it and double check if there are more similar
code style issues.
You may
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/39
[ROCKETMQ-45]Delete hanged consume queue files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
Please follow instructs
[here](http://rocketmq.incubator.apache.org/docs/pull-request/).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/39#discussion_r95959190
--- Diff:
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -397,11 +397,21 @@ public int deleteExpiredFileByOffset(long
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/39
> what's the appearance/effect of this BUG?
Reported bug description is consume queue files cannot be automatically
deleted and took up large portion of disk.
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/33#discussion_r95966853
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java ---
@@ -53,8 +53,9 @@ public MQClientInstance
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/28
OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/42
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/43
Minor changes, appears OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/39#discussion_r97212223
--- Diff:
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -397,11 +397,21 @@ public int deleteExpiredFileByOffset(long
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/39
> We'd better not merge the PR if the opinion fails to unite
Agree. But this is a minor change to fix obvious corner case mis-handling.
Proposing review points are c
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/50
[ROCKETMQ-74] Fix DataVersion equals defect
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/50
@vongosling Any opinion on this PR? If not, I would merge it to master
branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Yes, both quickstart.Consumer and quickstart.Producer should have
xxx.setNamesrv("XXX") as part of documentation, showing how to set name server
list programmatically. My faul
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Could you relocate the line properly and wrap the code using appropriate
javadoc, say {@code Code is here;}
http://stackoverflow.com/questions/541920/multiple-line-code-example-in
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Agree. All directly executable code should be part of the e2e tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
BTW, should we remove example.transaction.* as this feature is not fully
implemented in current release. It does not make sense having orphan examples
alone.
---
If your project is
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/55
[ROCKETMQ-89] WS_DOMAIN_NAME, SUBGROUP default values overrides custom
values
WS_DOMAIN_NAME, SUBGROUP default values overrides custom values passed by
java options options
You can
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
We need to disable reuse forks for the broker module as the newly added
unit test requires a more isolated environment to run.
---
If your project is set up for it, you can reply to
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
> [ERROR] Failed to execute goal
org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on
project rocketmq-all: Processing of input or output data failed: Rep
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/56
[ROCKETMQ-90] Include client IP in consumerProgress command output
Include client IP per message queue of consumer progress command output
You can merge this pull request into a Git
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
> "Also, I don't think HTTP endpoint should be mentioned unless there is a
description on how a user can configure its own endpoint."
This, IMO, is the bes
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
@shroman We may create a JIRA ticket and thread in mailing list to follow
this idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
I'll check and merge. It looks I do not have permission to close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
This PR has been merged. @shroman you may close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/62
[ROCKETMQ-99] Add scripts for Windows
Add scripts for windows where possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
This issue is valid and the bug will be triggered under the following
conditions:
1. A target message queue is specified, which will pass null for
TopicPublishInfo parameter;
2
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Yes, #4 is not required as MQFaultStrategy#92 may also generate NPE.
Queue ID info is contained in the request header, minimal effort suffices.
---
If your project is set up for it
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/64
Can you provide some test data, say before/after applying this patch, how
many duplications are found respectively?
IMHO, we should make the API as concise as possible
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/58
Hi @yuweitaocn , if you examine the options here carefully, you would find
there is no "target pause time-goal", aka, RocketMQ does not set this option:
-XX:MaxGCPauseMill
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/64
I know this issue has been brought up in the past. What I suggest here is
providing some testing data to consolidate the rationality of this patch. By
doing so, you'll find it easi
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/61#discussion_r101704927
--- Diff: common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
---
@@ -47,6 +47,7 @@
private boolean
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
This feature is definitely nice to have and it expands scenarios that
RocketMQ fits best. For example, RocketMQ may have close, if not better,
performance with Kafka in log collecting
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/61#discussion_r101709294
--- Diff: common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
---
@@ -47,6 +47,7 @@
private boolean
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/68
As pointed out, I agree marking shutdown and start `synchronized` to keep
code as concise as possible.
---
If your project is set up for it, you can reply to this email and have your
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
Good catch.
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
@vongosling I plan to install a Windows XP on a virtual machine if there is
no feedback from community. Actually, I am hoping someone may test this PR on
Windows 10 which covers
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/61
This PR itself is OK. Abstracting the concept of`PutMessageLock` is pretty
handy.
What I suggest here is presenting the advice more formally instead of a
simple inline comment
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/59
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
Not everyone needs this feature, I suggest to set this feature as disabled
on default. Enable it only when application user manually set
`pullThresholdForTopic >= pullThresholdForQu
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/55#discussion_r103141482
--- Diff: broker/pom.xml ---
@@ -66,4 +66,17 @@
javassist
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
Agree, for the client related module, I think it's best to have maximum
compatibility as many application developers are still working on legacy
systems.
---
If your project is s
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
@shroman client/common/remoting
Frankly speaking, it's kind of dilemma. pom.xml has already defined Java
language version to 1.7 and JREs under 1.7 are no longer maintain
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/77
Guard MQVesion methods.
When register higher version brokers again old name servers, index out of
boundary exception is thrown, causing registration failure.
You can merge this pull
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/78
[ROCKETMQ-141]Make producer client connect to new-joined brokers eagerly
When new brokers joins the cluster, MQ producer clients polls name server
and add the new-joined brokers to
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/79
[ROCKETMQ-144]Aggregate packaging specific files to a new sub-module
When running maven-assembly-plugin, it constantly warns and suggests to use
a separate sub-module to aggregate
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/80
[ROCKETMQ-114] Add javadoc to codebase
Add javadoc to codebase
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@Jaskey You are right, I'll follow up and merge this PR ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
All right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
Hi, @Jaskey
> what about we provide a new a config call flowControlTreadholds and a
boolean config flowControlForTopic (false by default).
I think this is a good i
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@Jaskey I'll merge this PR soon. Please close this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
What I intend to deliver is that it's always good to have simple API, but
it would be miserably unexpected to change semantics of a configuration
quietly. Further, it's b
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
This is quick fix of typo and we have collected three +1s. Now it's merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
@vesense Please close this issue at your convenient time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/83
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/79
@shroman @zhouxinyu any idea on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108344108
--- Diff: distribution/release.xml ---
@@ -1,19 +1,19 @@
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108344089
--- Diff: distribution/pom.xml ---
@@ -0,0 +1,125 @@
+
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
All right. +1 now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/79
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
@shroman @zhouxinyu @vongosling Any idea on this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/85
The logic here shares much similar logic with ClientLogger class, can we
extract the common part into a reusable method?
---
If your project is set up for it, you can reply to this
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/56
@shroman @vongosling Any idea on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/85
> So do you agree this is indeed an issue that needed to be solved? If
yes, I will try doing that.
Changing specific dependency to a neutral logging framework is good to h
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/85
The conf folder has been moved to the distribution module, please rebase
this PR on top of develop branch. I'll +1 thereafter.
---
If your project is set up for it, you can rep
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
> We'd better merge PR not the same guys.
@vongosling Any rational reasoning behind this?
---
If your project is set up for it, you can reply to this email and have yo
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r108616049
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -196,22 +196,11 @@ private static void initLog
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/56
@shroman Please re-check and help merge this issue if it's all right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/61
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/88
[ROCKETMQ-165]Maximum pull batch size hard-coded restricted
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/89
[ROCKETMQ-166] onException callback may capture compressed message body
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/28
@Jaskey @vsair No, Broker only delete expired files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/77
As this PR is pretty trivial, I'll merge it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/77
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/88
Merged as this is really trivial.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
@vongosling @shroman any idea on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
> But I don't quite understand why it has to have so many levels -- why not
to remove rmqAddressServerDomain and let the user use only
rocketmq.namesrv.domain ... ?
Y
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 234 matches
Mail list logo
