Re: two things: Clean components final HTML Output - Button basic styles still around

2018-03-06 Thread Alex Harui
Hi Piotr, Your advice is no longer true (was true until recently). Carlos can move the visual styling from the Button Type selectors in defaults.css to basic.css. I have seen some surprising defaults in the browsers, like border-width defaulting to 4px. So a simple test is to not use Royale at

Re: two things: Clean components final HTML Output - Button basic styles still around

2018-03-06 Thread Carlos Rovira
HI Piotr, 2018-03-06 15:31 GMT+01:00 Piotr Zarzycki : > If you are extending Basic components, you got styles from there. If you > don't need those styles you will have to do one of the two things in my > opinion: > > 1) Exclude basic styles as we did it in MDL >

Re: two things: Clean components final HTML Output - Button basic styles still around

2018-03-06 Thread Piotr Zarzycki
If you are extending Basic components, you got styles from there. If you don't need those styles you will have to do one of the two things in my opinion: 1) Exclude basic styles as we did it in MDL 2) Override some of them using theme/your css file style 2018-03-06 15:26 GMT+01:00 Carlos

Re: two things: Clean components final HTML Output - Button basic styles still around

2018-03-06 Thread Carlos Rovira
In fact, If I remove the styles in basic, I end with some visual changes in JewelExample, like SVG strokes more thick in the buttons. Don't know exactly why this is happening, but it's clear that styles from basic component should be exactly 0, and then if people wants basic styles they should use