Re: [VOTE] Apache S2Graph(incubating) 0.1.0 release RC4

2016-09-22 Thread Sergio Fernández
Thanks Do Yung for putting together a new RC. So far I've successfully checked: * signatures and digests * source releases file layouts * matched git tags and commit ids * incubator suffix and disclaimer * NOTICE and LICENSE files * license headers * clean build (Java 1.8.0_91, Scala, 2.11.7, SBT

Re: [VOTE] Apache S2Graph(incubating) 0.1.0 release RC4

2016-09-22 Thread Kim, Min-Seok
+1 (non-binding) It works. I've checked: - clean build - run `bin/example.sh` at: - Java 1.8.0_60-b27, OSX x86_64 - Java 1.8.0_45, CentOS 7.1 x86_64 . To Sergio, The commands will work on `/path/to/incubator-s2graph/target/apache-s2graph-0.1.0-incubating-bin` after `sbt package`. Thanks M

Re: [VOTE] Apache S2Graph(incubating) 0.1.0 release RC4

2016-09-22 Thread Sergio Fernández
On Thu, Sep 22, 2016 at 11:56 AM, Kim, Min-Seok wrote: > > To Sergio, > > The commands will work on > `/path/to/incubator-s2graph/target/apache-s2graph-0.1.0-incubating-bin` > after `sbt package`. > Of course! Then the README needs to remark that to avoid people to get confused, like it happened

Re: [VOTE] Apache S2Graph(incubating) 0.1.0 release RC4

2016-09-22 Thread Jong Wook Kim
I wrote that section in the README.md in mind that the majority will download the binary distribution which will contain the content in the subdirectory, The section “Building from the source” specifies that the distribution will be created in target/apache-s2graph-$version-incubating-bin. So I

Re: [VOTE] Apache S2Graph(incubating) 0.1.0 release RC4

2016-09-22 Thread Sergio Fernández
On Fri, Sep 23, 2016 at 12:51 AM, Jong Wook Kim wrote: > I wrote that section in the README.md in mind that the majority will > download the binary distribution which will contain the content in the > subdirectory, > > The section “Building from the source” specifies that the distribution > will