+1 (non-binding)

It works.

I've checked:
 - clean build
 - run `bin/example.sh`
at:
 - Java 1.8.0_60-b27, OSX x86_64
 - Java 1.8.0_45, CentOS 7.1 x86_64
.

To Sergio,

The commands will work on
`/path/to/incubator-s2graph/target/apache-s2graph-0.1.0-incubating-bin`
after `sbt package`.

Thanks

Minseok


On Thu, Sep 22, 2016 at 5:04 PM, Sergio Fernández <wik...@apache.org> wrote:

> Thanks Do Yung for putting together a new RC.
>
> So far I've successfully checked:
> * signatures and digests
> * source releases file layouts
> * matched git tags and commit ids
> * incubator suffix and disclaimer
> * NOTICE and LICENSE files
> * license headers
> * clean build (Java 1.8.0_91, Scala, 2.11.7, SBT 0.13.9, Debian amd64)
>
> Regarding the source release everything looks fine. Therefore my vote is +1
> (binding). Great work, guys!
>
> But I have issues running it:
>
> $ ./bin/start-s2graph.sh
> Starting hbase...
> Service hbase might have failed to start; see
> /home/wikier/tmp/s2graph/incubator-s2graph/logs/hbase.log
> Starting s2rest_play...
> Service s2rest_play might have failed to start; see
> /home/wikier/tmp/s2graph/incubator-s2graph/logs/s2rest_play.log
>
> $ cat /home/wikier/tmp/s2graph/incubator-s2graph/logs/s2rest_play.log
> /usr/bin/java -cp
> /home/wikier/tmp/s2graph/incubator-s2graph/conf:/home/
> wikier/tmp/s2graph/incubator-s2graph/lib/*
> -Ds2graph.home=/home/wikier/tmp/s2graph/incubator-s2graph -Xms1g -Xmx1g
> play.core.server.NettyServer
> Error: Could not find or load main class play.core.server.NettyServer
>
> Any idea what I'm doing wrong?
>
> BTW, I found now documentation about how to run RAT; so inspecting the
> script I've created some minimal documentation, see
> https://github.com/apache/incubator-s2graph/pull/84
>
> Cheers,
>
> P.S.: you can remove all old RCs from https://dist.apache.org/r
> epos/dist/dev/incubator/s2graph/
>
>
>
> On Thu, Sep 22, 2016 at 3:19 AM, DO YUNG YOON <sho...@gmail.com> wrote:
>
> > Hi all,
> >
> > This is a call for a releasing Apache S2Graph 0.1.0-incubating, release
> > candidate 4.
> > This is the first release of S2Graph.
> >
> > The source tarball, including signatures, digests, etc. can be found at:
> > https://dist.apache.org/repos/dist/dev/incubator/s2graph/0.
> > 1.0-incubating-RC4/
> >
> >
> > The tag to be voted upon is v0.1.0-incubating-rc4:
> > https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.
> > git;a=shortlog;h=refs/tags/v0.1.0-incubating-rc4
> >
> > The release hash is c50d43a06a2044320c4e695b487fe5ee3fc48f91:
> > https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.
> > git;a=commit;h=c50d43a06a2044320c4e695b487fe5ee3fc48f91
> >
> >
> > Release artifacts are signed with the following key:
> > https://dist.apache.org/repos/dist/dev/incubator/s2graph/KEYS
> >
> > Once download source, please look into README.md to build from source.
> >
> > There are 3 issues has been resolved since RC3.
> >
> > 1. Added missing license headers on files (S2GRAPH-113, S2GRAPH-114).
> > 2. Add more committer's public keys on KEYS file (S2GRAPH-110).
> >
> > The vote will be open for at least 72 hours. Unless objection I will try
> to
> > close it Sunday September 25 if we have sufficient votes.
> >
> > Please download the release candidate and evaluate the necessary items
> > including checking hashes, signatures, build from source, and test.
> > please vote:
> >
> > [ ] +1 Release this package as 0.1.0
> > [ ] +0 no opinion
> > [ ] -1 Do not release this package because...
> >
> > Thanks,
> > DOYUNG YOON.
> >
>
>
>
> --
> Sergio Fernández
> Partner Technology Manager
> Redlink GmbH
> m: +43 6602747925
> e: sergio.fernan...@redlink.co
> w: http://redlink.co
>

Reply via email to