[jira] [Commented] (S2GRAPH-248) HTTP interface integration.
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751056#comment-16751056 ] ASF GitHub Bot commented on S2GRAPH-248: Github user asfgit closed the pull request at: https://github.com/apache/incubator-s2graph/pull/193 > HTTP interface integration. > --- > > Key: S2GRAPH-248 > URL: https://issues.apache.org/jira/browse/S2GRAPH-248 > Project: S2Graph > Issue Type: Task > Components: s2core, s2rest_netty, s2rest_play >Reporter: Daewon Jeong >Priority: Minor > > The current HTTP interface in S2Graph has the following problems. > known issues: > 1. The `s2rest_netty` project is experimental and supports only `graph > traverse` API. > 2. `s2rest_play` based on Play! Framework. > - Play! Framework is full stack framework, so it has a lot of > dependencies that s2graph does not need. > - There is also a conflict with byte buddy for patching asynchbase. > 3. `GraphQL` is still in the experimental phase and does not yet provide > all the functionality. > The discussion below is written on the link below. > discussions: > [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E] > > Based on this issue, the following work should be done. > * Create an HTTP interface project(without play!) > * Remove s2rest_netty > * API documentation (GraphQL, Rest) > * GraphQL and Rest HTTP interface integration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (S2GRAPH-248) HTTP interface integration.
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718799#comment-16718799 ] ASF GitHub Bot commented on S2GRAPH-248: GitHub user daewon opened a pull request: https://github.com/apache/incubator-s2graph/pull/193 [S2GRAPH-248] HTTP interface integration. Work to resolve this issue. 1. Crete s2http project and migrate functions (from s2rest_play) 2. Remove the http layer from s2graphql project and integrate into s2http 3. Set default startup script to use s2http on package. Todo: migrate s2rest_play tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/daewon/incubator-s2graph S2GRAPH-248 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-s2graph/pull/193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #193 commit a16ecb08819ea01f4498dfdd371717de56387a72 Author: daewon Date: 2018-11-26T08:11:36Z s2http initial commit commit 4154bbe1605a1fc7f4b8cae6fda71ecf8b317319 Author: daewon Date: 2018-11-28T04:51:43Z add PlayJsonSupport commit b8ab86dd39fd3810afcf44160324fa2dc6f5ee3f Author: DO YUNG YOON Date: 2018-11-29T01:51:20Z merge S2GRAPH-249 commit 1dda954d3c07ddb0966546501c3078c67e2cbc04 Author: daewon Date: 2018-11-29T08:16:24Z Merge pull request #3 from SteamShon/S2GRAPH-248 @SteamShon Thanks for your work.! merge [S2GRAPH-249] commit f41ab569345e9180e8f66355422bbeb7548f0670 Author: daewon Date: 2018-11-29T09:55:39Z merge S2GRAPH-249 commit dcaa1f34c4dd9bba863d5e532b9b0893e6b9a287 Author: daewon Date: 2018-11-30T07:46:03Z add graphql route in s2http commit ac630bf68c777fe963f1beaba90d7989fe755e4f Author: daewon Date: 2018-12-12T10:47:31Z Change startup script project to s2http > HTTP interface integration. > --- > > Key: S2GRAPH-248 > URL: https://issues.apache.org/jira/browse/S2GRAPH-248 > Project: S2Graph > Issue Type: Task > Components: s2core, s2rest_netty, s2rest_play >Reporter: Daewon Jeong >Priority: Minor > > The current HTTP interface in S2Graph has the following problems. > known issues: > 1. The `s2rest_netty` project is experimental and supports only `graph > traverse` API. > 2. `s2rest_play` based on Play! Framework. > - Play! Framework is full stack framework, so it has a lot of > dependencies that s2graph does not need. > - There is also a conflict with byte buddy for patching asynchbase. > 3. `GraphQL` is still in the experimental phase and does not yet provide > all the functionality. > The discussion below is written on the link below. > discussions: > [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E] > > Based on this issue, the following work should be done. > * Create an HTTP interface project(without play!) > * Remove s2rest_netty > * API documentation (GraphQL, Rest) > * GraphQL and Rest HTTP interface integration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (S2GRAPH-248) HTTP interface integration.
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704375#comment-16704375 ] Daewon Jeong commented on S2GRAPH-248: -- [~steamshon] Thank you for your suggestion. I think that all five things you presented are important. I just removed the http dependency from the s2graphql project and integrated it into the s2http project. I will modify the startup script so that s2http will work in place of s2rest_play when we package the project and we will close the issue. > HTTP interface integration. > --- > > Key: S2GRAPH-248 > URL: https://issues.apache.org/jira/browse/S2GRAPH-248 > Project: S2Graph > Issue Type: Task > Components: s2core, s2rest_netty, s2rest_play >Reporter: Daewon Jeong >Priority: Minor > > The current HTTP interface in S2Graph has the following problems. > known issues: > 1. The `s2rest_netty` project is experimental and supports only `graph > traverse` API. > 2. `s2rest_play` based on Play! Framework. > - Play! Framework is full stack framework, so it has a lot of > dependencies that s2graph does not need. > - There is also a conflict with byte buddy for patching asynchbase. > 3. `GraphQL` is still in the experimental phase and does not yet provide > all the functionality. > The discussion below is written on the link below. > discussions: > [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E] > > Based on this issue, the following work should be done. > * Create an HTTP interface project(without play!) > * Remove s2rest_netty > * API documentation (GraphQL, Rest) > * GraphQL and Rest HTTP interface integration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (S2GRAPH-248) HTTP interface integration.
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704141#comment-16704141 ] DOYUNG YOON commented on S2GRAPH-248: - [~daewon] Thanks for reviewing and mering it! I think we moved most of APIS on https://github.com/daewon/incubator-s2graph/pull/3. Here is the list I think we need to do for this issue. 1. add routes for s2graphql. I think it would be good for s2graphql project to hold graphql specific code, not http parts, then let s2http depends on s2graphql and add `Route` for graphql support on the s2http. 2. documentation since few APIs has been changed, I think it would be good to update document on our new documtation directory `doc`. Let's discuss how we document routes so users can try s2http more easily. 3. test cases I am not sure if we need full test cases on every routes in s2http, since all it does is pretty much unmarshall http request and call S2Graph's internal method. Since we have basic test cases covered on s2core, I think we can skip this and separate adding test cases as separate task. 4. startup script Change scripts to support s2http, and make sure it works. 5. deprecate s2rest_play, s2rest_netty Announce the deprecation of s2rest_netty, s2rest_play on our mailing. Please feel free to comments. > HTTP interface integration. > --- > > Key: S2GRAPH-248 > URL: https://issues.apache.org/jira/browse/S2GRAPH-248 > Project: S2Graph > Issue Type: Task > Components: s2core, s2rest_netty, s2rest_play >Reporter: Daewon Jeong >Priority: Minor > > The current HTTP interface in S2Graph has the following problems. > known issues: > 1. The `s2rest_netty` project is experimental and supports only `graph > traverse` API. > 2. `s2rest_play` based on Play! Framework. > - Play! Framework is full stack framework, so it has a lot of > dependencies that s2graph does not need. > - There is also a conflict with byte buddy for patching asynchbase. > 3. `GraphQL` is still in the experimental phase and does not yet provide > all the functionality. > The discussion below is written on the link below. > discussions: > [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E] > > Based on this issue, the following work should be done. > * Create an HTTP interface project(without play!) > * Remove s2rest_netty > * API documentation (GraphQL, Rest) > * GraphQL and Rest HTTP interface integration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (S2GRAPH-248) HTTP interface integration.
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702614#comment-16702614 ] DOYUNG YOON commented on S2GRAPH-248: - [~daewon] Hi daewon. I copied missing APIs from s2rest_play to s2http based on your branch(remote: daewon, branch: S2GRAPH0248). I am not very familiar with akka http yet, so please review the PR(https://github.com/daewon/incubator-s2graph/pull/3) and let me know if there are better way to implement these. > HTTP interface integration. > --- > > Key: S2GRAPH-248 > URL: https://issues.apache.org/jira/browse/S2GRAPH-248 > Project: S2Graph > Issue Type: Task > Components: s2core, s2rest_netty, s2rest_play >Reporter: Daewon Jeong >Priority: Minor > > The current HTTP interface in S2Graph has the following problems. > known issues: > 1. The `s2rest_netty` project is experimental and supports only `graph > traverse` API. > 2. `s2rest_play` based on Play! Framework. > - Play! Framework is full stack framework, so it has a lot of > dependencies that s2graph does not need. > - There is also a conflict with byte buddy for patching asynchbase. > 3. `GraphQL` is still in the experimental phase and does not yet provide > all the functionality. > The discussion below is written on the link below. > discussions: > [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E] > > Based on this issue, the following work should be done. > * Create an HTTP interface project(without play!) > * Remove s2rest_netty > * API documentation (GraphQL, Rest) > * GraphQL and Rest HTTP interface integration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [jira] [Commented] (S2GRAPH-248) HTTP interface integration.
@DOYUNG
Thank you for your feedback.
I think the graphql project does not need to have an http layer.
Therefore, in the s2graphql project, i want to remove the http layer by
leaving only graphql's unique functions such as schema creation and query
parsing.
I will also be able to set the graphql route in s2http.
ex) Trait S2GraphqlRoute {}
2018년 11월 27일 (화) 오전 10:30에 DO YUNG YOON 님이 작성:
> No problem deawon, I will work on S2GRAPH-249 based on your commit.
>
> Just quick questions, I guess you mention 4 high-level functionalities.
>
> 1. write
> 2. read
> 3. admin
> 4. graphql
>
> It seems like you intend to migrate s2graphql also into this new subproject
> s2http, so just quick question, are we going to deprecate s2graphql
> subproject?
>
> On Mon, Nov 26, 2018 at 5:38 PM daewon wrote:
>
> > [S2GRAPH-248] I made the first commit for the issue.
> >
> > Link:
> https://github.com/daewon/incubator-s2graph/tree/S2GRAPH-248/s2http
> >
> > I chose `akka http` because it was stable and lightweight with the`
> > framework` for `http layer`.
> > The initial implementation focused on minimizing external dependencies
> and
> > allowing the separate logically separate functions `write, read, admin,
> > graphql`.
> >
> > To do this, I chose to define logically separated `route` functions as
> each
> > `Trait` S2GraphAdminRoute | S2GraphTraversalRoute. (Please comment if you
> > have any opinions)
> >
> > An example implementation of functionality is `getEdges, experiments`,
> etc.
> > in` S2GraphTraversalRoute`.
> >
> > The `/graphs/*` APIs are implemented to be branched from the existing
> > restHandler.
> > Implement it first by delegating that function.
> >
> > ```
> > // expose routes in `S2GraphTraversalRoute` Trait
> > lazy val traversalRoute: Route =
> > post {
> > concat(
> > delegated // getEdges, experiments, etc.
> > )
> > }
> > ```
> >
> > An example implementation of functionality is `get / create Label /
> > Service` in `S2GraphAdminRoute`.
> >
> > ```
> > // expose routes in `S2GraphAdminRoute` Trait
> > lazy val adminRoute: Route =
> > get {
> > concat(
> > getService,
> > getLabel
> > )
> > } ~ post {
> > concat(
> > createService,
> > createLabel
> > )
> > }
> > ```
> >
> > There is a brief description in README.md about running the server and
> > testing its functionality.
> >
> > I think the rest of the functions will be created by creating each issue.
> >
> > @DOYUNG `https://issues.apache.org/jira/browse/S2GRAPH-249`
>
> > It seems to be
> > related to the issue.
> >
> >
> > 2018년 11월 23일 (금) 오후 2:18, Daewon Jeong (JIRA) 님이 작성:
> >
> > >
> > > [
> > >
> >
> https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696384#comment-16696384
> > > ]
> > >
> > > Daewon Jeong commented on S2GRAPH-248:
> > > --
> > >
> > > [~steamshon] Thank you for your feedback.
> > >
> > > I will quickly build a basic project that will be the base for HTTP
> > > integration task.
> > >
> > > > HTTP interface integration.
> > > > ---
> > > >
> > > > Key: S2GRAPH-248
> > > > URL:
> https://issues.apache.org/jira/browse/S2GRAPH-248
> > > > Project: S2Graph
> > > > Issue Type: Task
> > > > Components: s2core, s2rest_netty, s2rest_play
> > > >Reporter: Daewon Jeong
> > > >Priority: Minor
> > > >
> > > > The current HTTP interface in S2Graph has the following problems.
> > > > known issues:
> > > >1. The `s2rest_netty` project is experimental and supports only
> > > `graph traverse` API.
> > > >2. `s2rest_play` based on Play! Framework.
> > > > - Play! Framework is full stack framework, so it has a lot of
> > > dependencies that s2graph does not need.
> > > > - There is also a conflict with byte buddy for patching
> > asynchbase.
> > > >3. `GraphQL` is still in the experimental phase and does not yet
> > > provide all the functionality.
> > > > The discussion below is written on the link below.
> > > > discussions: [
> > >
> >
> https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E
> > > ]
> > > >
> > > > Based on this issue, the following work should be done.
> > > > * Create an HTTP interface project(without play!)
> > > > * Remove s2rest_netty
> > > > * API documentation (GraphQL, Rest)
> > > > * GraphQL and Rest HTTP interface integration
> > >
> > >
> > >
> > > --
> > > This message was sent by Atlassian JIRA
> > > (v7.6.3#76005)
> > >
> >
>
Re: [jira] [Commented] (S2GRAPH-248) HTTP interface integration.
No problem deawon, I will work on S2GRAPH-249 based on your commit.
Just quick questions, I guess you mention 4 high-level functionalities.
1. write
2. read
3. admin
4. graphql
It seems like you intend to migrate s2graphql also into this new subproject
s2http, so just quick question, are we going to deprecate s2graphql
subproject?
On Mon, Nov 26, 2018 at 5:38 PM daewon wrote:
> [S2GRAPH-248] I made the first commit for the issue.
>
> Link: https://github.com/daewon/incubator-s2graph/tree/S2GRAPH-248/s2http
>
> I chose `akka http` because it was stable and lightweight with the`
> framework` for `http layer`.
> The initial implementation focused on minimizing external dependencies and
> allowing the separate logically separate functions `write, read, admin,
> graphql`.
>
> To do this, I chose to define logically separated `route` functions as each
> `Trait` S2GraphAdminRoute | S2GraphTraversalRoute. (Please comment if you
> have any opinions)
>
> An example implementation of functionality is `getEdges, experiments`, etc.
> in` S2GraphTraversalRoute`.
>
> The `/graphs/*` APIs are implemented to be branched from the existing
> restHandler.
> Implement it first by delegating that function.
>
> ```
> // expose routes in `S2GraphTraversalRoute` Trait
> lazy val traversalRoute: Route =
> post {
> concat(
> delegated // getEdges, experiments, etc.
> )
> }
> ```
>
> An example implementation of functionality is `get / create Label /
> Service` in `S2GraphAdminRoute`.
>
> ```
> // expose routes in `S2GraphAdminRoute` Trait
> lazy val adminRoute: Route =
> get {
> concat(
> getService,
> getLabel
> )
> } ~ post {
> concat(
> createService,
> createLabel
> )
> }
> ```
>
> There is a brief description in README.md about running the server and
> testing its functionality.
>
> I think the rest of the functions will be created by creating each issue.
>
> @DOYUNG `https://issues.apache.org/jira/browse/S2GRAPH-249`
> It seems to be
> related to the issue.
>
>
> 2018년 11월 23일 (금) 오후 2:18, Daewon Jeong (JIRA) 님이 작성:
>
> >
> > [
> >
> https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696384#comment-16696384
> > ]
> >
> > Daewon Jeong commented on S2GRAPH-248:
> > --
> >
> > [~steamshon] Thank you for your feedback.
> >
> > I will quickly build a basic project that will be the base for HTTP
> > integration task.
> >
> > > HTTP interface integration.
> > > ---
> > >
> > > Key: S2GRAPH-248
> > > URL: https://issues.apache.org/jira/browse/S2GRAPH-248
> > > Project: S2Graph
> > > Issue Type: Task
> > > Components: s2core, s2rest_netty, s2rest_play
> > >Reporter: Daewon Jeong
> > >Priority: Minor
> > >
> > > The current HTTP interface in S2Graph has the following problems.
> > > known issues:
> > >1. The `s2rest_netty` project is experimental and supports only
> > `graph traverse` API.
> > >2. `s2rest_play` based on Play! Framework.
> > > - Play! Framework is full stack framework, so it has a lot of
> > dependencies that s2graph does not need.
> > > - There is also a conflict with byte buddy for patching
> asynchbase.
> > >3. `GraphQL` is still in the experimental phase and does not yet
> > provide all the functionality.
> > > The discussion below is written on the link below.
> > > discussions: [
> >
> https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E
> > ]
> > >
> > > Based on this issue, the following work should be done.
> > > * Create an HTTP interface project(without play!)
> > > * Remove s2rest_netty
> > > * API documentation (GraphQL, Rest)
> > > * GraphQL and Rest HTTP interface integration
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v7.6.3#76005)
> >
>
Re: [jira] [Commented] (S2GRAPH-248) HTTP interface integration.
[S2GRAPH-248] I made the first commit for the issue.
Link: https://github.com/daewon/incubator-s2graph/tree/S2GRAPH-248/s2http
I chose `akka http` because it was stable and lightweight with the`
framework` for `http layer`.
The initial implementation focused on minimizing external dependencies and
allowing the separate logically separate functions `write, read, admin,
graphql`.
To do this, I chose to define logically separated `route` functions as each
`Trait` S2GraphAdminRoute | S2GraphTraversalRoute. (Please comment if you
have any opinions)
An example implementation of functionality is `getEdges, experiments`, etc.
in` S2GraphTraversalRoute`.
The `/graphs/*` APIs are implemented to be branched from the existing
restHandler.
Implement it first by delegating that function.
```
// expose routes in `S2GraphTraversalRoute` Trait
lazy val traversalRoute: Route =
post {
concat(
delegated // getEdges, experiments, etc.
)
}
```
An example implementation of functionality is `get / create Label /
Service` in `S2GraphAdminRoute`.
```
// expose routes in `S2GraphAdminRoute` Trait
lazy val adminRoute: Route =
get {
concat(
getService,
getLabel
)
} ~ post {
concat(
createService,
createLabel
)
}
```
There is a brief description in README.md about running the server and
testing its functionality.
I think the rest of the functions will be created by creating each issue.
@DOYUNG `https://issues.apache.org/jira/browse/S2GRAPH-249` It seems to be
related to the issue.
2018년 11월 23일 (금) 오후 2:18, Daewon Jeong (JIRA) 님이 작성:
>
> [
> https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696384#comment-16696384
> ]
>
> Daewon Jeong commented on S2GRAPH-248:
> --
>
> [~steamshon] Thank you for your feedback.
>
> I will quickly build a basic project that will be the base for HTTP
> integration task.
>
> > HTTP interface integration.
> > ---
> >
> > Key: S2GRAPH-248
> > URL: https://issues.apache.org/jira/browse/S2GRAPH-248
> > Project: S2Graph
> > Issue Type: Task
> > Components: s2core, s2rest_netty, s2rest_play
> >Reporter: Daewon Jeong
> >Priority: Minor
> >
> > The current HTTP interface in S2Graph has the following problems.
> > known issues:
> >1. The `s2rest_netty` project is experimental and supports only
> `graph traverse` API.
> >2. `s2rest_play` based on Play! Framework.
> > - Play! Framework is full stack framework, so it has a lot of
> dependencies that s2graph does not need.
> > - There is also a conflict with byte buddy for patching asynchbase.
> >3. `GraphQL` is still in the experimental phase and does not yet
> provide all the functionality.
> > The discussion below is written on the link below.
> > discussions: [
> https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E
> ]
> >
> > Based on this issue, the following work should be done.
> > * Create an HTTP interface project(without play!)
> > * Remove s2rest_netty
> > * API documentation (GraphQL, Rest)
> > * GraphQL and Rest HTTP interface integration
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>
[jira] [Commented] (S2GRAPH-248) HTTP interface integration.
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696384#comment-16696384 ] Daewon Jeong commented on S2GRAPH-248: -- [~steamshon] Thank you for your feedback. I will quickly build a basic project that will be the base for HTTP integration task. > HTTP interface integration. > --- > > Key: S2GRAPH-248 > URL: https://issues.apache.org/jira/browse/S2GRAPH-248 > Project: S2Graph > Issue Type: Task > Components: s2core, s2rest_netty, s2rest_play >Reporter: Daewon Jeong >Priority: Minor > > The current HTTP interface in S2Graph has the following problems. > known issues: > 1. The `s2rest_netty` project is experimental and supports only `graph > traverse` API. > 2. `s2rest_play` based on Play! Framework. > - Play! Framework is full stack framework, so it has a lot of > dependencies that s2graph does not need. > - There is also a conflict with byte buddy for patching asynchbase. > 3. `GraphQL` is still in the experimental phase and does not yet provide > all the functionality. > The discussion below is written on the link below. > discussions: > [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E] > > Based on this issue, the following work should be done. > * Create an HTTP interface project(without play!) > * Remove s2rest_netty > * API documentation (GraphQL, Rest) > * GraphQL and Rest HTTP interface integration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (S2GRAPH-248) HTTP interface integration.
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696304#comment-16696304 ] DOYUNG YOON commented on S2GRAPH-248: - [~daewon] Many thanks for opening up this issue. In summary, I think the categories for APIs are following. # Vertex Mutate API # Vertex Query API # Edge Mutate API # Edge Query API # Admin API # GraphQL API I volunteer to work on Vertex Mutate API + Vertex Query API if no one mind. > HTTP interface integration. > --- > > Key: S2GRAPH-248 > URL: https://issues.apache.org/jira/browse/S2GRAPH-248 > Project: S2Graph > Issue Type: Task > Components: s2core, s2rest_netty, s2rest_play >Reporter: Daewon Jeong >Priority: Minor > > The current HTTP interface in S2Graph has the following problems. > known issues: > 1. The `s2rest_netty` project is experimental and supports only `graph > traverse` API. > 2. `s2rest_play` based on Play! Framework. > - Play! Framework is full stack framework, so it has a lot of > dependencies that s2graph does not need. > - There is also a conflict with byte buddy for patching asynchbase. > 3. `GraphQL` is still in the experimental phase and does not yet provide > all the functionality. > The discussion below is written on the link below. > discussions: > [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E] > > Based on this issue, the following work should be done. > * Create an HTTP interface project(without play!) > * Remove s2rest_netty > * API documentation (GraphQL, Rest) > * GraphQL and Rest HTTP interface integration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
