[GitHub] [samza] mynameborat commented on issue #981: Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when required

2019-04-01 Thread GitBox
mynameborat commented on issue #981: Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when required URL: https://github.com/apache/samza/pull/981#issuecomment-478844338 Can you create a JIRA and add explanation around the bug and

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

2019-03-29 Thread GitBox
rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270498446 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java ## @@

[GitHub] [samza] prateekm opened a new pull request #980: Cleaned up AM logs and naming convention

2019-03-29 Thread GitBox
prateekm opened a new pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980 1. To disambiguate between YARN containers and Samza Processor. 2. Use consistent logging format. Now can search logs with strings "Container ID: ",

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

2019-03-29 Thread GitBox
rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270496794 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java ## @@

[GitHub] [samza] prateekm commented on issue #980: Cleaned up AM logs and naming convention

2019-03-29 Thread GitBox
prateekm commented on issue #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#issuecomment-478070467 @vjagadish1989 @rmatharu Please take a look. This is an automated message from

[GitHub] [samza] mynameborat commented on issue #905: SAMZA-2055: Async high level api

2019-04-02 Thread GitBox
mynameborat commented on issue #905: SAMZA-2055: Async high level api URL: https://github.com/apache/samza/pull/905#issuecomment-479058100 `testSinkEndToEndWithKeyWithNullRecords` seems to be flaky. I have a 60% pass rate locally.

[GitHub] [samza] prateekm commented on a change in pull request #981: SAMZA-2152 : Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when requir

2019-04-02 Thread GitBox
prateekm commented on a change in pull request #981: SAMZA-2152 : Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when required URL: https://github.com/apache/samza/pull/981#discussion_r271393999 ## File path:

[GitHub] [samza] prateekm commented on a change in pull request #981: SAMZA-2152 : Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when requir

2019-04-02 Thread GitBox
prateekm commented on a change in pull request #981: SAMZA-2152 : Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when required URL: https://github.com/apache/samza/pull/981#discussion_r271392441 ## File path:

[GitHub] [samza] rmatharu commented on issue #981: SAMZA-2152 : Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when required

2019-04-02 Thread GitBox
rmatharu commented on issue #981: SAMZA-2152 : Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when required URL: https://github.com/apache/samza/pull/981#issuecomment-479104652 addressed your comments. adminClient accesses seem

[GitHub] [samza] mynameborat commented on issue #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-20 Thread GitBox
mynameborat commented on issue #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#issuecomment-475113792 Summary of 44d8c97 * Combined StandaloneIntegrationTestHarness and AbstractIntegrationTestHarness into IntegrationTestHarness. * Modified some

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267633462 ## File path:

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267638693 ## File path:

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267638140 ## File path:

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267636464 ## File path:

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267635690 ## File path:

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267636016 ## File path:

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267635366 ## File path:

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267638815 ## File path:

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267635139 ## File path:

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-21 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r267633751 ## File path:

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-20 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r267623921 ## File path: samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala ## @@ -301,12

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-20 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r267623375 ## File path: samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala ## @@

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-20 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r267582422 ## File path: samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala ## @@ -257,17

[GitHub] [samza] shanthoosh opened a new pull request #973: Remove semicolon from sub-headings of 1.1 blog post.

2019-03-25 Thread GitBox
shanthoosh opened a new pull request #973: Remove semicolon from sub-headings of 1.1 blog post. URL: https://github.com/apache/samza/pull/973 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [samza] shanthoosh commented on issue #974: SAMZA-2147: Improve the documentation of the samza release process.

2019-03-25 Thread GitBox
shanthoosh commented on issue #974: SAMZA-2147: Improve the documentation of the samza release process. URL: https://github.com/apache/samza/pull/974#issuecomment-476433492 @dxichen Please take a look when you have a chance.

[GitHub] [samza] vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys

2019-03-25 Thread GitBox
vjagadish1989 commented on a change in pull request #952: Improved standby-aware container allocation for active-containers on job redeploys URL: https://github.com/apache/samza/pull/952#discussion_r268930336 ## File path:

[GitHub] [samza] cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-25 Thread GitBox
cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268902437 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTestHarness.java

[GitHub] [samza] cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-25 Thread GitBox
cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268901338 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -594,7 +593,13

[GitHub] [samza] shanthoosh merged pull request #974: SAMZA-2147: Improve the documentation of the samza release process.

2019-03-25 Thread GitBox
shanthoosh merged pull request #974: SAMZA-2147: Improve the documentation of the samza release process. URL: https://github.com/apache/samza/pull/974 This is an automated message from the Apache Git Service. To respond to

[GitHub] [samza] dengpanyin commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default.

2019-03-25 Thread GitBox
dengpanyin commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default. URL: https://github.com/apache/samza/pull/961#discussion_r268860718 ## File path: samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java

[GitHub] [samza] dengpanyin commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default.

2019-03-25 Thread GitBox
dengpanyin commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default. URL: https://github.com/apache/samza/pull/961#discussion_r268856771 ## File path: samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java

[GitHub] [samza] cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-25 Thread GitBox
cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268900710 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -594,7 +593,13

[GitHub] [samza] asfgit closed pull request #972: [SAMZA-2146] - Expose physical name in StreamDescriptor

2019-03-25 Thread GitBox
asfgit closed pull request #972: [SAMZA-2146] - Expose physical name in StreamDescriptor URL: https://github.com/apache/samza/pull/972 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [samza] shanthoosh edited a comment on issue #975: SAMZA-2148: Fix the rendering of bash and sql scripts in samza-sql release validation page.

2019-03-25 Thread GitBox
shanthoosh edited a comment on issue #975: SAMZA-2148: Fix the rendering of bash and sql scripts in samza-sql release validation page. URL: https://github.com/apache/samza/pull/975#issuecomment-476437090 @srinipunuru @atoomula Please take a look when you have a chance. I've

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-25 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268891069 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -628,10 +589,12

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-25 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268861935 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-25 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268893914 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -628,10 +589,12

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-25 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268890341 ## File path: gradle/dependency-versions.gradle ## @@ -34,7 +34,7 @@ jodaTimeVersion = "2.2"

[GitHub] [samza] shanthoosh opened a new pull request #975: SAMZA-2148: Fix the rendering of bash and sql scripts in samza-sql release validation page.

2019-03-25 Thread GitBox
shanthoosh opened a new pull request #975: SAMZA-2148: Fix the rendering of bash and sql scripts in samza-sql release validation page. URL: https://github.com/apache/samza/pull/975 Currently, the bash/sql scripts available in samza-sql release validation page were not using the proper

[GitHub] [samza] shanthoosh commented on issue #975: SAMZA-2148: Fix the rendering of bash and sql scripts in samza-sql release validation page.

2019-03-25 Thread GitBox
shanthoosh commented on issue #975: SAMZA-2148: Fix the rendering of bash and sql scripts in samza-sql release validation page. URL: https://github.com/apache/samza/pull/975#issuecomment-476437090 @srinipunuru Please take a look when you have a chance. I've attached the screenshot of the

[GitHub] [samza] shanthoosh commented on issue #973: Remove semicolon from sub-headings of 1.1 blog post.

2019-03-25 Thread GitBox
shanthoosh commented on issue #973: Remove semicolon from sub-headings of 1.1 blog post. URL: https://github.com/apache/samza/pull/973#issuecomment-476411309 Thanks for the quick review Daniel. Since the change involves minor documentation cleanup, merging it to trunk.

[GitHub] [samza] shanthoosh merged pull request #973: Remove semicolon from sub-headings of 1.1 blog post.

2019-03-25 Thread GitBox
shanthoosh merged pull request #973: Remove semicolon from sub-headings of 1.1 blog post. URL: https://github.com/apache/samza/pull/973 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [samza] vjagadish1989 commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default.

2019-03-25 Thread GitBox
vjagadish1989 commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default. URL: https://github.com/apache/samza/pull/961#discussion_r268846328 ## File path: samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java

[GitHub] [samza] mynameborat opened a new pull request #972: [SAMZA-2146] - Expose physical name in StreamDescriptor

2019-03-25 Thread GitBox
mynameborat opened a new pull request #972: [SAMZA-2146] - Expose physical name in StreamDescriptor URL: https://github.com/apache/samza/pull/972 Refer to https://issues.apache.org/jira/browse/SAMZA-2146 for more details

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-26 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268899597 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-26 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268961813 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -594,7 +593,13 @@

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-26 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268959127 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-26 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268902597 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -668,22 +631,86

[GitHub] [samza] weisong44 commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default.

2019-03-26 Thread GitBox
weisong44 commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default. URL: https://github.com/apache/samza/pull/961#discussion_r269080557 ## File path: samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java

[GitHub] [samza] weisong44 commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default.

2019-03-26 Thread GitBox
weisong44 commented on a change in pull request #961: SAMZA-2134:Enable table rate limiter by default. URL: https://github.com/apache/samza/pull/961#discussion_r269080884 ## File path: samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java

[GitHub] [samza] srinipunuru opened a new pull request #979: SAMZA-2110 : Support for deleting records from a table

2019-03-27 Thread GitBox
srinipunuru opened a new pull request #979: SAMZA-2110 : Support for deleting records from a table URL: https://github.com/apache/samza/pull/979 1. Commit adds support for deleting records from table by adding a special __op__ field. SQL users can use this field to say whether the row

[GitHub] [samza] shanthoosh commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass

2019-03-27 Thread GitBox
shanthoosh commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass URL: https://github.com/apache/samza/pull/978#discussion_r269649574 ## File path:

[GitHub] [samza] prateekm commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass

2019-03-27 Thread GitBox
prateekm commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass URL: https://github.com/apache/samza/pull/978#discussion_r269637384 ## File path:

[GitHub] [samza] rmatharu commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass

2019-03-27 Thread GitBox
rmatharu commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass URL: https://github.com/apache/samza/pull/978#discussion_r269684095 ## File path:

[GitHub] [samza] rmatharu commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass

2019-03-27 Thread GitBox
rmatharu commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass URL: https://github.com/apache/samza/pull/978#discussion_r269684095 ## File path:

[GitHub] [samza] shanthoosh commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass

2019-03-27 Thread GitBox
shanthoosh commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass URL: https://github.com/apache/samza/pull/978#discussion_r269704869 ## File path:

[GitHub] [samza] atoomula merged pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass

2019-03-27 Thread GitBox
atoomula merged pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass URL: https://github.com/apache/samza/pull/978 This is an automated message from the Apache Git Service. To

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-27 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r269749949 ## File path: samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala ## @@ -169,59

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-27 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r269750016 ## File path: gradle/dependency-versions.gradle ## @@ -34,7 +34,7 @@ jodaTimeVersion = "2.2"

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-27 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r269747800 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -594,7 +593,13

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-27 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r269747886 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -594,7 +593,13

[GitHub] [samza] mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-27 Thread GitBox
mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r269750805 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on issue #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java

2019-03-26 Thread GitBox
shanthoosh commented on issue #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java URL: https://github.com/apache/samza/pull/955#issuecomment-476785179 @cameronlee314 Thanks for the changes. Merged to trunk.

[GitHub] [samza] srinipunuru opened a new pull request #966: Moving the Fixes from internal AvroRelConverter

2019-03-22 Thread GitBox
srinipunuru opened a new pull request #966: Moving the Fixes from internal AvroRelConverter URL: https://github.com/apache/samza/pull/966 Misc fixes that are made in internal copy of AvroRelConverter. This is an automated

[GitHub] [samza] shanthoosh merged pull request #967: Add 1.1.0 tools download page

2019-03-22 Thread GitBox
shanthoosh merged pull request #967: Add 1.1.0 tools download page URL: https://github.com/apache/samza/pull/967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [samza] dnishimura opened a new pull request #971: SAMZA-2144: In TaskInstance, bypass "SSP caught-up" check if offset is set by a startpoint

2019-03-24 Thread GitBox
dnishimura opened a new pull request #971: SAMZA-2144: In TaskInstance, bypass "SSP caught-up" check if offset is set by a startpoint URL: https://github.com/apache/samza/pull/971 TaskInstance maintains a "SSP caught-up map" to ensure that all tasks for the same SSP have caught up to he

[GitHub] [samza] shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java

2019-03-24 Thread GitBox
shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java URL: https://github.com/apache/samza/pull/955#discussion_r268481956 ## File path:

[GitHub] [samza] shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java

2019-03-24 Thread GitBox
shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java URL: https://github.com/apache/samza/pull/955#discussion_r268481428 ## File path:

[GitHub] [samza] shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java

2019-03-24 Thread GitBox
shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java URL: https://github.com/apache/samza/pull/955#discussion_r268010269 ## File path:

[GitHub] [samza] shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java

2019-03-24 Thread GitBox
shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java URL: https://github.com/apache/samza/pull/955#discussion_r268481222 ## File path:

[GitHub] [samza] shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java

2019-03-24 Thread GitBox
shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java URL: https://github.com/apache/samza/pull/955#discussion_r268415931 ## File path:

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386607 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -668,22 +631,86

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268384606 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -628,10 +589,12

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386258 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTestHarness.java

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386045 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386127 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386095 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386706 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -668,22 +631,86

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268385471 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -711,4 +738,29 @@

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268385422 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -628,10 +589,12

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386149 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386358 ## File path: gradle/dependency-versions.gradle ## @@ -34,7 +34,7 @@ jodaTimeVersion = "2.2" joptSimpleVersion

[GitHub] [samza] shanthoosh commented on a change in pull request #960: Update website for 1.1.0

2019-03-22 Thread GitBox
shanthoosh commented on a change in pull request #960: Update website for 1.1.0 URL: https://github.com/apache/samza/pull/960#discussion_r268372496 ## File path: docs/learn/tutorials/versioned/hello-samza-high-level-yarn.md ## @@ -63,7 +62,7 @@ Then, you can continue w/

[GitHub] [samza-hello-samza] shanthoosh commented on issue #39: Sample application to illustrate side-inputs using stream table join

2019-03-22 Thread GitBox
shanthoosh commented on issue #39: Sample application to illustrate side-inputs using stream table join URL: https://github.com/apache/samza-hello-samza/pull/39#issuecomment-475833257 Is this pull-request no longer necessary? Can we close if not needed.

[GitHub] [samza] shanthoosh commented on a change in pull request #960: Update website for 1.1.0

2019-03-22 Thread GitBox
shanthoosh commented on a change in pull request #960: Update website for 1.1.0 URL: https://github.com/apache/samza/pull/960#discussion_r268373402 ## File path: docs/learn/tutorials/versioned/hello-samza-high-level-yarn.md ## @@ -63,7 +62,7 @@ Then, you can continue w/

[GitHub] [samza] shanthoosh merged pull request #960: Update website for 1.1.0

2019-03-22 Thread GitBox
shanthoosh merged pull request #960: Update website for 1.1.0 URL: https://github.com/apache/samza/pull/960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [samza-hello-samza] dxichen opened a new pull request #52: Latest changes for 1.1.0

2019-03-22 Thread GitBox
dxichen opened a new pull request #52: Latest changes for 1.1.0 URL: https://github.com/apache/samza-hello-samza/pull/52 Bumped versions, fixed incompatible changes This is an automated message from the Apache Git Service. To

[GitHub] [samza] shanthoosh commented on issue #969: SAMZA-2142: Add the samza 1.1 release announce post to the samza blog.

2019-03-22 Thread GitBox
shanthoosh commented on issue #969: SAMZA-2142: Add the samza 1.1 release announce post to the samza blog. URL: https://github.com/apache/samza/pull/969#issuecomment-475830232

[GitHub] [samza] shanthoosh opened a new pull request #969: SAMZA-2142: Add the samza 1.1 release announce post to the samza blog.

2019-03-22 Thread GitBox
shanthoosh opened a new pull request #969: SAMZA-2142: Add the samza 1.1 release announce post to the samza blog. URL: https://github.com/apache/samza/pull/969 This is an automated message from the Apache Git Service. To

[GitHub] [samza] shanthoosh merged pull request #968: SAMZA-2141: Adding samza 1.1.0 blog in markdown format.

2019-03-22 Thread GitBox
shanthoosh merged pull request #968: SAMZA-2141: Adding samza 1.1.0 blog in markdown format. URL: https://github.com/apache/samza/pull/968 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [samza] shanthoosh opened a new pull request #968: SAMZA-2141: Adding samza 1.1.0 blog in markdown format.

2019-03-22 Thread GitBox
shanthoosh opened a new pull request #968: SAMZA-2141: Adding samza 1.1.0 blog in markdown format. URL: https://github.com/apache/samza/pull/968 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [samza] shanthoosh commented on issue #968: SAMZA-2141: Adding samza 1.1.0 blog in markdown format.

2019-03-22 Thread GitBox
shanthoosh commented on issue #968: SAMZA-2141: Adding samza 1.1.0 blog in markdown format. URL: https://github.com/apache/samza/pull/968#issuecomment-475828530 @dxichen Please take a look when you have a chance. This is an

[GitHub] [samza] shanthoosh merged pull request #969: SAMZA-2142: Add the samza 1.1 release announce post to the samza blog.

2019-03-22 Thread GitBox
shanthoosh merged pull request #969: SAMZA-2142: Add the samza 1.1 release announce post to the samza blog. URL: https://github.com/apache/samza/pull/969 This is an automated message from the Apache Git Service. To respond

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386258 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTestHarness.java

[GitHub] [samza] srinipunuru commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter

2019-03-25 Thread GitBox
srinipunuru commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter URL: https://github.com/apache/samza/pull/966#discussion_r268728229 ## File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java ## @@ -170,22

[GitHub] [samza] srinipunuru commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter

2019-03-25 Thread GitBox
srinipunuru commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter URL: https://github.com/apache/samza/pull/966#discussion_r268731436 ## File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java ## @@ -271,45

[GitHub] [samza] asfgit closed pull request #905: SAMZA-2055: Async high level api

2019-04-03 Thread GitBox
asfgit closed pull request #905: SAMZA-2055: Async high level api URL: https://github.com/apache/samza/pull/905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [samza] srinipunuru merged pull request #983: Samza-2154: Fixing the testSinkEndToEndWithKeyWithNullRecords test case

2019-04-03 Thread GitBox
srinipunuru merged pull request #983: Samza-2154: Fixing the testSinkEndToEndWithKeyWithNullRecords test case URL: https://github.com/apache/samza/pull/983 This is an automated message from the Apache Git Service. To

[GitHub] [samza] Zhangyx39 opened a new pull request #982: SAMZA-2153: Implement to Config for TableRetryPolicy

2019-04-03 Thread GitBox
Zhangyx39 opened a new pull request #982: SAMZA-2153: Implement to Config for TableRetryPolicy URL: https://github.com/apache/samza/pull/982 Added setTableId and getTableId to TablePart interface. Implemented toConfig method in TableRetryPolicy to serialize the class to json format so

[GitHub] [samza] srinipunuru opened a new pull request #983: Fixing the testSinkEndToEndWithKeyWithNullRecords test case

2019-04-03 Thread GitBox
srinipunuru opened a new pull request #983: Fixing the testSinkEndToEndWithKeyWithNullRecords test case URL: https://github.com/apache/samza/pull/983 This is an automated message from the Apache Git Service. To respond to

  1   2   3   4   5   6   7   8   9   10   >