/test/java/org/apache/samza/sql/task/StoredRuntimeContext.java
PRE-CREATION
Diff: https://reviews.apache.org/r/29994/diff/
Testing
---
Thanks,
Yi Pan (Data Infrastructure)
025f0557bfcec85b325db4b2475eff633cfe2f4a
Diff: https://reviews.apache.org/r/30241/diff/
Testing
---
All links tested.
Travis/build related links and download links are not updated yet. Need to
follow up with that.
Thanks,
Yi Pan (Data Infrastructure)
/watcher.samsa
025f0557bfcec85b325db4b2475eff633cfe2f4a
Diff: https://reviews.apache.org/r/30241/diff/
Testing
---
All links tested.
Travis/build related links and download links are not updated yet. Need to
follow up with that.
Thanks,
Yi Pan (Data Infrastructure)
d on the output entity that they represent. i.e.
essentially, window expression and join expression are expressions that all
generate a table-type data source entity.
- Yi Pan (Data Infrastructure)
On Jan. 26, 2015, 10:04 p.m., Milinda Pathirage wrote:
>
>
ql/src/test/java/org/apache/samza/sql/task/StreamSqlTask.java
PRE-CREATION
settings.gradle 3a01fd66359b8c79954ae8f34eeaf4b2e3fdc0b4
Diff: https://reviews.apache.org/r/29754/diff/
Testing (updated)
---
run ./bin/check-all.sh passed
Thanks,
Yi Pan (Data Infrastructure)
ile=840328#file840328line37>
> >
> > StoreMessageCollector?
Sounds good to me.
- Yi
---------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29754/#review70380
---
pache/samza/task/sql/StreamSqlTask.java
PRE-CREATION
settings.gradle 3a01fd66359b8c79954ae8f34eeaf4b2e3fdc0b4
Diff: https://reviews.apache.org/r/29754/diff/
Testing
---
run ./bin/check-all.sh passed
Thanks,
Yi Pan (Data Infrastructure)
t; -------
>
> (Updated Jan. 26, 2015, 10:04 p.m.)
>
>
> Review request for samza, Chris Riccomini and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> ---
>
> WIP: Stream SQL Obje
ava/org/apache/samza/task/sql/StreamSqlTask.java
PRE-CREATION
settings.gradle 3a01fd66359b8c79954ae8f34eeaf4b2e3fdc0b4
Diff: https://reviews.apache.org/r/29754/diff/
Testing
---
run ./bin/check-all.sh passed
Thanks,
Yi Pan (Data Infrastructure)
rg/apache/samza/task/sql/StreamSqlTask.java
PRE-CREATION
settings.gradle 3a01fd66359b8c79954ae8f34eeaf4b2e3fdc0b4
Diff: https://reviews.apache.org/r/29754/diff/
Testing
---
run ./bin/check-all.sh passed
Thanks,
Yi Pan (Data Infrastructure)
samza/task/sql/StreamSqlTask.java
PRE-CREATION
settings.gradle 3a01fd66359b8c79954ae8f34eeaf4b2e3fdc0b4
Diff: https://reviews.apache.org/r/29754/diff/
Testing
---
run ./bin/check-all.sh passed
Thanks,
Yi Pan (Data Infrastructure)
/java/org/apache/samza/task/sql/StreamSqlTask.java
PRE-CREATION
settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb
Diff: https://reviews.apache.org/r/30627/diff/
Testing
---
./bin/check-all.sh passed
Thanks,
Yi Pan (Data Infrastructure)
ackage name from
org.apache.samza.sql.task to org.apache.samza.task.sql since both tasks are
extended from org.apache.samza.task.StreamTask. The same for the StreamSqlTask.
- Yi Pan (Data Infrastructure)
On Feb. 4, 2015, 7:39 p.m., Navina Ramesh wrote:
>
> --
/RandomOperatorTask.java
PRE-CREATION
samza-sql/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java
PRE-CREATION
Diff: https://reviews.apache.org/r/30800/diff/
Testing
---
./gradlew clean build passed
Thanks,
Yi Pan (Data Infrastructure)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31909/#review76120
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On March 10
g4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventJsonSerde.java
<https://reviews.apache.org/r/32006/#comment123934>
nit: Serde
- Yi Pan (Data Infrastructure)
On March 13, 2015, 12:57 a.m., Chris Riccomini wrote:
>
> -
n metadata is not inserted in the
cache, getOffsets would raise exception? And how do we capture that case?
- Yi Pan (Data Infrastructure)
On March 13, 2015, 7:56 p.m., Chris Riccomini wrote:
>
> ---
> This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32006/#review76430
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On March 13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32052/#review76437
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On March 13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32052/#review76442
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On March 13
/samza/test/performance/TestKeyValuePerformance.scala
<https://reviews.apache.org/r/32188/#comment124695>
nit: do we need multiple instances of ByteSerde here?
- Yi Pan (Data Infrastructure)
On March 18, 2015, 9:48 p.m., Navina Ramesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32188/#review76989
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On March 18
ated?
2. In the code block from 153, wouldn't it be easier to set a noFlushStop
flag s.t. the stop() method can avoid calling the flush again when stop() is
triggered from failed flush anyways?
- Yi Pan (Data Infrastructure)
On March 17, 2015, 9:37 a.m.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32155/#review77282
---
Ship it!
Looks good to me.
- Yi Pan (Data Infrastructure)
On
://reviews.apache.org/r/32407/diff/
Testing
---
Unit test added. Pass with ./gradlew clean build
Thanks,
Yi Pan (Data Infrastructure)
f we can live w/
the fact that if user implements ExceptionTask automatically disables all
configured suppressions, I would go ahead w/ your suggestion.
Thanks!
- Yi
---
This is an automatically generated e-mail. To reply, visit:
https://revi
f6521
samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala
54b4df84f47f818d62ac0361196567ad1f430fde
Diff: https://reviews.apache.org/r/32407/diff/
Testing (updated)
---
Unit tests added. Pass with ./bin/check-all.sh
Thanks,
Yi Pan (Data Infrastructure)
/SystemConsumers.scala
125d37602e2c0a9da75674f37580a1ac02f94796
samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala
3fdc781c1275f928f4b51b01869e1122502a2c08
Diff: https://reviews.apache.org/r/32874/diff/
Testing
---
passed local unit tests.
Thanks,
Yi Pan (Data
d66b3bd070a4cef4b1d3dded1d79a33cbe3fa09b
Diff: https://reviews.apache.org/r/32872/diff/
Testing
---
Passed local test suite
Thanks,
Yi Pan (Data Infrastructure)
s.apache.org/r/32892/diff/
Testing
---
Passed ./bin/check-all.sh
Thanks,
Yi Pan (Data Infrastructure)
fd41b
samza-test/src/main/python/tests/sql_tests.py PRE-CREATION
samza-test/src/main/resources/orders.avsc PRE-CREATION
samza-test/src/main/resources/orders.json PRE-CREATION
Diff: https://reviews.apache.org/r/33142/diff/
Testing
---
Thanks,
Yi Pan (Data Infrastructure)
s://reviews.apache.org/r/33170/#comment129814>
Move to samza-sql-calcite
samza-sql-core/src/test/java/org/apache/samza/sql/test/metadata/TestAvroSchemaConverter.java
<https://reviews.apache.org/r/33170/#comment129816>
Same here.
- Yi Pan (Data Infrastructure)
eFilterableStreamScanSpec.java
<https://reviews.apache.org/r/33142/#comment129692>
These calcite specific class should be moved out-of samza-sql-core module.
- Yi Pan (Data Infrastructure)
On April 13, 2015, 9:04 p.m., Yi Pan (Data I
ma/types in
samza-sql-core model to Calcite's RelDataType? In that case, can we use the
generic Schema class in samza-sql-core instead of implementation specific for
Avro?
- Yi Pan (Data Infrastructure)
On April 15, 2015, 2:49 p.m.,
> On April 15, 2015, 6:20 p.m., Yi Pan (Data Infrastructure) wrote:
> > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/AvroSchemaConverter.java,
> > line 37
> > <https://reviews.apache.org/r/33219/diff/1/?file=930371#file930371line37>
> >
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33219/#review80237
---
Ship it!
+1
- Yi Pan (Data Infrastructure)
On April 15, 2015, 2
> On April 14, 2015, 9:14 p.m., Chris Riccomini wrote:
> > I'm concerned that there might be an issue with this approach. In
> > BaseKeyValueStorageEngineFactory, we compose stores by nesting them. If
> > this is the case, I think that the top-most store will implement the
> > batching key val
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33219/#review80248
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On April 15
test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
<https://reviews.apache.org/r/33146/#comment131257>
nit: prefer not to re-order the methods if not necessary.
- Yi Pan (Data Infrastructure)
On April 16, 2015,
> On April 21, 2015, 6:49 p.m., Yi Pan (Data Infrastructure) wrote:
> > samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueStore.java, line
> > 33
> > <https://reviews.apache.org/r/33146/diff/2/?file=931566#file931566line33>
> >
> > The sig
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33199/#review81242
---
Ship it!
Went through the latest patch w/ Naveen. LGTM
- Yi Pan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33146/#review81381
---
Ship it!
LGTM. Thanks!
- Yi Pan (Data Infrastructure)
On April
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33146/#review81497
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On April 24
> On April 24, 2015, 5:01 p.m., Yi Pan (Data Infrastructure) wrote:
> > Ship It!
>
> Mohamed Mahmoud (El-Geish) wrote:
> I don't have access to commit. Can you please grant me access or commit
> for me? Thanks!
Hi, MOhamed, I was trying to go through all the test
, here we may
be deleting empty/non-existing storagePartitionDirs.
- Yi Pan (Data Infrastructure)
On April 22, 2015, 9:54 p.m., Navina Ramesh wrote:
>
> ---
> This is an automatically generated e-mail.
-CREATION
Diff: https://reviews.apache.org/r/33749/diff/
Testing
---
./gradlew clean :samza-sql-core:build
Thanks,
Yi Pan (Data Infrastructure)
---
./gradlew clean :samza-sql-core:build
Thanks,
Yi Pan (Data Infrastructure)
a/storage/kv/KeyValueStorageEngine.scala
<https://reviews.apache.org/r/33761/#comment133095>
nit: same here.
- Yi Pan (Data Infrastructure)
On May 1, 2015, 6:43 p.m., Guozhang Wang wrote:
>
> ---
> This is an automatically genera
DB and call
getAll() vs many get() that directly hitting RocksDB APIs?
- Yi Pan (Data Infrastructure)
On May 4, 2015, 4:27 a.m., Mohamed Mahmoud (El-Geish) wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33146/#review82432
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On May 4, 2015
> On May 4, 2015, 8:14 p.m., Yi Pan (Data Infrastructure) wrote:
> > samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala,
> > line 320
> > <https://reviews.apache.org/r/33146/diff/5-6/?file=943969#file943969line320>
> >
>
to: K) = {
metrics.ranges.inc
flush()
getIter(store.range(from, to))
}
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala
<https://reviews.apache.org/r/33761/#comment133362>
It would be better to test iter.remove() for both range() and all(
e-mail. To reply, visit:
https://reviews.apache.org/r/33749/#review82673
---------------
On May 4, 2015, 6:58 a.m., Yi Pan (Data Infrastructure) wrote:
>
> ---
> This is an auto
parameter in doc comment.
Thanks! Will fix.
- Yi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33749/#review82674
-----------
On May 4, 2015,
-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala
<https://reviews.apache.org/r/33453/#comment133550>
Should be "default" here.
- Yi Pan (Data Infrastructure)
On May 6, 2015, 6:22 a.m., Nav
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33761/#review82777
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On May 6, 2015
ain/java/org/apache/samza/test/integration/join/Emitter.java
<https://reviews.apache.org/r/33488/#comment133628>
nit: There are still many trailing white spaces. We should remove them.
- Yi Pan (Data Infrastructure)
On April 27, 2015, 7:59 p.m., G
g to field X in A and field Y in B, the validation should
fail.
- Yi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33749/#review82821
----------------
ze.
- Yi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33749/#review82824
---------------
On May 4, 2015, 6:58 a.m., Yi Pan (Data Infrastructure) w
ry catch the exception here and log an error, in case
the db open failed.
- Yi Pan (Data Infrastructure)
On May 6, 2015, 8:55 p.m., Naveen Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
/StreamSqlTask.java
PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34009/diff/
Testing
---
Thanks,
Yi Pan (Data Infrastructure)
/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34009/diff/
Testing (updated)
---
./gradlew clean build passed
Thanks,
Yi Pan (Data Infrastructure)
Question: isn't this operator just a FilterableStreamScanOp? There is no
projection expression in the spec.
samza-test/src/main/java/org/apache/samza/test/integration/sql/OrdersStreamFactory.java
<https://reviews.apache.org/r/33280/#comment134288>
Question: do we need to in
I use this name to indicate that this is a task that users of operator APIs are
implementing a customized OperatorCallback in the SQL task.
- Yi
---------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3
--
On May 9, 2015, 1:52 a.m., Yi Pan (Data Infrastructure) wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34009/
> ---
t:
https://reviews.apache.org/r/34009/#review83405
---------------
On May 9, 2015, 1:52 a.m., Yi Pan (Data Infrastructure) wrote:
>
> ---
> This is an automatically generated e-
/apache/samza/task/sql/UserCallbacksSqlTask.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34009/diff/
Testing
---
./gradlew clean build passed
Thanks,
Yi Pan (Data Infrastructure)
e/src/main/java/org/apache/samza/task/sql/RouterMessageCollector.java
> PRE-CREATION
>
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SimpleMessageCollector.java
> PRE-CREATION
>
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SqlMessageCollector.java
> PRE-CREATION
>
> samza-sql-core/src/main/java/org/apache/samza/task/sql/StoreMessageCollector.java
> PRE-CREATION
>
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomOperatorTask.java
> PRE-CREATION
>
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java
> PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java
> PRE-CREATION
>
> samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34009/diff/
>
>
> Testing
> ---
>
> ./gradlew clean build passed
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>
/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34206/diff/
Testing
---
Thanks,
Yi Pan (Data Infrastructure)
/samza/task/sql/StreamSqlTask.java
PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34207/diff/
Testing
---
Thanks,
Yi Pan (Data Infrastructure)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33735/#review83847
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On May 13
/UserCallbacksSqlTask.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34206/diff/
Testing
---
Thanks,
Yi Pan (Data Infrastructure)
---
Thanks,
Yi Pan (Data Infrastructure)
. To reply, visit:
https://reviews.apache.org/r/34206/#review83937
-----------
On May 15, 2015, 2:16 a.m., Yi Pan (Data Infrastructure) wrote:
>
> ---
> This is an au
/samza/task/sql/StreamSqlTask.java
PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34500/diff/
Testing
---
./gradlew clean build passed
Thanks,
Yi Pan (Data Infrastructure)
ystem/SystemConsumers.scala
125d37602e2c0a9da75674f37580a1ac02f94796
samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala
3fdc781c1275f928f4b51b01869e1122502a2c08
Diff: https://reviews.apache.org/r/34574/diff/
Testing
---
Thanks,
Yi Pan (Data Infrastructure)
commit of the following:
commit fad81106901e494d3950eeaafaeefef482ac0125
Author: Yi Pan (Data Infrastructure)
Date: Mon May 25 23:40:00 2015 -0700
SAMZA-650 window message store and window store implementation
commit 58c2eeebf4bb0975f70aeba733379e1104f3a7de
Author: Yi Pan (Data
il. To reply, visit:
> https://reviews.apache.org/r/33280/
> ---
>
> (Updated May 23, 2015, 4:27 p.m.)
>
>
> Review request for samza, Guozhang Wang and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-561
> https://issues.apache.org/jira/browse/SAMZA-561
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34626/#review85155
---
Ship it!
LGTM. Thanks!
- Yi Pan (Data Infrastructure)
On May 23
> On May 26, 2015, 7:40 a.m., Yi Pan (Data Infrastructure) wrote:
> > build.gradle, line 408
> > <https://reviews.apache.org/r/33280/diff/5/?file=970932#file970932line408>
> >
> > You might need to re-base this change.
>
> Milinda Pathirage wrote:
sub-classes from operators
SAMZA-552 update the operator API
SAMZA-552: operator builder API update
Squashed commit of the following:
commit fad81106901e494d3950eeaafaeefef482ac0125
Author: Yi Pan (Data Infrastructure)
Date: Mon May 25 23:40:00 2015 -0700
SAMZA-650 window message store
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34500/#review85672
---------------
On May 20, 2015, 11:13 p.m., Yi Pan (Data Infrastructure) wrote:
>
> -
gt; > samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java,
> > line 123
> > <https://reviews.apache.org/r/34500/diff/1/?file=965740#file965740line123>
> >
> > Why do we need 2 instances of the TopologyBuilder here?
> &
nt OperatorSpec based API
> is you need to create intermediate streams (EntityName)s to wire operators
> together. I think we should try to hide that complexity through the builder
> API. Even though source and sink hides that complexity to some extent, its
> better if we
ree managers that all requires to
initialize the coordinatorSystemProducer/coordinatorSystemConsumer in a single
CoordinatorStreamManager? And
CoordinatorStreamManager.getCheckpointManager()/getChangelogManager()/getLocalityManager()
would return the specific management function handler?
- Yi Pan (
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34746/#review86125
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On May 30
> On May 30, 2015, 8:58 a.m., Yi Pan (Data Infrastructure) wrote:
> > samza-core/src/main/java/org/apache/samza/container/LocalityManager.java,
> > line 62
> > <https://reviews.apache.org/r/34746/diff/2/?file=974783#file974783line62>
> >
> > This woul
------------
On May 20, 2015, 11:13 p.m., Yi Pan (Data Infrastructure) wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34500/
> --
will update the RB accordingly.
- Yi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34500/#review86504
---
On May 20,
rivial to
claim exact-once under the asumption that the system running healthy,
- Yi Pan (Data Infrastructure)
On June 12, 2015, 11:54 p.m., Yan Fang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35325/#review87789
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On June 13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35577/#review88262
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On June 17
pClassloader {
exceptionHandler.maybeHandle {
task.process(envelope, collector, coordinator)
}
}
...
- Yi Pan (Data Infrastructure)
On June 18, 2015, 6:42 p.m., Guozhang Wang wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35601/#review88512
---
Ship it!
LGTM. Thanks!
- Yi Pan (Data Infrastructure)
On June
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35723/#review88820
---
Ship it!
+1. LGTM. Thanks for the quick fix, Yan.
- Yi Pan (Data
the offsets
2. remove all checkpoint.factory configuration
3. restart the job
- Yi Pan (Data Infrastructure)
On July 8, 2015, 1:41 a.m., Naveen Somasundaram wrote:
>
> ---
> This is an automatically generated e-m
Pan (Data Infrastructure)
On July 8, 2015, 1:41 a.m., Naveen Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On July 8, 2015, 7:34 p.m., Yi Pan (Data Infrastructure) wrote:
> > samza-core/src/main/scala/org/apache/samza/migration/JobRunnerMigration.scala,
> > line 46
> > <https://reviews.apache.org/r/35676/diff/3/?file=1001916#file1001916line46>
> >
> > Th
review
comment. Thanks!
samza-kafka/src/main/scala/old/checkpoint/KafkaCheckpointManager.scala (line
236)
<https://reviews.apache.org/r/35676/#comment144132>
nit: "reading both changelog partition mapping and checkpoint"?
- Yi Pan (Data Infrastructure)
On July 8, 2015, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36224/#review91248
---
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On July 6
1 - 100 of 433 matches
Mail list logo
