Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Brian Towles via Review Board
> On Nov. 26, 2018, 3:02 p.m., Na Li wrote: > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java > > Lines 30 (patched) > > > > > > This

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Brian Towles via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/ --- (Updated Nov. 26, 2018, 9:32 p.m.) Review request for sentry, Anthony

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Brian Towles via Review Board
> On Nov. 26, 2018, 3:22 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java > > Lines 20 (patched) > > > > > > or you should move it from

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Brian Towles via Review Board
> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js > > Lines 32 (patched) > > > > > > Why do we have 2 different copyrights? Is

Re: Review Request 69415: SENTRY-2463: Revoking ALL or * should revoke any other privilege on the entity

2018-11-26 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69415/#review210870 ---

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

2018-11-26 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/#review210874 ---

Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

2018-11-26 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

2018-11-26 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/ --- (Updated Nov. 26, 2018, 6:14 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210878 ---

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210877 ---

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

2018-11-26 Thread Arjun Mishra via Review Board
> On Nov. 26, 2018, 7:44 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > > Line 37 (original), 37 (patched) > > > > > > should this