we should add some
> > tag like annotations or comments for it
For such class I'll add the comments with todo to describe it should be removed
in the next step.
- Colin
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45152/#review124750
---
Ship it!
Ship It!
- Colin Ma
On March 22, 2016, 7:38 a.m
(), and comments
should be added to describe why retry is needed here.
- Colin Ma
On March 22, 2016, 7:40 a.m., Dapeng Sun wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/LocalGroupResourceAuthorizationProvider.java
489daf4
Diff: https://reviews.apache.org/r/45023/diff/
Testing
---
Thanks,
Colin Ma
/tests/e2e/hive/Context.java
(line 265)
<https://reviews.apache.org/r/45153/#comment187642>
I think the try-catch should be put here.
- Colin Ma
On March 22, 2016, 10:55 a.m., Dapeng Sun wrote:
>
> ---
> This is a
-hive-common?
- Colin Ma
On March 22, 2016, 10:52 a.m., Dapeng Sun wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44844/#review124944
---
Ship it!
Ship It!
- Colin Ma
On March 22, 2016, 10:52 a.m
/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
abaf61f
Diff: https://reviews.apache.org/r/45198/diff/
Testing
---
Thanks,
Colin Ma
/sentry/tests/e2e/hive/TestPerDBConfiguration.java
985f969
Diff: https://reviews.apache.org/r/45199/diff/
Testing
---
Thanks,
Colin Ma
for datanucleus are included for hive-v1 and hive-v2.
When package Sentry, the lib will include all these jars, how to avoid the
conflict?
2. test-hive-v1 is enable as default, when do the pre-commit, how to test
test-hive-v2?
- Colin Ma
On March 24, 2016, 1:25 a.m., Dapeng Sun wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45260/#review125218
---
Ship it!
Ship It!
- Colin Ma
On March 24, 2016, 5:41 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45262/#review125375
---
Ship it!
Ship It!
- Colin Ma
On March 24, 2016, 1:33 a.m
/test/java/org/apache/sentry/policy/indexer/IndexPolicyTestUtil.java
45d3400
Diff: https://reviews.apache.org/r/45198/diff/
Testing
---
Thanks,
Colin Ma
/tests/e2e/hive/TestPerDBConfiguration.java
985f969
Diff: https://reviews.apache.org/r/45199/diff/
Testing
---
Thanks,
Colin Ma
ive/TestPolicyImportExport.java
c72aea3
Diff: https://reviews.apache.org/r/45722/diff/
Testing
---
Thanks,
Colin Ma
/TestSentryStoreImportExport.java
a9e4ed6
Diff: https://reviews.apache.org/r/45727/diff/
Testing
---
Thanks,
Colin Ma
/sentry_policy_service.thrift
40889e8
Diff: https://reviews.apache.org/r/45728/diff/
Testing
---
Thanks,
Colin Ma
/TestSentryServiceImportExport.java
dbe4a27
Diff: https://reviews.apache.org/r/45730/diff/
Testing
---
Thanks,
Colin Ma
/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
8881d82
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java
dbe4a27
Diff: https://reviews.apache.org/r/45730/diff/
Testing
---
Thanks,
Colin Ma
/TestPolicyImportExport.java
c72aea3
Diff: https://reviews.apache.org/r/45732/diff/
Testing
---
Thanks,
Colin Ma
, visit:
https://reviews.apache.org/r/45728/#review127038
-------
On April 5, 2016, 3:53 a.m., Colin Ma wrote:
>
> ---
> This is an automatically gener
-db/src/main/resources/sentry_policy_service.thrift
40889e8
Diff: https://reviews.apache.org/r/45728/diff/
Testing
---
Thanks,
Colin Ma
/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
a9e4ed6
Diff: https://reviews.apache.org/r/45727/diff/
Testing
---
Thanks,
Colin Ma
uce levels of code blocks.
Thanks for the comments, done.
- Colin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45727/#review127039
---------
/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
8881d82
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java
dbe4a27
Diff: https://reviews.apache.org/r/45730/diff/
Testing
---
Thanks,
Colin Ma
ute this as one instead embeded into
> > the portion of code.
Thanks for the comments, all done.
- Colin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45730/#revi
/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
a9e4ed6
Diff: https://reviews.apache.org/r/45727/diff/
Testing
---
Thanks,
Colin Ma
- Colin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45727/#review127056
-------
On April 5, 2016, 7:38 a.m., Colin Ma wrote:
>
>
/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java
c72aea3
Diff: https://reviews.apache.org/r/45732/diff/
Testing
---
Thanks,
Colin Ma
instead of objectPath
Thanks for the comment, done.
- Colin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45732/#review127049
-------
On April 5, 2016, 8:03 a.m., Colin Ma wrote:
>
> ---
/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
8881d82
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java
dbe4a27
Diff: https://reviews.apache.org/r/45730/diff/
Testing
---
Thanks,
Colin Ma
re
getGroupNameRoleNamesMap(null) for databaseName == null and tableName == null
case.
- Colin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45730/#review127059
------
/TestSentryServiceImportExport.java
dbe4a27
Diff: https://reviews.apache.org/r/45730/diff/
Testing
---
Thanks,
Colin Ma
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/45730/#review127068
-------
On April 6, 2016, 2:38 a.m., Colin Ma wrote:
>
> ---
> This is an automatically generated e-mail.
/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java
c72aea3
Diff: https://reviews.apache.org/r/45732/diff/
Testing
---
Thanks,
Colin Ma
ct whose privileges
> > will be exported"
Thanks for the comments, done.
- Colin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45732/#review127064
------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45732/#review127277
-------
On April 6, 2016, 2:52 a.m., Colin Ma wrote:
>
>
/TestSentryServiceImportExport.java
dbe4a27
Diff: https://reviews.apache.org/r/45730/diff/
Testing
---
Thanks,
Colin Ma
/provider/db/service/thrift/TSentryRole.java
7645e25
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift
40889e8
Diff: https://reviews.apache.org/r/34078/diff/
Testing
---
Thanks,
Colin Ma
/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
dbb5d8e
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
02f98e2
Diff: https://reviews.apache.org/r/34079/diff/
Testing
---
Thanks,
Colin
/sentry/provider/db/log/util/TestCommandUtil.java
8620f62
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java
3afd6b2
Diff: https://reviews.apache.org/r/34080/diff/
Testing
---
Thanks,
Colin Ma
/r/34081/diff/
Testing
---
Thanks,
Colin Ma
: https://reviews.apache.org/r/34082/diff/
Testing
---
Thanks,
Colin Ma
://reviews.apache.org/r/34083/diff/
Testing
---
Thanks,
Colin Ma
0792eb6
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java
07c7f7a
Diff: https://reviews.apache.org/r/34086/diff/
Testing
---
Thanks,
Colin Ma
,
Colin Ma
/sentry-provider-db/src/main/resources/sentry_policy_service.thrift
40889e8
Diff: https://reviews.apache.org/r/34078/diff/
Testing
---
Thanks,
Colin Ma
/SentryStore.java
dbb5d8e
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
02f98e2
Diff: https://reviews.apache.org/r/34079/diff/
Testing
---
Thanks,
Colin Ma
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java
3afd6b2
Diff: https://reviews.apache.org/r/34080/diff/
Testing
---
Thanks,
Colin Ma
/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java
caf32cf
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
dfe93a5
Diff: https://reviews.apache.org/r/34081/diff/
Testing
---
Thanks,
Colin Ma
---
Thanks,
Colin Ma
/
Testing
---
Thanks,
Colin Ma
/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java
07c7f7a
Diff: https://reviews.apache.org/r/34086/diff/
Testing
---
Thanks,
Colin Ma
/TestGrantUserToRole.java
PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
8515a2b
Diff: https://reviews.apache.org/r/34087/diff/
Testing
---
Thanks,
Colin Ma
/sentry_policy_service.thrift
(line 109)
<https://reviews.apache.org/r/34078/#comment190960>
Thank you very much for catching it
- Colin Ma
On 四月 6, 2016, 2:39 p.m., Colin Ma wrote:
>
> ---
> This is an automatically generated e
/sentry-provider-db/src/main/resources/sentry_policy_service.thrift
40889e8
Diff: https://reviews.apache.org/r/34078/diff/
Testing
---
Thanks,
Colin Ma
/SentryStore.java
dbb5d8e
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
02f98e2
Diff: https://reviews.apache.org/r/34079/diff/
Testing
---
Thanks,
Colin Ma
it should be call before
transaction. committed.
- Colin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/#review126284
------
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/#review127543
-------
On 四月 8, 2016, 3:13 a.m., Colin Ma wrote:
>
> ---
> Thi
---
Thanks,
Colin Ma
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34086/#review127555
-------
On 四月 6, 2016, 2:56 p.m., Colin Ma wrote:
>
> ---
eviews.apache.org/r/34086/#review127564
-------
On 四月 6, 2016, 2:56 p.m., Colin Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34086/
> --
/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java
07c7f7a
Diff: https://reviews.apache.org/r/34086/diff/
Testing
---
Thanks,
Colin Ma
GroupMappings`, Thanks.
- Colin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34087/#review127561
---
On 四月 6, 2016, 2:58 p.m., Col
8515a2b
Diff: https://reviews.apache.org/r/34087/diff/
Testing
---
Thanks,
Colin Ma
27738
-------
On 四月 8, 2016, 4:26 a.m., Colin Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34086/
/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java
07c7f7a
Diff: https://reviews.apache.org/r/34086/diff/
Testing
---
Thanks,
Colin Ma
/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java
07c7f7a
Diff: https://reviews.apache.org/r/34086/diff/
Testing
---
Thanks,
Colin Ma
lin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34086/#review127748
---
On 四月 8, 2016, 9:20 a.m., Colin Ma wrote:
>
> -
/SentryStore.java
dbb5d8e
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
02f98e2
Diff: https://reviews.apache.org/r/34079/diff/
Testing
---
Thanks,
Colin Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45728/#review128054
---
Ship it!
Ship It!
- Colin Ma
On 四月 5, 2016, 6:28 a.m
/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java
c72aea3
Diff: https://reviews.apache.org/r/45732/diff/
Testing
---
Thanks,
Colin Ma
/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java
caf32cf
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
dfe93a5
Diff: https://reviews.apache.org/r/34081/diff/
Testing
---
Thanks,
Colin Ma
/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java
07c7f7a
Diff: https://reviews.apache.org/r/34086/diff/
Testing
---
Thanks,
Colin Ma
/tests/e2e/dbprovider/TestGrantUserToRole.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34087/diff/
Testing
---
Thanks,
Colin Ma
://reviews.apache.org/r/46366/diff/
Testing
---
Thanks,
Colin Ma
/SentryPolicyProviderForDb.java
2507f83
Diff: https://reviews.apache.org/r/46367/diff/
Testing
---
Thanks,
Colin Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46658/#review130532
---
Ship it!
Ship It!
- Colin Ma
On April 25, 2016, 8:53 p.m
-db/src/main/resources/sentry_policy_service.thrift
2088eae
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
8dadc2a
Diff: https://reviews.apache.org/r/46811/diff/
Testing
---
Thanks,
Colin Ma
: https://reviews.apache.org/r/46886/diff/
Testing
---
Thanks,
Colin Ma
/SentryPolicyServiceClientDefaultImpl.java
0da3cfd
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java
865f66e
Diff: https://reviews.apache.org/r/46961/diff/
Testing
---
Thanks,
Colin Ma
,
Colin Ma
/test/java/org/apache/sentry/binding/hive/TestSentryIniPolicyFileFormatter.java
0e7ee3d
Diff: https://reviews.apache.org/r/47012/diff/
Testing
---
Thanks,
Colin Ma
/
Testing
---
Thanks,
Colin Ma
tadatas from server side, I think there
should be one RPC call for this.
Too many rpc calls are in loadFromRemote() if there has many roles, this
will be a performance issue. SENTRY-197 is the feature about import/export for
Hive, and it can be a reference to add a new interface to get all the
> On May 6, 2016, 8:34 a.m., Colin Ma wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java,
> > line 123
> > <https://reviews.apache.org/r/46909/diff/2/?file=1374087#file1374087line123>
zKey.
Feel free to discuss on the implementation.
- Colin Ma
On May 26, 2016, 7:31 a.m., Hao Hao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47872/
> -
server=server1->db=db1->table=t1
Then, check the result.
- Colin Ma
On May 27, 2016, 1:29 a.m., Hao Hao wrote:
>
> ---
> This is an automatica
/TestDbPrivilegeCleanupOnDrop.java
767bcbe
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperationsPart2.java
8eb2851
Diff: https://reviews.apache.org/r/48055/diff/
Testing
---
Thanks,
Colin Ma
e better for this situation. I'll update the
patch, thanks.
- Colin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48055/#review135680
-------
On May 31, 2016, 5:14 a.m., Colin Ma wrote:
&g
/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java
767bcbe
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperationsPart2.java
8eb2851
Diff: https://reviews.apache.org/r/48055/diff/
Testing
---
Thanks,
Colin Ma
/TestOperationsPart2.java
8eb2851
Diff: https://reviews.apache.org/r/48055/diff/
Testing
---
Thanks,
Colin Ma
/TestOperationsPart2.java
8eb2851
Diff: https://reviews.apache.org/r/48055/diff/
Testing
---
Thanks,
Colin Ma
ps://reviews.apache.org/r/48055/#review136300
-------
On June 7, 2016, 5:44 a.m., Colin Ma wrote:
>
> ---
> This is an automatically generated e-mail.
er/db/tools/command/hive/CommandUtil.java
(line 55)
<https://reviews.apache.org/r/49182/#comment204514>
why set action to all?
- Colin Ma
On June 24, 2016, 5:46 a.m., Dapeng Sun wrote:
>
> ---
> This is an automatically
/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerformanceManually.java
PRE-CREATION
Diff: https://reviews.apache.org/r/49683/diff/
Testing
---
Thanks,
Colin Ma
privileges(eg, 5000 privileges).
Diffs
-
sentry-tests/sentry-tests-hive/pom.xml 02bfa49
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerformanceManually.java
PRE-CREATION
Diff: https://reviews.apache.org/r/49683/diff/
Testing
---
Thanks,
Colin
/TestOperationsPart2.java
8eb2851
Diff: https://reviews.apache.org/r/48055/diff/
Testing
---
Thanks,
Colin Ma
entry-provider-file/src/main/java/org/apache/sentry/provider/file/SimpleFileProviderBackend.java
69ab260
sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/TestLocalGroupMapping.java
9864b82
Diff: https://reviews.apache.org/r/50882/diff/
Testing
---
Thanks,
/diff/
Testing
---
Thanks,
Colin Ma
1 - 100 of 114 matches
Mail list logo
