[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170422863 ## File path: metrics/metrics-core/src/test/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170422785 ## File path: metrics/metrics-core/src/main/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170422650 ## File path: foundations/foundation-metrics/src/test/java/org/apach

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-23 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170412777 ## File path: metrics/metrics-core/src/main/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-23 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170412685 ## File path: metrics/metrics-core/src/main/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-23 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170412622 ## File path: foundations/foundation-metrics/src/test/java/org/apach

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-23 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170404621 ## File path: demo/perf/src/main/java/org/apache/servicecomb/demo/pe

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-23 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170404504 ## File path: demo/demo-springmvc/springmvc-client/src/main/java/org

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-23 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170404398 ## File path: core/src/main/java/org/apache/servicecomb/core/Invocati

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-22 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r169888260 ## File path: metrics/metrics-core/src/main/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-22 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r169881296 ## File path: common/common-rest/src/main/java/org/apache/servicecom

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-22 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r169881157 ## File path: common/common-rest/src/main/java/org/apache/servicecom

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-22 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r169885809 ## File path: demo/perf/src/main/java/org/apache/servicecomb/demo/pe

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-22 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r169887598 ## File path: foundations/foundation-metrics/src/main/java/org/apach

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-13 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168063945 ## File path: metrics/metrics-core/src/main/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-13 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168063658 ## File path: metrics/metrics-core/src/main/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-13 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168062197 ## File path: metrics/metrics-core/src/main/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-13 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168060887 ## File path: foundations/foundation-metrics/src/main/java/org/apach

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-13 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168060645 ## File path: foundations/foundation-metrics/src/main/java/org/apach

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-13 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168059325 ## File path: foundations/foundation-metrics/src/main/java/org/apach

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-13 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168057392 ## File path: core/src/main/java/org/apache/servicecomb/core/Invocati