[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934662#comment-14934662
]
Carsten Ziegeler commented on SLING-5068:
-
Ok, I've committed this version. I'll keep this issue
[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934631#comment-14934631
]
Carsten Ziegeler commented on SLING-4352:
-
Yes we could do a wrapper and we've also discussed
[
https://issues.apache.org/jira/browse/SLING-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933542#comment-14933542
]
Roy Teeuwen commented on SLING-4752:
Any progress on this issue ? Will the AEM QueryBuilder be
Justin Edelson created SLING-5071:
-
Summary: Adjust filter order for I18NFilter to accomodate changes
from SLING-2920
Key: SLING-5071
URL: https://issues.apache.org/jira/browse/SLING-5071
Project:
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933565#comment-14933565
]
Carsten Ziegeler commented on SLING-5068:
-
Thanks for the patch, I think it does the trick.
But :)
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933635#comment-14933635
]
Dirk Rudolph commented on SLING-5068:
-
The problem I see is, that the Servlet is cached globally and
[
https://issues.apache.org/jira/browse/SLING-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-5072:
--
Fix Version/s: (was: i18n 2.4.6)
Extensions Rewriter 1.1.2
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-5068:
Fix Version/s: Servlets Resolver 2.3.8
> perThreadScriptResolver is shared between multiple
Justin Edelson created SLING-5072:
-
Summary: Adjust filter order for RewriterFilter to accomodate
changes from SLING-2920
Key: SLING-5072
URL: https://issues.apache.org/jira/browse/SLING-5072
[
https://issues.apache.org/jira/browse/SLING-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933577#comment-14933577
]
Justin Edelson commented on SLING-3950:
---
hmmm. when did this show up? :)
Sorry for the noise.
>
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933875#comment-14933875
]
Dirk Rudolph commented on SLING-5068:
-
Isn't that exactly the same as the solution I proposed? I mean
[
https://issues.apache.org/jira/browse/SLING-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-3950.
---
Resolution: Invalid
> add JMX MBean for servlet resolver cache
>
[
https://issues.apache.org/jira/browse/SLING-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933573#comment-14933573
]
Carsten Ziegeler commented on SLING-3950:
-
[~justinedelson] There is a simple mbean already, but I
[
https://issues.apache.org/jira/browse/SLING-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-5072.
---
Resolution: Fixed
Fixed in r1705723
> Adjust filter order for RewriterFilter to accomodate
[
https://issues.apache.org/jira/browse/SLING-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-5071.
---
Resolution: Fixed
fixed in r1705720
> Adjust filter order for I18NFilter to accomodate
[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-4352:
---
Assignee: Carsten Ziegeler
> The ResourceResolver passed to SlingScripts should not
[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933592#comment-14933592
]
Carsten Ziegeler commented on SLING-4352:
-
We should create a dynamic proxy which simply ignores
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-5068:
---
Assignee: Carsten Ziegeler
> perThreadScriptResolver is shared between multiple
[
https://issues.apache.org/jira/browse/SLING-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-3950.
-
> add JMX MBean for servlet resolver cache
>
>
>
[
https://issues.apache.org/jira/browse/SLING-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-5067:
--
Fix Version/s: Testing Sling Mock Oak 1.0.0
Testing Sling Mock Jackrabbit
[
https://issues.apache.org/jira/browse/SLING-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933937#comment-14933937
]
Stefan Seifert commented on SLING-5067:
---
Completed: At revision: 1705765
unit tests are updated.
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933875#comment-14933875
]
Dirk Rudolph edited comment on SLING-5068 at 9/28/15 8:52 PM:
--
Makes sense.
Dirk Rudolph created SLING-5070:
---
Summary: ServletResolverCacheMBeanImpl throws NPE when cache is
diabled
Key: SLING-5070
URL: https://issues.apache.org/jira/browse/SLING-5070
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933420#comment-14933420
]
Dirk Rudolph edited comment on SLING-5068 at 9/28/15 3:09 PM:
--
Yes. In case
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933434#comment-14933434
]
Carsten Ziegeler commented on SLING-5068:
-
Lets assume, the servlet was created in Thread A, then
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933367#comment-14933367
]
Dirk Rudolph commented on SLING-5068:
-
I agree. But do we have access to ScriptContext/Bindings
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933401#comment-14933401
]
Dirk Rudolph commented on SLING-5068:
-
This is already done with the ScriptResource in
Hi Bertrand,
I'm glad you like it!
Yeah, the closing titles scrolled though way too quickly at the end.
Here are the GitHub links:
https://github.com/sandroboehme/sitebuilder
https://github.com/sandroboehme/car_rental
And as one person asked on site here at the adaptTo(): The license is of
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933325#comment-14933325
]
Dirk Rudolph commented on SLING-5068:
-
[~cziegeler]: What about implementing a special case for get()
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1494#comment-1494
]
Dirk Rudolph commented on SLING-5068:
-
Did you mean "not set to the per thread resource resolver"?
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1498#comment-1498
]
Carsten Ziegeler commented on SLING-5068:
-
The DefaultSlingScript has no access to the per thread
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933394#comment-14933394
]
Carsten Ziegeler commented on SLING-5068:
-
Ah right, it's a context attribute not a request
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933414#comment-14933414
]
Carsten Ziegeler commented on SLING-5068:
-
Ah, right - I start to remember this stuff :)
The
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933363#comment-14933363
]
Carsten Ziegeler commented on SLING-5068:
-
If I see it correctly, this is what happens:
- first
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933447#comment-14933447
]
Dirk Rudolph commented on SLING-5068:
-
Currently there is no ThreadLocal in ScriptResource.
So you
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933476#comment-14933476
]
Carsten Ziegeler commented on SLING-5068:
-
Sounds like a solution
> perThreadScriptResolver is
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933328#comment-14933328
]
Carsten Ziegeler commented on SLING-5068:
-
We somehow have to make sure that
[
https://issues.apache.org/jira/browse/SLING-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-5070:
Fix Version/s: Servlets Resolver 2.3.8
> ServletResolverCacheMBeanImpl throws NPE when
[
https://issues.apache.org/jira/browse/SLING-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5070:
Summary: ServletResolverCacheMBeanImpl throws NPE when cache is disabled
(was:
Github user Buuhuu closed the pull request at:
https://github.com/apache/sling/pull/102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/SLING-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933503#comment-14933503
]
ASF GitHub Bot commented on SLING-5070:
---
Github user Buuhuu closed the pull request at:
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5068:
Environment: We are facing the following issue with AEM 6.1 build on top of
Servlet Resolver 2.3.6.
[
https://issues.apache.org/jira/browse/SLING-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-5070:
---
Assignee: Carsten Ziegeler
> ServletResolverCacheMBeanImpl throws NPE when cache is
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933447#comment-14933447
]
Dirk Rudolph edited comment on SLING-5068 at 9/28/15 3:36 PM:
--
Currently
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933480#comment-14933480
]
Dirk Rudolph commented on SLING-5068:
-
Works with a small modification. Because of thread reuse (I
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933320#comment-14933320
]
Carsten Ziegeler commented on SLING-5068:
-
Yes, thanks - I was just further looking into the code
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1494#comment-1494
]
Dirk Rudolph edited comment on SLING-5068 at 9/28/15 2:08 PM:
--
Did you mean
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933381#comment-14933381
]
Dirk Rudolph commented on SLING-5068:
-
A simple workaround is setting the SlingServletResolver cache
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933325#comment-14933325
]
Dirk Rudolph edited comment on SLING-5068 at 9/28/15 2:04 PM:
--
[~cziegeler]:
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5068:
Attachment: sling-5068.patch
The attached patch
- uses a ThreadLocal for the Resource
- in case
[
https://issues.apache.org/jira/browse/SLING-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5070:
Description:
When setting the cache size configuration of SlingServletResolver to a value <
5 the
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933420#comment-14933420
]
Dirk Rudolph edited comment on SLING-5068 at 9/28/15 3:03 PM:
--
Yes. In case
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933420#comment-14933420
]
Dirk Rudolph commented on SLING-5068:
-
Yes. In case the perThreadScriptResolver is null (WeakReference
GitHub user Buuhuu opened a pull request:
https://github.com/apache/sling/pull/102
SLING-5070
As workaround for SLING-5068 we set the cache size of SlingServletResolver
to 0 to prevent it from caching servlets. We mentioned that there is a NPE
thrown by the MBean implementation
[
https://issues.apache.org/jira/browse/SLING-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933444#comment-14933444
]
ASF GitHub Bot commented on SLING-5070:
---
GitHub user Buuhuu opened a pull request:
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933514#comment-14933514
]
Dirk Rudolph edited comment on SLING-5068 at 9/28/15 4:19 PM:
--
The attached
Hi Sandro,
On Fri, Sep 25, 2015 at 1:08 AM, Sandro Boehme wrote:
> ...To see it in action and get an understanding of how it works I created a
> demo video...
The concepts look interesting, can we see the code or test a live
version somewhere?
-Bertrand
[
https://issues.apache.org/jira/browse/SLING-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-5039.
--
> Provide a variant of the junit.core Service annotation that uses generics
>
[
https://issues.apache.org/jira/browse/SLING-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-5038.
--
> junit.core Service annotation: provide access to BundleContext
>
[
https://issues.apache.org/jira/browse/SLING-5034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-5034.
--
> JUnit servlet: optionally serialize the raw JUnit Result object
>
[
https://issues.apache.org/jira/browse/SLING-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-5033.
--
> JUnit servlet should return 404 when no test is found
>
[
https://issues.apache.org/jira/browse/SLING-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-4320.
--
> Make JUnit Core depend on JUnit and Hamcrest with Compile scope
>
[
https://issues.apache.org/jira/browse/SLING-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-4322.
--
> JUnit Core: All RunListeners should expose the stack trace in case of test
> failures
>
[
https://issues.apache.org/jira/browse/SLING-5040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-5040.
--
> Simplified server-side tests with TeleporterRule
>
[
https://issues.apache.org/jira/browse/SLING-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-5037.
--
> Allow junit.core Service rule to run client-side
>
[
https://issues.apache.org/jira/browse/SLING-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-4918.
--
> Frequent failures of AuthenticationResponseCodeTest
>
[
https://issues.apache.org/jira/browse/SLING-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-4319.
--
> Include Hamcrest Library
>
>
> Key: SLING-4319
>
Hi,
On Wed, Sep 23, 2015 at 5:40 PM, Bertrand Delacretaz
wrote:
> ...Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1334/ ...
The vote passes with binding +1s from Carsten, Robert and myself and
another +1 from Julian, thanks!
[
https://issues.apache.org/jira/browse/SLING-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-5054.
--
> Rat plugin complains about testing/junit/teleporter
>
[
https://issues.apache.org/jira/browse/SLING-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-5067.
---
Resolution: Fixed
rev. 1705788 site updated as well
> sling-mock: "uniqueRoot()" to simplify
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933822#comment-14933822
]
Carsten Ziegeler commented on SLING-5068:
-
I've attached an alternative patch - not sure if it is
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-5068:
Attachment: sling-5068-2.patch
> perThreadScriptResolver is shared between multiple Threads
[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933895#comment-14933895
]
Dirk Rudolph commented on SLING-4352:
-
You could als expose an abstract ResourceResolverWrapper in the
[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933895#comment-14933895
]
Dirk Rudolph edited comment on SLING-4352 at 9/28/15 8:08 PM:
--
You could also
[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933272#comment-14933272
]
Dirk Rudolph edited comment on SLING-4352 at 9/28/15 1:20 PM:
--
This is an
[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933272#comment-14933272
]
Dirk Rudolph edited comment on SLING-4352 at 9/28/15 1:22 PM:
--
This is an
[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933272#comment-14933272
]
Dirk Rudolph commented on SLING-4352:
-
This is an urgent issue at least with AEM 6.1 base on Servlet
[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-4352:
Comment: was deleted
(was: This is an urgent issue at least with AEM 6.1 base on Servlet Resolver
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5068:
Summary: perThreadScriptResolver is shared between multiple Threads causing
ISE in
Dirk Rudolph created SLING-5068:
---
Summary: perThreadScriptResolver is shared between multiple Threads
Key: SLING-5068
URL: https://issues.apache.org/jira/browse/SLING-5068
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5068:
Attachment: opened-and-closed-trace.txt
error-stacktrace.txt
>
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5068:
Attachment: error-stacktrace.txt
> perThreadScriptResolver is shared between multiple Threads
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5068:
Attachment: (was: opened-and-closed-trace.txt)
> perThreadScriptResolver is shared between
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5068:
Attachment: (was: error-stacktrace.txt)
> perThreadScriptResolver is shared between multiple
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-5068:
Attachment: opened-and-closed-trace.txt
> perThreadScriptResolver is shared between multiple
Bakshinder Singh created SLING-5069:
---
Summary: Huge delta reported between sling request log and the
SlingMainServlet
Key: SLING-5069
URL: https://issues.apache.org/jira/browse/SLING-5069
Project:
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933304#comment-14933304
]
Carsten Ziegeler commented on SLING-5068:
-
Looking at the code, I currently fail where this could
[
https://issues.apache.org/jira/browse/SLING-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bakshinder Singh updated SLING-5069:
Affects Version/s: Engine 2.2.8
> Huge delta reported between sling request log and the
[
https://issues.apache.org/jira/browse/SLING-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933314#comment-14933314
]
Dirk Rudolph commented on SLING-5068:
-
I will have a look how to implement an integration test for
89 matches
Mail list logo