[ 
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933592#comment-14933592
 ] 

Carsten Ziegeler commented on SLING-4352:
-----------------------------------------

We should create a dynamic proxy which simply ignores calls to close() and pass 
this on.
A dynamic proxy allows us to run with any version of the resource resolver api 
and avoids updating the servlet resolver bundle each time the resource resolver 
api changes.

> The ResourceResolver passed to SlingScripts should not be closeable
> -------------------------------------------------------------------
>
>                 Key: SLING-4352
>                 URL: https://issues.apache.org/jira/browse/SLING-4352
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>            Reporter: Radu Cotescu
>            Assignee: Carsten Ziegeler
>             Fix For: Servlets Resolver 2.3.8
>
>
> The {{SlingServletResolver}} uses an administrative resource resolver 
> ({{sharedScriptResolver}}) for script resolution. This same resolver is 
> passed to SlingScripts when a resource is adapted to a {{SlingScript}} in 
> {{SlingServletResolver#findScript}} (see 
> {{SlingScriptAdapterFactory#getAdapter}}).
> Since this resolver is made available to scripts in the {{ScriptContext}} 
> (see the implementation of {{DefaultSlingScript#call}}), the resolver should 
> be protected against accidental closing from downstream callers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to