[ 
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934631#comment-14934631
 ] 

Carsten Ziegeler commented on SLING-4352:
-----------------------------------------

Yes we could do a wrapper and we've also discussed adding such a thing some 
time ago and decided against it (can't remember the details). Now for this 
case, if we would go that way, we would tie the servlet resolver to the latest 
Sling API and it wouldn't work with the older api. Therefore with a proxy we 
can make sure that it still runs with older api versions.

> The ResourceResolver passed to SlingScripts should not be closeable
> -------------------------------------------------------------------
>
>                 Key: SLING-4352
>                 URL: https://issues.apache.org/jira/browse/SLING-4352
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>            Reporter: Radu Cotescu
>            Assignee: Carsten Ziegeler
>             Fix For: Servlets Resolver 2.3.8
>
>
> The {{SlingServletResolver}} uses an administrative resource resolver 
> ({{sharedScriptResolver}}) for script resolution. This same resolver is 
> passed to SlingScripts when a resource is adapted to a {{SlingScript}} in 
> {{SlingServletResolver#findScript}} (see 
> {{SlingScriptAdapterFactory#getAdapter}}).
> Since this resolver is made available to scripts in the {{ScriptContext}} 
> (see the implementation of {{DefaultSlingScript#call}}), the resolver should 
> be protected against accidental closing from downstream callers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to