Re: [sling:resourceType] protected execution

2018-10-05 Thread Radu Cotescu
Hi Bertrand, > On 5 Oct 2018, at 16:18, Bertrand Delacretaz wrote: > > Hi, > > On Fri, Oct 5, 2018 at 2:47 PM Jason E Bailey wrote: >> ...1. Each resource provider, if it supports security, should be responsible >> for security... > > I think there are misunderstandings in this thread about

Re: [sling:resourceType] protected execution

2018-10-05 Thread Bertrand Delacretaz
Hi, On Fri, Oct 5, 2018 at 2:47 PM Jason E Bailey wrote: > ...1. Each resource provider, if it supports security, should be responsible > for security... I think there are misunderstandings in this thread about what we're trying to achieve. Radu, correct me if I'm wrong but I think the only

Re: [sling:resourceType] protected execution

2018-10-05 Thread Eric Norman
> > 1. Users can freely define sling:resourceType properties Is there some reason why this must be so? In JCR land, the jcr:nodeTypeManagement privilege must be granted for the user to have permission to add and remove mixin node types and change the primary node type of a node. I would expect

Re: [sling:resourceType] protected execution

2018-10-05 Thread Bertrand Delacretaz
Hi, On Fri, Oct 5, 2018 at 6:52 AM Carsten Ziegeler wrote: > ...I would like to get briefly back to the use case of this "dangerous > servlet". Why isn't that servlet doing the permission checks which I > think is way safer than relying on additional magic somewhere else > (regardless of what

Re: Introducing the Feature json schema validation

2018-10-05 Thread David Bosschaert
Hi Simo, It would be great if we had a JSON Schema definition for the feature files and if we could use that for validation. The schema itself can already be useful for documentation purposes! +1 from me. David On Fri, 5 Oct 2018 at 10:06, Simone Tripodi wrote: > Hi all, > I did an

Re: Introducing the Feature json schema validation

2018-10-05 Thread Simone Tripodi
Hi all, I did an experiment yesterday in the night with the Apache Johnzon JSON Schema implementation [1], but it doesn't fails where it is expect to be. I'll do some other tries during the WE :P ~Simo [1] https://johnzon.apache.org/ http://people.apache.org/~simonetripodi/

[jira] [Updated] (SLING-7978) Sling Mocks: Allow easy access to the ModelFactory

2018-10-05 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7978: --- Issue Type: Improvement (was: Bug) > Sling Mocks: Allow easy access to the ModelFactory >

[jira] [Commented] (SLING-7978) Sling Mocks: Allow easy access to the ModelFactory

2018-10-05 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639528#comment-16639528 ] Stefan Seifert commented on SLING-7978: --- lgtm > Sling Mocks: Allow easy access to the ModelFactory

[jira] [Created] (SLING-7985) ProjectHelper#getConfigValue() puts null values to the resulting Set values

2018-10-05 Thread Simone Tripodi (JIRA)
Simone Tripodi created SLING-7985: - Summary: ProjectHelper#getConfigValue() puts null values to the resulting Set values Key: SLING-7985 URL: https://issues.apache.org/jira/browse/SLING-7985 Project:

[jira] [Commented] (SLING-7978) Sling Mocks: Allow easy access to the ModelFactory

2018-10-05 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639596#comment-16639596 ] Konrad Windszus commented on SLING-7978: Merged with

[jira] [Commented] (SLING-7985) ProjectHelper#getConfigValue() puts null values to the resulting Set values

2018-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639595#comment-16639595 ] ASF GitHub Bot commented on SLING-7985: --- simonetripodi opened a new pull request #2: SLING-7985 -

[GitHub] simonetripodi opened a new pull request #2: SLING-7985 - ProjectHelper#getConfigValue() puts null values to the resulting Set values

2018-10-05 Thread GitBox
simonetripodi opened a new pull request #2: SLING-7985 - ProjectHelper#getConfigValue() puts null values to the resulting Set values URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/2 proposed fix This is

[jira] [Commented] (SLING-7978) Sling Mocks: Allow easy access to the ModelFactory

2018-10-05 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639631#comment-16639631 ] Konrad Windszus commented on SLING-7978: I published the updated site to

[jira] [Resolved] (SLING-7978) Sling Mocks: Allow easy access to the ModelFactory

2018-10-05 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-7978. Resolution: Fixed > Sling Mocks: Allow easy access to the ModelFactory >

Re: [sling:resourceType] protected execution

2018-10-05 Thread Radu Cotescu
Hi, Since this thread exploded so quickly it’s going to be difficult to respond to all of your questions / concerns individually. We eagerly started discussing implementation details (of which I’m to blame too) and I think we didn’t read between the lines of this thread or the previous [0] to

[jira] [Updated] (SLING-7978) Sling Mocks: Allow easy access to the ModelFactory

2018-10-05 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7978: --- Affects Version/s: (was: Testing Sling Mock 2.3.4) > Sling Mocks: Allow easy access to

[jira] [Updated] (SLING-7978) Sling Mocks: Allow easy access to the ModelFactory

2018-10-05 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7978: --- Component/s: Site > Sling Mocks: Allow easy access to the ModelFactory >

Re: [sling:resourceType] protected execution

2018-10-05 Thread Jason E Bailey
I don't think we are all that far off from each other. 1. Each resource provider, if it supports security, should be responsible for security 2. There should be a common interface to tell a resource provider what permissions to be set. 3. I should be able to take a resource and if I have the

[GitHub] bosschaert commented on issue #3: SLING-7970 Add Feature Model introspection service

2018-10-05 Thread GitBox
bosschaert commented on issue #3: SLING-7970 Add Feature Model introspection service URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/3#issuecomment-427362517 Hi @cziegeler and @karlpauls would you have time to take a quick look at these changes? I'll work on

[jira] [Commented] (SLING-7970) Add Feature Model introspection service

2018-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639820#comment-16639820 ] ASF GitHub Bot commented on SLING-7970: --- bosschaert commented on issue #3: SLING-7970 Add Feature

[jira] [Commented] (SLING-7970) Add Feature Model introspection service

2018-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639818#comment-16639818 ] ASF GitHub Bot commented on SLING-7970: --- bosschaert opened a new pull request #3: SLING-7970 Add

[GitHub] bosschaert opened a new pull request #3: SLING-7970 Add Feature Model introspection service

2018-10-05 Thread GitBox
bosschaert opened a new pull request #3: SLING-7970 Add Feature Model introspection service URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/3 Get the launcher to install a Felix Inventory Printer service that prints the effective feature. This can be used to