Hi Simo,
Take this with several grains of salt as I don't know the internals of the
feature processing, but just looking at your email from a generic "how do I
process a JSON file" it still seems inefficient.
Ideally, IMO, the substitution would be done as a filter applied to the
stream of parser
Dominik Süß created SLING-8092:
--
Summary: Relocation in Content Extension to bold
Key: SLING-8092
URL: https://issues.apache.org/jira/browse/SLING-8092
Project: Sling
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SLING-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683524#comment-16683524
]
Dominik Süß commented on SLING-8092:
The workaround, for now, is to depend on the shading mechanism
DominikSuess opened a new pull request #5: SLING-8092 - using relocation to
workaround the relocation issue of M…
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/5
…SHADE-156
This is an
It's only 1 - 2 from your list is taking a structured json and creates
resources out of the structure (if I'm not mistaken) which is something
I don't need.
With the approach I hope there is no need for b) (caching) as the
mapping is 1:1 (more or less). As there is no need for cachign I don't
+1
regards,
Karl
On Sunday, November 11, 2018, Daniel Klco wrote:
> +1
>
> On Sat, Nov 10, 2018 at 5:24 AM Carsten Ziegeler
> wrote:
>
> > +1
> >
> > Am 10.11.2018 um 11:23 schrieb Carsten Ziegeler:
> > > Hi,
> > >
> > > We solved 3 issues in this release
> > >
+1
regards,
Karl
On Sunday, November 11, 2018, Daniel Klco wrote:
> +1
>
> On Sat, Nov 10, 2018 at 7:40 AM Carsten Ziegeler
> wrote:
>
> > +1
> >
> > Am 10.11.2018 um 11:29 schrieb Carsten Ziegeler:
> > > Hi,
> > >
> > > We solved 2 issues in this release
> > >
karlpauls closed pull request #5: SLING-8092 - using relocation to workaround
the relocation issue of M…
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/5
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is
ah, ok - this sounds like fsresource 1.2.2 (all the new stuff was added in 2.x).
in this case it might make sense to create a new bundle without the existing
one, or maintain the 1.x branch in parallel to 2.x or fork it to a new bundle.
stefan
>-Original Message-
>From: Carsten Ziegeler
[
https://issues.apache.org/jira/browse/SLING-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683470#comment-16683470
]
Konrad Windszus commented on SLING-8090:
Unfortunately the annotation version determines
yes, the current implementation of the fsresource provider is no longer any
simple.
it currently supports three (configurable) modes:
1. simple mapping of folders and binary files from filesystem (this was the
starting point of fsresource)
2. reading structured resource data from JSON files and
[
https://issues.apache.org/jira/browse/SLING-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683526#comment-16683526
]
ASF GitHub Bot commented on SLING-8092:
---
DominikSuess opened a new pull request #5: SLING-8092 -
stefanseifert closed pull request #3: SLING-8066 MockProperty.setValue(final
String[] newValues) throws null pointer exception
URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/3
This is a PR merged from a forked repository.
As GitHub hides the original diff on
[
https://issues.apache.org/jira/browse/SLING-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683555#comment-16683555
]
ASF GitHub Bot commented on SLING-8092:
---
karlpauls closed pull request #5: SLING-8092 - using
Hi,
I would be totally happy if we can factor out the extensions, I'm
wondering however if this is worth the effort.
In my use case, I would like to have a simple mapping to directories and
files, supporting json and binary files. So a resource maps to a json
file 1:1 regardless of the
+1
> On 10 Nov 2018, at 11:23, Carsten Ziegeler wrote:
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
[
https://issues.apache.org/jira/browse/SLING-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683506#comment-16683506
]
Carsten Ziegeler commented on SLING-8090:
-
[~kwin] I think it's fine to go with R7 for DS,
+1
> On 10 Nov 2018, at 11:29, Carsten Ziegeler wrote:
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
so from my list below your use case is 1. + 2. + a) + probably b) and leaving
out the other parts?
or something different from what is implemented currently?
stefan
>-Original Message-
>From: Carsten Ziegeler [mailto:cziege...@apache.org]
>Sent: Monday, November 12, 2018 11:20 AM
>To:
simonetripodi opened a new pull request #8: SLING-8078 - New Analyser task
which is able to detect Export-Package dependencies between regions
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/8
handling the error case where the same package is listed in both the
We have to distinguish between the json representation of a feature as
defined in our "specification" and the additional support of our maven
plugin.
A feature must have an ID and we don't allow interpolation of
placeholders within the feature. Therefore the json code that we have to
read a
Am 09.11.2018 um 14:23 schrieb Robert Munteanu:
On Fri, 2018-11-09 at 13:49 +0100, Carsten Ziegeler wrote:
- what exactly does complete imply? can it be launched with other
features? etc. I guess we just need to define this.
My personal optinion is that we should be able to launch a
[
https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684782#comment-16684782
]
Carsten Ziegeler commented on SLING-7934:
-
True, but if you want to stream json out, creating a
bosschaert commented on issue #8: SLING-8078 - New Analyser task which is able
to detect Export-Package dependencies between regions
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/8#issuecomment-437854827
Hi Simo, thanks for the PR! Would it be possible to
[
https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683670#comment-16683670
]
ASF GitHub Bot commented on SLING-8078:
---
bosschaert commented on issue #8: SLING-8078 - New
[
https://issues.apache.org/jira/browse/SLING-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-8093.
Resolution: Fixed
Fixed with
[
https://issues.apache.org/jira/browse/SLING-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-8094:
---
Summary: Add OSGi sling servlet annotations to dependencyMgmt (was: Add
OSGi sling servlet
[
https://issues.apache.org/jira/browse/SLING-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683729#comment-16683729
]
Konrad Windszus commented on SLING-8095:
Just pushed a proposed fix in
[
https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683736#comment-16683736
]
ASF GitHub Bot commented on SLING-8078:
---
bosschaert closed pull request #8: SLING-8078 - New
simonetripodi commented on issue #8: SLING-8078 - New Analyser task which is
able to detect Export-Package dependencies between regions
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/8#issuecomment-437872968
awesome, thanks a lot to your for the review! :)
[
https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683780#comment-16683780
]
ASF GitHub Bot commented on SLING-8078:
---
simonetripodi commented on issue #8: SLING-8078 - New
[
https://issues.apache.org/jira/browse/SLING-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert resolved SLING-7970.
-
Resolution: Fixed
> Add Feature Model introspection service
>
David Bosschaert created SLING-8096:
---
Summary: Make it possible to configure Merge Handlers and Post
Processors
Key: SLING-8096
URL: https://issues.apache.org/jira/browse/SLING-8096
Project: Sling
Konrad Windszus created SLING-8094:
--
Summary: Add OSGi sling servlet annotations to pluginMgmt
Key: SLING-8094
URL: https://issues.apache.org/jira/browse/SLING-8094
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683714#comment-16683714
]
Konrad Windszus commented on SLING-8095:
The artifacts has been explicitly added in
[
https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683710#comment-16683710
]
ASF GitHub Bot commented on SLING-8078:
---
simonetripodi commented on issue #8: SLING-8078 - New
+1 on a simple resource provider, I'm curious about the focus on a filesystem
provider. I've started playing around with creating one and I see a clear
logical association between what a resource provider needs and a key-value
store. Good key-value stores already have versioning, and non
[
https://issues.apache.org/jira/browse/SLING-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683840#comment-16683840
]
David Bosschaert commented on SLING-7970:
-
A mechanism to look up the effective feature model is
Konrad Windszus created SLING-8095:
--
Summary: Include Sling Servlet Annotations in Aggregate Javadoc
Key: SLING-8095
URL: https://issues.apache.org/jira/browse/SLING-8095
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683718#comment-16683718
]
ASF GitHub Bot commented on SLING-8078:
---
simonetripodi commented on issue #8: SLING-8078 - New
[
https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683737#comment-16683737
]
ASF GitHub Bot commented on SLING-8078:
---
bosschaert commented on issue #8: SLING-8078 - New
[
https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683596#comment-16683596
]
ASF GitHub Bot commented on SLING-8078:
---
simonetripodi opened a new pull request #8: SLING-8078 -
[
https://issues.apache.org/jira/browse/SLING-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-8090:
---
Fix Version/s: (was: Bundle Parent 35)
> Use newest OSGi annotation versions
>
[
https://issues.apache.org/jira/browse/SLING-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683669#comment-16683669
]
Konrad Windszus commented on SLING-8090:
Ok, I track the newer versions in SLING-8093 and close
[
https://issues.apache.org/jira/browse/SLING-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-8090.
Resolution: Won't Fix
> Use newest OSGi annotation versions
>
simonetripodi commented on issue #8: SLING-8078 - New Analyser task which is
able to detect Export-Package dependencies between regions
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/8#issuecomment-437859716
of course, please apologise for the missing test,
Am 12.11.2018 um 14:31 schrieb Bertrand Delacretaz:
Hi,
On Mon, Nov 12, 2018 at 12:20 PM Carsten Ziegeler wrote:
...As a side note, the markdown resource provider in the whiteboard is
another file system based rp which is closer to my use case, except that
it supports markdown files
Yes, I was thinking of using the 1.x branch, however that branch is at
version 1.3.x which contains a lot of the unneeded (from my pov) as well.
Maybe I just start a prototype in the whiteboard and then we can figure
out what to do about it :)
As a side note, the markdown resource provider
Konrad Windszus created SLING-8093:
--
Summary: Raise OSGi annotations and DS, metatype and configuration
admin versions to R7
Key: SLING-8093
URL: https://issues.apache.org/jira/browse/SLING-8093
[
https://issues.apache.org/jira/browse/SLING-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683719#comment-16683719
]
Konrad Windszus commented on SLING-8095:
Most probably the word splitting
simonetripodi commented on issue #8: SLING-8078 - New Analyser task which is
able to detect Export-Package dependencies between regions
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/8#issuecomment-437860775
`testPackageEnlistedInBothRegions()` added, see
Hi,
On Mon, Nov 12, 2018 at 12:20 PM Carsten Ziegeler wrote:
> ...As a side note, the markdown resource provider in the whiteboard is
> another file system based rp which is closer to my use case, except that
> it supports markdown files instead of json...
Having a GitHub-friendly resource
[
https://issues.apache.org/jira/browse/SLING-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-8093:
--
Assignee: Konrad Windszus
> Raise OSGi annotations and DS, metatype and configuration
bosschaert commented on issue #8: SLING-8078 - New Analyser task which is able
to detect Export-Package dependencies between regions
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/8#issuecomment-437865324
Thanks @simonetripodi for code and test case - it's
bosschaert closed pull request #8: SLING-8078 - New Analyser task which is able
to detect Export-Package dependencies between regions
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/8
This is an
Timothee Maret created SLING-8097:
-
Summary: Expose queue capabilities as resource property
Key: SLING-8097
URL: https://issues.apache.org/jira/browse/SLING-8097
Project: Sling
Issue Type:
[
https://issues.apache.org/jira/browse/SLING-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-8098.
---
Resolution: Fixed
> Update DistributionQueue method/variable to deal with entries
>
[
https://issues.apache.org/jira/browse/SLING-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683951#comment-16683951
]
Timothee Maret commented on SLING-8098:
---
Done in
Dominik Süß created SLING-8099:
--
Summary: Potential NPE condition in ContentOrderMergeProcessor
Key: SLING-8099
URL: https://issues.apache.org/jira/browse/SLING-8099
Project: Sling
Issue Type:
[
https://issues.apache.org/jira/browse/SLING-8065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-8065.
---
Resolution: Won't Do
Instead of extracting trait APIs, we used a queue meta data approach to
Timothee Maret created SLING-8098:
-
Summary: Update DistributionQueue documentation and variable names
Key: SLING-8098
URL: https://issues.apache.org/jira/browse/SLING-8098
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert reassigned SLING-8096:
---
Assignee: David Bosschaert
> Make it possible to configure Merge Handlers and Post
[
https://issues.apache.org/jira/browse/SLING-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-8098:
--
Summary: Update DistributionQueue documentation and method/variable names
(was: Update
[
https://issues.apache.org/jira/browse/SLING-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-8098:
--
Summary: Update DistributionQueue method/variable to deal with entries
(was: Update
[
https://issues.apache.org/jira/browse/SLING-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-8097.
---
Resolution: Fixed
Done in
[
https://issues.apache.org/jira/browse/SLING-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683978#comment-16683978
]
ASF GitHub Bot commented on SLING-8099:
---
DominikSuess opened a new pull request #6: SLING-8099 -
bosschaert closed pull request #6: SLING-8099 - eliminating NPE condition
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/6
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
Hi,
The vote has passed with the following result:
+1 (binding): Konrad Windszus, Daniel Klco, Carsten Ziegeler, Radu
Cotescu
I'll promote the artifacts to the central Maven repository and will copy
this release to the Sling dist directory.
-Georg
On 2018-11-09 15:42, Radu Cotescu wrote:
[
https://issues.apache.org/jira/browse/SLING-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Georg Henzler closed SLING-8083.
> Installer Hook: Installer events are not in all cases received
>
DominikSuess opened a new pull request #6: SLING-8099 - eliminating NPE
condition
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/6
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/SLING-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert updated SLING-7970:
Fix Version/s: Feature Model Launcher 0.2.0
> Add Feature Model introspection service
>
[
https://issues.apache.org/jira/browse/SLING-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-8086.
---
Resolution: Fixed
> Extend distribution queue SPI with the ability to clear and batch remove
[
https://issues.apache.org/jira/browse/SLING-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683921#comment-16683921
]
Timothee Maret commented on SLING-8086:
---
Done in
[
https://issues.apache.org/jira/browse/SLING-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683984#comment-16683984
]
ASF GitHub Bot commented on SLING-8099:
---
bosschaert closed pull request #6: SLING-8099 -
bosschaert commented on issue #6: SLING-8099 - eliminating NPE condition
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/6#issuecomment-437932381
Thanks @DominikSuess for the PR - it's merged.
[
https://issues.apache.org/jira/browse/SLING-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683985#comment-16683985
]
ASF GitHub Bot commented on SLING-8099:
---
bosschaert commented on issue #6: SLING-8099 - eliminating
stefanseifert closed pull request #4: SLING-8066 remove property if set to null
(for all nullable property value types)
URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/4
This is an automated
[
https://issues.apache.org/jira/browse/SLING-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-8066.
---
Resolution: Fixed
fixed in
Hi all mates,
during the last couple of months the work we've been doing on Feature
files processing is HUGE, so the iterations to refine the pipeline
process introduced some "overhead" operations we can improve, what we
currently do is:
* the pre processor starts by reading the whole file to
[
https://issues.apache.org/jira/browse/SLING-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert resolved SLING-8076.
-
Resolution: Fixed
Resolved with
[
https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684342#comment-16684342
]
Jason E Bailey commented on SLING-7934:
---
I'm not sure what you're definition of easily done is in
[
https://issues.apache.org/jira/browse/SLING-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert resolved SLING-8096.
-
Resolution: Fixed
Fixed with
82 matches
Mail list logo
