[jira] [Commented] (SLING-8854) In-file and In-memory queue-providers for Forward Distribution report incorrect value for processing "Attempts"

2019-12-04 Thread Ashish Chopra (Jira)
[ https://issues.apache.org/jira/browse/SLING-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987745#comment-16987745 ] Ashish Chopra commented on SLING-8854: -- [~marett], comments on SLING-8743 indicate that separating

[jira] [Assigned] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-04 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reassigned SLING-8869: - Assignee: Timothee Maret > SimpleHttpDistributionTransport does not refresh the secret

Re: sling.servlet.resolution = strict ?

2019-12-04 Thread Carsten Ziegeler
With compatibility I mean that existing code(servlets) work as before, even if they specified the extensions/methods properties that are ignored today. Bertrand's proposal covers that. And yes, we should rely on capabilities. The servlets resolver bundle already provides such a capability, so

[jira] [Comment Edited] (SLING-8853) Develop an Active variant of ResourceQueue and make it available as possible queue.provider for ForwardDistributionAgentFactory

2019-12-04 Thread Ashish Chopra (Jira)
[ https://issues.apache.org/jira/browse/SLING-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987743#comment-16987743 ] Ashish Chopra edited comment on SLING-8853 at 12/4/19 11:02 AM: I've

[jira] [Commented] (SLING-8853) Develop an Active variant of ResourceQueue and make it available as possible queue.provider for ForwardDistributionAgentFactory

2019-12-04 Thread Ashish Chopra (Jira)
[ https://issues.apache.org/jira/browse/SLING-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987743#comment-16987743 ] Ashish Chopra commented on SLING-8853: -- I've updated the PR for this issue [0] with the tests for

[jira] [Commented] (SLING-8868) DistributionPackage built using DistributionPackageBuilder.getPackage doesn't contain correct DIstributionPackageInfo

2019-12-04 Thread Ashish Chopra (Jira)
[ https://issues.apache.org/jira/browse/SLING-8868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987754#comment-16987754 ] Ashish Chopra commented on SLING-8868: -- [~marett], I've updated the PR [0] to address sonarqube and

[jira] [Updated] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-04 Thread Mohit Arora (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Arora updated SLING-8869: --- Attachment: SLING-8869-new.patch > SimpleHttpDistributionTransport does not refresh the secret for

Re: [VOTE] Release Apache Sling Content Distribution Journal Core 0.1.6

2019-12-04 Thread Radu Cotescu
+1 > On 3 Dec 2019, at 21:29, Timothee Maret wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

[jira] [Commented] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-04 Thread Mohit Arora (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987641#comment-16987641 ] Mohit Arora commented on SLING-8869: [~bdelacretaz], [~ashishc] I have attached another patch,

Re: sling.servlet.resolution = strict ?

2019-12-04 Thread Carsten Ziegeler
It's important that we are compatible. For the new property I think we should support two values, one of them being the default (works as today) and one for the new behaviour. Not specifying the prop then is the same as specifying the default value. I'm not sure if "strict" is a good choice,

Re: Sling preventing Login

2019-12-04 Thread Robert Munteanu
Hi Andy, On Tue, 2019-12-03 at 16:46 -0800, Andreas Schaefer wrote: > Hi > > I am running into a problem with Sling 11 on Java 8. When I launch > Sling 11 and then install Peregrine on it everything works just fine. > But then I restart Sling I am not able to login anymore as the login > page

Re: sling.servlet.resolution = strict ?

2019-12-04 Thread Radu Cotescu
+1 > On 4 Dec 2019, at 11:00, Carsten Ziegeler wrote: > > And yes, we should rely on capabilities. The servlets resolver bundle already > provides such a capability, so we can build on that one. > If developers use the annotations, we can use the bnd functionality to > automatically generate

[jira] [Commented] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-04 Thread Ashish Chopra (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987757#comment-16987757 ] Ashish Chopra commented on SLING-8869: -- [~mohiaror], may I suggest raising a PR for SCD maintainers

Re: sling.servlet.resolution = strict ?

2019-12-04 Thread Konrad Windszus
Well, compatibility is hard to achieve here. Imagine you have a servlet registered to a path with an extension. That obviously requires the new servlet resolver bundle (evaluating the sling.servlet.resolution property). Therefore it cannot be backwards compatible. It should fail in case you try

Re: sling.servlet.resolution = strict ?

2019-12-04 Thread Bertrand Delacretaz
Hi, On Wed, Dec 4, 2019 at 11:00 AM Carsten Ziegeler wrote: > ...The servlets resolver bundle > already provides such a capability, so we can build on that one. > If developers use the annotations, we can use the bnd functionality to > automatically generate the requirement if the annotation

[jira] [Commented] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-04 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987967#comment-16987967 ] Timothee Maret commented on SLING-8869: --- {quote}It works fine for credentials based secret provider

RE: [VOTE] Release Apache Sling Content Distribution Journal Core 0.1.6

2019-12-04 Thread Stefan Seifert
+1

Re: sling.servlet.resolution = strict ?

2019-12-04 Thread Carsten Ziegeler
Am 04.12.2019 um 14:42 schrieb Bertrand Delacretaz: We can discuss separately whether "strict" is the right base name. Naming is hard ;-) :) 1) When this is implemented, the o.a.s.servlets.resolver bundle gets an additional (static, in pom.xml) value for its Provide-Capability header.

Re: sling.servlet.resolution = strict ?

2019-12-04 Thread Konrad Windszus
For b) we can use https://osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/bundle/Requirement.html as meta annotation on a new servlet annotation. That way, bnd will automatically add the

Re: sling.servlet.resolution = strict ?

2019-12-04 Thread Bertrand Delacretaz
Hi, On Wed, Dec 4, 2019 at 2:48 PM Carsten Ziegeler wrote: > Am 04.12.2019 um 14:42 schrieb Bertrand Delacretaz: > >...org.apache.sling.servlets.resolver;strict.mode.support:Version=1.0.0 > > > >... >osgi.extender;osgi.extender="org.apache.sling.servlets.resolver";version:Version="1.1"

[jira] [Comment Edited] (SLING-5946) XSSAPI#encodeForJSString is not restrictive enough

2019-12-04 Thread Ilguiz Latypov (Jira)
[ https://issues.apache.org/jira/browse/SLING-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988288#comment-16988288 ] Ilguiz Latypov edited comment on SLING-5946 at 12/4/19 11:26 PM: - Please

[jira] [Comment Edited] (SLING-5946) XSSAPI#encodeForJSString is not restrictive enough

2019-12-04 Thread Ilguiz Latypov (Jira)
[ https://issues.apache.org/jira/browse/SLING-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988288#comment-16988288 ] Ilguiz Latypov edited comment on SLING-5946 at 12/4/19 11:27 PM: - Please

[jira] [Comment Edited] (SLING-5946) XSSAPI#encodeForJSString is not restrictive enough

2019-12-04 Thread Ilguiz Latypov (Jira)
[ https://issues.apache.org/jira/browse/SLING-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988288#comment-16988288 ] Ilguiz Latypov edited comment on SLING-5946 at 12/4/19 11:30 PM: - Please

[jira] [Commented] (SLING-5946) XSSAPI#encodeForJSString is not restrictive enough

2019-12-04 Thread Ilguiz Latypov (Jira)
[ https://issues.apache.org/jira/browse/SLING-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988288#comment-16988288 ] Ilguiz Latypov commented on SLING-5946: --- Please reopen this due to an improper implementation

[jira] [Comment Edited] (SLING-5946) XSSAPI#encodeForJSString is not restrictive enough

2019-12-04 Thread Ilguiz Latypov (Jira)
[ https://issues.apache.org/jira/browse/SLING-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988288#comment-16988288 ] Ilguiz Latypov edited comment on SLING-5946 at 12/4/19 11:32 PM: - Please

[jira] [Commented] (SLING-8875) Create new Goal to create a FM Descriptor from a Maven Module

2019-12-04 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988319#comment-16988319 ] Andreas Schaefer commented on SLING-8875: - [~cziegeler] Sorry, I got confused between the

[jira] [Commented] (SLING-5946) XSSAPI#encodeForJSString is not restrictive enough

2019-12-04 Thread Ilguiz Latypov (Jira)
[ https://issues.apache.org/jira/browse/SLING-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988471#comment-16988471 ] Ilguiz Latypov commented on SLING-5946: --- [~radu], [~rombert], [~vladb] > XSSAPI#encodeForJSString

[jira] [Commented] (SLING-8875) Create new Goal to create a FM Descriptor from a Maven Module

2019-12-04 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988511#comment-16988511 ] Carsten Ziegeler commented on SLING-8875: - [~andysch] Good point with the naming, yes, we should

[jira] [Commented] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-04 Thread Mohit Arora (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988514#comment-16988514 ] Mohit Arora commented on SLING-8869: [~marett] I have raised PRs for both the approaches -

[GitHub] [sling-org-apache-sling-distribution-core] mohiaror opened a new pull request #29: SLING-8869 SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-04 Thread GitBox
mohiaror opened a new pull request #29: SLING-8869 SimpleHttpDistributionTransport does not refresh the secret for token based implementations. URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/29 Do not cache the token based executor as we do not know when a

[jira] [Commented] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-04 Thread Ashish Chopra (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988538#comment-16988538 ] Ashish Chopra commented on SLING-8869: -- bq. If an Executor with a wrong pwd is cached then the only

[GitHub] [sling-org-apache-sling-distribution-core] mohiaror opened a new pull request #28: SLING-8869 SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-04 Thread GitBox
mohiaror opened a new pull request #28: SLING-8869 SimpleHttpDistributionTransport does not refresh the secret for token based implementations. URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/28 Do not set the default authorization header at the time of

encryption/decryption module

2019-12-04 Thread Oliver Lietz
Hi *, I need some encryption/decryption functionalities in Sling similar to what is available in Karaf - but without dependencies to Karaf and Blueprint. Do we want to host it here at Sling as Commons Crypto or should I make it an OPS4J Pax project? Thanks, O.