Re: [VOTE] Release Apache Sling API 2.17.0
On Tuesday 13 March 2018 21:09:59 Carsten Ziegeler wrote: > Hmm interesting, I can't remember to change it, but apparently it got > changed by my commit. That's a mistake. > > I guess the best would be to revert that change and do another release > > WDYT? I've fixed the bundle version in javadoc. 2.17.2 would have been fine, no? Thanks, O. > Carsten > > > Oliver Lietz wrote > > > On Tuesday 13 March 2018 15:46:44 Julian Sedding wrote: > >> Hi Oli > >> > >> I think it's ok, because ResourceResolver#getSearchPath() also returns > >> String[]. So I think for consistency's sake we should leave it as-is. > >> While I agree with you in principle, there are other examples where > >> the singular term is used to refer to a list of paths, e.g. the java > >> classpath. > > > > ACK, makes sense to be consistent. > > > > Why was package version for o.a.s.request increased? > > > > Thanks, Julian! > > > > O. > > > >> Regards > >> Julian > >> > >> On Tue, Mar 13, 2018 at 3:24 PM, Oliver Lietz wrote: > >>> On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: > Hi, > >>> > >>> Hi, > >>> > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12342301 > >>> > >>> SLING-7537: The method name should be getSearchPaths() instead of > >>> getSearchPath() as it returns a list of strings (paths), no? > >>> > >>> Regards, > >>> O. > >>> > >>> https://github.com/apache/sling-org-apache-sling-api/blob/master/src/mai > >>> n/ > >>> java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222
Re: [VOTE] Release Apache Sling API 2.17.0
Hmm interesting, I can't remember to change it, but apparently it got changed by my commit. That's a mistake. I guess the best would be to revert that change and do another release WDYT? Carsten Oliver Lietz wrote > On Tuesday 13 March 2018 15:46:44 Julian Sedding wrote: >> Hi Oli >> >> I think it's ok, because ResourceResolver#getSearchPath() also returns >> String[]. So I think for consistency's sake we should leave it as-is. >> While I agree with you in principle, there are other examples where >> the singular term is used to refer to a list of paths, e.g. the java >> classpath. > > ACK, makes sense to be consistent. > > Why was package version for o.a.s.request increased? > > Thanks, Julian! > > O. > >> Regards >> Julian >> >> On Tue, Mar 13, 2018 at 3:24 PM, Oliver Lietz wrote: >>> On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: Hi, >>> >>> Hi, >>> We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12342301 >>> >>> SLING-7537: The method name should be getSearchPaths() instead of >>> getSearchPath() as it returns a list of strings (paths), no? >>> >>> Regards, >>> O. >>> >>> https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/ >>> java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222 > -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling API 2.17.0
On Tuesday 13 March 2018 15:46:44 Julian Sedding wrote: > Hi Oli > > I think it's ok, because ResourceResolver#getSearchPath() also returns > String[]. So I think for consistency's sake we should leave it as-is. > While I agree with you in principle, there are other examples where > the singular term is used to refer to a list of paths, e.g. the java > classpath. ACK, makes sense to be consistent. Why was package version for o.a.s.request increased? Thanks, Julian! O. > Regards > Julian > > On Tue, Mar 13, 2018 at 3:24 PM, Oliver Lietz wrote: > > On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: > >> Hi, > > > > Hi, > > > >> We solved 3 issues in this release: > >> > >> https://issues.apache.org/jira/projects/SLING/versions/12342301 > > > > SLING-7537: The method name should be getSearchPaths() instead of > > getSearchPath() as it returns a list of strings (paths), no? > > > > Regards, > > O. > > > > https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/ > > java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222
Re: [VOTE] Release Apache Sling API 2.17.0
Hi Oli I think it's ok, because ResourceResolver#getSearchPath() also returns String[]. So I think for consistency's sake we should leave it as-is. While I agree with you in principle, there are other examples where the singular term is used to refer to a list of paths, e.g. the java classpath. Regards Julian On Tue, Mar 13, 2018 at 3:24 PM, Oliver Lietz wrote: > On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: >> Hi, > > Hi, > >> We solved 3 issues in this release: >> >> https://issues.apache.org/jira/projects/SLING/versions/12342301 > > SLING-7537: The method name should be getSearchPaths() instead of > getSearchPath() as it returns a list of strings (paths), no? > > Regards, > O. > > https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222 >
Re: [VOTE] Release Apache Sling API 2.17.0
On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: > Hi, Hi, > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12342301 SLING-7537: The method name should be getSearchPaths() instead of getSearchPath() as it returns a list of strings (paths), no? Regards, O. https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222
Re: [VOTE] Release Apache Sling API 2.17.0
On Tue, 2018-03-13 at 08:36 +0100, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling API 2.17.0
+1 On Tue, Mar 13, 2018 at 6:58 AM, Radu Cotescu wrote: > +1 > > On Tue, 13 Mar 2018 at 08:36 Carsten Ziegeler > wrote: > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe Research Switzerland > > cziege...@apache.org > > >
Re: [VOTE] Release Apache Sling API 2.17.0
+1 On Tue, 13 Mar 2018 at 08:36 Carsten Ziegeler wrote: > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
RE: [VOTE] Release Apache Sling API 2.17.0
+1
[VOTE] Release Apache Sling API 2.17.0
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12342301 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1884 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1884 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling API 2.17.0
+1 Carsten Ziegeler wrote > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12342301 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1884 > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1884 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org