Re: [context-aware config] first release this week?

2016-10-14 Thread Carsten Ziegeler
Oliver Lietz wrote
> On Thursday 13 October 2016 20:36:10 Stefan Seifert wrote:
>>> Do we really want org.apache.sling.contextaware.config as package name?
>>> Sling Content Distribution uses org.apache.sling.distribution, so
>>> org.apache.sling.configuration for Sling's context-ware configuration
>>> should be fine, no?
>>
>> only "configuration" is misleading, because it's not about osgi
>> configuration, but only about context-aware configuration. thus
>> "contextaware" has to be part of the package name.
> 
> I do remember the discussion regarding the naming and do not want that 
> starting again. But not sure if the "product label" has to be also the 
> package 
> name – for distribution, which is also a *very* generic name – it has to be 
> not. And as this configurations are based on resources I should have 
> suggested 
> o.a.s.resource.configuration.
> 
>> one could argue if it should be
>>   o.a.s.contextaware.config
>> or
>>   o.a.s.contextawareconfig

I'm fine with contextawareconfig - I think over time we renamed the
packages a little bit, and for example had everything as sub packages of
contextaware (config, resource).
I think we either rename it to contextawareconfig
or go with
contextaware.config
.resource
.annotation
leaving contextaware empty

> 
> The second fits better in our naming pattern. Also these modules are the 
> first 
> using dashes in property names (or node/resource types) instead of camel case.

Hmm, true, haven't really thought about it. I guess camel case would be
more consistent, but I think in the end it's not that important

Regards
Carsten
> 
>>> Any hints for using it on AEM 6.1?
>>
>> i've created a small sample project using it with AEM 6.1 at [1].
>> no further dependencies are required atm.
>> but without customization via SPI it does not yet support cq:Page node types
>> or other AEM specifica.
> 
> Will you provide AEM extensions, tooling and GUI under wcm.io umbrella?
> 
> Hopefully I will find some time in the next weeks to move a project from 
> custom configuration to _context-aware_ configuration (POC). 
> 
> Thanks for contributing that stuff to Sling, Stefan!
> 
> Regards,
> O.
> 
>> stefan
>>
>> [1] https://github.com/stefanseifert/sling-contextaware-config-aem-sample
> 
> 
> 


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org



RE: [context-aware config] first release this week?

2016-10-14 Thread Oliver Lietz
On Thursday 13 October 2016 20:36:10 Stefan Seifert wrote:
> >Do we really want org.apache.sling.contextaware.config as package name?
> >Sling Content Distribution uses org.apache.sling.distribution, so
> >org.apache.sling.configuration for Sling's context-ware configuration
> >should be fine, no?
> 
> only "configuration" is misleading, because it's not about osgi
> configuration, but only about context-aware configuration. thus
> "contextaware" has to be part of the package name.

I do remember the discussion regarding the naming and do not want that 
starting again. But not sure if the "product label" has to be also the package 
name – for distribution, which is also a *very* generic name – it has to be 
not. And as this configurations are based on resources I should have suggested 
o.a.s.resource.configuration.

> one could argue if it should be
>   o.a.s.contextaware.config
> or
>   o.a.s.contextawareconfig

The second fits better in our naming pattern. Also these modules are the first 
using dashes in property names (or node/resource types) instead of camel case.

> >Any hints for using it on AEM 6.1?
> 
> i've created a small sample project using it with AEM 6.1 at [1].
> no further dependencies are required atm.
> but without customization via SPI it does not yet support cq:Page node types
> or other AEM specifica.

Will you provide AEM extensions, tooling and GUI under wcm.io umbrella?

Hopefully I will find some time in the next weeks to move a project from 
custom configuration to _context-aware_ configuration (POC). 

Thanks for contributing that stuff to Sling, Stefan!

Regards,
O.

> stefan
> 
> [1] https://github.com/stefanseifert/sling-contextaware-config-aem-sample




Re: [context-aware config] first release this week?

2016-10-14 Thread Bertrand Delacretaz
On Thu, Oct 13, 2016 at 10:36 PM, Stefan Seifert  wrote:
> ...only "configuration" is misleading, because it's not about osgi 
> configuration, but only
> about context-aware configuration. thus "contextaware" has to be part of the 
> package name...

I agree that just "configuration" would be too generic in this case.

-Bertrand


RE: [context-aware config] first release this week?

2016-10-13 Thread Stefan Seifert

>Do we really want org.apache.sling.contextaware.config as package name?
>Sling Content Distribution uses org.apache.sling.distribution, so
>org.apache.sling.configuration for Sling's context-ware configuration
>should be fine, no?

only "configuration" is misleading, because it's not about osgi configuration, 
but only about context-aware configuration. thus "contextaware" has to be part 
of the package name.

one could argue if it should be
  o.a.s.contextaware.config
or
  o.a.s.contextawareconfig


>Any hints for using it on AEM 6.1?

i've created a small sample project using it with AEM 6.1 at [1].
no further dependencies are required atm.
but without customization via SPI it does not yet support cq:Page node types or 
other AEM specifica.

stefan

[1] https://github.com/stefanseifert/sling-contextaware-config-aem-sample



Re: [context-aware config] first release this week?

2016-10-13 Thread Oliver Lietz
On Tuesday 11 October 2016 21:51:19 Stefan Seifert wrote:
> we've reached a quite good featureset in the current implementation of the
> context-ware configuration [1].
> 
> to make it usable by projects it would be useful to make a release soon.
> 
> there are some planned extensions missing, but i've moved them to version
> 1.1.0 because i think they are not really imporant vor version 1.0.0 and
> should not break the API or SPI. [2]
> 
> i will have no time to work on this new issues the next two weeks, and the
> remaining time slots in this week i want to use to provide documentation
> about the API/SPI and content structure/inheritance features of the
> implementation that is available now.
> 
> if no one objects i will start a release vote by end of this week.

Hi,

catching up here and skimming all issues in JIRA...
Do we really want org.apache.sling.contextaware.config as package name?
Sling Content Distribution uses org.apache.sling.distribution, so 
org.apache.sling.configuration for Sling's context-ware configuration should 
be fine, no?

Any hints for using it on AEM 6.1?

Regards,
O.

> stefan
> 
> 
> [1] https://issues.apache.org/jira/browse/SLING/fixforversion/12338139
> [2]
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20sling%20AND%20la
> bels%20%3D%20contextaware-config%20AND%20resolution%20%3D%20unresolved%20ORD
> ER%20BY%20priority%20DESC%2C%20key%20ASC



Re: [context-aware config] first release this week?

2016-10-12 Thread Carsten Ziegeler
+1 for a release

Stefan Seifert wrote
> we've reached a quite good featureset in the current implementation of the 
> context-ware configuration [1].
> 
> to make it usable by projects it would be useful to make a release soon.
> 
> there are some planned extensions missing, but i've moved them to version 
> 1.1.0 because i think they are not really imporant vor version 1.0.0 and 
> should not break the API or SPI. [2]
> 
> i will have no time to work on this new issues the next two weeks, and the 
> remaining time slots in this week i want to use to provide documentation 
> about the API/SPI and content structure/inheritance features of the 
> implementation that is available now.
> 
> if no one objects i will start a release vote by end of this week.
> 
> stefan
> 
> 
> [1] https://issues.apache.org/jira/browse/SLING/fixforversion/12338139
> [2] 
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20sling%20AND%20labels%20%3D%20contextaware-config%20AND%20resolution%20%3D%20unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
> 
> 
> 


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org