Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-21 Thread Jungtaek Lim
gt;>>> https://github.com/apache/spark/pull/22492 >>>>>>> Otherwise mleap cannot build against spark 2.4.0 >>>>>>> Thanks! >>>>>>> >>>>>>> On Wed, Sep 19, 2018 at 1:16 PM Yinan Li >>>>>>> wr

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-21 Thread Wenchen Fan
at 1:16 PM Yinan Li >>>>>> wrote: >>>>>> >>>>>>> FYI: SPARK-23200 has been resolved. >>>>>>> >>>>>>> On Tue, Sep 18, 2018 at 8:49 AM Felix Cheung < >>>>>>> felixcheun...@hotmail.c

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-20 Thread Jungtaek Lim
>>>>> >>>>> On Wed, Sep 19, 2018 at 1:16 PM Yinan Li wrote: >>>>> >>>>>> FYI: SPARK-23200 has been resolved. >>>>>> >>>>>> On Tue, Sep 18, 2018 at 8:49 AM Felix Cheung < >>>>>> felixcheun...@hotmail.com> wrote: >>>>>> >>>&g

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-20 Thread Wenchen Fan
t;>>>> FYI: SPARK-23200 has been resolved. >>>>> >>>>> On Tue, Sep 18, 2018 at 8:49 AM Felix Cheung < >>>>> felixcheun...@hotmail.com> wrote: >>>>> >>>>>> If we could work on this quickly - it might get on to future RCs. >>>>>> &g

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-20 Thread Jungtaek Lim
>> >>>> On Tue, Sep 18, 2018 at 8:49 AM Felix Cheung >>>> wrote: >>>> >>>>> If we could work on this quickly - it might get on to future RCs. >>>>> >>>>> >>>>> >>>>> ------------------ >>>>> *From:* Stavros Kontopo

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-20 Thread Holden Karau
*Sent:* Monday, September 17, 2018 2:35 PM >>>> *To:* Yinan Li >>>> *Cc:* Xiao Li; eerla...@redhat.com; van...@cloudera.com.invalid; Sean >>>> Owen; Wenchen Fan; dev >>>> *Subject:* Re: [VOTE] SPARK 2.4.0 (RC1) >>>> >>>> Hi Xiao

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-20 Thread Jungtaek Lim
gt;> *To:* Yinan Li >>> *Cc:* Xiao Li; eerla...@redhat.com; van...@cloudera.com.invalid; Sean >>> Owen; Wenchen Fan; dev >>> *Subject:* Re: [VOTE] SPARK 2.4.0 (RC1) >>> >>> Hi Xiao, >>> >>> I just tested it, it seems ok. There are some

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-20 Thread Weichen Xu
cloudera.com.invalid; Sean >> Owen; Wenchen Fan; dev >> *Subject:* Re: [VOTE] SPARK 2.4.0 (RC1) >> >> Hi Xiao, >> >> I just tested it, it seems ok. There are some questions about which >> properties we should keep when restoring the config. Otherwise it loo

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-18 Thread Yinan Li
gt; *To:* Yinan Li > *Cc:* Xiao Li; eerla...@redhat.com; van...@cloudera.com.invalid; Sean > Owen; Wenchen Fan; dev > *Subject:* Re: [VOTE] SPARK 2.4.0 (RC1) > > Hi Xiao, > > I just tested it, it seems ok. There are some questions about which > properties we should keep

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-18 Thread Felix Cheung
] SPARK 2.4.0 (RC1) Hi Xiao, I just tested it, it seems ok. There are some questions about which properties we should keep when restoring the config. Otherwise it looks ok to me. The reason this should go in 2.4 is that streaming on k8s is something people want to try day one (or at least it is cool

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-18 Thread Wenchen Fan
Thanks Marcelo to point out my gpg key issue! I've re-generated it and uploaded to ASF spark repo. Let's see if it works in the next RC. Thanks Saisai to point out the Python doc issue, I'll fix it in the next RC. This RC fails because: 1. it doesn't include a Scala 2.12 build 2. the gpg key

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-18 Thread Marco Gaido
Sorry but I am -1 because of what was reported here: https://issues.apache.org/jira/browse/SPARK-22036?focusedCommentId=16618104=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16618104 . It is a regression unfortunately. Despite the impact is not huge and there are

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Holden Karau
Deprecating Py 2 in the 2.4 release probably doesn't belong in the RC vote thread. Personally I think we might be a little too late in the game to deprecate it in 2.4, but I think calling it out as "soon to be deprecated" in the release docs would be sensible to give folks extra time to prepare.

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Saisai Shao
Hi Wenchen, I think you need to set SPHINXPYTHON to python3 before building the docs, to workaround the doc issue ( https://dist.apache.org/repos/dist/dev/spark/v2.4.0-rc1-docs/_site/api/python/pyspark.ml.html#pyspark.ml.classification.LogisticRegression ). Here is the notes for release page:

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Stavros Kontopoulos
Hi Xiao, I just tested it, it seems ok. There are some questions about which properties we should keep when restoring the config. Otherwise it looks ok to me. The reason this should go in 2.4 is that streaming on k8s is something people want to try day one (or at least it is cool to try) and

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Yinan Li
We can merge the PR and get SPARK-23200 resolved if the whole point is to make streaming on k8s work first. But given that this is not a blocker for 2.4, I think we can take a bit more time here and get it right. With that being said, I would expect it to be resolved soon. On Mon, Sep 17, 2018 at

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Xiao Li
Hi, Erik and Stavros, This bug fix SPARK-23200 is not a blocker of the 2.4 release. It sounds important for the Streaming on K8S. Could the K8S oriented committers speed up the reviews? Thanks, Xiao Erik Erlandson 于2018年9月17日周一 上午11:04写道: > > I have no binding vote but I second Stavros’

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Erik Erlandson
I have no binding vote but I second Stavros’ recommendation for spark-23200 Per parallel threads on Py2 support I would also like to propose deprecating Py2 starting with this 2.4 release On Mon, Sep 17, 2018 at 10:38 AM Marcelo Vanzin wrote: > You can log in to https://repository.apache.org

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Marcelo Vanzin
You can log in to https://repository.apache.org and see what's wrong. Just find that staging repo and look at the messages. In your case it seems related to your signature. failureMessageNo public key: Key with id: () was not able to be located on http://gpg-keyserver.de/. Upload your public

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Stavros Kontopoulos
I just follow the comment Wehnchen Fan (of course it is not merged yet, but I wanted to bring this to the attention of the dev list) "We should definitely merge it to branch 2.4, but I won't block the release since it's not that critical and it's still in progress. After it's merged, feel free to

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Nicholas Chammas
I believe -1 votes are merited only for correctness bugs and regressions since the previous release. Does SPARK-23200 count as either? 2018년 9월 17일 (월) 오전 9:40, Stavros Kontopoulos < stavros.kontopou...@lightbend.com>님이 작성: > -1 > > I would like to see:

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-17 Thread Stavros Kontopoulos
-1 I would like to see: https://github.com/apache/spark/pull/22392 in, as discussed here: https://issues.apache.org/jira/browse/SPARK-23200. It is important IMHO for streaming on K8s. I just started testing it btw. Also 2.12.7(https://contributors.scala-lang.org/t/2-12-7-release/2301,

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-16 Thread Wenchen Fan
I confirmed that https://repository.apache.org/content/repositories/orgapachespark-1285 is not accessible. I did it via ./dev/create-release/do-release-docker.sh -d /my/work/dir -s publish , not sure what's going wrong. I didn't see any error message during it. Any insights are appreciated! So

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-16 Thread Sean Owen
I think one build is enough, but haven't thought it through. The Hadoop 2.6/2.7 builds are already nearly redundant. 2.12 is probably best advertised as a 'beta'. So maybe publish a no-hadoop build of it? Really, whatever's the easy thing to do. On Sun, Sep 16, 2018 at 10:28 PM Wenchen Fan wrote:

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-16 Thread Wenchen Fan
Ah I missed the Scala 2.12 build. Do you mean we should publish a Scala 2.12 build this time? Current for Scala 2.11 we have 3 builds: with hadoop 2.7, with hadoop 2.6, without hadoop. Shall we do the same thing for Scala 2.12? On Mon, Sep 17, 2018 at 11:14 AM Sean Owen wrote: > A few

Re: [VOTE] SPARK 2.4.0 (RC1)

2018-09-16 Thread Sean Owen
A few preliminary notes: Wenchen for some weird reason when I hit your key in gpg --import, it asks for a passphrase. When I skip it, it's fine, gpg can still verify the signature. No issue there really. The staging repo gives a 404: