[GitHub] storm issue #1729: [STORM-2144] Fix Storm-sql group-by behavior in standalon...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1729 Found storm-jms version issue while checking Travis CI failing. Will submit a patch shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request #1731: Fix storm-jms parent version issue (1.x)

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1731 Fix storm-jms parent version issue (1.x) You can merge this pull request into a Git repository by running: $ git pull https://github.com/HeartSaVioR/storm

[GitHub] storm issue #1732: Fix storm-jms parent version (1.0.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1732 Since it's version issue, and it affects Travis CI build result, I will merge when Travis CI passes. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1731: Fix storm-jms parent version issue (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1731 Since it's version issue, and it affects Travis CI build result, I will merge when Travis CI passes. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request #1732: Fix storm-jms parent version (1.0.x)

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1732 Fix storm-jms parent version (1.0.x) You can merge this pull request into a Git repository by running: $ git pull https://github.com/HeartSaVioR/storm fix-storm-jms-parent-version-1.0.x

[GitHub] storm issue #1729: [STORM-2144] Fix Storm-sql group-by behavior in standalon...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1729 Other than that I'm +1. IMHO, standalone mode also needs to have some abstraction or introduce something to not creating source code by manipulate string directly. --- If your project is set

[GitHub] storm issue #1731: Fix storm-jms parent version issue (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1731 All of builds passed and run into integration tests. #1715 needs to be ported back to 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1732: Fix storm-jms parent version (1.0.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1732 All of builds passed and run into integration tests. #1715 needs to be ported back to 1.0.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1732: Fix storm-jms parent version (1.0.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1732 Ported back #1715 and rebased and force pushed this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1731: Fix storm-jms parent version issue (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1731 Ported back #1715 and rebased and force pushed this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #1730: STORM-2145 Leave leader nimbus's hostname to log w...

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1730 STORM-2145 Leave leader nimbus's hostname to log when trying to connect leader nimbus * leave a log regarding leader Nimbus connection information when connecting to leader Nimbus * also

[GitHub] storm pull request #1724: STORM-2131: Add blob command to worker-launcher, m...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1724#discussion_r82611549 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -414,33 +414,30 @@ static int copy_file(int input, const char* in_filename,

[GitHub] storm pull request #1724: STORM-2131: Add blob command to worker-launcher, m...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1724#discussion_r82612830 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -485,14 +482,14 @@ int setup_stormdist_dir(const char* local_dir) {

[GitHub] storm pull request #1724: STORM-2131: Add blob command to worker-launcher, m...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1724#discussion_r82608722 --- Diff: storm-core/src/native/worker-launcher/impl/main.c --- @@ -155,7 +155,23 @@ int main(int argc, char **argv) { fflush(ERRORFILE);

[GitHub] storm pull request #1724: STORM-2131: Add blob command to worker-launcher, m...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1724#discussion_r82611232 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -414,33 +414,30 @@ static int copy_file(int input, const char* in_filename,

[GitHub] storm pull request #1724: STORM-2131: Add blob command to worker-launcher, m...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1724#discussion_r82608542 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java --- @@ -104,6 +104,16 @@ public static void

[GitHub] storm issue #1729: [STORM-2144] Fix Storm-sql group-by behavior in standalon...

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1729 @HeartSaVioR you are right, its very tedious to maintain. Right now its kind of a bridge to translate sql to java so that sql abstractions can be executed in storm core. IMO we should get out

[GitHub] storm issue #1726: STORM-2139: Let ShellBolts and ShellSpouts run with scrip...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1726 @HeartSaVioR we have someone who wants to ship their own version of python with a topology on a multi-tenant cluster. They tried to package it as part of the jar, but were getting permission denied

[GitHub] storm issue #1732: Fix storm-jms parent version (1.0.x)

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1732 +1 Thanks for catching this @HeartSaVioR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1729: [STORM-2144] Fix Storm-sql group-by behavior in standalon...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1729 +1. Isn't standalone mode still helpful for devs instead of just moving to abstract API. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request #1734: STORM-2141 UDAFWrapper needs to provide parameter ...

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1734 STORM-2141 UDAFWrapper needs to provide parameter information when error invoking method While developing UDF and UDAF, users should be aware of association between Calcite RelType and Java

Re: Are storm metrics reported through JMX too?

I’ve been thinking about metrics lately, specifically the fact that people tend to struggle with implementing a metrics consumer. (Like this one [1]). The IMetricsConsumer interface is pretty low level, and common aggregations, calculations, etc. are left up to each individual implementation.

[GitHub] storm pull request #1733: [STORM-2134] - improving the current scheduling st...

GitHub user jerrypeng opened a pull request: https://github.com/apache/storm/pull/1733 [STORM-2134] - improving the current scheduling strategy for RAS You can merge this pull request into a Git repository by running: $ git pull https://github.com/jerrypeng/storm STORM-2134

[GitHub] storm issue #1733: [STORM-2134] - improving the current scheduling strategy ...

Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/1733 Also re-add some RAS related tests that were accidentally deleted in the past --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request #1724: STORM-2131: Add blob command to worker-launcher, m...

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1724#discussion_r82672834 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -414,33 +414,30 @@ static int copy_file(int input, const char* in_filename,

[GitHub] storm pull request #1724: STORM-2131: Add blob command to worker-launcher, m...

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1724#discussion_r82672822 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -414,33 +414,30 @@ static int copy_file(int input, const char* in_filename,

[GitHub] storm pull request #1732: Fix storm-jms parent version (1.0.x)

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1732 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1732: Fix storm-jms parent version (1.0.x)

Github user satishd commented on the issue: https://github.com/apache/storm/pull/1732 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1732: Fix storm-jms parent version (1.0.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1732 Merged into 1.0.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1726: STORM-2139: Let ShellBolts and ShellSpouts run with scrip...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1726 @revans2 Interesting use case... I didn't even think about that. Thanks for clarifying. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [DISCUSS] Plan for merge SQE and Storm SQL

Hi Morrigan, since we're making SQL feature, we need to respect SQL standard, behavior, and common sense, instead of changing its behavior to meet Storm's streaming fashion. Some limitations are actually unavoidable. And I didn't deeply think about "Streaming SQL" yet, since there're still lots

[GitHub] storm pull request #1731: Fix storm-jms parent version issue (1.x)

Github user HeartSaVioR closed the pull request at: https://github.com/apache/storm/pull/1731 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1731: Fix storm-jms parent version issue (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1731 Seems like @harshach already pushed quick fix. Closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [DISCUSS] Plan for merge SQE and Storm SQL

Thank you for this update Jungtaek. I've been meaning to do my own followup to your technical analysis, but unfortunately had some Kafka work eat up a lot of my time. I do have some immediate questions/thoughts, though: 1) From reading the Calcite documentation, a monotonic expression is required

Re: Are storm metrics reported through JMX too?

Thanks Bobby. If we write our own metrics consumer, how do we ensure that it is better than HttpForwardingMetricsServer? In other words, what aspects of the HttpForwardingMetricsServer should we avoid to make our own metrics consumer better and ready for production? Is versign/storm-graphite

[GitHub] storm pull request #1724: STORM-2131: Add blob command to worker-launcher, m...

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1724#discussion_r82634237 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -485,14 +482,14 @@ int setup_stormdist_dir(const char* local_dir) {

[GitHub] storm pull request #1724: STORM-2131: Add blob command to worker-launcher, m...

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1724#discussion_r82634841 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java --- @@ -104,6 +104,16 @@ public static void

Re: Are storm metrics reported through JMX too?

First of all the server exposes essentially the same interface that the IMetricsConsumer exposes.  It mostly just adds a bunch of overhead in the middle to serialize out the objects send them over http to another process which then has to deserialize them and process them.  If you really don't

Re: [DISCUSS] Plan for merge SQE and Storm SQL

One more, Flink seems to made lots of progress on SQL (still in experimenting), but they set more limited features to streaming SQL. https://ci.apache.org/projects/flink/flink-docs-master/dev/table_api.html#limitations-1 SELECT, FROM, WHERE, and UNION clauses are all that Flink supports for

[GitHub] storm issue #1729: [STORM-2144] Fix Storm-sql group-by behavior in standalon...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1729 I guess Calcite itself can provide interpreter for handling query. If then standalone users can just move to Calcite interpreter, and standalone mode could be removed. I'm planning to find it

[GitHub] storm issue #1729: [STORM-2144] Fix Storm-sql group-by behavior in standalon...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1729 I guess `Interpreter` seems to be candidate for replacement of standalone more on storm-sql.

Re: Are storm metrics reported through JMX too?

+1 We can probably start by opening a JIRA for this and adding a design approach for the same? I would like to help in the coding-effort for this. -SG On Mon, Oct 10, 2016 at 1:51 PM, P. Taylor Goetz wrote: > I’ve been thinking about metrics lately, specifically the fact

[GitHub] storm issue #1729: [STORM-2144] Fix Storm-sql group-by behavior in standalon...

Github user satishd commented on the issue: https://github.com/apache/storm/pull/1729 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1729: [STORM-2144] Fix Storm-sql group-by behavior in st...

GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/1729 [STORM-2144] Fix Storm-sql group-by behavior in standalone mode Fix group-by to not rely on monotonic group-by keys You can merge this pull request into a Git repository by running: $

Re: Are storm metrics reported through JMX too?

First of all there really are two different sets of metrics.  One set is the topology metrics and the other set is the daemon metrics (metrics for things like the ui and nimbus).  The JmxPreparableReporter plugin only exposes daemon metrics not the topology metrics through JMX.  Exposing

Re: tuning output rate of spout in apache storm without using CPU sleep command

The spout in the ThroughputVsLatency example does not block and does not sleep in the spout. https://github.com/apache/storm/blob/master/examples/storm-starter/src/jvm/org/apache/storm/starter/ThroughputVsLatency.java#L156-L168 But the system is still sleeping behind the scenes.  Every time

[GitHub] storm issue #1729: [STORM-2144] Fix Storm-sql group-by behavior in standalon...

Github user satishd commented on the issue: https://github.com/apache/storm/pull/1729 +1 for replacing code generation with an abstract API as it is hard to maintain. But that can be a different task and it is not related to this PR. --- If your project is set up for it, you can