Github user milantracy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2803#discussion_r210499451
--- Diff:
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/EsLookupBolt.java
---
@@ -76,12 +78,12 @@ public void
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2803
@milantracy Thanks for the contribution! Could you please reduce the number
of max violation count so that we can see how many spots your patch address,
and also we never break it again?
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r210684974
--- Diff: pom.xml ---
@@ -280,7 +280,7 @@
1.6.6
2.8.2
1.7.21
-3.1.0
+3.2.6
--- End diff --
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r210680050
--- Diff: pom.xml ---
@@ -280,7 +280,7 @@
1.6.6
2.8.2
1.7.21
-3.1.0
+3.2.6
--- End diff --
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r210681943
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -622,6 +620,12 @@ protected String javaCmd(String cmd) {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r210685351
--- Diff: pom.xml ---
@@ -280,7 +280,7 @@
1.6.6
2.8.2
1.7.21
-3.1.0
+3.2.6
--- End diff --
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2800#discussion_r210633216
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1565,23 +1565,26 @@ public static ComponentPageInfo aggCompExecsStats(
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2800#discussion_r210632176
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1525,27 +1528,24 @@ public static ComponentPageInfo aggCompExecsStats(
*
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
Fixed the nimbus_test https://github.com/zd-project/storm/pull/1
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r210683327
--- Diff: pom.xml ---
@@ -278,7 +278,7 @@
4.1.25.Final
1.0.2
1.6.6
-2.8.2
+2.11.0
--- End
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r210682266
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -705,6 +705,13 @@
*/
@isString(acceptedValues = { "S0", "S1", "S2", "S3"
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r210690260
--- Diff: pom.xml ---
@@ -280,7 +280,7 @@
1.6.6
2.8.2
1.7.21
-3.1.0
+3.2.6
--- End diff --
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2805
STORM-3197: Make StormMetricsRegistry non-static
https://issues.apache.org/jira/browse/STORM-3197
This also fixes https://issues.apache.org/jira/browse/STORM-3101 and
GitHub user jacobtolar opened a pull request:
https://github.com/apache/storm/pull/2806
[STORM-3198] Topology submitters should be able to supply log4j2 conf
This adds a new config setting, `topology.logging.config`, that allows a
topology submitter to specify an additional log4j2
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2802
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2792
The changes look good to me. Please raise an issue at
https://issues.apache.org/jira and rename this PR and the commit message to
contain the issue number.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r210688568
--- Diff: pom.xml ---
@@ -280,7 +280,7 @@
1.6.6
2.8.2
1.7.21
-3.1.0
+3.2.6
--- End diff --
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2800#discussion_r210639246
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1660,26 +1658,18 @@ private TopologyDetails readTopologyDetails(String
Github user jacobtolar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r210671831
--- Diff: pom.xml ---
@@ -278,7 +278,7 @@
4.1.25.Final
1.0.2
1.6.6
-2.8.2
+2.11.0
---
Github user milantracy commented on the issue:
https://github.com/apache/storm/pull/2803
Hi @HeartSaVioR , reduced the value to 0.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2807
STORM-3199: Remove metrics-ganglia due to LGPL dependency
https://issues.apache.org/jira/browse/STORM-3199
You can merge this pull request into a Git repository by running:
$ git pull
Github user jacobtolar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r210769170
--- Diff: pom.xml ---
@@ -278,7 +278,7 @@
4.1.25.Final
1.0.2
1.6.6
-2.8.2
+2.11.0
---
Github user jacobtolar commented on the issue:
https://github.com/apache/storm/pull/2806
Looks like there are a couple unit tests I need to fix. Probably won't get
to that till next week.
---
+1
On Wed, Aug 8, 2018 at 1:16 AM Hugo Louro wrote:
> +1
>
> On Tue, Aug 7, 2018 at 9:02 AM Alexandre Vermeerbergen <
> avermeerber...@gmail.com> wrote:
>
> > +1 for a Storm release 1.2.3 first (non binding)
> >
> > Alexandre Vermeerbergen
> > Le mar. 7 août 2018 à 17:47, Stig Rohde Døssing
> >
Github user jacobtolar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r210768599
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -622,6 +620,12 @@ protected String javaCmd(String
25 matches
Mail list logo
