Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r208577649
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/PreparableCallback.java
---
@@ -0,0 +1,32 @@
+/**
+ * Licensed to the
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207771586
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/PreparableCallback.java
---
@@ -0,0 +1,32 @@
+/**
+ * Licensed to
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2790
---
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207761956
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -17,73 +17,140 @@
*/
package
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207711135
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -17,73 +17,140 @@
*/
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207709023
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -17,73 +17,140 @@
*/
package
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207708527
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -17,73 +17,140 @@
*/
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207706595
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -17,73 +17,140 @@
*/
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207671937
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -62,6 +62,7 @@
private OutputCollector
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207649108
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -62,6 +62,7 @@
private OutputCollector
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207560866
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -129,6 +140,27 @@ public void prepare(Map topoConf,
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207537361
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -62,6 +62,7 @@
private OutputCollector
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207534991
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -129,6 +140,27 @@ public void prepare(Map topoConf,
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207526335
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -37,38 +39,48 @@
import
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207524658
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -37,38 +39,48 @@
import
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207524275
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -37,38 +39,48 @@
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207511238
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -62,6 +62,7 @@
private OutputCollector
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207515186
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -37,38 +39,48 @@
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207512766
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -62,6 +62,7 @@
private OutputCollector
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207514281
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -37,38 +39,48 @@
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207511912
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -129,6 +140,27 @@ public void prepare(Map topoConf,
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207428218
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -129,6 +140,27 @@ public void prepare(Map topoConf,
GitHub user dfdemar opened a pull request:
https://github.com/apache/storm/pull/2790
STORM-3175 - Allow usage of custom Callback.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dfdemar/storm custom-kafkabolt-callback
23 matches
Mail list logo
