Re: [apache/struts] WW-4920 fix java.net.JarURLConnection#parseSpecs (#209)

2018-02-20 Thread Yasser Zamani
On 2/20/2018 1:37 PM, Lukasz Lenart wrote: > 2018-02-20 10:21 GMT+01:00 Yasser Zamani : >>> This is not needed as the reload check was moved into >>> FileManager#fileNeedsReloading methods - see usage of those methods. >> >> Yes I saw. However,

Re: [apache/struts] WW-4920 fix java.net.JarURLConnection#parseSpecs (#209)

2018-02-20 Thread Yasser Zamani
On 2/20/2018 10:13 AM, Lukasz Lenart wrote: > I moved discussion here to avoid notify other Apache committers. I think > you should close the PR and open a new one :) Yes I closed and also locked that :) I'm sorry and embarrassed if I harmed Struts :( As a user, I wished GitHub at least show a

Re: [apache/struts] WW-4920 fix java.net.JarURLConnection#parseSpecs (#209)

2018-02-20 Thread Lukasz Lenart
2018-02-20 10:21 GMT+01:00 Yasser Zamani : >> This is not needed as the reload check was moved into >> FileManager#fileNeedsReloading methods - see usage of those methods. > > Yes I saw. However, FileManager#fileNeedsReloading method depends on if > `revision = files.get`

Re: [apache/struts] WW-4920 fix java.net.JarURLConnection#parseSpecs (#209)

2018-02-20 Thread Lukasz Lenart
2018-02-20 12:32 GMT+01:00 Yasser Zamani : > Thanks Łukasz! you were right. Then to sum up, Struts monitors all > loaded files regardless of devMode or "struts.configuration.xml.reload" > values (i.e. user may get a warning exception if framework was not able > to create a

Save the date: ApacheCon North America, September 24-27 in Montréal

2018-02-20 Thread Rich Bowen
Dear Apache Enthusiast, (You’re receiving this message because you’re subscribed to a user@ or dev@ list of one or more Apache Software Foundation projects.) We’re pleased to announce the upcoming ApacheCon [1] in Montréal, September 24-27. This event is all about you — the Apache project