java code formatter style.xml for eclipse

2014-01-31 Thread Greg Huber
Hello, Is there a standard style.xml for the java code formatter in Eclipse, that I can import? Cheers Greg

Re: java code formatter style.xml for eclipse

2014-01-31 Thread Greg Huber
ok, I will keep this in mind. Some differences seem to be in the line length, what does intellij use? Cheers Greg On 31 January 2014 11:30, Lukasz Lenart wrote: > I don't think so... as a member of ASF you can order free license of > IntelliJ IDEA > > 2014-01-31 Greg

Re: java code formatter style.xml for eclipse

2014-01-31 Thread Greg Huber
well 120 does not seem to match. Seems to be some difficulty getting these two to work together :-< On 31 January 2014 12:59, Dave Newton wrote: > Likewise. IMO 80 doesn't really work for Java. > On Jan 31, 2014 7:29 AM, "Lukasz Lenart" wrote: > > > 20

Re: [struts-dev] Re: java code formatter style.xml for eclipse

2014-01-31 Thread Greg Huber
On 31 January 2014 14:36, Jason Pyeron wrote: > > -Original Message- > > From: Greg Huber > > Sent: Friday, January 31, 2014 9:09 > > > > well 120 does not seem to match. Seems to be some > > difficulty getting these two to work together :-< &g

Re: git commit: Make we sure we handle doubles/longs correctly, for class cast exception.

2014-02-03 Thread Greg Huber
Sorry, yes. 120 == 80 in eclipse. The only change was the (String) itt.next(); >> itt.next().toString(); as per mods to the param tag suppressEmptyParameters. Cheers Greg On 3 February 2014 10:15, Lukasz Lenart wrote: > 2014-02-03 : > > + Object itemKey = findV

Re: git commit: Make we sure we handle doubles/longs correctly, for class cast exception.

2014-02-03 Thread Greg Huber
/struts2-javatemplates-plugin/ so I can re-test it? Cheers Greg On 3 February 2014 10:46, Lukasz Lenart wrote: > 2014-02-03 Greg Huber : > > Sorry, yes. 120 == 80 in eclipse. > > No need to sorry :-) > > > The only change was the (String) itt.next(); >> itt.next().

Re: git commit: Make we sure we handle doubles/longs correctly, for class cast exception.

2014-02-03 Thread Greg Huber
014-02-03 Greg Huber : > > I think 80 is the default, and after many years I now find myself needing > > to use a 16 font, so 120 would be too much horizontal scrolling. > > Forget about default, it was defined in early 60' or 70' ;-) The > question is: is it

Re: git commit: Make we sure we handle doubles/longs correctly, for class cast exception.

2014-02-05 Thread Greg Huber
To remember to check-in first before changing the code may be problematic, ie forget to do it. It is really only the diff where it matters, cannot it be configured to ignore white space changes? git diff --ignore-space-change ??? On 5 February 2014 09:01, Lukasz Lenart wrote: > Tadam

Re: git commit: Make we sure we handle doubles/longs correctly, for class cast exception.

2014-02-05 Thread Greg Huber
On 5 February 2014 10:12, Lukasz Lenart wrote: > 2014-02-05 Greg Huber : > > To remember to check-in first before changing the code may be > > problematic, ie forget to do it. It is really only the diff where it > > matters, cannot it be configured to ignore white space

Re: git commit: Make we sure we handle doubles/longs correctly, for class cast exception.

2014-02-05 Thread Greg Huber
.. always fisticuffs, kind of like drinking someone's beer ;) On 5 February 2014 10:12, Lukasz Lenart wrote: > 2014-02-05 Greg Huber : > > To remember to check-in first before changing the code may be > > problematic, ie forget to do it. It is really only the diff

Re: HTTP PUT request with message body

2014-02-11 Thread Greg Huber
Have you an example of code that you are using? Cheers Greg On 11 February 2014 07:11, Dong Qiu wrote: > Hi, > > When I do a HTTP PUT request with message body. eg. x=12. It does not seem > to be put into the requestParamters. (e.g cannot find the x=12 entry in > request.getParameterMap ) > >

Re: DevMode override

2014-02-16 Thread Greg Huber
The way I do mine is via web.xml: ui.struts2.util.config.EnvironmentListener public class EnvironmentListener implements ServletContextListener { private static Log log = LogFactory.getLog(EnvironmentListener.class); /** * @see javax.servlet.ServletContextListener#conte

WW-2537 Fix generics in all codebase

2014-02-28 Thread Greg Huber
Is this an ongoing job that I can look at? Cheers Greg.

Re: [VOTE][FASTTRACK] Struts 2.3.16.1

2014-03-03 Thread Greg Huber
How would I get my access to https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.16.1] changed? Cheers Greg On 3 March 2014 08:19, Lukasz Lenart wrote: > The Struts 2.3.16.1 test build is now available. It includes the > latest security patch which fixes two possible vulnerabilit

LocalizedTextUtil mods

2014-03-06 Thread Greg Huber
Seeing this mod the other day has reminded me that I do a local change on LocalizedTextUtil to speed up the screens. What I do is to add a check to see if the property comes from the getDefaultMessage(..) method (ie from ApplicationResources.properties) and if it does skip all the checking that it

Re: LocalizedTextUtil mods

2014-03-06 Thread Greg Huber
"regular" localization. > > Dave > > > > On Thu, Mar 6, 2014 at 7:38 AM, Greg Huber wrote: > > > Seeing this mod the other day has reminded me that I do a local change on > > LocalizedTextUtil to speed up the screens. > > > > What I do

Re: LocalizedTextUtil mods

2014-03-06 Thread Greg Huber
Following this http://struts.apache.org/git-for-struts.html url https://github.com/apachestruts/struts don't look correct? 404 >> apache/struts <https://github.com/apachestruts/struts> On 6 March 2014 13:34, Lukasz Lenart wrote: > 2014-03-06 13:38 GMT+01:00 Greg Huber :

Re: [GitHub] struts pull request: loadedFileUrls only contains the last one of ...

2014-03-20 Thread Greg Huber
...thought there should only be one url in urls.hasNext() for each file, maybe there are multiple struts-biz.xml file/jars? On 20 March 2014 12:14, code4craft wrote: > Github user code4craft commented on the pull request: > > https://github.com/apache/struts/pull/6#issuecomment-38159811 > >

Re: [GitHub] struts pull request: loadedFileUrls only contains the last one of ...

2014-03-20 Thread Greg Huber
It does fix the reloading issue, but now it reloads a whole lot more files. I can see it checks the files per configuration, but it seems to check them twice? Whether it actually reloads them twice I will investigate. If you log needsReload() {..} you can see, for me its gone from 4 to 11 files!

Re: Time to start new release

2014-03-31 Thread Greg Huber
when will it be available at apache.nexus ASF Nexus Staging https://repository.apache.org/content/groups/staging/ On 30 March 2014 19:52, Lukasz Lenart wrote: > Version Notes > https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.17 > > Please take a look if eve

Re: [VOTE][FASTTRACK] Struts 2.3.16.2

2014-04-25 Thread Greg Huber
Where the class ExcludedPattern now exists, do we still need to do: (.*\.|^|.*|\[('|"))(c|C)lass(\.|('|")]|\[).*,^dojo\..*,^struts\..*,^session\..*,^request\..*,^application\..*,^servlet(Request|Response)\..*,^parameters\..*,^action:.*,^method:.* or just ^action:.*,^method:.* On 24 Ap

Re: [VOTE][FASTTRACK] Struts 2.3.16.2

2014-04-25 Thread Greg Huber
does test against (.*\\.|^|.*|\\[('|\"))class(\\.|('|\")]|\\[).* Thought it would have logged it? On 25 April 2014 11:09, Lukasz Lenart wrote: > The second is enough > > 2014-04-25 12:08 GMT+02:00 Greg Huber : > > Where the class Exclu

Re: [VOTE][FASTTRACK] Struts 2.3.16.3

2014-05-03 Thread Greg Huber
If I add to a link as a parameter and then click the link I do not get a notifyDeveloper from ParametersInterceptor if (!this.excludeParams.isEmpty()) { for (Pattern pattern : excludeParams) { System.out.println(pattern); Matcher matcher = pattern.mat

Re: [VOTE][FASTTRACK] Struts 2.3.16.3

2014-05-04 Thread Greg Huber
22 http://www.lenart.org.pl/ > > 2014-05-03 12:22 GMT+02:00 Greg Huber : > > If I add > > > > > > > > to a link as a parameter and then click the link I do not get a > > notifyDeveloper from ParametersInterceptor > > > > if (!thi

Re: Submitting patches

2014-05-21 Thread Greg Huber
Last time I tried to install git flow on centos 6 it was not compatible with some packages or other, and was not able to do it. Maybe because I installed git from the git website rather than the older yum version. What distro do you use? Also, is there an easier work around for no git flow? On

Re: dynamic interceptor insertion

2014-07-03 Thread Greg Huber
What would be useful, if you could have a place holder in the interceptor stack and then inject the interceptor element you need on the action? Copying the whole lot each time makes a lot more maintenance and more prone to errors. On 3 July 2014 02:32, Paul Benedict wrote: > Most of the time,

Re: Struts 2.3.18 ready for test

2014-09-21 Thread Greg Huber
..The reason for message: The following artifacts could not be resolved: org.apache.struts:struts2-core:jar:2.3.18... ? at https://repository.apache.org/content/groups/staging/ Cheers Greg On 22 September 2014 07:42, Lukasz Lenart wrote: > 2014-09-21 15:36 GMT+02:00 Lukasz Lenart : > > Hi,

Re: Struts 2.3.18 ready for test

2014-09-22 Thread Greg Huber
27;s an alias of cssClass attribute. Cheers Greg On 22 September 2014 22:01, Lukasz Lenart wrote: > Finally I was able redeploy new artifacts - you can test them again :-) > > 2014-09-22 8:58 GMT+02:00 Lukasz Lenart : > > 2014-09-22 8:55 GMT+02:00 Greg Huber : > >> .

Re: Struts 2.3.18 ready for test

2014-09-24 Thread Greg Huber
The url I have is: https://repository.apache.org/content/groups/snapshots-group/ ie http://repository.apache.org/content/groups/snapshots-group/org/apache/struts/struts2-core/2.3.18-SNAPSHOT/ etc.. If this is correct, it works, no exception and checked it uses the class. Cheers Greg On 24 Sep

Re: Struts 2.3.18 ready for test

2014-09-28 Thread Greg Huber
May need to add: always as changes may not be picked up. On 28 September 2014 17:55, Lukasz Lenart wrote: > 2014-09-28 3:18 GMT+02:00 Martin Gainty : > >> Staging Maven repo > >> https://repository.apache.org/content/groups/staging/ > > > > https://repository.apache.org/content/groups/stag

Re: Struts 2.3.18 ready for test

2014-09-28 Thread Greg Huber
Retesting this, it seems that the validator messages have stopped working. Have there been any changes wrt to this from the previous snapshot, which I think were working OK. Cheers Greg. On 27 September 2014 10:01, Lukasz Lenart wrote: > Hi, > > I have deployed new artefacts to staging repo,

Re: Struts 2.3.18 ready for test

2014-09-29 Thread Greg Huber
29 September 2014 08:00, Lukasz Lenart wrote: > 2014-09-29 8:55 GMT+02:00 Greg Huber : > > Retesting this, it seems that the validator messages have stopped > working. > > Have there been any changes wrt to this from the previous snapshot, > which I > > think were working OK.

Re: Struts 2.3.18 ready for test

2014-09-29 Thread Greg Huber
sorry did a manual project "clean" and now works ok, something new with luna especially when changing jars around. Cheers greg On 29 September 2014 08:00, Lukasz Lenart wrote: > 2014-09-29 8:55 GMT+02:00 Greg Huber : > > Retesting this, it seems that the validator me

Re: Struts 2.3.18 ready for test

2014-10-12 Thread Greg Huber
Went through this release and tested it, seems good to be released. Are there other issues? Cheers Greg On 3 October 2014 07:49, Lukasz Lenart wrote: > 2014-09-30 9:09 GMT+02:00 Lukasz Lenart : > > Added a note to docs (I thought there was one already) - in your case > > the problem is with

Re: [VOTE] Struts 2.3.18

2014-10-27 Thread Greg Huber
+1 On 27 October 2014 07:33, Lukasz Lenart wrote: > The Apache Struts 2.3.18 test build is now available. With this release: > - merged security fixes from version 2.3.16.1, 2.3.16.2, 2.3.16.3 > - extended existing security mechanism to block access to given Java > packages and Classes, see #11

Re: Struts 2.3.20 ready for test

2014-11-27 Thread Greg Huber
+1 nb On 21 November 2014 at 20:48, Lukasz Lenart wrote: > Hi, > > Please take a time and test the bits - any help is appreciated. Please > report back any problems. I'll call for vote in a week if no problems > will be spotted. > > Staging Maven repo > https://repository.apache.org/content/grou

Re: Struts 2.3.21 ready for test

2015-01-07 Thread Greg Huber
Looks good. +1 nb. Cheers Greg. On 7 January 2015 at 14:01, Lukasz Lenart wrote: > 2014-12-31 18:13 GMT+01:00 Lukasz Lenart : > > Hi, > > > > Please take a time and test the bits - any help is appreciated. Please > > report back any problems. I'll call for vote in a week if no problems > > wil

Re: Struts 2.3.22 ready for test

2015-03-20 Thread Greg Huber
Thanks for your good work, looks great and no issues +1 nb. Cheers Greg. On 19 March 2015 at 08:22, Lukasz Lenart wrote: > Hi, > > Please take a time and test the bits - any help is appreciated. Please > report back any problems. I'll call for vote in a week if no problems > will be spotted. >

Re: Struts 2.3.22 ready for test

2015-04-03 Thread Greg Huber
>> > >> Johannes > >> > >> # > >> web: http://www.jgeppert.com > >> twitter: http://twitter.com/jogep > >> > >> > >> 2015-03-20 15:10 GMT+01:00 Greg Huber : > &

Re: Struts 2.3.24 ready for test

2015-05-04 Thread Greg Huber
looks good :) On 4 May 2015 at 12:27, Lukasz Lenart wrote: > One small change, I would like to start vote sooner, tomorrow afternoon or > so > > 2015-05-03 14:00 GMT+02:00 Lukasz Lenart : > > Hi, > > > > Please take a time and test the bits - any help is appreciated. Please > > report any proble

Re: Starting work on 2.5

2015-05-26 Thread Greg Huber
Been using struts with jdk1.7.0_xx for ages and no issues. ... After April 2015, Oracle will no longer post updates of Java SE 7 to its public download sites. Cheers Greg On 25 May 2015 at 10:23, Lukasz Lenart wrote: > 2015-05-15 15:08 GMT+02:00 Lukasz Lenart : > > Finally struts-archive was m

Re: Realease a first beta of version 2.5

2015-07-17 Thread Greg Huber
Are there any maven staging builds for 2.5 ? Cheers Greg. On 16 July 2015 at 21:50, Johannes Geppert wrote: > +1 :-) > > # > web: http://www.jgeppert.com > twitter: http://twitter.com/jogep > > > 2015-07-13 13:49 GMT+02:00 Lukasz Lenart : > > > Ok

Re: Realease a first beta of version 2.5

2015-07-17 Thread Greg Huber
; So I guess not yet? Cheers Greg On 17 July 2015 at 08:27, Lukasz Lenart wrote: > 2015-07-17 9:17 GMT+02:00 Greg Huber : > > Are there any maven staging builds for 2.5 ? > > On each build Jenkins publishes snapshot version here > > >

Re: Realease a first beta of version 2.5

2015-07-17 Thread Greg Huber
Ok, #2 should have checked. .do I have to specify a build date to get the latest? 2.5-SNAPSHOT struts2-core-2.5-20150717.074551-37 Cheers Greg. On 17 July 2015 at 08:50, Lukasz Lenart wrote: > > if I look at > > > > > https://repository.apache.org/content/groups/snapshots/org/apache/stru

Re: Realease a first beta of version 2.5

2015-07-17 Thread Greg Huber
esult location: package org.apache.struts2.dispatcher cannot find symbol symbol: class ValidationAware location: package com.opensymphony.xwork2 Cheers Greg On 17 July 2015 at 09:22, Lukasz Lenart wrote: > 2015-07-17 10:19 GMT+02:00 Greg Huber : > > Ok, #2 should have checked. >

Re: Realease a first beta of version 2.5

2015-07-17 Thread Greg Huber
class ValidationAware location: package com.opensymphony.xwork2 Cheers Greg On 17 July 2015 at 09:40, Lukasz Lenart wrote: > 2015-07-17 10:36 GMT+02:00 Greg Huber : > > ah, working now but was getting > > > > [WARNING] The POM for org.apache.struts:struts2-core:jar:2.5-S

Re: Struts 2.5-BETA1

2015-07-27 Thread Greg Huber
+1, good job! Cheers Greg. On 27 July 2015 at 07:05, Lukasz Lenart wrote: > 2015-07-24 21:49 GMT+02:00 Johannes Geppert : > > Is there a reason why we don't publish the javadocs? > > I just refactored the javadocs a bit and some of them contains may > usefully > > information's for developers.

Re: [VOTE] Struts 2.5 BETA1

2015-07-30 Thread Greg Huber
I am seeing this on my console output for tomcat: ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console... Any ideas? There is no log4j-core, would I need to add this manually to my pom? /WEB-INF/lib/l

Re: [VOTE] Struts 2.5 BETA1

2015-07-30 Thread Greg Huber
sing these jars: > > > > - slf4j-api > > - slf4j-log4j12 > > - log4j > > - log4j-to-slf4j > > > > > > That means struts log messages are forwarded like this: > > struts -> log4j2 -> slf4j -> log4j1 > > > > > > Might not make m

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-01 Thread Greg Huber
Would these be regex style method names? On 1 September 2015 at 07:10, lukaszlenart wrote: > GitHub user lukaszlenart opened a pull request: > > https://github.com/apache/struts/pull/47 > > WW-4540: Strict DMI > > This PR enables `Strict DMI` be default (or rather it's always > enabl

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-01 Thread Greg Huber
method like method="do{2}" it's supported. If > you need anything else please give me an example. > > [1] https://struts.apache.org/docs/wildcard-mappings.html > > 2015-09-01 12:23 GMT+02:00 Greg Huber : > > Would these be regex style method names? > >

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Greg Huber
String query() {..} public String cancel() {..} public String cancelClosed() {..} public String cancelCurrent() {..} public String cancelOpen() {..} public String cancelOpenAuction() {..} On 2 September 2015 at 08:09, Lukasz Lenart wrote: > 2015-09-01 12:41 GMT+02:00 Greg Huber : > >

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Greg Huber
Maybe public methods and by package name? mypackage.com regex:(([A-Z]?)([a-z]+)?) On 2 September 2015 at 08:09, Lukasz Lenart wrote: > 2015-09-01 12:41 GMT+02:00 Greg Huber : > > The same way interceptors are configured, something like: > > > > publish* > >

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-03 Thread Greg Huber
per would this be on the action element in the struts.xml? Have you an example of the config? On 2 September 2015 at 10:54, Lukasz Lenart wrote: > 2015-09-02 10:18 GMT+02:00 Christoph Nenning < > christoph.nenn...@lex-com.net>: > > In my apps I would not need to use any patterns. Just a list

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-03 Thread Greg Huber
Probably the config to go with are there any docs on the for the ? Cheers Greg On 3 September 2015 at 08:21, Lukasz Lenart wrote: > 2015-09-03 9:13 GMT+02:00 Greg Huber : > > per would this be on the action element in > the > > struts.xml? > > > > Hav

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-15 Thread Greg Huber
Restricting to public methods on the action class/package would be more useful, may be less of an overhead? It would be inherited methods that could potentially cause the issues. On 15 September 2015 at 08:11, Lukasz Lenart wrote: > I have extended the list of default 'global-allowed-methods' b

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-16 Thread Greg Huber
Hm, getAString(), would it return anything? I will do a check to see what happens. On 16 September 2015 at 07:56, Lukasz Lenart wrote: > 2015-09-16 8:51 GMT+02:00 Greg Huber : > > Restricting to public methods on the action class/package would be more > > useful, may be less

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-17 Thread Greg Huber
"true" ... "false" ... "null" ... "#this" ... "#root" ... "#" ... "[" ... "{" ... "@" ... "new" ... ... ... "\'" ... "`" ... "\"" ... ... ... 2. Malformed OGNL expression: getBean(

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-17 Thread Greg Huber
; } } I though this was what we were trying to stop? On 17 September 2015 at 08:27, Lukasz Lenart wrote: > 2015-09-17 9:11 GMT+02:00 Greg Huber : > > For my form bean, getBean().getName(); > > > > > > edit!getBean().getName > > > > > > For me it show

Re: [VOTE][FASTRACK] Struts 2.3.24.1

2015-09-23 Thread Greg Huber
+1 nb On 22 September 2015 at 19:38, Lukasz Lenart wrote: > The Struts 2.3.24.1 test build is now available. It includes the > latest security patch which fixes one possible vulnerabilities: > - Special top object can be used to access Struts' internals > > For details and the rationale behind t

Re: [VOTE] Struts 2.5 BETA2

2015-09-28 Thread Greg Huber
Just upgrading the jars, I now get ERROR Dispatcher Could not find action or result: /events/license.action This method: execute for action license is not allowed! - [unknown location] I have not added any DMI security settings, is this correct? Cheers Greg On 29 September 2015 at 07:38, Johan

Re: [VOTE] Struts 2.5 BETA2

2015-09-29 Thread Greg Huber
tion-ref?,default-class-ref?,global-results?,global-allowed-methods?,global-exception-mappings?,action*)". Not sure where it goes? I need to allow all methods until I have time to go through and add each one to my actions. Cheers Greg On 29 September 2015 at 08:14, Lukasz Lenart wrote:

Re: [VOTE] Struts 2.5 BETA2

2015-09-29 Thread Greg Huber
Yes, http://struts.apache.org/dtds/struts-2.5.dtd";> On 29 September 2015 at 09:12, Lukasz Lenart wrote: > 2015-09-29 9:47 GMT+02:00 Greg Huber : > > sorry, following https://github.com/apache/struts/pull/47 > > > > if I add to my extended package : > > &g

Re: [VOTE] Struts 2.5 BETA2

2015-09-29 Thread Greg Huber
2015 at 09:24, Lukasz Lenart wrote: > 2015-09-29 9:47 GMT+02:00 Greg Huber : > > sorry, following https://github.com/apache/struts/pull/47 > > > > if I add to my extended package : > > > > > > > > > > > execute,input,back,cancel,browse &g

Re: [VOTE] Struts 2.5 BETA2

2015-09-30 Thread Greg Huber
s the case at least the execute should work? On 30 September 2015 at 09:20, Lukasz Lenart wrote: > 2015-09-30 8:34 GMT+02:00 Greg Huber : > > I reverted back to beta1 struts.xml changed the dtd to 2.5, are there any > > other changes needed as I am still getting > > Not sue

Re: [VOTE] Struts 2.5 BETA2

2015-09-30 Thread Greg Huber
Here is my abbreviated structure: .. .. .Favourites .Favourites .. On 30 September 2015 at 09:36, Lukasz Lenart wrote: > 2015-09-30 10:30 GMT+02:00 Greg Huber : > > I went back to beta1 where DMI works, I then changed to beta2 and now the > > execute method i

Re: [VOTE] Struts 2.5 BETA2

2015-09-30 Thread Greg Huber
Also the execute in my default "events" package do not work (same mesage) .. Cheers Greg. On 30 September 2015 at 09:46, Lukasz Lenart wrote: > 2015-09-30 10:43 GMT+02:00 Greg Huber : > > Here is my abbreviated structure: > > > > > > .

Re: Struts 2.5 BETA3

2016-01-05 Thread Greg Huber
Beta 2 did not work for me due to the dmi changes, was this ever resolved? Cheers Greg. from a previous email: On 30 September 2015 at 09:46, Lukasz Lenart wrote: 2015-09-30 10:43 GMT+02:00 Greg Huber : > Here is my abbreviated structure: > > > .. > >

Re: [VOTE] Struts 2.5 BETA3

2016-01-21 Thread Greg Huber
I cannot seem to get the dmi to work, I get action not allowed: *This method: save for action eventAdd is not allowed! - [unknown location]* I then get this error when I add global-allowed-methods : .. execute,input,cancel([A-Z]*),([A-Z]*) which was what I had before, last time I tested b

Re: [VOTE] Struts 2.5 BETA3

2016-01-21 Thread Greg Huber
On 21 January 2016 at 15:32, Greg Huber wrote: > I cannot seem to get the dmi to work, I get action not allowed: > > *This method: save for action eventAdd is not allowed! - [unknown > location]* > > I then get this error when I add global-allowed-methods : > > > .

Fwd: [VOTE] Struts 2.5 BETA3

2016-01-22 Thread Greg Huber
()), but I guess it should come from the ActionConfig stored in the packageContext or where the orig gets its allowedMethods from. Apart from this is works great! Cheers Greg -- Forwarded message -- From: Greg Huber Date: 21 January 2016 at 16:45 Subject: Re: [VOTE] Struts 2.5 BETA3 To

Re: [VOTE] Struts 2.5 BETA3

2016-01-25 Thread Greg Huber
11:04, Lukasz Lenart wrote: > 2016-01-22 18:26 GMT+01:00 Greg Huber : > > Best I can come up with is > > com.opensymphony.xwork2.config.implActionConfigMatcher creates a new > > ActionConfig but then only uses the default allowed names: > > > > return

Upgrade to tiles 3 jcl-over-slf4j

2016-01-28 Thread Greg Huber
Should jcl-over-slf4j be in the tiles-core pom? It seems to be an option for migrating from Jakarta Commons Logging which some might not want to do. org.slf4j jcl-over-slf4j ​http://www.slf4j.org/legacy.html​ ​To ease migration to SLF4J from JCL​ ​#​ ​I use ​Jakarta Commons

Re: Upgrade to tiles 3 jcl-over-slf4j

2016-01-29 Thread Greg Huber
Well, I currently log with commons, but to get struts logging working I have had to upgrade to v2 and use the log4j2.xml file. Also a good idea to bypass the commons for slf4j and go directly. Cheers Greg On 29 January 2016 at 15:07, Christoph Nenning < christoph.nenn...@lex-com.net> wrote: >

Re: Upgrade to tiles 3 jcl-over-slf4j

2016-01-29 Thread Greg Huber
Yes, if you are logging directly to log4j2 but if other jars use slf4j you need to delegate the logging (create a log4j2.xml if upgrading from v1, note the format is also different!) org.slf4j slf4j-api 1.7.14 org.apache.logging.log4j

Re: Upgrade to tiles 3 jcl-over-slf4j

2016-01-29 Thread Greg Huber
I plan to, but not really motivated at the moment as its quite a job converting all my poorly formatted logging to use the new format. Cheers Greg btw does any body know how to get velocity to log correctly to log4j 2? On 29 January 2016 at 17:12, Paul Benedict wrote: > Why not log4j2? > > Ch

Re: Upgrade to tiles 3 jcl-over-slf4j

2016-01-29 Thread Greg Huber
Paul > > On Fri, Jan 29, 2016 at 11:14 AM, Greg Huber wrote: > > > Yes, if you are logging directly to log4j2 but if other jars use slf4j > you > > need to delegate the logging (create a log4j2.xml if upgrading from v1, > > note the format is also diffe

Re: SMI on steroids

2016-02-05 Thread Greg Huber
​my lastest comment.. The entry that we don't want is {1} style PatternAllowedMethod{allowedMethodPattern=(.*), original='\{1\}'\} which is don't check anything, effectively disabling SMI. run{1}This style could be left in, as they are pretty restrictive, or is there a regex for the pattern tha

Re: SMI on steroids

2016-02-05 Thread Greg Huber
You can use global and action allowed methods: MyMethod,etc MyMethod,etc For SMI to work on method="{1}" there is no option as it adds a (.*) so must be removed. For method="prefix{1}suffix" it adds a prefix(.*)suffix and if this is removed all methods would require a definition in either the

Re: SMI on steroids

2016-02-05 Thread Greg Huber
To pass globally: regex:prefix(.*)suffix On 5 February 2016 at 14:25, Christoph Nenning < christoph.nenn...@lex-com.net> wrote: > > Hi, > > > > There is a huge discussion about how SMI should work in case of using > > wildcard mapping [1]. Basically when action is defined as follow: > > > > > >

Re: SMI on steroids

2016-02-05 Thread Greg Huber
My understanding is it now on by default, so you will need to use and latest beta for any methods that are not standard. save input, execute, etc But, it currently does not check as if you use method="{1}" or method="prefix{1}suffix" style it bypasses the checks as it generates a (.*) and pref

beta3 testing

2016-02-08 Thread Greg Huber
I was dong some more testing and noticed that my message store interceptor messages have stopped working. There is a check in the org.apache.struts2.interceptor.MessageStoreInterceptor to see if the response has been committed, and if it is skip the messages processing. boolean isCommitted = Serv

Re: beta3 testing

2016-02-08 Thread Greg Huber
Ok thanks, I will have a look. Cheers Greg On 8 February 2016 at 12:50, Lukasz Lenart wrote: > 2016-02-08 13:44 GMT+01:00 Greg Huber : > > I was dong some more testing and noticed that my message store > interceptor > > messages have stopped working. > > >

Re: beta3 testing

2016-02-08 Thread Greg Huber
I was doing a redirect, so if you say its working I can wait until the next beta to test it. Cheers Greg On 8 February 2016 at 12:50, Lukasz Lenart wrote: > 2016-02-08 13:44 GMT+01:00 Greg Huber : > > I was dong some more testing and noticed that my message store > interceptor

Re: beta3 testing

2016-02-08 Thread Greg Huber
Ok, tested it from the snapshot and its good! Thanks. On 8 February 2016 at 12:50, Lukasz Lenart wrote: > 2016-02-08 13:44 GMT+01:00 Greg Huber : > > I was dong some more testing and noticed that my message store > interceptor > > messages have stopped working. > > >

Html 5 email fields

2016-02-09 Thread Greg Huber
On the java template plugin the TextFieldHandler defaults to attr.add("type", "text") whilst the s:textfield has the attribute, is there a default set of values already supported on the normal rendering? For mobile devices it is helpful if it knows the field type as you get different keyboard symb

Re: SMI on steroids

2016-02-11 Thread Greg Huber
) remove {1} and prefix{0}suffix so it will then fall back on the global/allowed-methods. Just a thought. Cheers Greg On 5 February 2016 at 09:23, Lukasz Lenart wrote: > 2016-02-05 10:20 GMT+01:00 Greg Huber : > > my lastest comment.. > > > > The entry that we do

Re: beta3 testing

2016-02-14 Thread Greg Huber
* STORE Any ideas? Cheers Greg On 11 February 2016 at 07:23, Lukasz Lenart wrote: > 2016-02-08 13:50 GMT+01:00 Lukasz Lenart : > > 2016-02-08 13:44 GMT+01:00 Greg Huber : > >> I was dong some more testing and noticed that my message store > interceptor >

Re: beta3 testing

2016-02-14 Thread Greg Huber
GMT+01:00 Greg Huber : > >> I was dong some more testing and noticed that my message store > interceptor > >> messages have stopped working. > >> > >> There is a check in the > >> org.apache.struts2.interceptor.MessageStoreInterceptor to see if th

Re: SMI on steroids

2016-02-15 Thread Greg Huber
A configurable default regex would be useful, so can override it in the struts.xmleg [a-zA-Z]* >> ^[A-Za-z0-9]{1,25}$ etc. Also, not too many changes needed! Cheers Greg. On 14 February 2016 at 14:23, Lukasz Lenart wrote: > 2016-02-11 12:02 GMT+01:00 Greg Huber : >

Re: beta3 testing

2016-03-04 Thread Greg Huber
-4605?focusedCommentId=15179528&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15179528 > > > Cheers > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > > 2016-02-14 12:16 GMT+01:00 Greg Huber : > > .I seem to now have to

Re: beta3 testing

2016-03-04 Thread Greg Huber
I re-tested it and it seems to need the stack now. On 4 March 2016 at 17:22, Lukasz Lenart wrote: > Ah.. looks like a regression, I thought it was something else, so I > will try to figure out what's wrong. > > 2016-03-04 18:19 GMT+01:00 Greg Huber : > > Seems to be OK no

Re: beta3 testing

2016-03-04 Thread Greg Huber
ll try to figure out what's wrong. > > 2016-03-04 18:19 GMT+01:00 Greg Huber : > > Seems to be OK now, don't think it was a problem as I have added the > > default stack, which seems what you have to do now. > > > > Cheers Greg > > > > On 4 March

Re: beta3 testing

2016-03-06 Thread Greg Huber
Ah, sorry, here it is again, .. .. .. STORE I was looking to see where this gets built, which class does the building? On 6 March 2016 at 09:48, Lukasz Lenart wrote: > 2016-03-04 20:17 GMT+01:00 Greg Huber : > > What it seems to be doing is executing th

Re: beta3 testing

2016-03-06 Thread Greg Huber
Ah, sorry, here it is again, .. .. .. STORE I was looking to see where this gets built, which class does the building? On 6 March 2016 at 09:48, Lukasz Lenart wrote: > 2016-03-04 20:17 GMT+01:00 Greg Huber : > > What it seems to be doing is exec

Re: beta3 testing

2016-03-06 Thread Greg Huber
} ${searchString} true favourites On 6 March 2016 at 10:21, Lukasz Lenart wrote: > 2016-03-06 11:06 GMT+01:00 Greg Huber : > > Ah, sorry, here it is again, > > > > > > > > > > .. > > > &

Re: beta3 testing

2016-03-06 Thread Greg Huber
,cancel* execute,cancel* It is the ActionPrepareInterceptor & DMIAwareValidationInterceptor that does not get called. On 6 March 2016 at 10:41, Lukasz Lenart wrote: > 2016-03-06 11:37 GMT+01:00 Gre

Re: beta3 testing

2016-03-06 Thread Greg Huber
1, Lukasz Lenart wrote: > 2016-03-06 11:37 GMT+01:00 Greg Huber : > > It definitely does not include/call myStack, as I can see it does not > call > > an initialise method I use. > > > > here is the action: > > > >

Re: beta3 testing

2016-03-06 Thread Greg Huber
2016-03-06 12:48 GMT+01:00 Greg Huber : > > In DefaultConfiguration.buildFullActionConfig(..) it checks for the > > interceptors that were added and if it does not find any it adds the > > getFullDefaultInterceptorRef() which in my case is myStack. > > > > I guess th

Re: beta3 testing

2016-03-06 Thread Greg Huber
. AUTOMATIC HelloWorld2 On 6 March 2016 at 12:23, Lukasz Lenart wrote: > 2016-03-06 12:48 GMT+01:00 Greg Huber : > > In DefaultConfiguration.buildFullActionConfig(..) it checks for the > > interce

  1   2   3   4   5   6   >