Re: Potential regression: high server-side memory consumption during import

2018-03-02 Thread Philip Martin
Evgeny Kotkov writes: > Perhaps, a simpler reproduction script would be to issue an 'svn log' for > a medium-sized repository. In my environment, doing so for the trunk of > TortoiseSVN's repository with 25,000 revisions causes the httpd process > to consume up to a

Re: 1.10 release notes: protocol changes, LZ4, etc.

2018-03-02 Thread Julian Foad
Evgeny Kotkov wrote: Julian Foad writes: - On the server-side, SVNCompressionLevel 0 can be used to disable compression altogether. The special value of SVNCompressionLevel 1 forces the use of LZ4 compression for clients that support it. All other values result in

Re: Potential regression: high server-side memory consumption during import

2018-03-02 Thread Philip Martin
Stefan Sperling writes: > Hmmm. Does this help? The authz_tests pass with it. > > Index: subversion/mod_authz_svn/mod_authz_svn.c > === > --- subversion/mod_authz_svn/mod_authz_svn.c (revision 1825730) > +++

Re: Potential regression: high server-side memory consumption during import (was: Subversion 1.10 RC1?)

2018-03-02 Thread Stefan Sperling
On Fri, Mar 02, 2018 at 09:02:02PM +0300, Evgeny Kotkov wrote: > Stefan Sperling writes: > > > I'd rather ship 1.10.0 at the prospected release date followed closely > > by 1.10.1 to fix bugs such as these, than delay general access to 1.10.0 > > even further. > > While I do not

Re: Potential regression: high server-side memory consumption during import

2018-03-02 Thread Stefan Sperling
On Fri, Mar 02, 2018 at 03:56:40PM +, Philip Martin wrote: > Evgeny Kotkov writes: > > > Perhaps, a simpler reproduction script would be to issue an 'svn log' for > > a medium-sized repository. In my environment, doing so for the trunk of > > TortoiseSVN's

Re: Potential regression: high server-side memory consumption during import (was: Subversion 1.10 RC1?)

2018-03-02 Thread Evgeny Kotkov
Stefan Sperling writes: > I'd rather ship 1.10.0 at the prospected release date followed closely > by 1.10.1 to fix bugs such as these, than delay general access to 1.10.0 > even further. While I do not have significant objections against such plan, I find the idea of shipping a

Re: Potential regression: high server-side memory consumption during import

2018-03-02 Thread Stefan Sperling
On Fri, Mar 02, 2018 at 06:20:48PM +, Philip Martin wrote: > Stefan Sperling writes: > > > Hmmm. Does this help? The authz_tests pass with it. > > > > Index: subversion/mod_authz_svn/mod_authz_svn.c > > === > >

Re: Wiki migration to Confluence: test conversion ready for review

2018-03-02 Thread Johan Corveleyn
On Tue, Feb 27, 2018 at 11:25 PM, Johan Corveleyn wrote: > Johan Corveleyn wrote: > After ironing out most of the big issues, I think the current "test conversion" is ready for review by a larger audience. I'd like to perform the final

Re: Potential regression: high server-side memory consumption during import (was: Subversion 1.10 RC1?)

2018-03-02 Thread Stefan Sperling
On Fri, Mar 02, 2018 at 07:21:15PM +0100, Stefan Sperling wrote: > I am just questioning the usefulness of halting the presses and restarting > the soak for another month for something that isn't a security / data > corruption issue. I anticipate that problems of similar severity to this > one

Re: Potential regression: high server-side memory consumption during import

2018-03-02 Thread Philip Martin
Philip Martin writes: > Again, 1.10 would be nearly twice as fast, but now rereading the authz > removes most of that gain. I think I see the underlying problem: the authz code now incorporates a cache based on the md5 checksum of the rules, so when the rules are

Re: Potential regression: high server-side memory consumption during import

2018-03-02 Thread Philip Martin
Stefan Sperling writes: > On Fri, Mar 02, 2018 at 06:20:48PM +, Philip Martin wrote: >> >> Yes, that solves the memory use problem. > > Nice, I'll commit it then. This might not be a final fix but at least > it's a step forward. > >> There is still a time penalty: >> >> Your

[PATCH] fsfs: Better 'parse error' error message

2018-03-02 Thread Daniel Shahaf
[[[ * subversion/libsvn_fs_fs/id.c (svn_fs_fs__id_parse): Include more information in an error message. ]]] [[[ Index: subversion/libsvn_fs_fs/id.c === --- subversion/libsvn_fs_fs/id.c(revision 1825746) +++

Re: Potential regression: high server-side memory consumption during import

2018-03-02 Thread Philip Martin
Philip Martin writes: > All of those figures are the first run after starting Apache, i.e. when > the OS cache and the Subversion cache is cold. With a hot Subversion I meant to write "the OS cache is hot and the Subversion cache is cold" > cache the values are: >

Re: Wiki migration to Confluence: test conversion ready for review

2018-03-02 Thread Thomas Åkesson
> On 2018-02-27, at 23:25, Johan Corveleyn wrote: > > Johan Corveleyn wrote: > After ironing out most of the big issues, I think the current "test conversion" is ready for review by a larger audience. I'd like to perform the final migration

Re: Potential regression: high server-side memory consumption during import (was: Subversion 1.10 RC1?)

2018-03-02 Thread Stefan Sperling
On Fri, Mar 02, 2018 at 05:15:46PM +0300, Evgeny Kotkov wrote: > Unless I am missing something, this might be worth considering before the > 1.10 GA release. Not about the actual bug, just a meta comment on the process: I'd rather ship 1.10.0 at the prospected release date followed closely by

Re: Potential regression: high server-side memory consumption during import (was: Subversion 1.10 RC1?)

2018-03-02 Thread Evgeny Kotkov
Stefan Fuhrmann writes: > Would it be possible for you to bisect this to find the offending revision? > My random guess would be that in the context of mod_dav_svn, we might use > an unsuitable pool for authz caching. While looking through the various 1.10-related topics, I

Re: APR's check for installed libtool is inconsistent

2018-03-02 Thread Julian Foad
Julian Foad wrote: > Branko Čibej wrote (to dev@subversion.a.o): >> On 26.02.2018 18:39, Julian Foad wrote: >>> (CC'ing Subversion as Subversion's build system both uses and kind-of >>> duplicates this.) >>> >>> APR's 'build/buildcheck.sh' says: >>> [[[ >>> # Require libtool 1.4 or newer >>>

Re: APR's check for installed libtool is inconsistent

2018-03-02 Thread Julian Foad
Branko Čibej wrote (to dev@subversion.a.o): > On 26.02.2018 18:39, Julian Foad wrote: >> (CC'ing Subversion as Subversion's build system both uses and kind-of >> duplicates this.) >> >> APR's 'build/buildcheck.sh' says: >> [[[ >> # Require libtool 1.4 or newer >> libtool=`build/PrintPath glibtool1

Re: Wiki migration to Confluence: test conversion ready for review

2018-03-02 Thread Johan Corveleyn
On Fri, Mar 2, 2018 at 3:56 PM, Thomas Åkesson wrote: > >> On 2018-02-27, at 23:25, Johan Corveleyn wrote: >> >> Johan Corveleyn wrote: >> > After ironing out most of the big issues, I think the current "test > conversion" is