Re: [PATCH] Make display_lines() spawn diff

2010-07-24 Thread Stefan Sperling
On Sat, Jul 24, 2010 at 06:46:11PM +0530, Ramkumar Ramachandra wrote: Hi, This patch is not intended for inclusion, but I hope it conveys the idea- I want display_lines() to display a diff instead of the full actual and expected outputs. That would be nice indeed, but ... + exit_code,

Re: [WIP] Make the patch code accept dirs as targets for prop only patches

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 09:59:01AM +0200, Daniel Näslund wrote: [[[ Enable the patch code to use dirs as targets if we only have property changes. * subversion/libsvn_client/patch.c (patch_target_t): Add fields 'has_text_changes' and 'has_prop_changes' to be able to decide if we

Re: [PATCH] new feature, lazy sync via export --skipfilesmatchingsize

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 03:04:02AM +, svnusert...@href.com wrote: [[[ Contributed Feature: enable lazy sync via new export flag, --skipfilesmatchingsize Discussed in part here: http://svn.haxx.se/users/archive-2010-07/0282.shtml Hi Ann, As I've said before in the discussion you've

Re: [PATCH v2] Make display_lines output a diff

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 05:21:28PM +0530, Ramkumar Ramachandra wrote: Hi, Ramkumar Ramachandra writes: Hi, Instead of spawning diff, I used difflib in Python. Here's the result. I need a +1 to commit this since it's outside my area. Is this patch alright? Do all tests pass with

Re: [PATCH] Import svnsync tests into svnrdump

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 05:17:07PM +0530, Ramkumar Ramachandra wrote: Hi, Ramkumar Ramachandra writes: The tests in svnsync_tests_data/ are in dumpfile v2 and these are unsuitable for testing svnrdump. Hence, load all of them into a repository and re-dump them in dumpfile v3 format

Re: svn commit: r979094 - /subversion/trunk/subversion/svnrdump/svnrdump.c

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 05:25:10PM +0530, Ramkumar Ramachandra wrote: Hi Kamesh, Kamesh Jayachandran writes: This breaks the 2 tests in svnrdump_tests. Though the following inline patch may fix it you may have different plans Thanks! Yes, I'm aware that it breaks tests.

Re: [PATCH v2] Make display_lines output a diff

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 05:33:20PM +0530, Ramkumar Ramachandra wrote: Hi Stefan, Stefan Sperling writes: Do all tests pass with it? Yes, they do. I ran `make check` and checked. I'm running it once more, just in case. That's not neccessary. Your patch and the new diff output look quite

Re: Proposal: Rename svnrdump

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 03:16:35PM +0200, Bert Huijben wrote: But I'm fine with just keeping 'svnrdump' even for loading. It just uses 'dump' for referring that it processes dumpfiles (like svndumpfilter does), instead of to just dumping the repository. +1 Stefan

Re: svn commit: r979094 - /subversion/trunk/subversion/svnrdump/svnrdump.c

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 06:53:26PM +0530, Ramkumar Ramachandra wrote: Hi Stefan, Stefan Sperling writes: What about doing one thing at a time instead? I'm not trying to be sarcastic or offensive, but you seem to be trying to juggle too many things at once. Writing good code takes time

Re: [PATCH v2] Make display_lines output a diff

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 07:07:12PM +0530, Ramkumar Ramachandra wrote: [[[ * subversion/tests/cmdline/svntest/verify.py (display_lines): Additionally print unified diff output using Python difflib.unified_diff. ]]] +1 Index: subversion/tests/cmdline/svntest/verify.py

Re: [PATCH] new feature, lazy sync via export --skipfilesmatchingsize

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 01:40:01PM +, svnusert...@href.com wrote: Hi Stefan, I do hear you. I also question whether RSync, or something, is truly a good option for Windows users for pulling files from a repository. Do you know Windows users that use RSync happily?I fully

Re: Proposal: Rename svnrdump

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 07:54:30AM -0700, Justin Erenkrantz wrote: On Mon, Jul 26, 2010 at 6:16 AM, Bert Huijben b...@qqmail.nl wrote: (A much older suggestion was moving the code into svnsync as they are related tools) I think either that or folding it into svnadmin itself. But, we don't

Re: [PATCH] new feature, lazy sync via export --skipfilesmatchingsize

2010-07-26 Thread Stefan Sperling
On Mon, Jul 26, 2010 at 05:30:56PM +0100, Bolstridge, Andrew wrote: If you have a directory full of source files, and it contains a sub-directory full of almost-never-changing, large binary files, then it would be great to initiate an export and have it recognise the binaries haven't changed

Re: [PATCH] Import svnsync tests into svnrdump

2010-07-27 Thread Stefan Sperling
On Tue, Jul 27, 2010 at 12:10:55AM +0530, Ramkumar Ramachandra wrote: Hi Stefan, I imported and ran the copy_and_modify test from svnsync. The diff I get clearly indicates what more needs to be done, and I think this test is very valuable. Unfortunately, `svn diff` refuses to show me the

Re: GSoC Progress report

2010-07-28 Thread Stefan Sperling
On Wed, Jul 28, 2010 at 12:06:11PM +0200, Daniel Näslund wrote: Hi! Property diffs === * We can create parseable prop patches * We can parse property patches * We can match property patches * We can write patched properties to tmp files * We can install those prop changes to

Re: GSoC Progress report

2010-07-29 Thread Stefan Sperling
On Wed, Jul 28, 2010 at 10:55:39PM +0300, Daniel Shahaf wrote: Stefan Sperling wrote on Wed, Jul 28, 2010 at 16:05:49 +0200: But there's no harm in making svn patch interpret existing move information in git diffs. We can carry out a corresponding copy + delete. We won't be generating move

Re: This is fun.

2010-07-29 Thread Stefan Sperling
On Wed, Jul 28, 2010 at 03:22:58PM -0500, Hyrum K. Wright wrote: Forgive my rambling. Over the past few months, I've noticed something: Subversion development is fun again. I don't know if it's the fact that we're all working hard on a difficult problem, or that the code is changing

Re: 1.7 Release Plan

2010-07-29 Thread Stefan Sperling
On Wed, Jul 28, 2010 at 09:43:13PM -0500, Hyrum K. Wright wrote: On Wed, Jul 28, 2010 at 6:28 PM, Talden tal...@gmail.com wrote: It looks like we might be fairly close to having on-disk formats stabilized, and hence rolling alphas.  Prereleases may be fairly prolific, since I want to work

Re: svn commit: r980427 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/patch.c svn/notify.c tests/cmdline/patch_tests.py

2010-07-29 Thread Stefan Sperling
On Thu, Jul 29, 2010 at 12:43:56PM -, dan...@apache.org wrote: Author: dannas Date: Thu Jul 29 12:43:56 2010 New Revision: 980427 URL: http://svn.apache.org/viewvc?rev=980427view=rev Log: Make 'svn patch' do notifications for property hunks. We use the same notification actions as

Re: Callbacks, prompts, etc. for issue 2779

2010-07-29 Thread Stefan Sperling
On Thu, Jul 29, 2010 at 12:09:19PM -0400, C. Michael Pilato wrote: Fer yer reference: http://subversion.tigris.org/issues/show_bug.cgi?id=2779 I've got Subversion on the issue-2779-dev branch able to follow redirects from the server without user verification, with a hard-coded limit as to the

Re: [patch] hotcopy fails on fsfs.conf that has never been created

2010-07-29 Thread Stefan Sperling
On Thu, Jul 29, 2010 at 04:19:02AM -0500, Peter Samuelson wrote: [Stefan Sperling] So my vote is: leave it as is, but print a more informative error message suggesting to create the file (so that people don't have to post to users@ to be instructed to do so), and make svnadmin upgrade

Re: svn commit: r980679 - /subversion/trunk/subversion/libsvn_client/patch.c

2010-07-30 Thread Stefan Sperling
On Fri, Jul 30, 2010 at 08:44:39AM -, dan...@apache.org wrote: Author: dannas Date: Fri Jul 30 08:44:39 2010 New Revision: 980679 URL: http://svn.apache.org/viewvc?rev=980679view=rev Log: Move the hunk notifications parts to it's own function for code reuse and readability. Nice

Re: Callbacks, prompts, etc. for issue 2779

2010-07-30 Thread Stefan Sperling
On Fri, Jul 30, 2010 at 08:28:06AM -0500, Hyrum K. Wright wrote: -Hyrum (who doesn't envy Mike's position of being at the receiving end of design by committee) I appeal to this commitee to saving Mike from unnecessary complexity! Let's try not to let the perfect be the enemy of the good.

Re: svn commit: r980811 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

2010-08-01 Thread 'Stefan Sperling'
On Sun, Aug 01, 2010 at 10:39:04AM +0200, Bert Huijben wrote: + if (APR_STATUS_IS_ENOENT(err-apr_err)) +{ + /* 1.6.0 to 1.6.11 did not copy the configuration file during + * hotcopy. So if we're hotcopying a repository which has been +

Re: svn commit: r980811 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

2010-08-01 Thread 'Stefan Sperling'
On Sun, Aug 01, 2010 at 03:50:49PM +0200, Bert Huijben wrote: Yes, her you do, but before that there are a few SVN_ERR() statements that can return WITHOUT wrapping the error. + SVN_ERR(svn_dirent_get_absolute(src_abspath, src_path, pool)); +

Re: svn commit: r980811 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

2010-08-01 Thread Stefan Sperling
On Sun, Aug 01, 2010 at 03:58:14PM +0200, Bert Huijben wrote: I don't think we should remove the '/db' part here. At the repos layer the '/db' doesn't make sense, but this is an implementation on the 'fs' layer and there the 'db' does make sense. (And if we decide to remove /db here, we

Re: svn commit: r980811 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

2010-08-01 Thread 'Stefan Sperling'
On Sun, Aug 01, 2010 at 10:56:47PM +0200, Bert Huijben wrote: Looking a bit further: Do we really need to take the absolute path for the error message? (What do we in similar code paths?) I would like Subversion to print helpful error message. Though the path need not be absolute, but see

Re: svn commit: r980811 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

2010-08-01 Thread 'Stefan Sperling'
On Sun, Aug 01, 2010 at 11:21:02PM +0200, Bert Huijben wrote: But you've also said that you didn't want the dirname() hack to strip off the trailing 'db'. I'm not against doing this.. I just think we should fix the other messages too, if we decide this is the right thing to do. Where

Re: svn commit: r980811 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

2010-08-02 Thread Stefan Sperling
On Mon, Aug 02, 2010 at 02:18:45AM +0300, Daniel Shahaf wrote: Why not err2 = svn_dirent_get_absolute(); if (err2) return svn_error_compose_create(err2, err); ? Oh, right! Thanks for the cluestick :)

Re: svn commit: r980811 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

2010-08-02 Thread Stefan Sperling
On Mon, Aug 02, 2010 at 10:10:18AM -0500, Peter Samuelson wrote: [s...@apache.org] + switch (kind) +{ +case svn_node_none: + SVN_ERR(write_config(fs, pool)); + break; +case svn_node_dir: + return svn_error_return(svn_error_createf(SVN_ERR_FS_GENERAL,

Re: svn commit: r982173 - /subversion/trunk/subversion/svn/log-cmd.c

2010-08-04 Thread Stefan Sperling
On Wed, Aug 04, 2010 at 09:21:16AM -, rhuij...@apache.org wrote: Author: rhuijben Date: Wed Aug 4 09:21:13 2010 New Revision: 982173 URL: http://svn.apache.org/viewvc?rev=982173view=rev Log: * subversion/svn/log-cmd.c (svn_cl__log): Check for paths starting with a '/' instead of

merging into locally added files

2010-08-04 Thread Stefan Sperling
While trying to improve input validation in svn merge, I stumbled across an apparently unsupported use case. It does not seem possible right now to merge into locally added files, because the Subversion assumes that the merge target will always have a corresponding URL in the repository, and

Re: svn commit: r982275 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-08-04 Thread Stefan Sperling
On Wed, Aug 04, 2010 at 02:56:42PM -, rhuij...@apache.org wrote: Author: rhuijben Date: Wed Aug 4 14:56:41 2010 New Revision: 982275 URL: http://svn.apache.org/viewvc?rev=982275view=rev Log: * subversion/libsvn_wc/wc_db.c (set_new_dir_to_incomplete_baton_txn): Following up on

Re: Bikeshed: configuration override order

2010-08-06 Thread Stefan Sperling
On Fri, Aug 06, 2010 at 02:28:11PM -0400, Bob Archer wrote: But really why do people want this. I think it is so some settings like auto-props and other things that need to be set for a specific project will take place without having to distribute a config or send an email with make sure

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Stefan Sperling
On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk. Next time, you could send this with a [PATCH] marker in the subject line, and a full committer could +1 you to commit that to directly to /trunk. Yes, please

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Stefan Sperling
On Tue, Aug 10, 2010 at 12:56:19PM +0200, Stefan Sperling wrote: On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk. Next time, you could send this with a [PATCH] marker in the subject line, and a full

Re: Bikeshed: configuration override order

2010-08-10 Thread Stefan Sperling
On Tue, Aug 10, 2010 at 06:25:15PM +0100, Julian Foad wrote: All I know about Andrew's particular requirements related to this query is what's quoted above - If I ... accidentally leave the banned buildlog.htm file in ... - which sounded vaguely like a requirement for a path-based rule. Maybe

Re: NODE_DATA (2nd iteration)

2010-08-12 Thread Stefan Sperling
On Thu, Aug 12, 2010 at 02:28:39PM +0200, Neels J Hofmeyr wrote: I've had so many family and summer events in the past weeks... soon I'll start forgetting my passwords! Just type yes at the really save in plaintext? prompt :)

Re: svn log --show-diff behavior

2010-08-14 Thread Stefan Sperling
On Fri, Aug 13, 2010 at 06:54:19PM -0700, Alexey Neyman wrote: [Posting here as 'svn log --show-diff' is currently only available in trunk] Hi All, I am trying out 1.7.0 (yes, I know it's a bit early) and noticed that svn log now supports --show-diff. It's very convenient, thanks. As

Re: svn log --show-diff behavior

2010-08-15 Thread Stefan Sperling
On Sat, Aug 14, 2010 at 11:47:52AM -0700, Alexey Neyman wrote: On Saturday, August 14, 2010 04:31:44 am Stefan Sperling wrote: Judging from the commit message, this option should mimic 'git log -p' behavior, but git does not dump the whole diff by default when -p is specified. It only

Re: svn diff - Is this behaviour expected?

2010-08-15 Thread Stefan Sperling
On Sat, Aug 14, 2010 at 04:05:17AM +0100, chr...@lavabit.com wrote: Hello, I'm running 'svn diff ...' from my application. I want to make it work with filenames that contain '@'. However, I'm finding, what appear to be, inconsistencies in its behaviour. For testing I have a working copy

Re: [WIP] Enable passing copyfrom information for the diff code when dealing with repository diffs.

2010-08-15 Thread Stefan Sperling
On Sun, Aug 15, 2010 at 09:27:22PM +0200, Daniel Näslund wrote: Hi! Why doesn't svn_ra_do_diff3() request that the repository sends copyfrom args? The best explanation I've found is this commit message: r866577 |

Re: svn commit: r985514 - stream_move_mark()

2010-08-16 Thread Stefan Sperling
On Mon, Aug 16, 2010 at 10:04:31AM +0100, Julian Foad wrote: On Mon, 2010-08-16 at 09:55 +0100, Julian Foad wrote: On Sat, 2010-08-14, stef...@apache.org wrote: Log: Extend the stream API by three functions: svn_stream_move_mark() to move an existing mark by some delta Hi Stefan.

Re: svn commit: r985514 - stream_move_mark()

2010-08-18 Thread Stefan Sperling
On Tue, Aug 17, 2010 at 11:57:11PM +0200, Stefan Fuhrmann wrote: I overgeneralized my use-case here: I actually needed move forward only. The concept of skip N bytes, however, is perfectly in line with the general stream semantics. Because this also fits my needs, I changed the API in r986485

Re: Branch audit

2010-08-18 Thread Stefan Sperling
On Tue, Aug 17, 2010 at 05:33:13PM -0500, Hyrum K. Wright wrote: It's that time again! In looking at the list of current branches (excepting release and backport branches I've noticed several which look to be abandoned or unmaintained. Branches which have not been touched in over a year

Re: svn diff optimization to make blame faster?

2010-08-18 Thread Stefan Sperling
On Wed, Aug 18, 2010 at 12:59:21AM +0200, Johan Corveleyn wrote: Hi devs, While Looking to improve performance of svn annotate [1], I found that the current blame algorithm is mainly client-side bound, and that most of its time is spent on svn diff (calls to svn_diff_file_diff_2 from

Re: Bug: resolve --accept theirs-conflict does not properly handle paths

2010-08-19 Thread Stefan Sperling
On Thu, Aug 19, 2010 at 08:24:38PM +0100, Philip Martin wrote: Doug Reeder reeder...@gmail.com writes: svn, version 1.6.4 (r38063) That's old. compiled Aug 7 2009, 11:08:17 running under OS X 10.5.8 on a Intel Core 2 Duo (i.e. a 64-bit processor) resolve --accept

Re: Issue #3693 -- any ideas?

2010-08-20 Thread Stefan Sperling
On Thu, Aug 19, 2010 at 11:35:13PM -0700, C. Michael Pilato wrote: See http://subversion.tigris.org/issues/show_bug.cgi?id=3693 Would it make sense for a multi-target update (such as 'svn update *') to print headers for each of its targets? $ svn up projects/* Updating 'projects/ezt'. At

Reduce the 1.7 release feature set a bit?

2010-08-20 Thread Stefan Sperling
I think that the recent NODE_DATA developments in wc-ng show that wc-ng is still in flux, or at least a bit further from stabilisation than we'd like it to be. That's fine! I'd much rather see us release a great working copy library than get the release out 3 months earlier. Our new focus on

Re: svn commit: r987454 - /subversion/site/publish/roadmap.html

2010-08-21 Thread Stefan Sperling
On Fri, Aug 20, 2010 at 04:59:00PM +0100, Hyrum K. Wright wrote: On Fri, Aug 20, 2010 at 11:39 AM, s...@apache.org wrote: Author: stsp Date: Fri Aug 20 10:39:27 2010 New Revision: 987454 URL: http://svn.apache.org/viewvc?rev=987454view=rev Log: * site/publish/roadmap.html  

Re: [serf-dev] Re: Reduce the 1.7 release feature set a bit?

2010-08-21 Thread Stefan Sperling
On Fri, Aug 20, 2010 at 10:23:28PM -0700, Justin Erenkrantz wrote: BTW, those who complain that no one's working on ra_serf hasn't looked at the diffs between 1.6.x and trunk. New authn framework, digest auth, Kerberos auth, error handling fixes, better proxy support, HTTPv2 support, etc.

Re: Reduce the 1.7 release feature set a bit?

2010-08-21 Thread Stefan Sperling
On Fri, Aug 20, 2010 at 11:55:10AM -0700, Bert Huijben wrote: From: Stefan Sperling - Conflict storage Do we really need to have this ready for 1.7? We might as well keep using the 1.6-style of recording conflict information in temporary files, that act as conflict markers

Re: sasl mechanisms order

2010-08-22 Thread Stefan Sperling
On Sun, Aug 22, 2010 at 12:17:41PM +0700, Victor Sudakov wrote: Colleagues, I understand that you are expecting a patch. I am sorry, I am a systems administrator and not a programmer, my code writing ability does not go beyond scripting. Can you try this patch and let me know if it works?

Re: sasl mechanisms order

2010-08-22 Thread Stefan Sperling
On Sun, Aug 22, 2010 at 12:56:23PM +0200, Stefan Sperling wrote: On Sun, Aug 22, 2010 at 12:17:41PM +0700, Victor Sudakov wrote: Colleagues, I understand that you are expecting a patch. I am sorry, I am a systems administrator and not a programmer, my code writing ability does not go beyond

Re: svn commit: r987869 - /subversion/branches/performance/subversion/libsvn_fs_fs/temp_serializer.c

2010-08-22 Thread Stefan Sperling
On Sun, Aug 22, 2010 at 01:44:07PM +0200, Stefan Sperling wrote: On Sun, Aug 22, 2010 at 11:37:38AM -, stef...@apache.org wrote: Author: stefan2 Date: Sun Aug 22 11:37:38 2010 New Revision: 987869 URL: http://svn.apache.org/viewvc?rev=987869view=rev Log: Fix VisualStudio build

Re: merging into locally added files

2010-08-23 Thread Stefan Sperling
On Wed, Aug 04, 2010 at 11:23:00AM -0400, Paul Burba wrote: On Wed, Aug 4, 2010 at 10:52 AM, Julian Foad julian.f...@wandisco.com wrote: Stefan Sperling wrote: It does not seem possible right now to merge into locally added files, because the Subversion assumes that the merge target

Re: merging into locally added files

2010-08-23 Thread Stefan Sperling
On Wed, Aug 04, 2010 at 12:32:06PM -0400, Paul Burba wrote: On Wed, Aug 4, 2010 at 12:14 PM, Julian Foad julian.f...@wandisco.com wrote: On Wed, 2010-08-04 at 11:23 -0400, Paul Burba wrote: On Wed, Aug 4, 2010 at 10:52 AM, Julian Foad julian.f...@wandisco.com wrote: if the tree conflict

Re: merging into locally added files

2010-08-23 Thread Stefan Sperling
On Mon, Aug 23, 2010 at 06:40:39PM +0100, Julian Foad wrote: You seem to be talking only about the case where the (locally added) target is the root of the whole merge, and saying that lack of ancestral relationship between the source node and this target node doesn't matter. Maybe the user

Re: merging into locally added files

2010-08-24 Thread Stefan Sperling
On Tue, Aug 24, 2010 at 08:59:32AM +0100, Julian Foad wrote: On Tue, 2010-08-24, Stefan Sperling wrote: On Mon, Aug 23, 2010 at 06:40:39PM +0100, Julian Foad wrote: You seem to be talking only about the case where the (locally added) target is the root of the whole merge, and saying

Re: Disable diff-cmd

2010-08-24 Thread Stefan Sperling
On Tue, Aug 24, 2010 at 02:24:25PM +0300, anatoly techtonik wrote: On Tue, Aug 24, 2010 at 11:35 AM, Martin Furter m...@rola.ch wrote: --internal-diff seems to be new in 1.7 so i guess the only option is using --config-dir to override it. Why not to stop proliferation of options by

Re: Disable diff-cmd

2010-08-24 Thread Stefan Sperling
On Tue, Aug 24, 2010 at 01:48:43PM +0100, Julian Foad wrote: anatoly techtonik wrote: On Tue, Aug 24, 2010 at 2:29 PM, Stefan Sperling s...@elego.de wrote: --internal-diff seems to be new in 1.7 so i guess the only option is using --config-dir to override it. Why

Re: git diff format support

2010-08-24 Thread Stefan Sperling
On Tue, Aug 24, 2010 at 05:44:50PM +0100, Jon Foster wrote: Hi, There is a --git-diff option in Subversion Trunk, so this will probably be available in Subversion 1.7. Yes. But there are some restrictions, most notably with renames. Our git-style diffs show adds, deletes, and copies

Re: git diff format support

2010-08-24 Thread Stefan Sperling
On Tue, Aug 24, 2010 at 07:51:28PM +0300, anatoly techtonik wrote: Good to know. Is it worth to rename it to `svn diff --git` for unification with Mercurial? I suppose we could rename the option to --git, yes. Do you want to send a patch that does so? See

Re: svn commit: r987869 - /subversion/branches/performance/subversion/libsvn_fs_fs/temp_serializer.c

2010-08-25 Thread Stefan Sperling
On Wed, Aug 25, 2010 at 11:13:17AM +0200, Stefan Fuhrmann wrote: I picked up the count*sizeof(T[1]) idiom from come STL implementations. They were probably working around some non-standard compiler behavior somewhere. Since that turned out to be unnecessary, I dropped the confusing [1] in

Re: About character encoding of the text files

2010-08-25 Thread Stefan Sperling
On Wed, Aug 25, 2010 at 06:58:50PM +0200, Branko Čibej wrote: On 25.08.2010 18:54, Ivan Cenov wrote: Well, I tested with svn:mime-type=text/plain; charset=windows1251. I tried to define it as auto property in [auto-props] section of Subversion config file (it resides in C:\Documents and

Re: Get latest file changes in repository

2010-08-25 Thread Stefan Sperling
On Wed, Aug 25, 2010 at 10:48:30AM -0700, Steve wrote: I am trying to get a list from the repository (not anyone's working copy) of the files and folders that have changed since the last revision. How do I do this? Please post such questions to the users list. This list is about development of

Re: [PATCH] Rename --git-diff to --git for svn diff

2010-08-25 Thread Stefan Sperling
On Wed, Aug 25, 2010 at 07:13:15PM +0300, anatoly techtonik wrote: Here is the patch. I've embedded log message inside and also opened Rietveld issue if you like. http://codereview.appspot.com/2012048/ Thank you! Committed in r989327. I've tweaked the log message a bit, most importanly to

Re: Two svn_wc__db_t for single-db upgrade

2010-08-27 Thread Stefan Sperling
On Fri, Aug 27, 2010 at 12:03:04PM -0400, Bob Archer wrote: I'm just talking as a user here... and not an svn dev... but do you really need to spend time on a 1.6 to 1.7 WC upgrade? Why not just have 1.7 not work with 1.7 WCs and tell the users they need to do a new checkout with 1.7. I

Re: Two svn_wc__db_t for single-db upgrade

2010-08-27 Thread Stefan Sperling
On Fri, Aug 27, 2010 at 05:54:38PM +0100, Julian Foad wrote: The trouble is, people often won't find out until some time after they've upgraded, especially if it's a WC they aren't working on at the moment and they try to come back to work on it some weeks later. And for most people

Re: Two svn_wc__db_t for single-db upgrade

2010-08-27 Thread Stefan Sperling
On Fri, Aug 27, 2010 at 01:20:31PM -0400, Bob Archer wrote: Or, if not, the user can do a new checkout, and then use a compare tool to apply your pending changes to your new WC. This means, don't auto-update a WC that has pending changes in it. There won't be any auto-update, I think. The plan

Re: Another FSFS bug somewhere?

2010-09-02 Thread Stefan Sperling
On Tue, Aug 31, 2010 at 05:49:03PM -0400, John Szakmeister wrote: I can't be sure which version of SVN this occurred with (I believe it was a very recent version), but I had a user email me the other day about a broken revision. After taking a look, it appears that SVN picked the right

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-02 Thread Stefan Sperling
On Thu, Sep 02, 2010 at 12:04:15PM +0200, Branko Čibej wrote: On 02.09.2010 11:03, Daniel Näslund wrote: Note that we don't yet perform any symlink operation when applying a path with svn:special set. If that isn't fixed for 1.7, then it rates a big warning!! in the release notes. Filed

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-02 Thread Stefan Sperling
On Thu, Sep 02, 2010 at 11:03:36AM +0200, Daniel Näslund wrote: We have two goals I think: i) Implement a format that is interoperable with git and mercurial and possible other vcs tools that choose to implement the git extensions to the unidiff format. ii) Adjust the format dictated

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-02 Thread Stefan Sperling
On Thu, Sep 02, 2010 at 11:27:07AM +0300, Daniel Shahaf wrote: Daniel Näslund wrote on Thu, Sep 02, 2010 at 07:13:00 +0200: On Wed, Sep 01, 2010 at 06:37:08PM +0100, Julian Foad wrote: This may be off topic, but I'm wondering whether Git has defined such operations on directories fully or

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-02 Thread Stefan Sperling
On Thu, Sep 02, 2010 at 02:09:03PM +0200, Branko Čibej wrote: On 02.09.2010 13:25, Stefan Sperling wrote: For now, an svn symlink will show up as an empty file when the patch is applied with git. I don't think that's a huge problem. Nice to have, but not release critical for Subversion

Re: Another FSFS bug somewhere?

2010-09-02 Thread Stefan Sperling
On Thu, Sep 02, 2010 at 06:29:41PM +0300, Daniel Shahaf wrote: John Szakmeister wrote on Thu, Sep 02, 2010 at 07:09:43 -0400: On Thu, Sep 2, 2010 at 6:48 AM, Stefan Sperling s...@elego.de wrote: John, if you had time for a quick IRC session where you could explain the ideas behind

Re: sasl mechanisms order

2010-09-02 Thread Stefan Sperling
On Sun, Aug 22, 2010 at 01:08:52PM +0200, Stefan Sperling wrote: On Sun, Aug 22, 2010 at 12:56:23PM +0200, Stefan Sperling wrote: On Sun, Aug 22, 2010 at 12:17:41PM +0700, Victor Sudakov wrote: Colleagues, I understand that you are expecting a patch. I am sorry, I am a systems

Re: svn commit: r992050 - /subversion/trunk/subversion/tests/cmdline/merge_tests.py

2010-09-02 Thread Stefan Sperling
On Thu, Sep 02, 2010 at 03:33:13PM -0400, Paul Burba wrote: On Thu, Sep 2, 2010 at 3:18 PM, Bert Huijben b...@qqmail.nl wrote: $ python ActivePython 2.6.1.1 (ActiveState Software Inc.) based on Python 2.6.1 (r261:67515, Dec  5 2008, 13:58:38) [MSC v.1500 32 bit (Intel)] on win32 Type

Re: Pascal bindings

2010-09-02 Thread Stefan Sperling
On Thu, Sep 02, 2010 at 09:27:57PM +0100, Julian Foad wrote: C. Michael Pilato wrote: On 09/02/2010 01:38 PM, Philip Martin wrote: dmitry boyarintsev skalogryz.li...@gmail.com writes: Hello Subversion-dev, I can see, that there's no much of interest in Pascal bindings. Well,

Re: [PROPOSAL] WC-NG: merge NODE_DATA, WORKING_NODE and BASE_NODE into a single table (NODES)

2010-09-02 Thread Stefan Sperling
On Thu, Sep 02, 2010 at 11:34:50PM +0200, Erik Huelsmann wrote: Comments? Fears? Enhancements? I always like simplifications. I cannot judge the overall impact of this change, but I guess you guys will have figured out the consequences. It feels like with a single table we're going back to a

Re: svn commit: r990385 - /subversion/trunk/subversion/libsvn_client/patch.c

2010-09-03 Thread Stefan Sperling
On Fri, Sep 03, 2010 at 01:47:06PM +0300, Daniel Shahaf wrote: s...@apache.org wrote on Sat, Aug 28, 2010 at 15:49:52 -: Author: stsp Date: Sat Aug 28 15:49:52 2010 New Revision: 990385 URL: http://svn.apache.org/viewvc?rev=990385view=rev Log: * subversion/libsvn_client/patch.c

Re: [PATCH] don't do autoprops on symbolic links

2010-09-03 Thread Stefan Sperling
On Fri, Sep 03, 2010 at 08:58:09PM +0800, Wei-Yin Chen wrote: Sorry, that line should have been matching_filenames = [f for f in matching_filenames if not os.path.islink(dirname+'/'+f)] Hi, thanks for your patch! I think we should use os.sep instead of '/', because os.sep is more portable.

Re: [PATCH]svnrdump to dump single specified revision

2010-09-06 Thread Stefan Sperling
On Mon, Sep 06, 2010 at 09:53:24PM +0530, vijayaguru wrote: Attaching the patch, Thanks Regards, Vijayaguru From the output of svnrdump help dump: dump: usage: svnrdump dump URL [-r LOWER[:UPPER]] Dump revisions LOWER to UPPER of repository at remote URL to stdout in a 'dumpfile'

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-06 Thread Stefan Sperling
On Tue, Sep 07, 2010 at 12:09:47AM -, s...@apache.org wrote: Author: stsp Date: Tue Sep 7 00:09:46 2010 New Revision: 993183 URL: http://svn.apache.org/viewvc?rev=993183view=rev Log: Introduce a new family of functions to parse numbers from strings. *

Re: svn commit: r993258 - /subversion/trunk/subversion/mod_dav_svn/reports/log.c

2010-09-07 Thread Stefan Sperling
On Tue, Sep 07, 2010 at 01:19:42PM +0530, Senthil Kumaran S wrote: Hi Bert, rhuij...@apache.org wrote: Author: rhuijben Date: Tue Sep 7 07:32:34 2010 New Revision: 993258 URL: http://svn.apache.org/viewvc?rev=993258view=rev Log: * subversion/mod_dav_svn/reports/log.c

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-07 Thread Stefan Sperling
On Tue, Sep 07, 2010 at 09:17:10AM +0200, Stephen Butler wrote: * subversion/include/svn_string.h (svn_cstring_strtoi64, svn_cstring_atoi64, svn_cstring_atoi, svn_cstring_strtoui64, svn_cstring_atoui64, svn_cstring_atoui): Declare. Uh oh, some buildbots complain about

bump-to-19.py users: bump *all* dirs to format 18 first

2010-09-07 Thread Stefan Sperling
Qouting myself here from IRC in case anyone missed this. I've already lost a couple of working copies due to this problem, so just in case this helps someone I'm pasting it here: stsp when this happens with the bump-to-19.py script: skipped: format is 16 not 18: stsp you have basically lost your

Apache Retreat in Hursely, UK

2010-09-08 Thread Stefan Sperling
Hi, there are still free slots for the Apache Retreat in Hursely next week: http://sites.google.com/site/apacheretreat/ AFAIK the following Subversion developers will be present: Stephen Butler, Daniel Näslund, Daniel Shahaf, Hyrum Wright, myself. There are still free slots for the event, and

Re: svn commit: r995383 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2010-09-09 Thread Stefan Sperling
On Thu, Sep 09, 2010 at 03:20:17PM +0300, Daniel Shahaf wrote: s...@apache.org wrote on Thu, Sep 09, 2010 at 11:31:13 -: + return svn_error_return( + svn_error_create(SVN_ERR_FS_CORRUPT, NULL, +_(Malformed representation header)));

Re: svn commit: r995383 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2010-09-09 Thread Stefan Sperling
On Thu, Sep 09, 2010 at 03:39:04PM +0300, Daniel Shahaf wrote: It might be good to make the rule 'return svn_error_*();' never needs svn_error_return() wrapper and fix the svn_error_* functions/macros that don't already record the file/line. +1

Re: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c

2010-09-10 Thread Stefan Sperling
On Thu, Sep 09, 2010 at 08:58:10PM +0200, Bert Huijben wrote: @@ -524,9 +524,11 @@ parse_property_block(svn_stream_t *strea else if ((buf[0] == 'D') (buf[1] == ' ')) { char *keybuf; + apr_int64_t len; + SVN_ERR(svn_cstring_atoi64(len,

Re: svn commit: r995603 - /subversion/branches/performance/subversion/libsvn_subr/svn_string.c

2010-09-10 Thread Stefan Sperling
On Thu, Sep 09, 2010 at 10:58:06PM -, stef...@apache.org wrote: Author: stefan2 Date: Thu Sep 9 22:58:06 2010 New Revision: 995603 URL: http://svn.apache.org/viewvc?rev=995603view=rev Log: Try really hard to help the compiler generate good code for this frequently called function.

Re: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c

2010-09-10 Thread Stefan Sperling
On Fri, Sep 10, 2010 at 04:02:52PM +0200, Branko Čibej wrote: On 10.09.2010 15:26, Stefan Sperling wrote: I know we're using C89, but maybe it's time to move on and upgrade to C99 where the benefits are desirable? When Subversion was started, C89 was about a decade old, and C99 is just

Re: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c

2010-09-10 Thread Stefan Sperling
On Fri, Sep 10, 2010 at 04:47:39PM +0200, Bert Huijben wrote: -Original Message- From: Stefan Sperling [mailto:s...@elego.de] Sent: vrijdag 10 september 2010 15:26 To: Bert Huijben Cc: dev@subversion.apache.org Subject: Re: svn commit: r995475 - /subversion/trunk

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8

2010-09-11 Thread Stefan Sperling
On Fri, Sep 10, 2010 at 04:57:41PM -0700, Daniel Trebbien wrote: When I was working on my changes, I was looking for a to UTF-8 function that would return whether it actually re-encoded the input string, but did not find one. The re-encoding function that I used, `svn_subst_translate_string`,

Re: svn commit: r996383 - in /subversion/trunk/subversion: svn/conflict-callbacks.c tests/cmdline/resolve_tests.py

2010-09-12 Thread Stefan Sperling
On Sun, Sep 12, 2010 at 08:23:30PM -, danie...@apache.org wrote: Author: danielsh Date: Sun Sep 12 20:23:30 2010 New Revision: 996383 URL: http://svn.apache.org/viewvc?rev=996383view=rev Log: 'svn --accept': add shorthands. * subversion/tests/cmdline/resolve_tests.py

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8

2010-09-13 Thread Stefan Sperling
On Sun, Sep 12, 2010 at 04:21:03PM -0700, Daniel Trebbien wrote: I removed the normalization counting code without much thought in my hastened efforts to produce a version of `svnsync` that I could use to mirror the GNU Nano repository. Currently, I am thinking that Stefan Sperling's idea of a

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

2010-09-13 Thread Stefan Sperling
On Mon, Sep 13, 2010 at 05:50:05PM +0100, Julian Foad wrote: On Mon, 2010-09-13, s...@apache.org wrote: * subversion/libsvn_diff/parse-diff.c (svn_diff_parse_next_patch): When generating a reverse diff, do not swap the old and new filenames of the patch. The old filename in a unidiff

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

2010-09-14 Thread Stefan Sperling
On Tue, Sep 14, 2010 at 12:49:06PM +0100, Julian Foad wrote: Right. The issue seems to be How do I determine what path I should apply the patch to? If the patch style is --- wc/file +++ wc/file or --- old_wc/file +++ new_wc/file then you're going to be stripping the first

Re: svn commit: r997203 - in /subversion/trunk: ./ subversion/include/ subversion/libsvn_client/ subversion/libsvn_diff/ subversion/libsvn_fs_fs/ subversion/libsvn_ra_svn/ subversion/libsvn_repos/ sub

2010-09-15 Thread Stefan Sperling
On Wed, Sep 15, 2010 at 06:52:07AM -, hwri...@apache.org wrote: == --- subversion/trunk/subversion/include/svn_string.h (original) +++ subversion/trunk/subversion/include/svn_string.h Wed Sep 15 06:52:06 2010 @@

  1   2   3   4   5   6   7   8   9   10   >