[GitHub] john-bodley opened a new pull request #4884: [pylint] prepping for enabling pylint for non-errors

2018-04-25 Thread GitBox
john-bodley opened a new pull request #4884: [pylint] prepping for enabling pylint for non-errors URL: https://github.com/apache/incubator-superset/pull/4884 To help improve stability and code quality I thought it would be prudent to enable `pylint` for non-errors. Given that numbers of

[GitHub] codecov-io commented on issue #4884: [pylint] prepping for enabling pylint for non-errors

2018-04-25 Thread GitBox
codecov-io commented on issue #4884: [pylint] prepping for enabling pylint for non-errors URL: https://github.com/apache/incubator-superset/pull/4884#issuecomment-384521389 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4884?src=pr=h1) Report > Merging

[GitHub] manishkhorgade commented on issue #3078: [sql lab] add ability to schedule queries

2018-04-25 Thread GitBox
manishkhorgade commented on issue #3078: [sql lab] add ability to schedule queries URL: https://github.com/apache/incubator-superset/issues/3078#issuecomment-384510093 Thanks, @mistercrunch. This is an automated message

[GitHub] mistercrunch commented on a change in pull request #4587: [logs] Dropping dt column

2018-04-25 Thread GitBox
mistercrunch commented on a change in pull request #4587: [logs] Dropping dt column URL: https://github.com/apache/incubator-superset/pull/4587#discussion_r184273398 ## File path: superset/migrations/versions/30bb17c0dc76_.py ## @@ -0,0 +1,26 @@ +"""empty message +

[GitHub] john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto

2018-04-25 Thread GitBox
john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#discussion_r183947245 ## File path: superset/sql_lab.py ## @@ -255,23 +237,27 @@ def handle_error(msg):

[GitHub] john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto

2018-04-25 Thread GitBox
john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#discussion_r183946690 ## File path: superset/db_engine_specs.py ## @@ -639,7 +641,28 @@ def

[GitHub] john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto

2018-04-25 Thread GitBox
john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#discussion_r183946731 ## File path: superset/db_engine_specs.py ## @@ -639,7 +641,28 @@ def

[GitHub] john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto

2018-04-25 Thread GitBox
john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#discussion_r183946690 ## File path: superset/db_engine_specs.py ## @@ -639,7 +641,28 @@ def

[GitHub] john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto

2018-04-25 Thread GitBox
john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#discussion_r183947122 ## File path: superset/db_engine_specs.py ## @@ -650,12 +673,21 @@ def

[GitHub] john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto

2018-04-25 Thread GitBox
john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#discussion_r183947348 ## File path: superset/sql_lab.py ## @@ -158,6 +136,9 @@ def handle_error(msg):

[GitHub] john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto

2018-04-25 Thread GitBox
john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#discussion_r183947898 ## File path: superset/views/core.py ## @@ -2304,14 +2304,15 @@ def results(self, key):

[GitHub] john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto

2018-04-25 Thread GitBox
john-bodley commented on a change in pull request #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#discussion_r183947742 ## File path: superset/utils.py ## @@ -836,3 +881,16 @@ def ensure_path_exists(path):

[GitHub] codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values.

2018-04-25 Thread GitBox
codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values. URL: https://github.com/apache/incubator-superset/pull/4712#issuecomment-380476608 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr=h1)

[GitHub] codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values.

2018-04-25 Thread GitBox
codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values. URL: https://github.com/apache/incubator-superset/pull/4712#issuecomment-380476608 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr=h1)

[GitHub] shyam2794 opened a new pull request #4880: Adding X and Y axis Formats to the Bubble Chart Tooltip

2018-04-25 Thread GitBox
shyam2794 opened a new pull request #4880: Adding X and Y axis Formats to the Bubble Chart Tooltip URL: https://github.com/apache/incubator-superset/pull/4880 The Bubble chart does not apply the formatting options on the metrics in the tooltip . Adding the x-axis and y-axis formatting

[GitHub] andrewsali opened a new issue #4879: [SqlLab] Async & Sync execution mixed up

2018-04-25 Thread GitBox
andrewsali opened a new issue #4879: [SqlLab] Async & Sync execution mixed up URL: https://github.com/apache/incubator-superset/issues/4879 It appears that async and sync execution got mixed up:

[GitHub] andrewsali closed issue #4879: [SqlLab] Async & Sync execution mixed up

2018-04-25 Thread GitBox
andrewsali closed issue #4879: [SqlLab] Async & Sync execution mixed up URL: https://github.com/apache/incubator-superset/issues/4879 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] benkindt commented on issue #519: Ordering on X axis on the distribution bar chart

2018-04-25 Thread GitBox
benkindt commented on issue #519: Ordering on X axis on the distribution bar chart URL: https://github.com/apache/incubator-superset/issues/519#issuecomment-384256979 For me it still does only sort alphabetically. > "version": "0.24.0" For example: it does not work when ordering

[GitHub] benkindt commented on issue #519: Ordering on X axis on the distribution bar chart

2018-04-25 Thread GitBox
benkindt commented on issue #519: Ordering on X axis on the distribution bar chart URL: https://github.com/apache/incubator-superset/issues/519#issuecomment-384256979 For me it still does only sort alphabetically. > "version": "0.24.0" For example: it does not work when ordering

[GitHub] benkindt commented on issue #519: Ordering on X axis on the distribution bar chart

2018-04-25 Thread GitBox
benkindt commented on issue #519: Ordering on X axis on the distribution bar chart URL: https://github.com/apache/incubator-superset/issues/519#issuecomment-384256979 For me it still does only sort alphabetically. > "version": "0.24.0" For example: it does not work when ordering

[GitHub] ripoul commented on issue #4656: the schema of short url is hard code to http

2018-04-25 Thread GitBox
ripoul commented on issue #4656: the schema of short url is hard code to http URL: https://github.com/apache/incubator-superset/issues/4656#issuecomment-384285151 this code should do the work : ` scheme = request.scheme\n return Response(

[GitHub] ripoul commented on issue #4656: the schema of short url is hard code to http

2018-04-25 Thread GitBox
ripoul commented on issue #4656: the schema of short url is hard code to http URL: https://github.com/apache/incubator-superset/issues/4656#issuecomment-384285151 this code should do the work : `scheme = request.scheme return Response(

[GitHub] ripoul commented on issue #4656: the schema of short url is hard code to http

2018-04-25 Thread GitBox
ripoul commented on issue #4656: the schema of short url is hard code to http URL: https://github.com/apache/incubator-superset/issues/4656#issuecomment-384285151 this code should do the work : ``` scheme = request.scheme return Response(

[GitHub] ripoul commented on issue #4656: the schema of short url is hard code to http

2018-04-25 Thread GitBox
ripoul commented on issue #4656: the schema of short url is hard code to http URL: https://github.com/apache/incubator-superset/issues/4656#issuecomment-384285151 this code should do the work : ` scheme = request.scheme return Response(

[GitHub] ripoul commented on issue #4656: the schema of short url is hard code to http

2018-04-25 Thread GitBox
ripoul commented on issue #4656: the schema of short url is hard code to http URL: https://github.com/apache/incubator-superset/issues/4656#issuecomment-384285151 this code should do the work : scheme = request.scheme return Response(

[GitHub] manishkhorgade commented on issue #3078: [sql lab] add ability to schedule queries

2018-04-25 Thread GitBox
manishkhorgade commented on issue #3078: [sql lab] add ability to schedule queries URL: https://github.com/apache/incubator-superset/issues/3078#issuecomment-384338854 This is great! Does 'this quarter' mean by the end of June? We are working on a feature and would love to have this by

[GitHub] musunuru opened a new issue #4881: Issue when Superset is integrated with LDAP and AUTH_LDAP_USE_TLS = True

2018-04-25 Thread GitBox
musunuru opened a new issue #4881: Issue when Superset is integrated with LDAP and AUTH_LDAP_USE_TLS = True URL: https://github.com/apache/incubator-superset/issues/4881 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset

[GitHub] codecov-io commented on issue #4882: Implement Snowflake engine with supported time grains

2018-04-25 Thread GitBox
codecov-io commented on issue #4882: Implement Snowflake engine with supported time grains URL: https://github.com/apache/incubator-superset/pull/4882#issuecomment-384441539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr=h1) Report > Merging

[GitHub] villebro opened a new pull request #4882: Implement Snowflake engine with supported time grains

2018-04-25 Thread GitBox
villebro opened a new pull request #4882: Implement Snowflake engine with supported time grains URL: https://github.com/apache/incubator-superset/pull/4882 Initial implementation of Snowflake specific engine. This is an

[GitHub] codecov-io commented on issue #4882: Implement Snowflake engine with supported time grains

2018-04-25 Thread GitBox
codecov-io commented on issue #4882: Implement Snowflake engine with supported time grains URL: https://github.com/apache/incubator-superset/pull/4882#issuecomment-384441539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr=h1) Report > Merging

[GitHub] mistercrunch closed pull request #4882: Implement Snowflake engine with supported time grains

2018-04-25 Thread GitBox
mistercrunch closed pull request #4882: Implement Snowflake engine with supported time grains URL: https://github.com/apache/incubator-superset/pull/4882 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mistercrunch commented on issue #4882: Implement Snowflake engine with supported time grains

2018-04-25 Thread GitBox
mistercrunch commented on issue #4882: Implement Snowflake engine with supported time grains URL: https://github.com/apache/incubator-superset/pull/4882#issuecomment-38146 ![giphy](https://user-images.githubusercontent.com/487433/39274527-2006f196-4897-11e8-9f1a-8c6da9d52999.gif)

[GitHub] mistercrunch commented on a change in pull request #4880: Adding X and Y axis Formats to the Bubble Chart Tooltip

2018-04-25 Thread GitBox
mistercrunch commented on a change in pull request #4880: Adding X and Y axis Formats to the Bubble Chart Tooltip URL: https://github.com/apache/incubator-superset/pull/4880#discussion_r184216823 ## File path: superset/assets/src/visualizations/nvd3_vis.js ## @@ -370,7

[GitHub] mistercrunch commented on a change in pull request #4880: Adding X and Y axis Formats to the Bubble Chart Tooltip

2018-04-25 Thread GitBox
mistercrunch commented on a change in pull request #4880: Adding X and Y axis Formats to the Bubble Chart Tooltip URL: https://github.com/apache/incubator-superset/pull/4880#discussion_r184216781 ## File path: superset/assets/src/visualizations/nvd3_vis.js ## @@ -384,7

[GitHub] mistercrunch opened a new pull request #4883: Add note about 0.25.0 upgrade in UPDATING.md

2018-04-25 Thread GitBox
mistercrunch opened a new pull request #4883: Add note about 0.25.0 upgrade in UPDATING.md URL: https://github.com/apache/incubator-superset/pull/4883 @john-bodley @hug This is an automated message from the Apache Git

[GitHub] nick-gray commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE()

2018-04-25 Thread GitBox
nick-gray commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE() URL: https://github.com/apache/incubator-superset/issues/4857#issuecomment-384486221 Is this all related to

[GitHub] musunuru commented on issue #4881: Issue when Superset is integrated with LDAP and AUTH_LDAP_USE_TLS = True

2018-04-25 Thread GitBox
musunuru commented on issue #4881: Issue when Superset is integrated with LDAP and AUTH_LDAP_USE_TLS = True URL: https://github.com/apache/incubator-superset/issues/4881#issuecomment-384451986 Sure This is an automated

[GitHub] mistercrunch commented on a change in pull request #4587: [logs] Dropping dt column

2018-04-25 Thread GitBox
mistercrunch commented on a change in pull request #4587: [logs] Dropping dt column URL: https://github.com/apache/incubator-superset/pull/4587#discussion_r184246484 ## File path: superset/migrations/versions/30bb17c0dc76_.py ## @@ -0,0 +1,26 @@ +"""empty message +

[GitHub] codecov-io commented on issue #4882: Implement Snowflake engine with supported time grains

2018-04-25 Thread GitBox
codecov-io commented on issue #4882: Implement Snowflake engine with supported time grains URL: https://github.com/apache/incubator-superset/pull/4882#issuecomment-384441539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4656: the schema of short url is hard code to http

2018-04-25 Thread GitBox
mistercrunch commented on issue #4656: the schema of short url is hard code to http URL: https://github.com/apache/incubator-superset/issues/4656#issuecomment-384445537 @ripoul mind submitting a PR ? This is an automated

[GitHub] mistercrunch commented on issue #4881: Issue when Superset is integrated with LDAP and AUTH_LDAP_USE_TLS = True

2018-04-25 Thread GitBox
mistercrunch commented on issue #4881: Issue when Superset is integrated with LDAP and AUTH_LDAP_USE_TLS = True URL: https://github.com/apache/incubator-superset/issues/4881#issuecomment-384445372 Mind closing here and reopening on the FAB side?

[GitHub] codecov-io commented on issue #4883: Add note about 0.25.0 upgrade in UPDATING.md

2018-04-25 Thread GitBox
codecov-io commented on issue #4883: Add note about 0.25.0 upgrade in UPDATING.md URL: https://github.com/apache/incubator-superset/pull/4883#issuecomment-384484324 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4883?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #3078: [sql lab] add ability to schedule queries

2018-04-25 Thread GitBox
mistercrunch commented on issue #3078: [sql lab] add ability to schedule queries URL: https://github.com/apache/incubator-superset/issues/3078#issuecomment-38514 Yes this quarter currently means end of june This is an

[GitHub] musunuru closed issue #4881: Issue when Superset is integrated with LDAP and AUTH_LDAP_USE_TLS = True

2018-04-25 Thread GitBox
musunuru closed issue #4881: Issue when Superset is integrated with LDAP and AUTH_LDAP_USE_TLS = True URL: https://github.com/apache/incubator-superset/issues/4881 This is an automated message from the Apache Git Service.

[GitHub] john-bodley commented on a change in pull request #4587: [logs] Dropping dt column

2018-04-25 Thread GitBox
john-bodley commented on a change in pull request #4587: [logs] Dropping dt column URL: https://github.com/apache/incubator-superset/pull/4587#discussion_r184249512 ## File path: superset/migrations/versions/30bb17c0dc76_.py ## @@ -0,0 +1,26 @@ +"""empty message +