Re: Annotations and Overlays

2017-09-26 Thread Fabian Menges
ion and it looks like our stuff
>>> is compatible and we haven't done much duplicate work
>>>
>>> I didn't really do anything server side, check out my code that add a
>>> annotation layer to the d3.svg...
>>>
>>> https://github.com/apache/incubator-superset/pull/3518/files
>>>
>>> Let me know what you think.
>>>
>>> On Sat, Sep 23, 2017 at 12:38 PM, Maxime Beauchemin <
>>> maximebeauche...@gmail.com> wrote:
>>>
>>>> Wait up! Grace and I have been working on annotations last week.
>>>>
>>>> Here's the backend part I wrote, Grace has code that shows one or many
>>>> "annotation layers" on the nvd3 time series charts
>>>>
>>>> https://github.com/apache/incubator-superset/compare/master.
>>>> ..mistercrunch:annotations?expand=1
>>>>
>>>> Those are time-related annotations, namespaced into arbitrary "layers"
>>>> stored in the backend. We have plans to support other types of
>>>> annotation
>>>> like "point in place" in the future. We're open to collaborate on all
>>>> that.
>>>>
>>>> I like the idea of formulas, curious how you're planning on safely
>>>> "eval-ing" the formulas too, I'm thinking users should also be able to
>>>> pick
>>>> their color and style for that special series.
>>>>
>>>> Max
>>>>
>>>> On Sep 23, 2017 8:41 AM, "Fabian Menges" <fmen...@twitter.com.invalid>
>>>> wrote:
>>>>
>>>> > Hi everyone,
>>>> >
>>>> > Just wanted to give everyone heads up, I'm working on adding
>>>> Annotations
>>>> > and Overlays to time series line charts in Superset.
>>>> >
>>>> > I'll probably have something done by next week. This is how it will
>>>> work:
>>>> >
>>>> > There are 3 different types of annotations:
>>>> >
>>>> >1. Events. Events are a list of dates with descriptions. They will
>>>> be
>>>> >displayed as vertical lines. Their description will show up in the
>>>> > tooltips
>>>> >if you hover over them. They are fetched from a "table" slice, that
>>>> >contains the data.
>>>> >2. Timeseries. Timeseries are are added as an additional line on
>>>> the
>>>> >line chart. The name and the display properties can be configured.
>>>> The
>>>> > data
>>>> >is fetched from any timeseries slce.
>>>> >3. Formulas. Formulas are added as an additional line to the
>>>> chart. You
>>>> >will be able to enter a mathematical expression, that will be
>>>> evaluated
>>>> > on
>>>> >the client side using "mathjs". You will be able to specify display
>>>> >properties. You will be able to specify any mathematical formula
>>>> e.g
>>>> >- y = 500  (horizontal line)
>>>> >   - y = 0.2x (line with inclination of 0.2)
>>>> >   - y = x^2 (parabola)
>>>> >
>>>> > Let me know if you have any concerns or can think of missing features.
>>>> >
>>>> >
>>>> > Fabian
>>>> >
>>>>
>>>
>>>
>>
>


Re: Annotations and Overlays

2017-09-26 Thread Fabian Menges
Just to close the loop, I just created some videos for how my annotations
work:

Events: https://youtu.be/My6ScXyAxIY
Time Series: https://youtu.be/EQm7Kk1D1Cw
Formulas: https://youtu.be/vBSaUNxLE0c

I'll probably need another few days to clean up and expose a couple more
features in the UI.
I think it does make sense for me to integrate your annotations
implementation, e.g. as an additional type.

Fabian



On Sat, Sep 23, 2017 at 2:15 PM, Fabian Menges <fmen...@twitter.com> wrote:

> Ok, I think we are solving two different but related problems.
>
> From your DB data model it looks like you will give users the ability to
> add annotations through the UI.
>
> My work enables users to overlay data from other datasources, like
> annotations, onto line charts. I think both of these are complementary.
>
> I'm happy to take on the UI work for both of these use cases if you are
> fine with that.
> Let me know how you envisioned the user experience for adding annotations
> and I'm happy to give it shot.
>
> Fabian
>
> On Sat, Sep 23, 2017 at 1:39 PM, Fabian Menges <fmen...@twitter.com>
> wrote:
>
>> Nice, I'm almost done with my implementation and it looks like our stuff
>> is compatible and we haven't done much duplicate work
>>
>> I didn't really do anything server side, check out my code that add a
>> annotation layer to the d3.svg...
>>
>> https://github.com/apache/incubator-superset/pull/3518/files
>>
>> Let me know what you think.
>>
>> On Sat, Sep 23, 2017 at 12:38 PM, Maxime Beauchemin <
>> maximebeauche...@gmail.com> wrote:
>>
>>> Wait up! Grace and I have been working on annotations last week.
>>>
>>> Here's the backend part I wrote, Grace has code that shows one or many
>>> "annotation layers" on the nvd3 time series charts
>>>
>>> https://github.com/apache/incubator-superset/compare/master.
>>> ..mistercrunch:annotations?expand=1
>>>
>>> Those are time-related annotations, namespaced into arbitrary "layers"
>>> stored in the backend. We have plans to support other types of annotation
>>> like "point in place" in the future. We're open to collaborate on all
>>> that.
>>>
>>> I like the idea of formulas, curious how you're planning on safely
>>> "eval-ing" the formulas too, I'm thinking users should also be able to
>>> pick
>>> their color and style for that special series.
>>>
>>> Max
>>>
>>> On Sep 23, 2017 8:41 AM, "Fabian Menges" <fmen...@twitter.com.invalid>
>>> wrote:
>>>
>>> > Hi everyone,
>>> >
>>> > Just wanted to give everyone heads up, I'm working on adding
>>> Annotations
>>> > and Overlays to time series line charts in Superset.
>>> >
>>> > I'll probably have something done by next week. This is how it will
>>> work:
>>> >
>>> > There are 3 different types of annotations:
>>> >
>>> >1. Events. Events are a list of dates with descriptions. They will
>>> be
>>> >displayed as vertical lines. Their description will show up in the
>>> > tooltips
>>> >if you hover over them. They are fetched from a "table" slice, that
>>> >contains the data.
>>> >2. Timeseries. Timeseries are are added as an additional line on the
>>> >line chart. The name and the display properties can be configured.
>>> The
>>> > data
>>> >is fetched from any timeseries slce.
>>> >3. Formulas. Formulas are added as an additional line to the chart.
>>> You
>>> >will be able to enter a mathematical expression, that will be
>>> evaluated
>>> > on
>>> >the client side using "mathjs". You will be able to specify display
>>> >properties. You will be able to specify any mathematical formula e.g
>>> >- y = 500  (horizontal line)
>>> >   - y = 0.2x (line with inclination of 0.2)
>>> >   - y = x^2 (parabola)
>>> >
>>> > Let me know if you have any concerns or can think of missing features.
>>> >
>>> >
>>> > Fabian
>>> >
>>>
>>
>>
>


Re: Annotations and Overlays

2017-09-23 Thread Fabian Menges
Ok, I think we are solving two different but related problems.

>From your DB data model it looks like you will give users the ability to
add annotations through the UI.

My work enables users to overlay data from other datasources, like
annotations, onto line charts. I think both of these are complementary.

I'm happy to take on the UI work for both of these use cases if you are
fine with that.
Let me know how you envisioned the user experience for adding annotations
and I'm happy to give it shot.

Fabian

On Sat, Sep 23, 2017 at 1:39 PM, Fabian Menges <fmen...@twitter.com> wrote:

> Nice, I'm almost done with my implementation and it looks like our stuff
> is compatible and we haven't done much duplicate work
>
> I didn't really do anything server side, check out my code that add a
> annotation layer to the d3.svg...
>
> https://github.com/apache/incubator-superset/pull/3518/files
>
> Let me know what you think.
>
> On Sat, Sep 23, 2017 at 12:38 PM, Maxime Beauchemin <
> maximebeauche...@gmail.com> wrote:
>
>> Wait up! Grace and I have been working on annotations last week.
>>
>> Here's the backend part I wrote, Grace has code that shows one or many
>> "annotation layers" on the nvd3 time series charts
>>
>> https://github.com/apache/incubator-superset/compare/master.
>> ..mistercrunch:annotations?expand=1
>>
>> Those are time-related annotations, namespaced into arbitrary "layers"
>> stored in the backend. We have plans to support other types of annotation
>> like "point in place" in the future. We're open to collaborate on all
>> that.
>>
>> I like the idea of formulas, curious how you're planning on safely
>> "eval-ing" the formulas too, I'm thinking users should also be able to
>> pick
>> their color and style for that special series.
>>
>> Max
>>
>> On Sep 23, 2017 8:41 AM, "Fabian Menges" <fmen...@twitter.com.invalid>
>> wrote:
>>
>> > Hi everyone,
>> >
>> > Just wanted to give everyone heads up, I'm working on adding Annotations
>> > and Overlays to time series line charts in Superset.
>> >
>> > I'll probably have something done by next week. This is how it will
>> work:
>> >
>> > There are 3 different types of annotations:
>> >
>> >1. Events. Events are a list of dates with descriptions. They will be
>> >displayed as vertical lines. Their description will show up in the
>> > tooltips
>> >if you hover over them. They are fetched from a "table" slice, that
>> >contains the data.
>> >2. Timeseries. Timeseries are are added as an additional line on the
>> >line chart. The name and the display properties can be configured.
>> The
>> > data
>> >is fetched from any timeseries slce.
>> >3. Formulas. Formulas are added as an additional line to the chart.
>> You
>> >will be able to enter a mathematical expression, that will be
>> evaluated
>> > on
>> >the client side using "mathjs". You will be able to specify display
>> >properties. You will be able to specify any mathematical formula e.g
>> >- y = 500  (horizontal line)
>> >   - y = 0.2x (line with inclination of 0.2)
>> >   - y = x^2 (parabola)
>> >
>> > Let me know if you have any concerns or can think of missing features.
>> >
>> >
>> > Fabian
>> >
>>
>
>


Re: Annotations and Overlays

2017-09-23 Thread Fabian Menges
Nice, I'm almost done with my implementation and it looks like our stuff is
compatible and we haven't done much duplicate work

I didn't really do anything server side, check out my code that add a
annotation layer to the d3.svg...

https://github.com/apache/incubator-superset/pull/3518/files

Let me know what you think.

On Sat, Sep 23, 2017 at 12:38 PM, Maxime Beauchemin <
maximebeauche...@gmail.com> wrote:

> Wait up! Grace and I have been working on annotations last week.
>
> Here's the backend part I wrote, Grace has code that shows one or many
> "annotation layers" on the nvd3 time series charts
>
> https://github.com/apache/incubator-superset/compare/
> master...mistercrunch:annotations?expand=1
>
> Those are time-related annotations, namespaced into arbitrary "layers"
> stored in the backend. We have plans to support other types of annotation
> like "point in place" in the future. We're open to collaborate on all that.
>
> I like the idea of formulas, curious how you're planning on safely
> "eval-ing" the formulas too, I'm thinking users should also be able to pick
> their color and style for that special series.
>
> Max
>
> On Sep 23, 2017 8:41 AM, "Fabian Menges" <fmen...@twitter.com.invalid>
> wrote:
>
> > Hi everyone,
> >
> > Just wanted to give everyone heads up, I'm working on adding Annotations
> > and Overlays to time series line charts in Superset.
> >
> > I'll probably have something done by next week. This is how it will work:
> >
> > There are 3 different types of annotations:
> >
> >1. Events. Events are a list of dates with descriptions. They will be
> >displayed as vertical lines. Their description will show up in the
> > tooltips
> >if you hover over them. They are fetched from a "table" slice, that
> >contains the data.
> >2. Timeseries. Timeseries are are added as an additional line on the
> >line chart. The name and the display properties can be configured. The
> > data
> >is fetched from any timeseries slce.
> >3. Formulas. Formulas are added as an additional line to the chart.
> You
> >will be able to enter a mathematical expression, that will be
> evaluated
> > on
> >the client side using "mathjs". You will be able to specify display
> >properties. You will be able to specify any mathematical formula e.g
> >- y = 500  (horizontal line)
> >   - y = 0.2x (line with inclination of 0.2)
> >   - y = x^2 (parabola)
> >
> > Let me know if you have any concerns or can think of missing features.
> >
> >
> > Fabian
> >
>


Re: Annotations and Overlays

2017-09-23 Thread Maxime Beauchemin
Wait up! Grace and I have been working on annotations last week.

Here's the backend part I wrote, Grace has code that shows one or many
"annotation layers" on the nvd3 time series charts

https://github.com/apache/incubator-superset/compare/master...mistercrunch:annotations?expand=1

Those are time-related annotations, namespaced into arbitrary "layers"
stored in the backend. We have plans to support other types of annotation
like "point in place" in the future. We're open to collaborate on all that.

I like the idea of formulas, curious how you're planning on safely
"eval-ing" the formulas too, I'm thinking users should also be able to pick
their color and style for that special series.

Max

On Sep 23, 2017 8:41 AM, "Fabian Menges" <fmen...@twitter.com.invalid>
wrote:

> Hi everyone,
>
> Just wanted to give everyone heads up, I'm working on adding Annotations
> and Overlays to time series line charts in Superset.
>
> I'll probably have something done by next week. This is how it will work:
>
> There are 3 different types of annotations:
>
>1. Events. Events are a list of dates with descriptions. They will be
>displayed as vertical lines. Their description will show up in the
> tooltips
>if you hover over them. They are fetched from a "table" slice, that
>contains the data.
>2. Timeseries. Timeseries are are added as an additional line on the
>line chart. The name and the display properties can be configured. The
> data
>is fetched from any timeseries slce.
>3. Formulas. Formulas are added as an additional line to the chart. You
>will be able to enter a mathematical expression, that will be evaluated
> on
>the client side using "mathjs". You will be able to specify display
>properties. You will be able to specify any mathematical formula e.g
>- y = 500  (horizontal line)
>   - y = 0.2x (line with inclination of 0.2)
>   - y = x^2 (parabola)
>
> Let me know if you have any concerns or can think of missing features.
>
>
> Fabian
>


Annotations and Overlays

2017-09-23 Thread Fabian Menges
Hi everyone,

Just wanted to give everyone heads up, I'm working on adding Annotations
and Overlays to time series line charts in Superset.

I'll probably have something done by next week. This is how it will work:

There are 3 different types of annotations:

   1. Events. Events are a list of dates with descriptions. They will be
   displayed as vertical lines. Their description will show up in the tooltips
   if you hover over them. They are fetched from a "table" slice, that
   contains the data.
   2. Timeseries. Timeseries are are added as an additional line on the
   line chart. The name and the display properties can be configured. The data
   is fetched from any timeseries slce.
   3. Formulas. Formulas are added as an additional line to the chart. You
   will be able to enter a mathematical expression, that will be evaluated on
   the client side using "mathjs". You will be able to specify display
   properties. You will be able to specify any mathematical formula e.g
   - y = 500  (horizontal line)
  - y = 0.2x (line with inclination of 0.2)
  - y = x^2 (parabola)

Let me know if you have any concerns or can think of missing features.


Fabian