Re: Getting ready for 5.4.2
Thank you very much for your help and time, Jochen! On Thu, Apr 6, 2017 at 6:30 AM, Jochen Kemnade wrote: > Should be fixed now. > > > Am 06.04.2017 um 10:50 schrieb Jochen Kemnade: > >> Hi, >> >> Am 06.04.2017 um 04:52 schrieb Thiago H. de Paula Figueiredo: >> >>> The test I've added passes locally but it's failing >>> in Travis. I'll rewrite it a little bit. >>> >> >> It works with jQuery but fails with Prototype. >> >> Jochen >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org >> For additional commands, e-mail: dev-h...@tapestry.apache.org >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > -- Thiago
Re: Getting ready for 5.4.2
Should be fixed now. Am 06.04.2017 um 10:50 schrieb Jochen Kemnade: Hi, Am 06.04.2017 um 04:52 schrieb Thiago H. de Paula Figueiredo: The test I've added passes locally but it's failing in Travis. I'll rewrite it a little bit. It works with jQuery but fails with Prototype. Jochen - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Hi, Am 06.04.2017 um 04:52 schrieb Thiago H. de Paula Figueiredo: The test I've added passes locally but it's failing in Travis. I'll rewrite it a little bit. It works with jQuery but fails with Prototype. Jochen - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Hello, Jochen! dom.getEventUrl fixed (again, a Coffee issue, a missing return statement makes the function return something else) and test added (I had already written it, but somehow it didn't make it to Git). Build failed and I'll take a look tomorrow. The test I've added passes locally but it's failing in Travis. I'll rewrite it a little bit. On Wed, Apr 5, 2017 at 8:39 AM, Jochen Kemnade wrote: > Now, dom.getEventUrl is broken on both branches. > Thiago, can you please add tests? > > - On Apr 4, 2017, at 6:49 PM, Thiago H. de Paula Figueiredo > thiag...@gmail.com wrote: > > > On Tue, Apr 4, 2017 at 9:37 AM, Jochen Kemnade < > jochen.kemn...@eddyson.de> > > wrote: > > > >> Thiago, > >> > > > > Hello, Jochen! > > > > > >> the JavaDoc for PublishEvent is broken, please fix it. > >> https://travis-ci.org/apache/tapestry-5/builds/218065676#L570 > >> https://travis-ci.org/apache/tapestry-5/jobs/217885298#L897 > > > > > > Thanks for noticing it. I've just fixed it in both master and 5.4.2. > > > > Are the Travis builds configured to send e-mails to any Tapestry mailing > > list? I didn't get any e-mails from them. > > - > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > -- Thiago
Re: Getting ready for 5.4.2
Now, dom.getEventUrl is broken on both branches. Thiago, can you please add tests? - On Apr 4, 2017, at 6:49 PM, Thiago H. de Paula Figueiredo thiag...@gmail.com wrote: > On Tue, Apr 4, 2017 at 9:37 AM, Jochen Kemnade > wrote: > >> Thiago, >> > > Hello, Jochen! > > >> the JavaDoc for PublishEvent is broken, please fix it. >> https://travis-ci.org/apache/tapestry-5/builds/218065676#L570 >> https://travis-ci.org/apache/tapestry-5/jobs/217885298#L897 > > > Thanks for noticing it. I've just fixed it in both master and 5.4.2. > > Are the Travis builds configured to send e-mails to any Tapestry mailing > list? I didn't get any e-mails from them. - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Hi, - On Apr 4, 2017, at 6:49 PM, Thiago H. de Paula Figueiredo thiag...@gmail.com wrote: > Are the Travis builds configured to send e-mails to any Tapestry mailing > list? I didn't get any e-mails from them. I tried to configure that [1] but it doesn't work. Apparently, you can only have emails delivered to an address that's registered with both Travis and Github [2]. Jochen [1] https://docs.travis-ci.com/user/notifications/#Configuring-email-notifications [2] https://docs.travis-ci.com/user/notifications/#Missing-build-notifications - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
On Tue, Apr 4, 2017 at 9:37 AM, Jochen Kemnade wrote: > Thiago, > Hello, Jochen! > the JavaDoc for PublishEvent is broken, please fix it. > https://travis-ci.org/apache/tapestry-5/builds/218065676#L570 > https://travis-ci.org/apache/tapestry-5/jobs/217885298#L897 Thanks for noticing it. I've just fixed it in both master and 5.4.2. Are the Travis builds configured to send e-mails to any Tapestry mailing list? I didn't get any e-mails from them.
Re: Getting ready for 5.4.2
There's a typescript gradle plugin https://github.com/sothmann/typescript-gradle-plugin The Tapestry build could use this at build time to convert Typescript to Javascript which is published to maven central. So downstream consumers wouldn't need nodejs installed On 4 Apr 2017 12:13 p.m., "Jochen Kemnade" wrote: > Hi, > > Am 04.04.2017 um 13:05 schrieb Bob Harner: > >> As I understand it the Typescript compiler is written Typescript, which >> can >> be compiled to JavaScript, and then that compiled compiler can be run in >> any compliant JavaScript engine, including Rhino that Tapestry already >> employs as well as the Nashorn engine built into Java 8. >> > > Not if they use Node API, for example for file access etc. But even if > they do that, there are ways to get it to work. You could rely on Node > being available on the PATH and just execute it, which is what > tapestry-react [1] does. > Or you could install a Node distribution on the fly and use that. > > Jochen > > [1] https://github.com/eddyson-de/tapestry-react > > - > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > >
Re: Getting ready for 5.4.2
Thiago,
the JavaDoc for PublishEvent is broken, please fix it.
https://travis-ci.org/apache/tapestry-5/builds/218065676#L570
https://travis-ci.org/apache/tapestry-5/jobs/217885298#L897
Jochen
Am 03.04.2017 um 15:01 schrieb Thiago H. de Paula Figueiredo:
On Mon, Apr 3, 2017 at 3:45 AM, Jochen Kemnade
wrote:
Hi,
Hello!
Am 03.04.2017 um 00:35 schrieb Thiago H. de Paula Figueiredo:
I've investigated and I've found that the place I've added the getEventUrl
function in the Coffee file has caused some weird issues with the way the
JavaScript was output.
Yes, I'd fixed that already in [1].
Thanks! I was working on the 5.4.2 branch first, so I hadn't noticed it and
ended up fixing it in the branch then merged into master.
I'm really not a fan of Coffee.
We can always switch back to JS or use ES6 with Babel. This is what I do
for all of my JS now.
Hmm, I wouldn't consider changing the whole JS codebase from Coffee to
vanilla JS, ES6 or not, a good use of *my* very scarce time for Tapestry.
Of course, if someone wants to do that, I'd love it. :) For my personal
projects, I'd start using TypeScript from now on. ES6 + ES7 + type checking.
I'll probably create another 5.4.2 release/vote next week, if you'd like
to address some of the other issues before then.
+1!
Jochen
[1] https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=b
lobdiff;f=tapestry-core/src/main/preprocessed-coffeescript/
org/apache/tapestry5/t5-core-dom.coffee;h=97b2a0698d1da7194
11c43df4e6768665170fa89;hp=1f07d96e76997574b74fa57c3b88cc290
a9a78a4;hb=589ff43b17f80db1698b1c30257f808588a8f5c8;hpb=ea4d
b57b91fc8153a553f78c7a10b043080d4ce9
On Wed, Mar 29, 2017 at 3:02 AM, Jochen Kemnade <
jochen.kemn...@eddyson.de>
wrote:
Thiago,
do you think you'll find the time to address those issues in the near
future? I'd rather create a new 5.4.2 release than shipping the current
build with known issues.
Jochen
- On Mar 24, 2017, at 1:25 PM, Thiago H. de Paula Figueiredo
thiag...@gmail.com wrote:
On Fri, Mar 24, 2017 at 5:03 AM, Jochen Kemnade <
jochen.kemn...@eddyson.de>
wrote:
Thiago,
Hello!
I've had a look at the new code and here's what I've found so far:
The @PublishEvent JavaDoc is misleading:
It says that the event handler method is "to be called in JavaScript
through the t5/core/triggerServerEvent function", but there is no such
function.
Oh, the annotation was the first thing I've wrote for this ticket and my
idea of what the JS API at the time for this would be. I'll fix this.
An ElementWrapper (e.g. dom.body or dom('#foo')) passed as `element` is
not handled correctly by getEventUrl. You should probably add
if element instanceof ElementWrapper
element = element.element
Good catch! Thanks!
Shouldn't dom.getEventUrl throw or at least warn if it cannot determine
the url for the event, e.g. if you forget to add the @PublishEvent
annotation?
Right now it returns null. Well, another good idea. :) Or maybe we could
leave the say it is and let the caller handle null values and properly
document this
The code I've wrote so far doesn't have automated tests, but the demo
page
is actually a test: notice the Expected and the Value columns. They
should
match for each row.
Did you create 5.4.2 with or without this feature?
Thank you very much!
-
To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
For additional commands, e-mail: dev-h...@tapestry.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
For additional commands, e-mail: dev-h...@tapestry.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Hi, Am 04.04.2017 um 13:05 schrieb Bob Harner: As I understand it the Typescript compiler is written Typescript, which can be compiled to JavaScript, and then that compiled compiler can be run in any compliant JavaScript engine, including Rhino that Tapestry already employs as well as the Nashorn engine built into Java 8. Not if they use Node API, for example for file access etc. But even if they do that, there are ways to get it to work. You could rely on Node being available on the PATH and just execute it, which is what tapestry-react [1] does. Or you could install a Node distribution on the fly and use that. Jochen [1] https://github.com/eddyson-de/tapestry-react - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
As I understand it the Typescript compiler is written Typescript, which can be compiled to JavaScript, and then that compiled compiler can be run in any compliant JavaScript engine, including Rhino that Tapestry already employs as well as the Nashorn engine built into Java 8. So it should be possible. Maybe not easy, but possible. On Apr 3, 2017 5:59 PM, "Thiago H. de Paula Figueiredo" wrote: > > > > Has there been any discussion of integrating TypeScript into Tapestry as > a > > native feature/option? That would be high on my feature wish list. > > > > You mean on-the-fly compilation of TypeScript sources to JS? Hmm, that > would be hard, as the TypeScript compiler, as far as I know, is only > implemented as a Node.js package. There are a couple of Node-inside-the-JVM > projects like http://nodyn.io, but then I don't know how hard it would be > nor how it would perform. Anyway, that's something which would be nice to > have as a org.apache.tapestry5.services.assets.ResourceTransformer. > > > > > > Thanks, > > > > mrg > > > > > > -- > Thiago >
Re: Getting ready for 5.4.2
> > Has there been any discussion of integrating TypeScript into Tapestry as a > native feature/option? That would be high on my feature wish list. > You mean on-the-fly compilation of TypeScript sources to JS? Hmm, that would be hard, as the TypeScript compiler, as far as I know, is only implemented as a Node.js package. There are a couple of Node-inside-the-JVM projects like http://nodyn.io, but then I don't know how hard it would be nor how it would perform. Anyway, that's something which would be nice to have as a org.apache.tapestry5.services.assets.ResourceTransformer. > > Thanks, > > mrg > -- Thiago
Re: Getting ready for 5.4.2
On Mon, Apr 3, 2017 at 9:01 AM, Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: > Hmm, I wouldn't consider changing the whole JS codebase from Coffee to > vanilla JS, ES6 or not, a good use of *my* very scarce time for Tapestry. > Of course, if someone wants to do that, I'd love it. :) For my personal > projects, I'd start using TypeScript from now on. ES6 + ES7 + type > checking. > Has there been any discussion of integrating TypeScript into Tapestry as a native feature/option? That would be high on my feature wish list. Thanks, mrg
Re: Getting ready for 5.4.2
On Mon, Apr 3, 2017 at 3:45 AM, Jochen Kemnade
wrote:
> Hi,
Hello!
> Am 03.04.2017 um 00:35 schrieb Thiago H. de Paula Figueiredo:
>
>> I've investigated and I've found that the place I've added the getEventUrl
>> function in the Coffee file has caused some weird issues with the way the
>> JavaScript was output.
>>
>
> Yes, I'd fixed that already in [1].
Thanks! I was working on the 5.4.2 branch first, so I hadn't noticed it and
ended up fixing it in the branch then merged into master.
> I'm really not a fan of Coffee.
>>
>
> We can always switch back to JS or use ES6 with Babel. This is what I do
> for all of my JS now.
>
Hmm, I wouldn't consider changing the whole JS codebase from Coffee to
vanilla JS, ES6 or not, a good use of *my* very scarce time for Tapestry.
Of course, if someone wants to do that, I'd love it. :) For my personal
projects, I'd start using TypeScript from now on. ES6 + ES7 + type checking.
>
> I'll probably create another 5.4.2 release/vote next week, if you'd like
> to address some of the other issues before then.
>
+1!
>
> Jochen
>
> [1] https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=b
> lobdiff;f=tapestry-core/src/main/preprocessed-coffeescript/
> org/apache/tapestry5/t5-core-dom.coffee;h=97b2a0698d1da7194
> 11c43df4e6768665170fa89;hp=1f07d96e76997574b74fa57c3b88cc290
> a9a78a4;hb=589ff43b17f80db1698b1c30257f808588a8f5c8;hpb=ea4d
> b57b91fc8153a553f78c7a10b043080d4ce9
>
>
>
>> On Wed, Mar 29, 2017 at 3:02 AM, Jochen Kemnade <
>> jochen.kemn...@eddyson.de>
>> wrote:
>>
>> Thiago,
>>>
>>> do you think you'll find the time to address those issues in the near
>>> future? I'd rather create a new 5.4.2 release than shipping the current
>>> build with known issues.
>>>
>>> Jochen
>>>
>>> - On Mar 24, 2017, at 1:25 PM, Thiago H. de Paula Figueiredo
>>> thiag...@gmail.com wrote:
>>>
>>> On Fri, Mar 24, 2017 at 5:03 AM, Jochen Kemnade <
>>> jochen.kemn...@eddyson.de>
>>>
wrote:
Thiago,
>
>
Hello!
I've had a look at the new code and here's what I've found so far:
>
> The @PublishEvent JavaDoc is misleading:
> It says that the event handler method is "to be called in JavaScript
> through the t5/core/triggerServerEvent function", but there is no such
> function.
>
>
Oh, the annotation was the first thing I've wrote for this ticket and my
idea of what the JS API at the time for this would be. I'll fix this.
An ElementWrapper (e.g. dom.body or dom('#foo')) passed as `element` is
> not handled correctly by getEventUrl. You should probably add
> if element instanceof ElementWrapper
> element = element.element
>
>
Good catch! Thanks!
Shouldn't dom.getEventUrl throw or at least warn if it cannot determine
> the url for the event, e.g. if you forget to add the @PublishEvent
> annotation?
>
>
Right now it returns null. Well, another good idea. :) Or maybe we could
leave the say it is and let the caller handle null values and properly
document this
The code I've wrote so far doesn't have automated tests, but the demo
>>> page
>>>
is actually a test: notice the Expected and the Value columns. They
>>> should
>>>
match for each row.
Did you create 5.4.2 with or without this feature?
Thank you very much!
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
>>> For additional commands, e-mail: dev-h...@tapestry.apache.org
>>>
>>>
>>>
>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
> For additional commands, e-mail: dev-h...@tapestry.apache.org
>
>
--
Thiago
Re: Getting ready for 5.4.2
Hi,
Am 03.04.2017 um 00:35 schrieb Thiago H. de Paula Figueiredo:
I've investigated and I've found that the place I've added the getEventUrl
function in the Coffee file has caused some weird issues with the way the
JavaScript was output.
Yes, I'd fixed that already in [1].
I'm really not a fan of Coffee.
We can always switch back to JS or use ES6 with Babel. This is what I do
for all of my JS now.
I'll probably create another 5.4.2 release/vote next week, if you'd like
to address some of the other issues before then.
Jochen
[1]
https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blobdiff;f=tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee;h=97b2a0698d1da719411c43df4e6768665170fa89;hp=1f07d96e76997574b74fa57c3b88cc290a9a78a4;hb=589ff43b17f80db1698b1c30257f808588a8f5c8;hpb=ea4db57b91fc8153a553f78c7a10b043080d4ce9
On Wed, Mar 29, 2017 at 3:02 AM, Jochen Kemnade
wrote:
Thiago,
do you think you'll find the time to address those issues in the near
future? I'd rather create a new 5.4.2 release than shipping the current
build with known issues.
Jochen
- On Mar 24, 2017, at 1:25 PM, Thiago H. de Paula Figueiredo
thiag...@gmail.com wrote:
On Fri, Mar 24, 2017 at 5:03 AM, Jochen Kemnade <
jochen.kemn...@eddyson.de>
wrote:
Thiago,
Hello!
I've had a look at the new code and here's what I've found so far:
The @PublishEvent JavaDoc is misleading:
It says that the event handler method is "to be called in JavaScript
through the t5/core/triggerServerEvent function", but there is no such
function.
Oh, the annotation was the first thing I've wrote for this ticket and my
idea of what the JS API at the time for this would be. I'll fix this.
An ElementWrapper (e.g. dom.body or dom('#foo')) passed as `element` is
not handled correctly by getEventUrl. You should probably add
if element instanceof ElementWrapper
element = element.element
Good catch! Thanks!
Shouldn't dom.getEventUrl throw or at least warn if it cannot determine
the url for the event, e.g. if you forget to add the @PublishEvent
annotation?
Right now it returns null. Well, another good idea. :) Or maybe we could
leave the say it is and let the caller handle null values and properly
document this
The code I've wrote so far doesn't have automated tests, but the demo
page
is actually a test: notice the Expected and the Value columns. They
should
match for each row.
Did you create 5.4.2 with or without this feature?
Thank you very much!
-
To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
For additional commands, e-mail: dev-h...@tapestry.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Hello, Jochen!
I've investigated and I've found that the place I've added the getEventUrl
function in the Coffee file has caused some weird issues with the way the
JavaScript was output. I'm really not a fan of Coffee. But it's now fixed
in the 5.4.x branch and master and at least that tapestry-beanvalidation
test failure isn't happening anymore.
On Wed, Mar 29, 2017 at 3:02 AM, Jochen Kemnade
wrote:
> Thiago,
>
> do you think you'll find the time to address those issues in the near
> future? I'd rather create a new 5.4.2 release than shipping the current
> build with known issues.
>
> Jochen
>
> - On Mar 24, 2017, at 1:25 PM, Thiago H. de Paula Figueiredo
> thiag...@gmail.com wrote:
>
> > On Fri, Mar 24, 2017 at 5:03 AM, Jochen Kemnade <
> jochen.kemn...@eddyson.de>
> > wrote:
> >
> >> Thiago,
> >>
> >
> > Hello!
> >
> >
> >> I've had a look at the new code and here's what I've found so far:
> >>
> >> The @PublishEvent JavaDoc is misleading:
> >> It says that the event handler method is "to be called in JavaScript
> >> through the t5/core/triggerServerEvent function", but there is no such
> >> function.
> >>
> >
> > Oh, the annotation was the first thing I've wrote for this ticket and my
> > idea of what the JS API at the time for this would be. I'll fix this.
> >
> >
> >> An ElementWrapper (e.g. dom.body or dom('#foo')) passed as `element` is
> >> not handled correctly by getEventUrl. You should probably add
> >> if element instanceof ElementWrapper
> >> element = element.element
> >>
> >
> > Good catch! Thanks!
> >
> >
> >> Shouldn't dom.getEventUrl throw or at least warn if it cannot determine
> >> the url for the event, e.g. if you forget to add the @PublishEvent
> >> annotation?
> >>
> >
> > Right now it returns null. Well, another good idea. :) Or maybe we could
> > leave the say it is and let the caller handle null values and properly
> > document this
> >
> > The code I've wrote so far doesn't have automated tests, but the demo
> page
> > is actually a test: notice the Expected and the Value columns. They
> should
> > match for each row.
> >
> > Did you create 5.4.2 with or without this feature?
> >
> > Thank you very much!
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
> For additional commands, e-mail: dev-h...@tapestry.apache.org
>
>
--
Thiago
Re: Getting ready for 5.4.2
Thiago,
do you think you'll find the time to address those issues in the near future?
I'd rather create a new 5.4.2 release than shipping the current build with
known issues.
Jochen
- On Mar 24, 2017, at 1:25 PM, Thiago H. de Paula Figueiredo
thiag...@gmail.com wrote:
> On Fri, Mar 24, 2017 at 5:03 AM, Jochen Kemnade
> wrote:
>
>> Thiago,
>>
>
> Hello!
>
>
>> I've had a look at the new code and here's what I've found so far:
>>
>> The @PublishEvent JavaDoc is misleading:
>> It says that the event handler method is "to be called in JavaScript
>> through the t5/core/triggerServerEvent function", but there is no such
>> function.
>>
>
> Oh, the annotation was the first thing I've wrote for this ticket and my
> idea of what the JS API at the time for this would be. I'll fix this.
>
>
>> An ElementWrapper (e.g. dom.body or dom('#foo')) passed as `element` is
>> not handled correctly by getEventUrl. You should probably add
>> if element instanceof ElementWrapper
>> element = element.element
>>
>
> Good catch! Thanks!
>
>
>> Shouldn't dom.getEventUrl throw or at least warn if it cannot determine
>> the url for the event, e.g. if you forget to add the @PublishEvent
>> annotation?
>>
>
> Right now it returns null. Well, another good idea. :) Or maybe we could
> leave the say it is and let the caller handle null values and properly
> document this
>
> The code I've wrote so far doesn't have automated tests, but the demo page
> is actually a test: notice the Expected and the Value columns. They should
> match for each row.
>
> Did you create 5.4.2 with or without this feature?
>
> Thank you very much!
-
To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Hi, - On Mar 24, 2017, at 1:25 PM, Thiago H. de Paula Figueiredo thiag...@gmail.com wrote: >> Shouldn't dom.getEventUrl throw or at least warn if it cannot determine >> the url for the event, e.g. if you forget to add the @PublishEvent >> annotation? >> > > Right now it returns null. Well, another good idea. :) Or maybe we could > leave the say it is and let the caller handle null values and properly > document this I think it is an error case and it should throw or warn. I usually try to adhere to the convention that if methods are named get*, it is an error if there is nothing to get, as opposed to find*. > The code I've wrote so far doesn't have automated tests, but the demo page > is actually a test: notice the Expected and the Value columns. They should > match for each row. I'd appreciate if you added some tests. > Did you create 5.4.2 with or without this feature? 5.4.2 includes the feature in its current state. Cheers, Jochen - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
On Fri, Mar 24, 2017 at 5:03 AM, Jochen Kemnade
wrote:
> Thiago,
>
Hello!
> I've had a look at the new code and here's what I've found so far:
>
> The @PublishEvent JavaDoc is misleading:
> It says that the event handler method is "to be called in JavaScript
> through the t5/core/triggerServerEvent function", but there is no such
> function.
>
Oh, the annotation was the first thing I've wrote for this ticket and my
idea of what the JS API at the time for this would be. I'll fix this.
> An ElementWrapper (e.g. dom.body or dom('#foo')) passed as `element` is
> not handled correctly by getEventUrl. You should probably add
> if element instanceof ElementWrapper
> element = element.element
>
Good catch! Thanks!
> Shouldn't dom.getEventUrl throw or at least warn if it cannot determine
> the url for the event, e.g. if you forget to add the @PublishEvent
> annotation?
>
Right now it returns null. Well, another good idea. :) Or maybe we could
leave the say it is and let the caller handle null values and properly
document this
The code I've wrote so far doesn't have automated tests, but the demo page
is actually a test: notice the Expected and the Value columns. They should
match for each row.
Did you create 5.4.2 with or without this feature?
Thank you very much!
Re: Getting ready for 5.4.2
Btw.: Are there any tests for the new feature or just the demo page?
- On Mar 24, 2017, at 9:03 AM, Jochen Kemnade jochen.kemn...@eddyson.de
wrote:
> Thiago,
>
> I've had a look at the new code and here's what I've found so far:
>
> The @PublishEvent JavaDoc is misleading:
> It says that the event handler method is "to be called in JavaScript through
> the
> t5/core/triggerServerEvent function", but there is no such function.
>
> An ElementWrapper (e.g. dom.body or dom('#foo')) passed as `element` is not
> handled correctly by getEventUrl. You should probably add
> if element instanceof ElementWrapper
> element = element.element
>
> Shouldn't dom.getEventUrl throw or at least warn if it cannot determine the
> url
> for the event, e.g. if you forget to add the @PublishEvent annotation?
>
> Jochen
-
To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Thiago,
I've had a look at the new code and here's what I've found so far:
The @PublishEvent JavaDoc is misleading:
It says that the event handler method is "to be called in JavaScript through
the t5/core/triggerServerEvent function", but there is no such function.
An ElementWrapper (e.g. dom.body or dom('#foo')) passed as `element` is not
handled correctly by getEventUrl. You should probably add
if element instanceof ElementWrapper
element = element.element
Shouldn't dom.getEventUrl throw or at least warn if it cannot determine the url
for the event, e.g. if you forget to add the @PublishEvent annotation?
Jochen
-
To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Hello, Jochen! I'll try to take a look and fix them before the weekend. If not, feel free to revert it in the 5.4.x branch. On Mon, Mar 20, 2017 at 9:52 AM, Jochen Kemnade wrote: > Hi, > > Am 20.03.2017 um 09:53 schrieb Jochen Kemnade: > >> Am 19.03.2017 um 21:59 schrieb Thiago H. de Paula Figueiredo: >> >>> https://issues.apache.org/jira/browse/TAP5-2225 finished and committed >>> to >>> both 5.4.2 and 5.5 (master). Feedback welcome! >>> >> >> ./gradlew tapestry-beanvalidator:test --tests >> org.apache.tapestry5.beanvalidator.integration.TapestryBeanV >> alidationIntegrationTests.nested_object_validation >> > > tapestry-core:testWithPrototype also fails. > > I'd like to get 5.4.2 by this weekend. Thiago, can you please fix or > revert TAP5-2225 in the 5.4.x branch? > > Thanks, > Jochen > > > >> >> >> fails with a client-side error: dom.wrap(id).trigger is not a function >> >> >>> On Wed, Mar 8, 2017 at 11:45 AM, Thiago H. de Paula Figueiredo < >>> thiag...@gmail.com> wrote: >>> >>> I've started https://issues.apache.org/jira/browse/TAP5-2225 but I haven't finished yet. I was planning to work on this next week's weekend. Jochen, if you want to go ahead, I can make another release later. Also, thank you very, very much for taking TAP5-2575. :) On Wed, Mar 8, 2017 at 7:45 AM, Jochen Kemnade wrote: Hi, > > due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to > address that issue. > Is there anything we want to pick from master? Or anything else we want > to include? > > Jochen > > - > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > > -- Thiago >>> >>> >>> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org >> For additional commands, e-mail: dev-h...@tapestry.apache.org >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > -- Thiago
Re: Getting ready for 5.4.2
Hi, Am 20.03.2017 um 09:53 schrieb Jochen Kemnade: Am 19.03.2017 um 21:59 schrieb Thiago H. de Paula Figueiredo: https://issues.apache.org/jira/browse/TAP5-2225 finished and committed to both 5.4.2 and 5.5 (master). Feedback welcome! ./gradlew tapestry-beanvalidator:test --tests org.apache.tapestry5.beanvalidator.integration.TapestryBeanValidationIntegrationTests.nested_object_validation tapestry-core:testWithPrototype also fails. I'd like to get 5.4.2 by this weekend. Thiago, can you please fix or revert TAP5-2225 in the 5.4.x branch? Thanks, Jochen fails with a client-side error: dom.wrap(id).trigger is not a function On Wed, Mar 8, 2017 at 11:45 AM, Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: I've started https://issues.apache.org/jira/browse/TAP5-2225 but I haven't finished yet. I was planning to work on this next week's weekend. Jochen, if you want to go ahead, I can make another release later. Also, thank you very, very much for taking TAP5-2575. :) On Wed, Mar 8, 2017 at 7:45 AM, Jochen Kemnade wrote: Hi, due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to address that issue. Is there anything we want to pick from master? Or anything else we want to include? Jochen - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org -- Thiago - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Am 19.03.2017 um 21:59 schrieb Thiago H. de Paula Figueiredo: https://issues.apache.org/jira/browse/TAP5-2225 finished and committed to both 5.4.2 and 5.5 (master). Feedback welcome! ./gradlew tapestry-beanvalidator:test --tests org.apache.tapestry5.beanvalidator.integration.TapestryBeanValidationIntegrationTests.nested_object_validation fails with a client-side error: dom.wrap(id).trigger is not a function On Wed, Mar 8, 2017 at 11:45 AM, Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: I've started https://issues.apache.org/jira/browse/TAP5-2225 but I haven't finished yet. I was planning to work on this next week's weekend. Jochen, if you want to go ahead, I can make another release later. Also, thank you very, very much for taking TAP5-2575. :) On Wed, Mar 8, 2017 at 7:45 AM, Jochen Kemnade wrote: Hi, due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to address that issue. Is there anything we want to pick from master? Or anything else we want to include? Jochen - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org -- Thiago - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
Great. I just merged the tapestry-json changes into the 5.4.x branch. I'll probably start a vote tomorrow. Am 19.03.2017 um 21:59 schrieb Thiago H. de Paula Figueiredo: https://issues.apache.org/jira/browse/TAP5-2225 finished and committed to both 5.4.2 and 5.5 (master). Feedback welcome! On Wed, Mar 8, 2017 at 11:45 AM, Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: I've started https://issues.apache.org/jira/browse/TAP5-2225 but I haven't finished yet. I was planning to work on this next week's weekend. Jochen, if you want to go ahead, I can make another release later. Also, thank you very, very much for taking TAP5-2575. :) On Wed, Mar 8, 2017 at 7:45 AM, Jochen Kemnade wrote: Hi, due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to address that issue. Is there anything we want to pick from master? Or anything else we want to include? Jochen - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org -- Thiago - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
https://issues.apache.org/jira/browse/TAP5-2225 finished and committed to both 5.4.2 and 5.5 (master). Feedback welcome! On Wed, Mar 8, 2017 at 11:45 AM, Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: > I've started https://issues.apache.org/jira/browse/TAP5-2225 but I > haven't finished yet. I was planning to work on this next week's weekend. > Jochen, if you want to go ahead, I can make another release later. Also, > thank you very, very much for taking TAP5-2575. :) > > On Wed, Mar 8, 2017 at 7:45 AM, Jochen Kemnade > wrote: > >> Hi, >> >> due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to >> address that issue. >> Is there anything we want to pick from master? Or anything else we want >> to include? >> >> Jochen >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org >> For additional commands, e-mail: dev-h...@tapestry.apache.org >> >> > > > -- > Thiago > -- Thiago
Re: Getting ready for 5.4.2
Hi, Am 08.03.2017 um 15:45 schrieb Thiago H. de Paula Figueiredo: I've started https://issues.apache.org/jira/browse/TAP5-2225 but I haven't finished yet. I was planning to work on this next week's weekend. Jochen, if you want to go ahead, I can make another release later. You want to do that for 5.4.x? Well, take your time. I'd like to call the vote over the 5.4.2 release by the end of March. > Also, thank you very, very much for taking TAP5-2575. :) I pushed the code to master for inspection. I'll probably merge it into 5.4.x in about 2 weeks if nobody objects. Jochen - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
Re: Getting ready for 5.4.2
I've started https://issues.apache.org/jira/browse/TAP5-2225 but I haven't finished yet. I was planning to work on this next week's weekend. Jochen, if you want to go ahead, I can make another release later. Also, thank you very, very much for taking TAP5-2575. :) On Wed, Mar 8, 2017 at 7:45 AM, Jochen Kemnade wrote: > Hi, > > due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to > address that issue. > Is there anything we want to pick from master? Or anything else we want to > include? > > Jochen > > - > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > -- Thiago
Re: Getting ready for 5.4.2
That blocker maybe? https://issues.apache.org/jira/browse/TAP5-2391 The last comment makes it seem as if the fix would be a simple one-liner. > Am 08.03.2017 um 11:45 schrieb Jochen Kemnade : > > Hi, > > due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to > address that issue. > Is there anything we want to pick from master? Or anything else we want to > include? > > Jochen > > - > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
