[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734788#comment-16734788 ] James E. King III commented on THRIFT-4654: --- Any chance someone could finish this work? It seems like it's close to complete. > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695907#comment-16695907 ] ASF GitHub Bot commented on THRIFT-4654: jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-441031973 Reminder: this needs more work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676903#comment-16676903 ] ASF GitHub Bot commented on THRIFT-4654: robbecker-wf commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-436294530 Oh, yes `.dart_tool` should be ignored. Thanks for adding that! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676809#comment-16676809 ] ASF GitHub Bot commented on THRIFT-4654: jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-436266285 I am going to commit some changes to master to fix the sca build job. It doesn't affect dart anyway so we can ignore it. I noticed when I "make precross" locally I see: ``` jking@ubuntu:~/thrift$ git status On branch dart2 Your branch is up to date with 'robbecker/dart2'. Untracked files: (use "git add ..." to include in what will be committed) lib/dart/.dart_tool/ test/dart/test_client/.dart_tool/ ``` It looks like we need to exclude `**/.dart_tool` in `.gitignore`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676767#comment-16676767 ] ASF GitHub Bot commented on THRIFT-4654: jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-436252451 Looks like flake8 was updated but the docker build image hasn't been regenerated since. Working on this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1443#comment-1443 ] ASF GitHub Bot commented on THRIFT-4654: jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-433715742 Looks like you need to rebase your changes on the tip. If you are getting flake8 issues in the build you must have branched off some other point where those issues existed. Current builds are running clean (with some retries, admittedly). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663056#comment-16663056 ] ASF GitHub Bot commented on THRIFT-4654: jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-432874489 ``` Because tutorial_client requires SDK version >=1.13.0 <2.0.0, version solving failed. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659776#comment-16659776 ] ASF GitHub Bot commented on THRIFT-4654: jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-432016870 ``` make -C dart precross make[2]: Entering directory '/thrift/src/test/dart' /thrift/src/compiler/cpp/thrift --gen dart ../ThriftTest.thrift [WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator named 'noexist' could be found! [WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator does not accept 'noexist' as sub-namespace! cd gen-dart/thrift_test; /usr/lib/dart/bin/pub get [[7m [27m[90m[0m] \ loadDep:ws: [7msill[0m [35minstall[0m loadAllDepsIntoIdealTree[0m[K [[7m[27m[90m..[0m] \ loadDep:wordwrap: [7msill[0m [35minstall[0m loadAllDepsIntoIdealTree[0m[K [[7m[27m[90m..[0m] \ loadDep:underscore: [7msill[0m [35minstall[0m loadAllDepsIntoIdealTre[0m[K [[7m [27m[90m.[0m] \ loadDep:xtend: [7msill[0m [35minstall[0m loadAllDepsIntoIdealTree[0m[K [[7m [27m[90m.[0m] \ loadDep:strip-json-comments: [7msill[0m [35minstall[0m loadAllDepsInt[0m[K [[7m [27m[90m...[0m] | diffTrees: [7msill[0m [35minstall[0m generateActionsToTake[0m[K Resolving dependencies... [[7m [27m[90m...[0m] - postinstall: [7msill[0m [35minstall[0m executeActions[0m[K The current Dart SDK version is 2.0.0. Because thrift_test requires SDK version ^1.12.0, version solving failed. Makefile:626: recipe for target 'pub-get-gen' failed make[2]: *** [pub-get-gen] Error 1 make[2]: Leaving directory '/thrift/src/test/dart' Makefile:911: recipe for target 'precross-dart' failed make[1]: *** [precross-dart] Error 2 make[1]: Leaving directory '/thrift/src/test' Makefile:1094: recipe for target 'precross-test' failed make: *** [precross-test] Error 2 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659775#comment-16659775 ] ASF GitHub Bot commented on THRIFT-4654: jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-432016629 Need to investigate the build failures. I will rekick things that are environmental. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659758#comment-16659758 ] ASF GitHub Bot commented on THRIFT-4654: robbecker-wf commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-432010016 @jeking3 What's the next step? If we're ready to merge, do I need to squash commits? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659553#comment-16659553 ] ASF GitHub Bot commented on THRIFT-4654: ericklaus-wf commented on a change in pull request #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#discussion_r227045903 ## File path: lib/dart/pubspec.yaml ## @@ -24,20 +24,15 @@ homepage: http://thrift.apache.org documentation: http://thrift.apache.org environment: - sdk: ">=1.13.0 <2.0.0" + sdk: '>=1.24.3<3.0.0' Review comment: It doesn't matter to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659463#comment-16659463 ] ASF GitHub Bot commented on THRIFT-4654: robbecker-wf commented on a change in pull request #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#discussion_r227016468 ## File path: lib/dart/pubspec.yaml ## @@ -24,20 +24,15 @@ homepage: http://thrift.apache.org documentation: http://thrift.apache.org environment: - sdk: ">=1.13.0 <2.0.0" + sdk: '>=1.24.3<3.0.0' Review comment: They are both valid, so I'm not super concerned but if you'd like I can add a space. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659447#comment-16659447 ] ASF GitHub Bot commented on THRIFT-4654: robbecker-wf removed a comment on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-431730444 Hey, thanks for updating the dockerfiles @jeking3 ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659437#comment-16659437 ] ASF GitHub Bot commented on THRIFT-4654: ericklaus-wf commented on a change in pull request #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#discussion_r227007049 ## File path: lib/dart/pubspec.yaml ## @@ -24,20 +24,15 @@ homepage: http://thrift.apache.org documentation: http://thrift.apache.org environment: - sdk: ">=1.13.0 <2.0.0" + sdk: '>=1.24.3<3.0.0' Review comment: For consistency, should there be a space between the two version constraints? (3<3 becomes 3 <3) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658525#comment-16658525 ] ASF GitHub Bot commented on THRIFT-4654: robbecker-wf commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-431735159 Thanks for updating the dockerfiles @jeking3 ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658489#comment-16658489 ] ASF GitHub Bot commented on THRIFT-4654: robbecker-wf commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-431730444 Hey, thanks for updating the dockerfiles @jeking3 ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657850#comment-16657850 ] ASF GitHub Bot commented on THRIFT-4654: jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-431577806 Yes, sometimes the CI builds fail for other reasons. I usually come back around and kick failed jobs that look like that. At time permits we try to resolve these issues, but some of them have been pretty difficult to nail down (like the sbcl issue). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657842#comment-16657842 ] James E. King III commented on THRIFT-4654: --- Oh, I didn't see the pull request. I'll reopen and dupe THRIFT-4599 to this. > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Assignee: James E. King III >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657020#comment-16657020 ] ASF GitHub Bot commented on THRIFT-4654: robbecker-wf commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-431419263 Maybe @chadknight-wf or @ericklaus-wf can review? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657018#comment-16657018 ] ASF GitHub Bot commented on THRIFT-4654: robbecker-wf commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617#issuecomment-431418809 I don't think those CI failures are related to these Dart changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656836#comment-16656836 ] ASF GitHub Bot commented on THRIFT-4654: robbecker-wf opened a new pull request #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible) URL: https://github.com/apache/thrift/pull/1617 # Overview Make the minimal changes needed to make the dart code compatible with Dart 2 while being backwards compatible with Dart 1. This fixes https://issues.apache.org/jira/browse/THRIFT-4654 # Changes - Specify the Dart SDK range in the pubspec.yaml file to allow Dart 1 & 2. NOTE: This does up the minimum from 1.13.0 to 1.24.3 but I don't believe anyone is using that old of a Dart. - Use the dart2_constant package to adjust constant usage from all caps constant names to camel case constant names. # Testing - [ ] Install dependencies under Dart 1 and Dart 2 by running `pub get` - [ ] Verify the tests pass by running `pub run test` under Dart 1 and 2 (I did this locally) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Thrift Dart port is not compatible with Dart 2 > -- > > Key: THRIFT-4654 > URL: https://issues.apache.org/jira/browse/THRIFT-4654 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library > Environment: Any OS, under Dart 2+ >Reporter: Rob Becker >Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires > opting in via a setting in the pubspec.yaml and the code needs to update the > use of all caps constant names to the new camel case names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
