Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Robert Dale
Looks good! Robert Dale On Tue, Sep 26, 2017 at 1:38 PM, Daniel Kuppitz wrote: > Yea, that was the right regex to look for these errors: grep '^== $' > $(find . -name "*.asciidoc") > Got them all now, will push the fix in a few. > > Cheers, > Daniel > > > On Tue, Sep 26,

[jira] [Commented] (TINKERPOP-1786) Recipe and missing manifest items for Spark on Yarn

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181447#comment-16181447 ] ASF GitHub Bot commented on TINKERPOP-1786: --- Github user vtslab commented on the issue:

[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...

2017-09-26 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Could I assume a pseudo-hadoop cluster present during the integration test phase? I thought only the asciidoc processing had that. Anyway, breaking the spark-yarn option will be noticed through

[jira] [Created] (TINKERPOP-1793) addE() should allow dynamic edge labels

2017-09-26 Thread Daniel Kuppitz (JIRA)
Daniel Kuppitz created TINKERPOP-1793: - Summary: addE() should allow dynamic edge labels Key: TINKERPOP-1793 URL: https://issues.apache.org/jira/browse/TINKERPOP-1793 Project: TinkerPop

[jira] [Commented] (TINKERPOP-1789) Reference elements should be represented by id and label

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181720#comment-16181720 ] ASF GitHub Bot commented on TINKERPOP-1789: --- Github user dkuppitz commented on the issue:

[jira] [Commented] (TINKERPOP-1792) Random TraversalSource Selection in GremlinScriptEngine

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181763#comment-16181763 ] ASF GitHub Bot commented on TINKERPOP-1792: --- GitHub user spmallette opened a pull request:

[GitHub] tinkerpop pull request #723: TINKERPOP-1792 Fixed GremlinScriptEngine bug in...

2017-09-26 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/723 TINKERPOP-1792 Fixed GremlinScriptEngine bug in lambda processing https://issues.apache.org/jira/browse/TINKERPOP-1792 GremlinScriptEngine instances should now properly select the

[jira] [Commented] (TINKERPOP-1782) RangeByIsCountStrategy doesn't handle floating point numbers properly

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180986#comment-16180986 ] ASF GitHub Bot commented on TINKERPOP-1782: --- Github user okram commented on the issue:

[GitHub] tinkerpop issue #714: TINKERPOP-1782 RangeByIsCountStrategy doesn't handle f...

2017-09-26 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/714 VOTE +1 ---

[GitHub] tinkerpop pull request #712: TINKERPOP-1752: Gremlin.Net: Generate completel...

2017-09-26 Thread FlorianHockmann
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/712#discussion_r141104538 --- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs --- @@ -79,7 +85,77 @@ public void AddSource(string sourceName, params

[jira] [Commented] (TINKERPOP-1752) Gremlin.Net: Generate completely type-safe methods

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181006#comment-16181006 ] ASF GitHub Bot commented on TINKERPOP-1752: --- Github user FlorianHockmann commented on a diff

[jira] [Commented] (TINKERPOP-1789) Reference elements should be represented by id and label

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181193#comment-16181193 ] ASF GitHub Bot commented on TINKERPOP-1789: --- Github user dkuppitz commented on the issue:

[GitHub] tinkerpop pull request #712: TINKERPOP-1752: Gremlin.Net: Generate completel...

2017-09-26 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/712#discussion_r141109744 --- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs --- @@ -79,7 +85,77 @@ public void AddSource(string sourceName, params object[]

[jira] [Commented] (TINKERPOP-1752) Gremlin.Net: Generate completely type-safe methods

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181087#comment-16181087 ] ASF GitHub Bot commented on TINKERPOP-1752: --- Github user spmallette commented on a diff in

Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Robert Dale
^d Robert Dale On Tue, Sep 26, 2017 at 12:56 PM, Daniel Kuppitz wrote: > This is one. I pushed the changes to tp32/ and master/. I only found (and > fixed) 2 minor issues, where my script produced a little formatting mess. > > Cheers, > Daniel > > > On Tue, Sep 19, 2017 at

[jira] [Closed] (TINKERPOP-1782) RangeByIsCountStrategy doesn't handle floating point numbers properly

2017-09-26 Thread Daniel Kuppitz (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kuppitz closed TINKERPOP-1782. - Resolution: Fixed Fix Version/s: 3.3.1 3.2.7 >

Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Robert Dale
Looks like master CHANGELOG picked up a conflict... <<< HEAD == TinkerPop 3.3.0 (Gremlin Symphony #40 in G Minor) . . . == TinkerPop 3.2.0 (Nine Inch Gremlins) === == TinkerPop 3.2.0 (Nine Inch Gremlins) >>> asciidoc-header Robert Dale On Tue, Sep 26, 2017 at 1:19 PM, Daniel

[GitHub] tinkerpop issue #720: TINKERPOP-1789: Reference elements should be represent...

2017-09-26 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/720 VOTE: +0.5 Will add the other 0.5 once `docker/build.sh -t -i -n` reports success (currently running on my machine; just in case somebody else was planning to do it). ---

[GitHub] tinkerpop pull request #714: TINKERPOP-1782 RangeByIsCountStrategy doesn't h...

2017-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/714 ---

[jira] [Commented] (TINKERPOP-1782) RangeByIsCountStrategy doesn't handle floating point numbers properly

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181189#comment-16181189 ] ASF GitHub Bot commented on TINKERPOP-1782: --- Github user asfgit closed the pull request at:

Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Daniel Kuppitz
This is one. I pushed the changes to tp32/ and master/. I only found (and fixed) 2 minor issues, where my script produced a little formatting mess. Cheers, Daniel On Tue, Sep 19, 2017 at 9:23 AM, Stephen Mallette wrote: > For whatever reason we started writing our

Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Robert Dale
I see things like '== ==>6' in docs/src/upgrade/release-3.2.x-incubating.html Robert Dale On Tue, Sep 26, 2017 at 12:57 PM, Robert Dale wrote: > ^d > > Robert Dale > > On Tue, Sep 26, 2017 at 12:56 PM, Daniel Kuppitz wrote: > >> This is one. I pushed the

Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Robert Dale
docs/src/reference/gremlin-applications.asciidoc: @@ -294,8 +288,7 @@ v[2] v[3] v[4] v[5] -v[6] - +== v[6] It is also possible to pass arguments to scripts. Any parameters following the file name specification are treated as arguments to the script. They are collected into a list and

Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Robert Dale
That was master. tp32 is: @@ -278,8 +272,7 @@ v[2] v[3] v[4] v[5] -v[6] - +== v[6] It is also possible to pass arguments to scripts. Any parameters following the file name specification are treated as arguments to the script. They are collected into a list and passed in as a variable

[jira] [Commented] (TINKERPOP-1752) Gremlin.Net: Generate completely type-safe methods

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181064#comment-16181064 ] ASF GitHub Bot commented on TINKERPOP-1752: --- Github user jorgebay commented on a diff in the

[GitHub] tinkerpop pull request #712: TINKERPOP-1752: Gremlin.Net: Generate completel...

2017-09-26 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/712#discussion_r141112905 --- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs --- @@ -79,7 +85,77 @@ public void AddSource(string sourceName, params object[]

Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Robert Dale
git grep "== ==" Robert Dale On Tue, Sep 26, 2017 at 1:07 PM, Robert Dale wrote: > I see things like '== ==>6' in docs/src/upgrade/release-3.2. > x-incubating.html > > Robert Dale > > On Tue, Sep 26, 2017 at 12:57 PM, Robert Dale wrote: > >> ^d >> >>

Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Daniel Kuppitz
Ah, good find! That's the same issue I've had in the reference docs and recipes. Fixed. Cheers, Daniel On Tue, Sep 26, 2017 at 10:08 AM, Robert Dale wrote: > git grep "== ==" > > Robert Dale > > On Tue, Sep 26, 2017 at 1:07 PM, Robert Dale wrote: > > > I

Re: [DISCUSS] Asciidoc Header Reformat

2017-09-26 Thread Daniel Kuppitz
Yea, that was the right regex to look for these errors: grep '^== $' $(find . -name "*.asciidoc") Got them all now, will push the fix in a few. Cheers, Daniel On Tue, Sep 26, 2017 at 10:30 AM, Robert Dale wrote: > docs/src/reference/gremlin-applications.asciidoc: > @@