[Bug 55442] EL Constructor throws exception

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55442 --- Comment #1 from Violeta Georgieva violet...@apache.org --- According to the specification 1.5.2 Evaluating functions The expression with the syntax func(args...)(args...)... can mean any of the following. ... - A call to the

svn commit: r1515744 - in /tomcat/trunk: java/org/apache/el/parser/AstFunction.java test/org/apache/el/parser/TestAstFunction.java

2013-08-20 Thread violetagg
Author: violetagg Date: Tue Aug 20 08:38:29 2013 New Revision: 1515744 URL: http://svn.apache.org/r1515744 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55442 Handle calls to a constructor of an imported class or to a static method, imported statically. Unit test based on a patch

[Bug 55442] EL Constructor throws exception

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55442 Violeta Georgieva violet...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 55454] New: NullPointerException caused by invalid contentType, e.g. trailing semicolon

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55454 Bug ID: 55454 Summary: NullPointerException caused by invalid contentType, e.g. trailing semicolon Product: Tomcat 7 Version: 7.0.42 Hardware: PC Status:

Re: Back-porting JSR-356 Progress update

2013-08-20 Thread Mark Thomas
On 20/08/2013 06:35, Rainer Jung wrote: On 19.08.2013 15:22, Mark Thomas wrote: I plan to commit what I have so far once I am happy that the unit tests still work. I do want to look at removing the Java 7 dependency from the WebSocket implementation - at least for Tomcat 7 - but I don't

svn commit: r1515761 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread markt
Author: markt Date: Tue Aug 20 10:23:23 2013 New Revision: 1515761 URL: http://svn.apache.org/r1515761 Log: Reduce a potential timing sensitivity Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java Modified:

svn commit: r1515778 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread markt
Author: markt Date: Tue Aug 20 11:13:33 2013 New Revision: 1515778 URL: http://svn.apache.org/r1515778 Log: Further reduce a potential timing sensitivity Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java Modified:

svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread markt
Author: markt Date: Tue Aug 20 11:14:39 2013 New Revision: 1515779 URL: http://svn.apache.org/r1515779 Log: Add the rather crucial missing i++ in the wait loop Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

2013-08-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4855 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 55454] NullPointerException caused by invalid contentType, e.g. trailing semicolon

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55454 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

buildbot success in ASF Buildbot on tomcat-trunk

2013-08-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4856 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 6:14 AM, ma...@apache.org wrote: Author: markt Date: Tue Aug 20 11:14:39 2013 New Revision: 1515779 URL: http://svn.apache.org/r1515779 Log: Add the rather crucial missing i++ in the wait loop Lol. Don't you hate when you do that?

Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread Mark Thomas
On 20/08/2013 13:45, Nick Williams wrote: On Aug 20, 2013, at 6:14 AM, ma...@apache.org wrote: Author: markt Date: Tue Aug 20 11:14:39 2013 New Revision: 1515779 URL: http://svn.apache.org/r1515779 Log: Add the rather crucial missing i++ in the wait loop Lol. Don't you hate when you

Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 7:59 AM, Mark Thomas wrote: On 20/08/2013 13:45, Nick Williams wrote: On Aug 20, 2013, at 6:14 AM, ma...@apache.org wrote: Author: markt Date: Tue Aug 20 11:14:39 2013 New Revision: 1515779 URL: http://svn.apache.org/r1515779 Log: Add the rather crucial missing

Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never gotten all the existing tests to pass on my machine. Last time I ran them it

svn commit: r1515817 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/websocket/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http

2013-08-20 Thread markt
Author: markt Date: Tue Aug 20 13:14:48 2013 New Revision: 1515817 URL: http://svn.apache.org/r1515817 Log: Deprecate the Tomcat 7 proprietary WebSocket API Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Request.java

buildbot exception in ASF Buildbot on tomcat-7-trunk

2013-08-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1350 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Mark Thomas
On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never gotten all the existing tests to

[Bug 55454] NullPointerException caused by invalid contentType, e.g. trailing semicolon

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55454 Violeta Georgieva violet...@apache.org changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Violeta Georgieva
2013/8/20 Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never gotten all the existing tests to pass on my

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Brian Burch
On 20/08/13 14:32, Violeta Georgieva wrote: 2013/8/20 Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never

[Bug 55454] NullPointerException caused by invalid contentType, e.g. trailing semicolon

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55454 --- Comment #3 from Violeta Georgieva violet...@apache.org --- What about if we do a change like this? --- org/apache/tomcat/util/http/parser/HttpParser.java(revision 1515761) +++ org/apache/tomcat/util/http/parser/HttpParser.java

Re: buildbot exception in ASF Buildbot on tomcat-7-trunk

2013-08-20 Thread Mark Thomas
On 20/08/2013 14:20, build...@apache.org wrote: The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1350 Buildbot URL: http://ci.apache.org/ Buildslave for this

[Bug 55454] NullPointerException caused by invalid contentType, e.g. trailing semicolon

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55454 --- Comment #4 from Mark Thomas ma...@apache.org --- Works for me. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

svn commit: r1515827 - in /tomcat/trunk/java/org/apache: jasper/JspCompilationContext.java tomcat/util/descriptor/tld/TldRuleSet.java

2013-08-20 Thread markt
Author: markt Date: Tue Aug 20 14:03:27 2013 New Revision: 1515827 URL: http://svn.apache.org/r1515827 Log: Fix a couple of Eclipse warnings Modified: tomcat/trunk/java/org/apache/jasper/JspCompilationContext.java tomcat/trunk/java/org/apache/tomcat/util/descriptor/tld/TldRuleSet.java

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 8:25 AM, Mark Thomas wrote: On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance:

svn commit: r1515841 - in /tomcat/trunk: java/org/apache/tomcat/util/http/parser/HttpParser.java test/org/apache/tomcat/util/http/parser/TestMediaType.java

2013-08-20 Thread violetagg
Author: violetagg Date: Tue Aug 20 15:02:23 2013 New Revision: 1515841 URL: http://svn.apache.org/r1515841 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55454 Fixed NPE thrown when parsing an invalid content type. Modified:

[Bug 55453] AJP send Body with Status 304

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55453 --- Comment #1 from Christopher Schultz ch...@christopherschultz.net --- So you are saying that AbstractAjpProcessor.prepareResponse needs to have similar logic? Under what conditions is a 304 response being sent along with a body? Is this

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Mark, On 8/20/13 9:25 AM, Mark Thomas wrote: On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1)

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 10:12 AM, Christopher Schultz wrote: Mark, On 8/20/13 9:25 AM, Mark Thomas wrote: On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it

[Bug 55453] AJP send Body with Status 304

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55453 --- Comment #2 from Dieter Paradeiser dieter.paradei...@a1telekom.at --- *) same logic, would be solve the problem ;o) **) ajp should also remove the body from response when status 304 is set *) its a webapp, jira from atlassian *) I know

[Bug 55454] NullPointerException caused by invalid contentType, e.g. trailing semicolon

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55454 Violeta Georgieva violet...@apache.org changed: What|Removed |Added Component|Jasper |Catalina

svn commit: r1515862 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/HttpParser.java test/org/apache/tomcat/util/http/parser/TestMediaType.java webapps/docs/changelog.xml

2013-08-20 Thread violetagg
Author: violetagg Date: Tue Aug 20 16:38:49 2013 New Revision: 1515862 URL: http://svn.apache.org/r1515862 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55454 Merged revision 1515841 from tomcat/trunk: Fixed NPE thrown when parsing an invalid content type. Modified:

[Bug 55454] NullPointerException caused by invalid contentType, e.g. trailing semicolon

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55454 Violeta Georgieva violet...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-08-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1351 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

Re: Jasper improvements - web resources and TLDs

2013-08-20 Thread Violeta Georgieva
2013/8/12 Mark Thomas wrote: I'm wondering about adding enableWebSockets() and enableJSPs() methods to Tomcat which would automatically add the relevant SCI to any Context created via one of the addContext(...) methods. Thoughts? +1

svn commit: r1515889 - /tomcat/tc7.0.x/trunk/build.xml

2013-08-20 Thread markt
Author: markt Date: Tue Aug 20 17:16:05 2013 New Revision: 1515889 URL: http://svn.apache.org/r1515889 Log: Missed renaming the fileset for the JSR-356 WebSocket implementation in one location. Modified: tomcat/tc7.0.x/trunk/build.xml Modified: tomcat/tc7.0.x/trunk/build.xml URL:

Re: buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-08-20 Thread Mark Thomas
On 20/08/2013 17:47, build...@apache.org wrote: The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1351 Buildbot URL: http://ci.apache.org/ Buildslave for this

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Nick, On 8/20/13 11:15 AM, Nick Williams wrote: On Aug 20, 2013, at 10:12 AM, Christopher Schultz wrote: Mark, On 8/20/13 9:25 AM, Mark Thomas wrote: On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a

svn commit: r1515893 - /tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/parser/TestMediaType.java

2013-08-20 Thread markt
Author: markt Date: Tue Aug 20 17:31:57 2013 New Revision: 1515893 URL: http://svn.apache.org/r1515893 Log: Remove duplicate test Modified: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/parser/TestMediaType.java Modified:

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Nick, On 8/20/13 1:25 PM, Christopher Schultz wrote: tcnative can be built on Max OS X like this: $ cd $CATALINA_HOME/bin $ tar xzf tomcat-native.tar.gz $ cd tomcat-native-*-src/jni/native $ ./configure --with-apr=/usr/bin/apr-1-config --with-ssl --with-java-home=`/usr/libexec/java_home`

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Nick, On 8/20/13 1:41 PM, Christopher Schultz wrote: Nick, On 8/20/13 1:25 PM, Christopher Schultz wrote: tcnative can be built on Max OS X like this: $ cd $CATALINA_HOME/bin $ tar xzf tomcat-native.tar.gz $ cd tomcat-native-*-src/jni/native $ ./configure

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Nick, On 8/20/13 1:47 PM, Nick Williams wrote: On Aug 20, 2013, at 12:41 PM, Christopher Schultz wrote: Nick, On 8/20/13 1:25 PM, Christopher Schultz wrote: tcnative can be built on Max OS X like this: $ cd $CATALINA_HOME/bin $ tar xzf tomcat-native.tar.gz $ cd

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Mark Thomas
On 20/08/2013 18:58, Christopher Schultz wrote: In case you want to run the entire test suite but don't want to get APR failures, you can also set -Dexecute.test.apr=false and it will skip all the APR tests. The unit tests are smart enough that even with that set to true, the tests will be

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Mark Thomas
On 20/08/2013 18:47, Nick Williams wrote: My remaining original concern was the best approach for weaving byte code in Tomcat's unit tests, which I detailed in an earlier message. Use the Weaver to completely replace the byte code of the weaved class with the byte code from another class? That

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nicholas Williams
On Tue, Aug 20, 2013 at 1:10 PM, Mark Thomas ma...@apache.org wrote: On 20/08/2013 18:47, Nick Williams wrote: My remaining original concern was the best approach for weaving byte code in Tomcat's unit tests, which I detailed in an earlier message. Use the Weaver to completely replace the

svn commit: r1515926 - /tomcat/trunk/bin/catalina.sh

2013-08-20 Thread markt
Author: markt Date: Tue Aug 20 19:07:25 2013 New Revision: 1515926 URL: http://svn.apache.org/r1515926 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55439 Don't try a forced stop (kill -9 $PID) if Tomcat has already been stopped and the PID file cleared else a bunch of errors will

svn commit: r1515929 - in /tomcat/tc7.0.x/trunk: ./ bin/catalina.sh webapps/docs/changelog.xml

2013-08-20 Thread markt
Author: markt Date: Tue Aug 20 19:11:24 2013 New Revision: 1515929 URL: http://svn.apache.org/r1515929 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55439 Don't try a forced stop (kill -9 $PID) if Tomcat has already been stopped and the PID file cleared else a bunch of errors will

[Bug 55439] 'catalina.sh stop -force' doesn't account for empty pid file

2013-08-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55439 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: [GUMP@vmgump]: Project jakarta-tomcat-jasper_tc5 (in module jakarta-tomcat-jasper_tc5) failed

2013-08-20 Thread Mark Thomas
On 18/08/2013 00:42, b...@apache.org wrote: snip/ build-only: [javac] Compiling 97 source files to /srv/gump/public/workspace/jakarta-tomcat-jasper_tc5/build/shared/classes [javac]

Re: [GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2013-08-20 Thread Mark Thomas
On 20/08/2013 00:50, Bill Barker wrote: snip/ validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle [checkstyle] Running Checkstyle 5.7-SNAPSHOT on 2388 files [checkstyle]

buildbot failure in ASF Buildbot on tomcat-trunk

2013-08-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4859 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: [GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2013-08-20 Thread Konstantin Kolinko
2013/8/20 Mark Thomas ma...@apache.org: On 20/08/2013 00:50, Bill Barker wrote: snip/ validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle [checkstyle] Running Checkstyle 5.7-SNAPSHOT on 2388 files [checkstyle]

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 1:10 PM, Mark Thomas wrote: On 20/08/2013 18:47, Nick Williams wrote: My remaining original concern was the best approach for weaving byte code in Tomcat's unit tests, which I detailed in an earlier message. Use the Weaver to completely replace the byte code of the

[GUMP@vmgump]: Project jakarta-tomcat-jasper_tc5 (in module jakarta-tomcat-jasper_tc5) failed

2013-08-20 Thread bobh
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project jakarta-tomcat-jasper_tc5 has an issue affecting its community

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2013-08-20 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-08-20 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2013-08-20 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration.

Re: [GUMP@vmgump]: Project jakarta-tomcat-jasper_tc5 (in module jakarta-tomcat-jasper_tc5) failed

2013-08-20 Thread Stefan Bodewig
On 2013-08-20, Mark Thomas wrote: On 18/08/2013 00:42, b...@apache.org wrote: snip/ build-only: [javac] Compiling 97 source files to /srv/gump/public/workspace/jakarta-tomcat-jasper_tc5/build/shared/classes [javac]

Re: [GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2013-08-20 Thread Stefan Bodewig
On 2013-08-21, Konstantin Kolinko wrote: 2013/8/20 Mark Thomas ma...@apache.org: On 20/08/2013 00:50, Bill Barker wrote: snip/ validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle [checkstyle] Running Checkstyle 5.7-SNAPSHOT on 2388 files