[Bug 61795] Make JASPIC callback handler class configurable via a property of the authenticator

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61795 Lazar Kirchev changed: What|Removed |Added Severity|normal |enhancement

[GitHub] tomcat pull request #92: Support null for provider class name when registeri...

2017-11-22 Thread lkirchev
Github user lkirchev closed the pull request at: https://github.com/apache/tomcat/pull/92 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #92: Support null for provider class name when registering a pr...

2017-11-22 Thread lkirchev
Github user lkirchev commented on the issue: https://github.com/apache/tomcat/pull/92 Will replace it with a new PR. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

buildbot success in on tomcat-trunk

2017-11-22 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2836 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 61803] New: Documentation for sslEnabledProtocols describes the incorrect way to set this option

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61803 Bug ID: 61803 Summary: Documentation for sslEnabledProtocols describes the incorrect way to set this option Product: Tomcat 8 Version: 8.5.23 Hardware: All

[Bug 61733] lb_mult changes caused by status worker changing a subworker's factor are not propagated to all processes correctly.

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61733 --- Comment #2 from Jonathan Oddy --- I hadn't spotted that, but I don't think it helps. jk_lb_push() only pushes changes for subworkers where the sequence number has changed. update_worker() sets the sequence

svn commit: r1816038 - /tomcat/jk/trunk/native/apache-1.3/

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 11:36:45 2017 New Revision: 1816038 URL: http://svn.apache.org/viewvc?rev=1816038=rev Log: Remove the apache-1.3 component httpd 1.3 reached EOL over 12 years ago Removed: tomcat/jk/trunk/native/apache-1.3/

svn commit: r1816043 - in /tomcat/jk/trunk/native: BUILDING.txt configure.ac

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 12:06:41 2017 New Revision: 1816043 URL: http://svn.apache.org/viewvc?rev=1816043=rev Log: Remove apache-1.3 references Modified: tomcat/jk/trunk/native/BUILDING.txt tomcat/jk/trunk/native/configure.ac Modified: tomcat/jk/trunk/native/BUILDING.txt URL:

svn commit: r1816042 - /tomcat/jk/trunk/native/build.xml

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 12:06:03 2017 New Revision: 1816042 URL: http://svn.apache.org/viewvc?rev=1816042=rev Log: Remove build file that used jkant Removed: tomcat/jk/trunk/native/build.xml - To unsubscribe,

Re: svn commit: r1816043 - in /tomcat/jk/trunk/native: BUILDING.txt configure.ac

2017-11-22 Thread Konstantin Kolinko
2017-11-22 15:06 GMT+03:00 : > Author: markt > Date: Wed Nov 22 12:06:41 2017 > New Revision: 1816043 > > URL: http://svn.apache.org/viewvc?rev=1816043=rev > Log: > Remove apache-1.3 references > > Modified: > tomcat/jk/trunk/native/BUILDING.txt >

Re: [Bug 61733] lb_mult changes caused by status worker changing a subworker's factor are not propagated to all processes correctly.

2017-11-22 Thread Mark Thomas
Hi, A review from someone who knows the jk code better than I do would be appreciated. Does my alternative patch look appropriate? If not, is the OP's patch appropriate? If neither is appropriate, what might an appropriate patch look like and I'll see what I can do. Thanks, Mark On 22/11/17

svn commit: r1816037 - /tomcat/jk/trunk/jkant/

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 11:36:04 2017 New Revision: 1816037 URL: http://svn.apache.org/viewvc?rev=1816037=rev Log: Remove the jkant component The code has been untouched (in any meaningful way) for 14+ years. Removed: tomcat/jk/trunk/jkant/

[Bug 61733] lb_mult changes caused by status worker changing a subworker's factor are not propagated to all processes correctly.

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61733 --- Comment #1 from Mark Thomas --- Created attachment 35544 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35544=edit Possible alternative solution Having reviewed the source code it appears that after the lb_factor

[Bug 61733] lb_mult changes caused by status worker changing a subworker's factor are not propagated to all processes correctly.

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61733 --- Comment #3 from Mark Thomas --- That sounds reasonable. That does seem to be consistent with the general approach which looks to be calculate / update stuff once, put in in shared memory, have everything that needs to

svn commit: r1816045 - in /tomcat/jk/trunk/native: common/ scripts/build/unix/

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 12:13:58 2017 New Revision: 1816045 URL: http://svn.apache.org/viewvc?rev=1816045=rev Log: Ignore files generated by buildconf.sh Modified: tomcat/jk/trunk/native/common/ (props changed) tomcat/jk/trunk/native/scripts/build/unix/ (props changed)

Re: [PROPOSAL] Drop some JK components

2017-11-22 Thread Mark Thomas
On 21/11/17 14:50, Rémy Maucherat wrote: > On Tue, Nov 21, 2017 at 1:58 PM, Mark Thomas wrote: > >> All, >> >> I've been looking at jk/trunk with a view to rolling a release in the >> near future. (It has been just over a year since the last release.) >> >> As I have been

svn commit: r1816039 - /tomcat/jk/trunk/native/iis/installer/

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 11:38:30 2017 New Revision: 1816039 URL: http://svn.apache.org/viewvc?rev=1816039=rev Log: Remove the iis/installer component Last released 12+ years ago and requires an InstallShield license we do not have. Removed: tomcat/jk/trunk/native/iis/installer/

svn commit: r1816041 - in /tomcat/jk/trunk: native/iis/Makefile.ia64 xdocs/webserver_howto/iis.xml

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 11:44:50 2017 New Revision: 1816041 URL: http://svn.apache.org/viewvc?rev=1816041=rev Log: Remove references to building the ISAPI redirector for Itanium Removed: tomcat/jk/trunk/native/iis/Makefile.ia64 Modified:

Re: [PROPOSAL] Drop some JK components

2017-11-22 Thread Christopher Schultz
Mark, On 11/21/17 7:58 AM, Mark Thomas wrote: > All, > > I've been looking at jk/trunk with a view to rolling a release in the > near future. (It has been just over a year since the last release.) > > As I have been looking through the source, I have noticed a number of > components that we

[Bug 61803] Documentation for sslEnabledProtocols describes the incorrect way to set this option

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61803 --- Comment #1 from Simon Dawson --- Here is the original patch that changed this for version 8. https://svn.apache.org/viewvc?view=revision=1681779 It did include some documentation updates but not to

[GitHub] tomcat pull request #94: Support null for provider class name when registeri...

2017-11-22 Thread lkirchev
GitHub user lkirchev opened a pull request: https://github.com/apache/tomcat/pull/94 Support null for provider class name when registering a provider Patch for https://bz.apache.org/bugzilla/show_bug.cgi?id=61784 You can merge this pull request into a Git repository by running:

[Bug 61733] lb_mult changes caused by status worker changing a subworker's factor are not propagated to all processes correctly.

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61733 --- Comment #4 from Jonathan Oddy --- Created attachment 35547 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35547=edit Force update all subworkers for multiplier change Here's an attempt at doing

[Bug 61621] Content-Type is forced to lowercase when it goes through mod_jk

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61621 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement ---

Re: [Bug 61733] lb_mult changes caused by status worker changing a subworker's factor are not propagated to all processes correctly.

2017-11-22 Thread Rainer Jung
Will look this evening. Rainer Am 22.11.2017 um 11:59 schrieb Mark Thomas: Hi, A review from someone who knows the jk code better than I do would be appreciated. Does my alternative patch look appropriate? If not, is the OP's patch appropriate? If neither is appropriate, what might an

[Bug 61784] NPE if AuthConfigFactoryImpl.registerConfigProvider() is called with null provider name parameter

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61784 --- Comment #6 from Lazar Kirchev --- Thanks Mark! Agree. Here is a pull request with patch + tests: https://github.com/apache/tomcat/pull/94 -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1816058 - /tomcat/jk/trunk/native/configure.ac

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 14:33:11 2017 New Revision: 1816058 URL: http://svn.apache.org/viewvc?rev=1816058=rev Log: Follow-up to r1816043 kkolinko review Ensure correct version of apxs is specified Modified: tomcat/jk/trunk/native/configure.ac Modified:

buildbot failure in on tomcat-trunk

2017-11-22 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2834 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1816083 - in /tomcat/trunk: res/tomcat.nsi webapps/docs/changelog.xml

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 21:25:42 2017 New Revision: 1816083 URL: http://svn.apache.org/viewvc?rev=1816083=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=51496 When using the Windows installer, check if the requested service name already exists and, if it does, prompt the user

[Bug 61784] NPE if AuthConfigFactoryImpl.registerConfigProvider() is called with null provider name parameter

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61784 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1816080 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/AuthenticatorBase.java test/org/apache/catalina/authenticator/TestJaspicCallbackHandlerInAuthenticator.java w

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 20:49:06 2017 New Revision: 1816080 URL: http://svn.apache.org/viewvc?rev=1816080=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61795 Add a property to the Authenticator implementations to enable a custom JASPIC CallbackHandler to be specified. Patch

[GitHub] tomcat pull request #93: Make JASPIC callback handler class configurable via...

2017-11-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/93 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61795] Make JASPIC callback handler class configurable via a property of the authenticator

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61795 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 61692] CGIServlet should handle additional HTTP methods, for example MKCALENDAR, MKCOL, PROPFIND, PROPPATCH

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61692 --- Comment #6 from Mark Thomas --- Good point. Fixing that starts heading in the direction of the original patch again. More thought required. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1816074 - in /tomcat/jk/trunk/native: ./ common/

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 19:47:24 2017 New Revision: 1816074 URL: http://svn.apache.org/viewvc?rev=1816074=rev Log: Ignore generated files Modified: tomcat/jk/trunk/native/ (props changed) tomcat/jk/trunk/native/common/ (props changed) Propchange: tomcat/jk/trunk/native/

svn commit: r1816077 - in /tomcat/tc8.5.x/trunk: ./ conf/ java/org/apache/catalina/authenticator/jaspic/ test/org/apache/catalina/authenticator/jaspic/ webapps/docs/

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 20:18:37 2017 New Revision: 1816077 URL: http://svn.apache.org/viewvc?rev=1816077=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61784 Correctly handle the case when AuthConfigFactoryImpl.registerConfigProvider() is called with a provider name of null.

svn commit: r1816076 - in /tomcat/trunk: conf/ java/org/apache/catalina/authenticator/jaspic/ test/org/apache/catalina/authenticator/jaspic/ webapps/docs/

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 20:17:53 2017 New Revision: 1816076 URL: http://svn.apache.org/viewvc?rev=1816076=rev Log: Correctly handle the case when AuthConfigFactoryImpl.registerConfigProvider() is called with a provider name of null. Patch provided by Lazar. This closes #94 Modified:

[GitHub] tomcat pull request #94: Support null for provider class name when registeri...

2017-11-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/94 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1816078 - in /tomcat/trunk: java/org/apache/catalina/authenticator/AuthenticatorBase.java test/org/apache/catalina/authenticator/TestJaspicCallbackHandlerInAuthenticator.java webapps/docs

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 20:48:39 2017 New Revision: 1816078 URL: http://svn.apache.org/viewvc?rev=1816078=rev Log: Add a property to the Authenticator implementations to enable a custom JASPIC CallbackHandler to be specified. Patch provided by Lazar. This closes #93 Added:

svn commit: r1816085 - in /tomcat/tc8.0.x/trunk: ./ res/tomcat.nsi webapps/docs/changelog.xml

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 21:28:43 2017 New Revision: 1816085 URL: http://svn.apache.org/viewvc?rev=1816085=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=51496 When using the Windows installer, check if the requested service name already exists and, if it does, prompt the user

svn commit: r1816084 - in /tomcat/tc8.5.x/trunk: ./ res/tomcat.nsi webapps/docs/changelog.xml

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 21:27:31 2017 New Revision: 1816084 URL: http://svn.apache.org/viewvc?rev=1816084=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=51496 When using the Windows installer, check if the requested service name already exists and, if it does, prompt the user

svn commit: r1816086 - in /tomcat/tc7.0.x/trunk: ./ res/tomcat.nsi webapps/docs/changelog.xml

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 21:29:26 2017 New Revision: 1816086 URL: http://svn.apache.org/viewvc?rev=1816086=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=51496 When using the Windows installer, check if the requested service name already exists and, if it does, prompt the user

[Bug 51496] NSIS - Warn that duplicate service name will result in install failure

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=51496 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1816087 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestJaspicCallbackHandlerInAuthenticator.java

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 21:32:19 2017 New Revision: 1816087 URL: http://svn.apache.org/viewvc?rev=1816087=rev Log: Fix test failure Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestJaspicCallbackHandlerInAuthenticator.java Modified:

svn commit: r1816088 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/authenticator/TestJaspicCallbackHandlerInAuthenticator.java

2017-11-22 Thread markt
Author: markt Date: Wed Nov 22 21:33:03 2017 New Revision: 1816088 URL: http://svn.apache.org/viewvc?rev=1816088=rev Log: Fix test failure Modified: tomcat/tc8.5.x/trunk/ (props changed)

[Bug 61733] lb_mult changes caused by status worker changing a subworker's factor are not propagated to all processes correctly.

2017-11-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61733 --- Comment #5 from Rainer Jung --- Created attachment 35549 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35549=edit Reorder update actions and introduce flag for demanding updates for all members I think