[Bug 57665] support x-forwarded-host

2019-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org --- Comment #19

[Bug 63196] New: Add sane default value for RemoteIpValue#protocolHeader

2019-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63196 Bug ID: 63196 Summary: Add sane default value for RemoteIpValue#protocolHeader Product: Tomcat 8 Version: 8.5.34 Hardware: All OS: All

[Bug 63196] Add sane default value for RemoteIpValue#protocolHeader

2019-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63196 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

Re: [VOTE] Release Apache Tomcat 7.0.93

2019-02-21 Thread Violeta Georgieva
На сб, 16.02.2019 г. в 19:41 ч. Violeta Georgieva написа: > > The proposed Apache Tomcat 7.0.93 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.93/ > The Maven staging repo is: >

svn commit: r32578 - /dev/tomcat/tomcat-7/v7.0.93/ /release/tomcat/tomcat-7/v7.0.93/

2019-02-21 Thread violetagg
Author: violetagg Date: Thu Feb 21 15:22:10 2019 New Revision: 32578 Log: Release Tomcat 7.0.93 Added: release/tomcat/tomcat-7/v7.0.93/ - copied from r32577, dev/tomcat/tomcat-7/v7.0.93/ Removed: dev/tomcat/tomcat-7/v7.0.93/

[Bug 63195] New: Add easy way to test RemoteIpValve works properly

2019-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63195 Bug ID: 63195 Summary: Add easy way to test RemoteIpValve works properly Product: Tomcat 8 Version: 8.5.34 Hardware: All OS: All Status: NEW Severity:

[Bug 63195] Add easy way to test RemoteIpValve works properly

2019-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63195 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 63195] Add easy way to test RemoteIpValve works properly

2019-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63195 Christopher Schultz changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from

svn commit: r1854054 - in /tomcat/trunk/test/org/apache/tomcat/util/net: TestSSLHostConfigCompat.java TesterSupport.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 14:44:58 2019 New Revision: 1854054 URL: http://svn.apache.org/viewvc?rev=1854054=rev Log: Expand the TLS tests to cover RSA and/or EC certificates on the server with clients specifying RSA and/or EC cipher suites Modified:

svn commit: r1854056 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java test/org/apache/tomcat/util/net/TesterSupport.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 14:59:25 2019 New Revision: 1854056 URL: http://svn.apache.org/viewvc?rev=1854056=rev Log: Expand the TLS tests to cover RSA and/or EC certificates on the server with clients specifying RSA and/or EC cipher suites. (Requires Java 8) Modified:

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.93

2019-02-21 Thread Violeta Georgieva
Hi, На сб, 16.02.2019 г. в 19:41 ч. Violeta Georgieva написа: > > The proposed Apache Tomcat 7.0.93 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.93/ > The Maven staging repo is: >

svn commit: r1854025 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractJsseEndpoint.java SSLUtilBase.java jsse/JSSEUtil.java openssl/OpenSSLUtil.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 09:29:29 2019 New Revision: 1854025 URL: http://svn.apache.org/viewvc?rev=1854025=rev Log: Refactor creation of SSLContext to include configuration Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractJsseEndpoint.java

svn commit: r1854029 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ java/org/apache/tomcat/util/net/openssl/

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 09:54:19 2019 New Revision: 1854029 URL: http://svn.apache.org/viewvc?rev=1854029=rev Log: Refactor creation of SSLContext to include configuration Modified: tomcat/tc8.5.x/trunk/ (props changed)

Re: [VOTE] Release Apache Tomcat 7.0.93

2019-02-21 Thread Konstantin Kolinko
сб, 16 февр. 2019 г. в 20:41, Violeta Georgieva : > > The proposed 7.0.93 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 7.0.93 Stable > Tested all connectors with Java 6u45, 7u80 (32-bit), 8u202 (64-bit), OpenJDK 11u2 (64-bit) on Windows 10. No test failures

svn commit: r1854042 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 11:45:34 2019 New Revision: 1854042 URL: http://svn.apache.org/viewvc?rev=1854042=rev Log: Add missing configuration Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java

svn commit: r1854041 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 11:45:09 2019 New Revision: 1854041 URL: http://svn.apache.org/viewvc?rev=1854041=rev Log: Add missing configuration Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java Modified:

Better integration of RemoteIpValve, AuthenticatorBase and reverse proxies

2019-02-21 Thread Michael Osipov
Hi folks, I have some improvement ideas for several components where I think others would benefit from too. We intend to run a set of apps on Tomcat 8.5 behind Apache 2.4.x for a possible future load balacing scenario. While evaluating this task I have stumbled on the issue that it isn't

[Bug 63194] New: Tomcat 7.0.93: org.apache.tomcat.util.net.TestClientCertTls13: UnsatisfiedLinkError

2019-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63194 Bug ID: 63194 Summary: Tomcat 7.0.93: org.apache.tomcat.util.net.TestClientCertTls13: UnsatisfiedLinkError Product: Tomcat 7 Version: 7.0.93

[VOTE] Migrate to git

2019-02-21 Thread Mark Thomas
This is a VOTE to migrate the primary source code repository for Apache Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. The migration will be performed as per: https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration with the following changes: - 8.0.x will not be migrated - the tag name

Re: [VOTE] Migrate to git

2019-02-21 Thread Woonsan Ko
[X] +1 Go ahead with the migration Thanks! Woonsan On Thu, Feb 21, 2019 at 11:13 AM Mark Thomas wrote: > > This is a VOTE to migrate the primary source code repository for Apache > Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. > > The migration will be performed as per: >

svn commit: r1854068 - in /tomcat/trunk/java/org/apache/tomcat/util/net/openssl: OpenSSLKeyManager.java OpenSSLUtil.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 17:33:52 2019 New Revision: 1854068 URL: http://svn.apache.org/viewvc?rev=1854068=rev Log: Remove unused code Removed: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLKeyManager.java Modified:

svn commit: r1854069 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/OpenSSLKeyManager.java java/org/apache/tomcat/util/net/openssl/OpenSSLUtil.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 17:34:23 2019 New Revision: 1854069 URL: http://svn.apache.org/viewvc?rev=1854069=rev Log: Remove unused code Removed: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLKeyManager.java Modified: tomcat/tc8.5.x/trunk/ (props changed)

Re: [VOTE] Migrate to git

2019-02-21 Thread Michael Osipov
Am 2019-02-21 um 17:13 schrieb Mark Thomas: This is a VOTE to migrate the primary source code repository for Apache Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. The migration will be performed as per: https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration with the following

svn commit: r1854066 - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http11/upgrade/ java/org/apache/coyote/http2/ java/or

2019-02-21 Thread remm
Author: remm Date: Thu Feb 21 16:37:20 2019 New Revision: 1854066 URL: http://svn.apache.org/viewvc?rev=1854066=rev Log: Refactor to redo fix for 63182. The root cause is that the pending flag is released once processing start, and concurrent unsynced access from non container threads can cause

buildbot failure in on tomcat-trunk

2019-02-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4069 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

buildbot failure in on tomcat-85-trunk

2019-02-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-85-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1661 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: [VOTE] Migrate to git

2019-02-21 Thread Tim Funk
Sorry for the double email (sending via my apache account so its official) [X] +1 Go ahead with the migration -Tim >

Re: [VOTE] Migrate to git

2019-02-21 Thread Tim Funk
[X] +1 Go ahead with the migration A huge thanks to all the time, thought and planning to make this possible. -Tim

svn commit: r1854075 - /tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

2019-02-21 Thread remm
Author: remm Date: Thu Feb 21 18:27:54 2019 New Revision: 1854075 URL: http://svn.apache.org/viewvc?rev=1854075=rev Log: It is unclear if the two need to be strictly equal, so relax check. Modified: tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java Modified:

svn commit: r1854059 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2019-02-21 Thread violetagg
Author: violetagg Date: Thu Feb 21 15:38:10 2019 New Revision: 1854059 URL: http://svn.apache.org/viewvc?rev=1854059=rev Log: Update the release date for 7.0.93 Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL:

[Bug 63195] Add easy way to test RemoteIpValve works properly

2019-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63195 --- Comment #2 from Michael Osipov --- The snoop.jsp is a good start. Let's stash this for moment. Tomcat is not supposed to verify, but the user. Properly configuring the valve can be daunting for people. Even after they have configured it,

Re: [VOTE] Migrate to git

2019-02-21 Thread Coty Sutherland
On Thu, Feb 21, 2019 at 11:13 AM Mark Thomas wrote: > This is a VOTE to migrate the primary source code repository for Apache > Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. > > The migration will be performed as per: > https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration > > with

svn commit: r1854081 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/SSLUtilBase.java java/org/apache/tomcat/util/net/jsse/JSSEUtil.java java/org/apache/tomcat/util/net/openssl/OpenSSLU

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 18:48:58 2019 New Revision: 1854081 URL: http://svn.apache.org/viewvc?rev=1854081=rev Log: Refactor with the aim (several commits in the future) of enabling the AprEndpoint to use JSSE style configuration Modified: tomcat/tc8.5.x/trunk/ (props changed)

Re: [VOTE] Migrate to git

2019-02-21 Thread Martin Grigorov
On Thu, Feb 21, 2019, 18:13 Mark Thomas wrote: > This is a VOTE to migrate the primary source code repository for Apache > Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. > > The migration will be performed as per: > https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration > > with the

svn commit: r1854096 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ java/org/apache/tomcat/util/net/openssl/

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 20:41:32 2019 New Revision: 1854096 URL: http://svn.apache.org/viewvc?rev=1854096=rev Log: Refactor setting of sessionCacheSize and sessionTimeout It is a little more convoluted now for NIO[2]+OpenSSL but the end result should be the same and it brings the JSSE

svn commit: r1854095 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractJsseEndpoint.java SSLUtilBase.java jsse/JSSEUtil.java openssl/OpenSSLContext.java openssl/OpenSSLUtil.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 20:40:51 2019 New Revision: 1854095 URL: http://svn.apache.org/viewvc?rev=1854095=rev Log: Refactor setting of sessionCacheSize and sessionTimeout It is a little more convoluted now for NIO[2]+OpenSSL but the end result should be the same and it brings the JSSE

Re: [VOTE] Migrate to git

2019-02-21 Thread Felix Schumacher
Am 21.02.19 um 17:13 schrieb Mark Thomas: This is a VOTE to migrate the primary source code repository for Apache Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. The migration will be performed as per: https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration with the following

svn commit: r1854093 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 20:25:05 2019 New Revision: 1854093 URL: http://svn.apache.org/viewvc?rev=1854093=rev Log: Remove code that is essentially NO-OP Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1854091 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 20:24:25 2019 New Revision: 1854091 URL: http://svn.apache.org/viewvc?rev=1854091=rev Log: Remove code that is essentially NO-OP Modified: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java Modified:

buildbot success in on tomcat-85-trunk

2019-02-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1662 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1854089 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2019-02-21 Thread remm
Author: remm Date: Thu Feb 21 20:18:12 2019 New Revision: 1854089 URL: http://svn.apache.org/viewvc?rev=1854089=rev Log: Revert again after CI fail. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified:

Re: [VOTE] Migrate to git

2019-02-21 Thread Rémy Maucherat
On Thu, Feb 21, 2019 at 5:13 PM Mark Thomas wrote: > This is a VOTE to migrate the primary source code repository for Apache > Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. > > The migration will be performed as per: > https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration > > with

Re: [VOTE] Migrate to git

2019-02-21 Thread Igal Sapir
On 2/21/2019 8:13 AM, Mark Thomas wrote: This is a VOTE to migrate the primary source code repository for Apache Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. The migration will be performed as per: https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration with the following changes: -

buildbot failure in on tomcat-trunk

2019-02-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4075 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1854084 - in /tomcat/trunk/java/org/apache: coyote/ coyote/ajp/ coyote/http11/ coyote/http11/upgrade/ coyote/http2/ tomcat/util/net/

2019-02-21 Thread remm
Author: remm Date: Thu Feb 21 19:31:22 2019 New Revision: 1854084 URL: http://svn.apache.org/viewvc?rev=1854084=rev Log: Revert after CI failure, try something else. Modified: tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java

buildbot success in on tomcat-trunk

2019-02-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4074 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: [VOTE] Migrate to git

2019-02-21 Thread Emmanuel Bourg
Le 21/02/2019 à 17:13, Mark Thomas a écrit : > [X] +1 Go ahead with the migration > [ ] -1 Postpone the migration because... Thank you Mark. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

buildbot success in on tomcat-trunk

2019-02-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4076 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1854079 - in /tomcat/trunk/java/org/apache/tomcat/util/net: SSLUtilBase.java jsse/JSSEUtil.java openssl/OpenSSLUtil.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 18:44:51 2019 New Revision: 1854079 URL: http://svn.apache.org/viewvc?rev=1854079=rev Log: Refactor with the aim (several commits in the future) of enabling the AprEndpoint to use JSSE style configuration Modified:

svn commit: r1854097 - in /tomcat/trunk/java/org/apache/tomcat/util/net: SSLUtilBase.java jsse/JSSEUtil.java openssl/OpenSSLUtil.java

2019-02-21 Thread markt
Author: markt Date: Thu Feb 21 20:59:10 2019 New Revision: 1854097 URL: http://svn.apache.org/viewvc?rev=1854097=rev Log: More alignment of JSSE and OpenSSL (and a little code reduction) Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLUtilBase.java

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2019-02-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-bio has an issue affecting its community

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-02-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration.