[GitHub] [tomcat] jfclere opened a new pull request #309: Allow recursive substitution of properties.

2020-06-26 Thread GitBox
jfclere opened a new pull request #309: URL: https://github.com/apache/tomcat/pull/309 Related to https://issues.redhat.com/browse/JWS-973 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] michael-o commented on pull request #309: Allow recursive substitution of properties.

2020-06-26 Thread GitBox
michael-o commented on pull request #309: URL: https://github.com/apache/tomcat/pull/309#issuecomment-650097670 I don't have access to the ticket even with my Red Hat Enterprise Account. This is an automated message from the

[GitHub] [tomcat] FSchumacher commented on pull request #309: Allow recursive substitution of properties.

2020-06-26 Thread GitBox
FSchumacher commented on pull request #309: URL: https://github.com/apache/tomcat/pull/309#issuecomment-650099473 That could lead to a StackOverflowError. ``` @Test public void testReplacePropertiesRecursively() { Properties properties = new Properties();

[GitHub] [tomcat] jfclere commented on pull request #309: Allow recursive substitution of properties.

2020-06-26 Thread GitBox
jfclere commented on pull request #309: URL: https://github.com/apache/tomcat/pull/309#issuecomment-650128576 I have opened the JIRA and yes the recursion needs to be controlled. This is an automated message from the Apache

[tomcat] branch master updated: Ensure HTTP/1.1 processor is recycled after a direct h2c connection

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c9167ae Ensure HTTP/1.1 processor is recycled

[tomcat] branch 8.5.x updated: Ensure HTTP/1.1 processor is recycled after a direct h2c connection

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 923d834 Ensure HTTP/1.1 processor is recycled

[tomcat] branch 9.0.x updated: Ensure HTTP/1.1 processor is recycled after a direct h2c connection

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 172977f Ensure HTTP/1.1 processor is recycled

Re: Changing the name of the default branch in our git repos

2020-06-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 6/26/20 10:48, Mark Thomas wrote: > Picking up this thread again I see a range of views. "main" seems > to be the most popular although several folks suggested "10.0.x" > and "use whatever GitHub use". There was also interest in "trunk". >

[Bug 63493] enhancement - add JMX counters to monitor authentication and authorization

2020-06-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63493 Eugène Adell changed: What|Removed |Added Attachment #36619|0 |1 is obsolete|

[Bug 63493] enhancement - add JMX counters to monitor authentication and authorization

2020-06-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63493 --- Comment #5 from Eugène Adell --- Thanks for looking Chris, GlobalRequestProcessor : The counters are no different from those already existing, and authentication denials could not logically go higher than errorCount which is an int (on

Re: Changing the name of the default branch in our git repos

2020-06-26 Thread Rémy Maucherat
On Fri, Jun 26, 2020 at 4:48 PM Mark Thomas wrote: > Hi, > > Picking up this thread again I see a range of views. "main" seems to be > the most popular although several folks suggested "10.0.x" and "use > whatever GitHub use". There was also interest in "trunk". Particularly > with the

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #309: Allow recursive substitution of properties.

2020-06-26 Thread GitBox
ChristopherSchultz commented on a change in pull request #309: URL: https://github.com/apache/tomcat/pull/309#discussion_r446392364 ## File path: java/org/apache/tomcat/util/IntrospectionUtils.java ## @@ -332,7 +341,15 @@ public static String replaceProperties(String value,

[GitHub] [tomcat] jfclere commented on pull request #309: Allow recursive substitution of properties.

2020-06-26 Thread GitBox
jfclere commented on pull request #309: URL: https://github.com/apache/tomcat/pull/309#issuecomment-650262993 @FSchumacher something like that? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

2020-06-26 Thread GitBox
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-650271782 Is anyone up for merging this? If something is missing please let me know :) I wasn't sure if this warranted a changelog.

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

2020-06-26 Thread GitBox
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-650272578 Also note that since this is handling push/pr on _master_ (to be renamed branch) there is no point applying this to other branches.

[tomcat] 03/03: Use method local counter for recurstion

2020-06-26 Thread fschumacher
This is an automated email from the ASF dual-hosted git repository. fschumacher pushed a commit to branch pr309-recursion in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7f1b56e587693bb8f7755c972fbac493101c53c8 Author: Felix Schumacher AuthorDate: Fri Jun 26 16:58:25 2020

[tomcat] 01/03: Allow recursive substitution of properties.

2020-06-26 Thread fschumacher
This is an automated email from the ASF dual-hosted git repository. fschumacher pushed a commit to branch pr309-recursion in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4f1ae64882486eeb0b60f9daf13daeca5df6b7c9 Author: Jean-Frederic Clere AuthorDate: Fri Jun 26 09:50:09 2020

[tomcat] branch pr309-recursion created (now 7f1b56e)

2020-06-26 Thread fschumacher
This is an automated email from the ASF dual-hosted git repository. fschumacher pushed a change to branch pr309-recursion in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 7f1b56e Use method local counter for recurstion This branch includes the following new commits:

[tomcat] 02/03: Add a iterationCount limited to 20 to prevent StackOverflowError.

2020-06-26 Thread fschumacher
This is an automated email from the ASF dual-hosted git repository. fschumacher pushed a commit to branch pr309-recursion in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 57e83d7c9eaa784d3af54fa57de100c99515f1bc Author: Jean-Frederic Clere AuthorDate: Fri Jun 26 15:18:30 2020

Re: [tomcat] branch pr309-recursion deleted (was 7f1b56e)

2020-06-26 Thread Felix Schumacher
Sorry for the noise. I wanted to work on the github branch pr/309 and accidently added a new branch. Felix Am 26.06.20 um 17:02 schrieb fschumac...@apache.org: > This is an automated email from the ASF dual-hosted git repository. > > fschumacher pushed a change to branch pr309-recursion > in

[tomcat] 01/02: SocketWrapper.upgraded is no longer used

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 354d6342603358076d0a256c67de98d9bc2dd475 Author: Mark Thomas AuthorDate: Fri Jun 26 15:31:00 2020 +0100

[tomcat] 02/02: socketWrapper.secure is no longer used

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4e63245d64e2bbe976c026115b49923b972831b1 Author: Mark Thomas AuthorDate: Fri Jun 26 16:12:34 2020 +0100

[tomcat] branch 8.5.x updated (923d834 -> 4e63245)

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 923d834 Ensure HTTP/1.1 processor is recycled after a direct h2c connection new 354d634 SocketWrapper.upgraded

Re: Changing the name of the default branch in our git repos

2020-06-26 Thread Mark Thomas
Hi, Picking up this thread again I see a range of views. "main" seems to be the most popular although several folks suggested "10.0.x" and "use whatever GitHub use". There was also interest in "trunk". Particularly with the additional suggestion of "10.0.x" appearing in the middle of the

[tomcat] reference refs/remotes/origin/pr/309 created (now 4fc54d5)

2020-06-26 Thread fschumacher
This is an automated email from the ASF dual-hosted git repository. fschumacher pushed a change to reference refs/remotes/origin/pr/309 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 4fc54d5 Add a iterationCount limited to 20 to prevent StackOverflowError. No new

[tomcat] branch pr309-recursion deleted (was 7f1b56e)

2020-06-26 Thread fschumacher
This is an automated email from the ASF dual-hosted git repository. fschumacher pushed a change to branch pr309-recursion in repository https://gitbox.apache.org/repos/asf/tomcat.git. was 7f1b56e Use method local counter for recurstion This change permanently discards the following

[tomcat] branch master updated: SocketWrapper.upgraded is no longer used

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 9eb4c28 SocketWrapper.upgraded is no longer

[GitHub] [tomcat] FSchumacher commented on pull request #309: Allow recursive substitution of properties.

2020-06-26 Thread GitBox
FSchumacher commented on pull request #309: URL: https://github.com/apache/tomcat/pull/309#issuecomment-650230095 I tried to push to this PR branch directly, but I think I messed it up :( The current change is not thread safe. I would go with a method parameter and a wrapper to count

[tomcat] 01/02: SocketWrapper.upgraded is no longer used

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 59a037152a3e41a81ddcb89e9e51e3624aeb9b66 Author: Mark Thomas AuthorDate: Fri Jun 26 15:31:00 2020 +0100

[tomcat] branch master updated (9eb4c28 -> 7977440)

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 9eb4c28 SocketWrapper.upgraded is no longer used new 977d440 socketWrapper.secure is no longer used new

[tomcat] 01/02: socketWrapper.secure is no longer used

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 977d440678168f15388f4ae510d997267e98eb4c Author: Mark Thomas AuthorDate: Fri Jun 26 16:12:34 2020 +0100

[tomcat] 02/02: socketWrapper.secure is no longer used

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b1ef294ccb62b8fd108ed117b654bf2f6c51f9a1 Author: Mark Thomas AuthorDate: Fri Jun 26 16:12:34 2020 +0100

[tomcat] 02/02: Remove unused code

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7977440111f96ccbfea039b913fd1744ea5867cb Author: Mark Thomas AuthorDate: Fri Jun 26 16:16:26 2020 +0100 Remove

[tomcat] branch 9.0.x updated (172977f -> b1ef294)

2020-06-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 172977f Ensure HTTP/1.1 processor is recycled after a direct h2c connection new 59a0371 SocketWrapper.upgraded