[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2017-04-18 Thread WegDamit
Github user WegDamit commented on the issue: https://github.com/apache/zeppelin/pull/1369 Those changes are only for dependencies given in the interpreter definition, right? Using a %spark.dep section in a notebook seems to uses a SparkDependencyContext which does not inherit from

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-09 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 OK I'll merge if no more remarks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-09 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai Checked again and it works well! After removing the wrong dependency, the error message doesn't show up anymore. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-09 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai Yeah your screenshot is saying so. Let me test it again. Thanks for your quick response! --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-09 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @AhyoungRyu I followed your procedure but it works perfectly for me, see below screenshot. Did you clean your browser cache when testing the new commit ? Maybe there is some old JS co

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-09 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai So sorry for my late response ㅠ_ㅠ Tested again and checked >when you navigate to different pages, the error popups are removed. the above issue is gone! 👍

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-09 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @AhyoungRyu @astroshim Please tell me if it's ok so that I can merge. We need to merge this PR before I can move on the refactoring task (of changing `synchronized` blocks by appropri

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-03 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim @AhyoungRyu Please see the final result, it should make you both happy :) ![fixed error popups](https://cloud.githubusercontent.com/assets/1532977/19050426/d23f560e

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-01 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim @AhyoungRyu The wrong counting on error popup is now fixed. Every time you * reload the interpreter page * update an interpreter setting all the error

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-01 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @AhyoungRyu > The ng-toast error message is still shown as @astroshim said in the above comment. How about adding some timeout property to the message? I knew that there is a

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai Sorry for my late response and thanks for the kind reminder. I tested again and checked the below issues I mentioned are gone :D >(edit interpreter -> add `one:two:1.1.1` to t

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-18 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai Could you take a look at the following screenshot? After the `alluxio` and `angular` dependency error occurs, I just saved `alluxio` interpreter setting several times but the `ang

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-16 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim > the number seems doesn't match with count What do you mean by this ? Which number did you expect to see ? On the animated screencapture, the count started

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-16 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai I know that number means but as you can see the screenshot i attached, the number seems doesn't match with count. --- If your project is set up for it, you can reply to this email a

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-16 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim The number you see in front of each error popup is normal, it comes from the fact that now we set `combineDuplications = true` for **ngToast**. The number corresponds to t

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-16 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai Sorry to keep you waiting. It works like a charm now but the error count number at the beginning of message appears a little strange like following screen shot. ![st](https:

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-15 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @AhyoungRyu @astroshim Is the fix ok for you now ? The build is green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-08 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim @AhyoungRyu Ok I've found the issue, it's my bad: ```javascript for (var setting = 0; setting < $scope.interpreterSettings.length; setting++) { var

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-07 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim @AhyoungRyu it tooks me hours but I have found the root cause of the issue and it's pretty ugly. Ready to hear ? 1) First issue is we **do not** set the InterpreterSetting `s

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-06 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 O I've found the issue, it's tricky. I have added a non-existing dependency to the angular interpreter and I can also see a spinning circle forever. With Web Dev Console, I can see

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-06 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 Let me investigate the root cause, it should be some Javascript subtle bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1369 I also checked the interpreter setting page like @astroshim did. (edit interpreter -> add `one:two:1.1.1` to the dependency table -> save ) Two things are different with master br

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-05 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai Could you check the infinitely downloading library problem(like following screen shot)? Strangely this problem happens all interpreter except spark. Is this problem happen only

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-02 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim > BTW how come only spark interpreter shows error message bar? The error popup applies to all interpreters, try to add a fictive dependency to `angular` or `shell`

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-01 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1369 Proxy repo tested and it works properly. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-01 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai BTW how come only spark interpreter shows `error message bar`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-09-01 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1369 @doanduyhai Good. I am going to check first commit(proxy) soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-08-31 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim Done, now the popup error is only displayed once even if you update many other interpreters. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-08-31 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 Ok let me push a new commit with the `combineDuplications = true` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-08-31 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1369 Wow very quick response!!: I think set `combineDuplications` true is better but I don't have much talent in UI.:) --- If your project is set up for it, you can reply to this email and hav

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-08-31 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim It is explained above: > The problem is that $route.reload(); in the success callback of updateInterpreterSetting() will trigger init() then getInterpreterSettings(

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-08-31 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1369 About the second commits, Is it intended behavior that the error message bar is stacked whenever save the other interpreter setting? ![image](https://cloud.githubusercontent.com/assets/

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-08-31 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1369 @astroshim @minahlee Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-08-29 Thread doanduyhai
Github user doanduyhai commented on the issue: https://github.com/apache/zeppelin/pull/1369 @jongyoul Sorry, it was a bad copy/paste between Github & JIRA, fixed now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your