[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366832#comment-16366832 ] ASF GitHub Bot commented on ZOOKEEPER-2940: --- GitHub user anmolnar opened a pull request:

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/466 ZOOKEEPER-2940. Deal with maxbuffer as it relates to large requests from clients This PR covers the other part of Jute buffer monitoring which relates to client response sizes.

ZooKeeper_branch35_openjdk7 - Build # 848 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/848/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.77 KB...] [junit] Running

[SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

Hi all, I think it would be nice to draw a line at branch-3.5 and target Java version 8 onwards. It seems to be a good opportunity for the upgrade before we release a stable version of 3.5. The benefit would be the ability to use new features of Java 8 in the code: Do think it's feasible?

Re: [SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

We have this section in the admin doc that talks about the system requirements: https://zookeeper.apache.org/doc/r3.5.3-beta/zookeeperAdmin.html#sc_requiredSoftware If we change, then we have to update that

Failed: ZOOKEEPER- PreCommit Build #1486

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1486/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 111.87 MB...] [exec] +1

Failed: ZOOKEEPER- PreCommit Build #1488

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1488/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.02 MB...] [exec] +1

Success: ZOOKEEPER- PreCommit Build #1487

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1487/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.28 MB...] [exec]

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168793211 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -435,7 +435,7 @@ private void waitForOne(ZooKeeper zk, States

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168794042 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +888,127 @@ public void testWithOnlyMinSessionTimeout()

Failed: ZOOKEEPER- PreCommit Build #1494

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1494/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 6.56 KB...] [exec]

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367495#comment-16367495 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on a diff in the

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168807943 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +888,127 @@ public void testWithOnlyMinSessionTimeout()

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168807976 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +888,127 @@ public void testWithOnlyMinSessionTimeout()

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168807853 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +888,127 @@ public void testWithOnlyMinSessionTimeout()

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168807914 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +888,127 @@ public void testWithOnlyMinSessionTimeout()

Failed: ZOOKEEPER- PreCommit Build #1492

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1492/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.04 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367491#comment-16367491 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367497#comment-16367497 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367504#comment-16367504 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on a diff in the

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168793764 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +888,127 @@ public void testWithOnlyMinSessionTimeout()

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367492#comment-16367492 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168793569 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +888,127 @@ public void testWithOnlyMinSessionTimeout()

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168795633 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +888,127 @@ public void testWithOnlyMinSessionTimeout()

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367503#comment-16367503 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168795646 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -435,7 +435,7 @@ private void waitForOne(ZooKeeper zk, States

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367559#comment-16367559 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367562#comment-16367562 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367563#comment-16367563 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367561#comment-16367561 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on a diff in the

Re: [SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

+1 for setting the Java8 requirement on server side. *Client side.* I'd like the idea of the setting the requirement on client side too without introducing anything Java8 specific. I'm not planning to use Java8 features right on, just thinking of opening the gates would be useful in the long run.

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367329#comment-16367329 ] ASF GitHub Bot commented on ZOOKEEPER-2184: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r168763559 --- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java --- @@ -239,13 +243,13 @@ public void testSessionEstablishment() throws

Success: ZOOKEEPER- PreCommit Build #1490

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1490/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.32 MB...] [exec]

Success: ZOOKEEPER- PreCommit Build #1491

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1491/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.59 MB...] [exec]

Re: [SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

2018-02-16 14:20 GMT+01:00 Andor Molnar : > +1 for setting the Java8 requirement on server side. > > *Client side.* > I'd like the idea of the setting the requirement on client side too without > introducing anything Java8 specific. I'm not planning to use Java8 features >

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367304#comment-16367304 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user mfenes commented on the issue:

[GitHub] zookeeper issue #459: ZOOKEEPER-2967: Add check to validate dataDir and data...

Github user mfenes commented on the issue: https://github.com/apache/zookeeper/pull/459 @afine I've removed the whitespace changes. Please have a look if it looks right now. ---

Success: ZOOKEEPER- PreCommit Build #1489

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1489/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.29 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367332#comment-16367332 ] ASF GitHub Bot commented on ZOOKEEPER-2184: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r168764368 --- Diff: src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java --- @@ -119,6 +120,68 @@ public void testTwoInvalidHostAddresses() {

Success: ZOOKEEPER- PreCommit Build #1493

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1493/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.79 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #1495

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1495/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.34 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367809#comment-16367809 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367814#comment-16367814 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367823#comment-16367823 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on the issue:

[GitHub] zookeeper issue #453: ZOOKEEPER-2845: Apply commit log when restarting serve...

Github user revans2 commented on the issue: https://github.com/apache/zookeeper/pull/453 @afine and @anmolnar I think I have addressed all of your review comments, except for the one about the change to `waitForOne` and I am happy to adjust however you want there. ---

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168857052 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -435,7 +435,7 @@ private void waitForOne(ZooKeeper zk, States

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168857757 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +888,127 @@ public void testWithOnlyMinSessionTimeout()

Re: [SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

I'm a -1 on requiring different minimum versions of java for the client and the server. I think this has the potential to create a lot of confusion for users and contributors. I would support moving master (3.6) to java 8, I also think it is worth considering moving to java 9. Given how long

Success: ZOOKEEPER- PreCommit Build #1496

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1496/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 72.50 MB...] [exec]

[GitHub] zookeeper pull request #443: ZOOKEEPER-2955: Enable Clover code coverage rep...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/443#discussion_r168883423 --- Diff: build.xml --- @@ -1861,4 +1876,18 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> + --- End

[GitHub] zookeeper pull request #458: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user mfenes commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/458#discussion_r16396 --- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java --- @@ -368,22 +368,37 @@ static void verifyThreadTerminated(Thread thread, long millis)

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367962#comment-16367962 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user afine commented on a diff in the

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168887935 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +923,103 @@ public void testWithOnlyMinSessionTimeout()

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168884819 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -465,6 +470,37 @@ private void waitForAll(ZooKeeper[] zks, States

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367959#comment-16367959 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user mfenes commented on a diff in the

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168886064 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -888,4 +923,103 @@ public void testWithOnlyMinSessionTimeout()

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367949#comment-16367949 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367961#comment-16367961 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367960#comment-16367960 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367963#comment-16367963 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367972#comment-16367972 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user mfenes commented on a diff in the

[GitHub] zookeeper pull request #459: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user mfenes commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/459#discussion_r168889616 --- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java --- @@ -351,20 +351,37 @@ static void verifyThreadTerminated(Thread thread, long millis)

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user mfenes commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r168891236 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java --- @@ -35,92 +38,181 @@ public class

Success: ZOOKEEPER- PreCommit Build #1497

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1497/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.60 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367982#comment-16367982 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user mfenes commented on a diff in the

Success: ZOOKEEPER- PreCommit Build #1498

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1498/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.14 MB...] [exec]