Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/534
Unit test refactoring: https://issues.apache.org/jira/browse/ZOOKEEPER-3065
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar reassigned ZOOKEEPER-236:
--
Assignee: Andor Molnar (was: Abraham Fine)
> SSL Support for Atomic Broadcast
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/534#discussion_r196052286
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -314,7 +340,7 @@ public InetSocketAddress next(long spinDelay) {
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/542#discussion_r196062698
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -686,6 +686,8 @@ public void configure(InetSocketAddress addr, int
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/534#discussion_r196050719
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -149,15 +185,12 @@ public
StaticHostProvider(Collection
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515635#comment-16515635
]
Hadoop QA commented on ZOOKEEPER-2184:
--
+1 overall. GitHub Pull Request Build
+1
Github user maoling closed the pull request at:
https://github.com/apache/zookeeper/pull/348
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/534#discussion_r196049820
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -73,15 +80,27 @@
* if serverAddresses is empty
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/534
@hanm @lvfangmin Reconfig tests have previously been implemented only for
IP addresses and hasn't covered hostnames which need to be resolved. I added a
few unit tests for coverage, but found
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1842/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 86.13 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar updated ZOOKEEPER-3065:
Description:
The following issues would be nice to address:
* Tests cover addresses
Andor Molnar created ZOOKEEPER-3065:
---
Summary: Refactor existing reconfig tests in StaticHostProviderTest
Key: ZOOKEEPER-3065
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3065
Project:
Github user timothyjward commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/529#discussion_r196102971
--- Diff: src/java/main/org/apache/zookeeper/Watcher.java ---
@@ -84,7 +84,14 @@
* client connection (the session) is no longer
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1844/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 86.61 MB...]
[exec] +1
Michael is waiting for the master version of ZOOKEEPER-2184 to be committed.
I think I've addressed all the issues, so there shouldn't be any
blockers anymore.
Andor
On 06/18/2018 04:22 PM, Patrick Hunt wrote:
I'm just back from vacation so I may have missed it - Michael any progress
on
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/540
Is this PR valid? Looks like it was created by accident, if so, please
close it.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515743#comment-16515743
]
Hadoop QA commented on ZOOKEEPER-3009:
--
+1 overall. GitHub Pull Request Build
+1
Github user timothyjward commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/529#discussion_r196090467
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1260,10 +1260,8 @@ public void run() {
cleanup();
Github user timothyjward commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/529#discussion_r196119877
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1438,6 +1436,11 @@ public void disconnect() {
}
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515907#comment-16515907
]
Hadoop QA commented on ZOOKEEPER-2368:
--
+1 overall. GitHub Pull Request Build
+1
I'm just back from vacation so I may have missed it - Michael any progress
on this? Should we/can we start the release cycle? If not what's the
blocker?
Regards,
Patrick
On Tue, Jun 5, 2018 at 7:22 AM Michael Han wrote:
> >> Perhaps you can commit the 3.5/trunk changes for 2184 prior to the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515800#comment-16515800
]
Norbert Kalmar commented on ZOOKEEPER-1990:
---
Are you still working on this [~mfenes]?
I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515801#comment-16515801
]
Norbert Kalmar commented on ZOOKEEPER-2873:
---
Are you still working on this [~mfenes]?
>
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1843/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 39.87 MB...]
[exec] +1
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/529#discussion_r196256868
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1438,6 +1436,11 @@ public void disconnect() {
}
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516514#comment-16516514
]
Brian Nixon commented on ZOOKEEPER-2873:
With no one commenting in almost a year, this issue
26 matches
Mail list logo
