[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451120479 retest this please This is an automated message

[GitHub] Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451108446 one more test, found a bug :) This is an automated message

[GitHub] Humbedooh commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

Humbedooh commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451108446 one more test, found a bug :) This is an automated message from the

[GitHub] Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451108055 Please ignore this comment, checking JIRA integration. This

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451121539 retest this please This is an automated message from the Apache Git

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451125713 retest this please This is an automated message from the Apache Git

[GitHub] ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network

ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/730#issuecomment-451128577 retest this please This is an automated message from the Apache

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963490 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/EphemeralType.java ## @@ -212,7 +212,8

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963240 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ## @@ -18,6 +18,7 @@

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963646 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java ## @@

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244962944 ## File path: excludeFindBugsFilter.xml ## @@ -0,0 +1,14 @@ + + + Review comment: Naming is a little bit

[GitHub] anmolnar commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list

anmolnar commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list URL: https://github.com/apache/zookeeper/pull/744#issuecomment-451113306 @ivmaykov `QuorumSSLTest.testProtocolVersion` is failing, because TLSv1.1 participant is able to join TLSv1.2-only

[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451117487 retest this please This is an automated message

[GitHub] eolivelli commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4

eolivelli commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 URL: https://github.com/apache/zookeeper/pull/764#issuecomment-454775677 @anmolnar thank you for your review You are suggesting me to add a bunch of SuppressFBWarnings and do not add so many

[GitHub] nkalmar commented on issue #776: WIP - MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

nkalmar commented on issue #776: WIP - MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-454800700 retest this please This is an automated message from

[GitHub] asfgit closed pull request #735: ZOOKEEPER-3209: New `getEphemerals` api to get all the ephemeral nodes created by the session

asfgit closed pull request #735: ZOOKEEPER-3209: New `getEphemerals` api to get all the ephemeral nodes created by the session URL: https://github.com/apache/zookeeper/pull/735 This is an automated message from the Apache

[GitHub] anmolnar commented on issue #735: ZOOKEEPER-3209: New `getEphemerals` api to get all the ephemeral nodes created by the session

anmolnar commented on issue #735: ZOOKEEPER-3209: New `getEphemerals` api to get all the ephemeral nodes created by the session URL: https://github.com/apache/zookeeper/pull/735#issuecomment-454776601 Committed to master branch. Thanks @dineshappavoo !

[GitHub] anmolnar commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4

anmolnar commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 URL: https://github.com/apache/zookeeper/pull/764#issuecomment-454777080 @eolivelli Just drop all of them in the server's code to be on the safe side.

[GitHub] eolivelli commented on issue #775: get update

eolivelli commented on issue #775: get update URL: https://github.com/apache/zookeeper/pull/775#issuecomment-454378037 I think you should rebase to current master This is an automated message from the Apache Git Service. To

[GitHub] tamaashu commented on issue #775: get update

tamaashu commented on issue #775: get update URL: https://github.com/apache/zookeeper/pull/775#issuecomment-454347443 Hi @kevindai007, Are you sure, you wanted to do this? Regards, Tamaas This is an automated message

[GitHub] anmolnar commented on issue #778: ZOOKEEPER-3209: Fix compilation error

anmolnar commented on issue #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778#issuecomment-454966996 Merged. This is an automated message from the Apache Git Service. To respond to

[GitHub] asfgit closed pull request #778: ZOOKEEPER-3209: Fix compilation error

asfgit closed pull request #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] anmolnar opened a new pull request #778: ZOOKEEPER-3209: Fix compilation error

anmolnar opened a new pull request #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] dineshappavoo commented on issue #778: ZOOKEEPER-3209: Fix compilation error

dineshappavoo commented on issue #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778#issuecomment-454957210 LGTM  . Just wondering if I could have caught this in the pull request. Somehow it didn't show any issues in the original PR#735 CI run.

[GitHub] anmolnar commented on issue #778: ZOOKEEPER-3209: Fix compilation error

anmolnar commented on issue #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778#issuecomment-454966015 The response cache patch has tricked us. 9828685d20bc99272ec0689a590d27b0f8f7ebb6

[GitHub] vivekpatani commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types …

vivekpatani commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types … URL: https://github.com/apache/zookeeper/pull/760#issuecomment-454982760 @anmolnar looks like it works for me. We can close this PR out and just comment on the issue if anyone comes

[GitHub] ivmaykov commented on issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

ivmaykov commented on issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options URL: https://github.com/apache/zookeeper/pull/681#issuecomment-455003558 @anmolnar done This is an automated message from the Apache Git

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248513820 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -389,6

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248512925 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6 +224,24

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248513947 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java ## @@

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455006285 @anmolnar how can I reproduce the reconfig failures? Just checkout branch-3.5 and run

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248512738 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -90,6 +89,7 @@

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248512821 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKClientSSLContext.java ## @@ -0,0

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248513615 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -389,6

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455010472 @anmolnar we kept seeing `ReconfigTest` failures on our internal fork when it was run as part

[GitHub] ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455010472 @anmolnar we kept seeing `ReconfigTest` failures on our internal fork when it was run

[GitHub] anmolnar commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

anmolnar commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248768571 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -389,6

[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248804344 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java ##

[GitHub] anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types …

anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types … URL: https://github.com/apache/zookeeper/pull/760#issuecomment-455260317 @eolivelli Sure. I like the idea. This is an

[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248803778 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6

[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248803849 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -389,6

[GitHub] anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455234431 Thanks @ivmaykov for your efforts. Please take a quick look, but my opinion is pretty much the

[GitHub] eolivelli commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types …

eolivelli commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types … URL: https://github.com/apache/zookeeper/pull/760#issuecomment-455237059 @anmolnar the 'release' flag is available only from JDK9+ we need to put a bunch of "if/else" in

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248781573 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java ## @@

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455271738 @eolivelli @anmolnar after trying to get netty3 to work on OpenJDK11 for over an hour last

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248781133 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java ## @@

[GitHub] eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455060339 @ivmaykov unfortunately Netty 3 is not maintained and it does not deal well with the new way

[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248803778 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-455303614 @ivmaykov - Updated the PR to resolve the comments. I stuck with the nested classes in the tests since package-private classes couldn't be

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248848163 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKConfig.java ## @@ -18,6 +18,12

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248847815 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -238,18

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248849244 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -238,18

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248851355 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -238,18

[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248810192 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6

[GitHub] enixon commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

enixon commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455304304 thanks @ivmaykov ! This is an

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248804741 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6 +224,24

[GitHub] ivmaykov commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-455342423 +1 (non-binding), but please address nits from my last review pass. Great work :)

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248850022 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -406,26

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248848936 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -513,4

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248848580 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -406,26

[GitHub] jhuan31 commented on issue #769: ZOOKEEPER-3242: Add server side connecting throttling

jhuan31 commented on issue #769: ZOOKEEPER-3242: Add server side connecting throttling URL: https://github.com/apache/zookeeper/pull/769#issuecomment-455374564 added doc This is an automated message from the Apache Git

[GitHub] anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types …

anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types … URL: https://github.com/apache/zookeeper/pull/760#issuecomment-455232025 Thanks @vivekpatani . I think a patch is needed anyway to modify ant/maven scripts to use release flag instead

[GitHub] eolivelli closed pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration file

eolivelli closed pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/751 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] eolivelli opened a new pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration file

eolivelli opened a new pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/751 This is an automated message from the Apache Git Service. To respond to the

[GitHub] eolivelli opened a new pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration file

eolivelli opened a new pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/751 This is an automated message from the Apache Git Service. To respond to the

[GitHub] eolivelli closed pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration file

eolivelli closed pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/751 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] eolivelli commented on issue #751: ZOOKEEPER-3234: Add Travis-CI configuration file

eolivelli commented on issue #751: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/751#issuecomment-455261293 seems that master is still broken This is an automated message from

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248780258 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6 +224,24

[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248640955 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java ##

[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248630588 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6

[GitHub] nkalmar commented on issue #776: WIP - MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

nkalmar commented on issue #776: WIP - MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-455121201 > I think that in the base apache apache parent pom there is already a configuration for gpg and source plugin, but it

[GitHub] jhuan31 commented on a change in pull request #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider to verify the ensemble name

jhuan31 commented on a change in pull request #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider to verify the ensemble name URL: https://github.com/apache/zookeeper/pull/768#discussion_r249099004 ## File path:

[GitHub] jhuan31 closed pull request #771: ZOOKEEPER-3245: Add useful metrics for ZK pipeline and request/server…

jhuan31 closed pull request #771: ZOOKEEPER-3245: Add useful metrics for ZK pipeline and request/server… URL: https://github.com/apache/zookeeper/pull/771 This is an automated message from the Apache Git Service. To respond

[GitHub] jhuan31 commented on issue #769: ZOOKEEPER-3242: Add server side connecting throttling

jhuan31 commented on issue #769: ZOOKEEPER-3242: Add server side connecting throttling URL: https://github.com/apache/zookeeper/pull/769#issuecomment-455755507 here comes the unit tests This is an automated message from the

[GitHub] jhuan31 commented on issue #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c…

jhuan31 commented on issue #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c… URL: https://github.com/apache/zookeeper/pull/781#issuecomment-455756446 Enrico, I'm pretty late to the game and I think I missed earlier discussion about MetricsProvider. Could you

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r249220918 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -17,10 +17,28

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r249221188 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -403,6

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r249221054 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -17,11

[GitHub] jhuan31 opened a new pull request #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c…

jhuan31 opened a new pull request #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c… URL: https://github.com/apache/zookeeper/pull/781 …ounter set This is an automated message from the Apache Git

[GitHub] enixon commented on issue #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read …

enixon commented on issue #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read … URL: https://github.com/apache/zookeeper/pull/684#issuecomment-455695255 Creating ZOOKEEPER-3252 as a follow up. This is

[GitHub] maoling closed pull request #629: ZOOKEEPER-2641:AvgRequestLatency metric improves to be more accurate

maoling closed pull request #629: ZOOKEEPER-2641:AvgRequestLatency metric improves to be more accurate URL: https://github.com/apache/zookeeper/pull/629 This is an automated message from the Apache Git Service. To respond

[GitHub] maoling closed pull request #618: ZOOKEEPER-1011:fix Java Barrier Documentation example's race condition issue and polish up the Barrier Documentation

maoling closed pull request #618: ZOOKEEPER-1011:fix Java Barrier Documentation example's race condition issue and polish up the Barrier Documentation URL: https://github.com/apache/zookeeper/pull/618 This is an automated

[GitHub] maoling opened a new pull request #618: ZOOKEEPER-1011:fix Java Barrier Documentation example's race condition issue and polish up the Barrier Documentation

maoling opened a new pull request #618: ZOOKEEPER-1011:fix Java Barrier Documentation example's race condition issue and polish up the Barrier Documentation URL: https://github.com/apache/zookeeper/pull/618 - This patch fix the race condition of double barrier and avoid the herd effect.

[GitHub] lwjli opened a new pull request #782: ZOOKEEPER-3250: typo in doc - zookeeperInternals

lwjli opened a new pull request #782: ZOOKEEPER-3250: typo in doc - zookeeperInternals URL: https://github.com/apache/zookeeper/pull/782 "has long as" -> "as long as" This is an automated message from the Apache Git Service.

[GitHub] jhuan31 commented on issue #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c…

jhuan31 commented on issue #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c… URL: https://github.com/apache/zookeeper/pull/781#issuecomment-455929089 Thank you @eolivelli ! I'm more than happy to join the force. I will discuss with @lvfangmin I've

[GitHub] asfgit closed pull request #723: ZOOKEEPER-3202: Add timing margin to improve reliability of testClientServerSSL()

asfgit closed pull request #723: ZOOKEEPER-3202: Add timing margin to improve reliability of testClientServerSSL() URL: https://github.com/apache/zookeeper/pull/723 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list,

[GitHub] anmolnar commented on a change in pull request #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

anmolnar commented on a change in pull request #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options URL: https://github.com/apache/zookeeper/pull/681#discussion_r247509842 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@

[GitHub] anmolnar commented on issue #723: ZOOKEEPER-3202: Add timing margin to improve reliability of testClientServerSSL()

anmolnar commented on issue #723: ZOOKEEPER-3202: Add timing margin to improve reliability of testClientServerSSL() URL: https://github.com/apache/zookeeper/pull/723#issuecomment-454025950 Committed to 3.5 and master branches. Thanks @mkedwards !

[GitHub] nkalmar opened a new pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

nkalmar opened a new pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776 This is an automated message from the Apache Git Service. To respond to the

[GitHub] eolivelli commented on a change in pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

eolivelli commented on a change in pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#discussion_r248048607 ## File path: src/assembly/jar.xml ## @@ -0,0 +1,65 @@

[GitHub] anmolnar commented on issue #710: ZOOKEEPER-3195: TLS - disable client-initiated renegotiation

anmolnar commented on issue #710: ZOOKEEPER-3195: TLS - disable client-initiated renegotiation URL: https://github.com/apache/zookeeper/pull/710#issuecomment-454114192 Committed to 3.5 and master branches. Thanks @ivmaykov !

[GitHub] anmolnar commented on issue #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read …

anmolnar commented on issue #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read … URL: https://github.com/apache/zookeeper/pull/684#issuecomment-454113601 Committed to master branch. Thanks @enixon !

[GitHub] asfgit closed pull request #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read …

asfgit closed pull request #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read … URL: https://github.com/apache/zookeeper/pull/684 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@zookeeper.apache.org

[GitHub] asfgit closed pull request #710: ZOOKEEPER-3195: TLS - disable client-initiated renegotiation

asfgit closed pull request #710: ZOOKEEPER-3195: TLS - disable client-initiated renegotiation URL: https://github.com/apache/zookeeper/pull/710 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@zookeeper.apache.org

[GitHub] asfgit closed pull request #630: ZOOKEEPER-2284:LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

asfgit closed pull request #630: ZOOKEEPER-2284:LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully URL: https://github.com/apache/zookeeper/pull/630 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list,

[GitHub] anmolnar commented on issue #630: ZOOKEEPER-2284:LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

anmolnar commented on issue #630: ZOOKEEPER-2284:LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully URL: https://github.com/apache/zookeeper/pull/630#issuecomment-454115244 Committed to master branch, but cannot be cherry-picked to 3.5 Please create

[GitHub] anmolnar commented on issue #773: MAVEN MIGRATION - 3.5 - ZOOKEEPER-3122 - pom versions fix

anmolnar commented on issue #773: MAVEN MIGRATION - 3.5 - ZOOKEEPER-3122 - pom versions fix URL: https://github.com/apache/zookeeper/pull/773#issuecomment-454117748 Merged. Please close this PR. Thanks @nkalmar ! This is

[GitHub] anmolnar commented on issue #772: MAVEN MIGRATION - 3.4 - ZOOKEEPER-3122 - pom versions fix

anmolnar commented on issue #772: MAVEN MIGRATION - 3.4 - ZOOKEEPER-3122 - pom versions fix URL: https://github.com/apache/zookeeper/pull/772#issuecomment-454117853 Merged. Please close this PR. Thanks @nkalmar ! This is

[GitHub] eolivelli commented on issue #751: ZOOKEEPER-3234: Add Travis-CI configuration file

eolivelli commented on issue #751: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/751#issuecomment-454189783 It seems that this one is failing consistently on Travis [ERROR] Tests run: 24, Failures: 1, Errors: 0, Skipped: 0, Time

[GitHub] eolivelli commented on a change in pull request #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4

eolivelli commented on a change in pull request #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 URL: https://github.com/apache/zookeeper/pull/764#discussion_r247661250 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java

  1   2   3   4   5   6   7   8   9   10   >