Thank you guys
I have found another problem about fatjar.
There is a problem with apache rat check
This is the patch.
We are excluding one file from fatjar at the root pom, but it looks like
maven is going to execute rat even in fatjar module and this makes the
build fail.
I should also note that
sg. Merged onto both. Thanks all!
Patrick
On Sat, Apr 18, 2020 at 10:08 AM Enrico Olivelli
wrote:
> Patrick,
> Yes only to be merged to branch3.6 and release-3.6.1
>
> Thanks
> Enrico
>
> Il Sab 18 Apr 2020, 18:25 Christopher ha scritto:
>
> > 3.6.1 and the 3.6 branch. PR #1314 has been
Patrick,
Yes only to be merged to branch3.6 and release-3.6.1
Thanks
Enrico
Il Sab 18 Apr 2020, 18:25 Christopher ha scritto:
> 3.6.1 and the 3.6 branch. PR #1314 has been updated to address the same
> issues and more for master/3.7
>
> On Sat, Apr 18, 2020, 11:47 Patrick Hunt wrote:
>
> > I
3.6.1 and the 3.6 branch. PR #1314 has been updated to address the same
issues and more for master/3.7
On Sat, Apr 18, 2020, 11:47 Patrick Hunt wrote:
> I can take a look. Does this need to go into just 3.6.1 or other branches
> as well? The JIRA says just 3.6.1,is that right?
>
> Patrick
>
>
I can take a look. Does this need to go into just 3.6.1 or other branches
as well? The JIRA says just 3.6.1,is that right?
Patrick
On Sat, Apr 18, 2020 at 6:02 AM Enrico Olivelli wrote:
> PR is finally ready
> https://github.com/apache/zookeeper/pull/1323
>
> Looking for some committer to help
PR is finally ready
https://github.com/apache/zookeeper/pull/1323
Looking for some committer to help me merge that patch
Enrico
Il giorno sab 18 apr 2020 alle ore 12:42 Enrico Olivelli <
eolive...@gmail.com> ha scritto:
> Thank you Christopher
>
> We are iterating over #1323.
> I think we can
Thank you Christopher
We are iterating over #1323.
I think we can finish the work today
Enrico
Il giorno sab 18 apr 2020 alle ore 09:39 Christopher
ha scritto:
> +1 to that approach. I reviewed and made a suggestion on the PR at
> https://github.com/apache/zookeeper/pull/1323
>
> On Sat, Apr
+1 to that approach. I reviewed and made a suggestion on the PR at
https://github.com/apache/zookeeper/pull/1323
On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli wrote:
>
> This is my patch.
> Basically it adds back the fatjar module to the full-build profile
> this way we have only one profile
This is my patch.
Basically it adds back the fatjar module to the full-build profile
this way we have only one profile that actually does the "full build" = all
maven modules
I feel this is a very clear way for users,
mvn clean package -Pfull-build
this builds the whole repository
Enrico
Il
Hi,
Branch-3.6 is broken due to the fatjat stuff
[eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar
[INFO] Scanning for projects...
[ERROR] [ERROR] Project
'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is
duplicated in the reactor @
[ERROR] Project
Il Ven 17 Apr 2020, 08:50 Enrico Olivelli ha scritto:
> Thank you Christopher !
>
> I have manually fixed the pom.xml files in branch-3.6 and release-3.6.1
> branches.
>
> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is now
> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT)
>
Thank you Christopher !
I have manually fixed the pom.xml files in branch-3.6 and release-3.6.1
branches.
I would like to port ZOOKEEPER-3791 to branch-3.6 (that is now
3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT)
We need another binding +1 on ZOOKEEPER-3791, Benjamin Reed already
On Thu, Apr 16, 2020 at 9:52 AM Enrico Olivelli wrote:
>
> Christopher,
> answers inline.
> Thank you for testing !
>
> Il giorno gio 16 apr 2020 alle ore 15:12 Christopher
> ha scritto:
>
> > -0 (non-binding), I did find some problems that prevent some maven
> > profiles, including fatjar, from
-1 from me
I confirm Christopher's finding about the bad version 3.7.0-SNAPSHOT on
branch-3.6 and release-3.6.1.
I will also cherry pick ZOOKEEPER-3726
I will send a patch about the pom files tomorrow if no one else does it.
I am officially cancelling this VOTE thread
Regards
Enrico
Il
Christopher,
answers inline.
Thank you for testing !
Il giorno gio 16 apr 2020 alle ore 15:12 Christopher
ha scritto:
> -0 (non-binding), I did find some problems that prevent some maven
> profiles, including fatjar, from being activated, among other minor
> issues; nothing too serious, but the
-0 (non-binding), I did find some problems that prevent some maven
profiles, including fatjar, from being activated, among other minor
issues; nothing too serious, but the inability to run the fatjar
profile might be a blocker for some, as might be the missing patch for
ipv6 comparisons in the C
+1 (non-binding)
- I built the source code on Ubuntu 18.4 using OpenJDK 8u242 and maven
3.6.3.
- All the unit tests passed (both Java and C-client).
- Checkstyle passed
- I executed a rolling-upgrade test from 3.5.7 to 3.6.1. (using
https://github.com/symat/zk-rolling-upgrade-test)
Kind regards,
+1 - xsum/sig validated, rat ran clean, I was able to compile and ran some
manual tests on varying cluster sizes.
Patrick
On Wed, Apr 15, 2020 at 11:44 AM Enrico Olivelli
wrote:
> This is a release candidate for 3.6.1.
>
> It is a bugfix release and it introduces a few bugfixes and new
This is a release candidate for 3.6.1.
It is a bugfix release and it introduces a few bugfixes and new features in
these areas:
- compatibility with applications built against 3.5 client libraries
(restored a few non public APIs)
- update Netty to 4.1.48.Final
- ability to pass configuration as
19 matches
Mail list logo
