[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859061#comment-15859061
]
Hudson commented on ZOOKEEPER-2080:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3269 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859052#comment-15859052
]
Rakesh R commented on ZOOKEEPER-2080:
-
Thanks [~hanm] for the good work and others for the useful
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859025#comment-15859025
]
ASF GitHub Bot commented on ZOOKEEPER-2080:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858792#comment-15858792
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
This looks good, thanks Michael. I'm still
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858789#comment-15858789
]
Michael Han commented on ZOOKEEPER-2080:
Thanks Alex. I made a small change to address your
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858773#comment-15858773
]
ASF GitHub Bot commented on ZOOKEEPER-2080:
---
Github user hanm commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834049#comment-15834049
]
ASF GitHub Bot commented on ZOOKEEPER-2080:
---
Github user shralex commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830406#comment-15830406
]
ASF GitHub Bot commented on ZOOKEEPER-2080:
---
Github user eribeiro commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830354#comment-15830354
]
Hadoop QA commented on ZOOKEEPER-2080:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830331#comment-15830331
]
Michael Han commented on ZOOKEEPER-2080:
Update... current status of this issue:
* Rebased
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830313#comment-15830313
]
Hadoop QA commented on ZOOKEEPER-2080:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722843#comment-15722843
]
Hadoop QA commented on ZOOKEEPER-2080:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722835#comment-15722835
]
ASF GitHub Bot commented on ZOOKEEPER-2080:
---
Github user hanm commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15718771#comment-15718771
]
ASF GitHub Bot commented on ZOOKEEPER-2080:
---
Github user lvfangmin commented on a diff in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613237#comment-15613237
]
Ted Yu commented on ZOOKEEPER-2080:
---
Thanks for the effort, Michael.
> ReconfigRecoveryTest fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593437#comment-15593437
]
Hadoop QA commented on ZOOKEEPER-2080:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593405#comment-15593405
]
Michael Han commented on ZOOKEEPER-2080:
I've also left some comments on PR about the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593386#comment-15593386
]
ASF GitHub Bot commented on ZOOKEEPER-2080:
---
GitHub user hanm opened a pull request:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593380#comment-15593380
]
Michael Han commented on ZOOKEEPER-2080:
Getting back on this issue. I have another
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526260#comment-15526260
]
Flavio Junqueira commented on ZOOKEEPER-2080:
-
The only reason I had to suggest that we
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523711#comment-15523711
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
I see. Maybe in this case Flavio's
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523638#comment-15523638
]
Michael Han commented on ZOOKEEPER-2080:
Hi Alex, the constraint here is that we can't invoke
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523553#comment-15523553
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
I agree about the cause, but my suggestion
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519026#comment-15519026
]
Flavio Junqueira commented on ZOOKEEPER-2080:
-
I suspect that {{connectOne}} needs to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517870#comment-15517870
]
Michael Han commented on ZOOKEEPER-2080:
Thanks a ton for your feedback Alex, and Flavio. Had
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504624#comment-15504624
]
Flavio Junqueira commented on ZOOKEEPER-2080:
-
Here is a thought. {{connectOne}} is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495437#comment-15495437
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
If I'm not mistaken, when the configuration
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495429#comment-15495429
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
There is a lot of accesses to the config
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494088#comment-15494088
]
Michael Han commented on ZOOKEEPER-2080:
Regarding [~fpj]'s comment on
bq. I'm wondering why
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494073#comment-15494073
]
Michael Han commented on ZOOKEEPER-2080:
bq. The server will remain in the looking state,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490982#comment-15490982
]
Flavio Junqueira commented on ZOOKEEPER-2080:
-
On the race involving {{shuttingDownLE}},
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489395#comment-15489395
]
Hadoop QA commented on ZOOKEEPER-2080:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482766#comment-15482766
]
Michael Han commented on ZOOKEEPER-2080:
bq. The shut down of leader election doesn't need to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478360#comment-15478360
]
Flavio Junqueira commented on ZOOKEEPER-2080:
-
I thought a bit more about this. My
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475420#comment-15475420
]
Michael Han commented on ZOOKEEPER-2080:
bq. First, it is in general better to keep such
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475408#comment-15475408
]
Michael Han commented on ZOOKEEPER-2080:
Thanks for feedback, [~fpj]!
bq. Is it the case that
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471541#comment-15471541
]
Flavio Junqueira commented on ZOOKEEPER-2080:
-
[~hanm] [~shralex] [~phunt]
I gave it a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435457#comment-15435457
]
Patrick Hunt commented on ZOOKEEPER-2080:
-
[~fpj] can you take a look at this one as it's
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415657#comment-15415657
]
Michael Han commented on ZOOKEEPER-2080:
Failed test is TestReconfig.cc that is taking care of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415654#comment-15415654
]
Michael Han commented on ZOOKEEPER-2080:
Yup stress tested (which is why updating the patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415646#comment-15415646
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
+1 from me, assuming you tested the patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415607#comment-15415607
]
Hadoop QA commented on ZOOKEEPER-2080:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414666#comment-15414666
]
Michael Han commented on ZOOKEEPER-2080:
Alex, the explanation about having an atomic config +
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414491#comment-15414491
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
I'm not sure about removing the synchonized
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404190#comment-15404190
]
Michael Han commented on ZOOKEEPER-2080:
[~rgs] I did a search on previous Jenkins builds and
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403431#comment-15403431
]
Raul Gutierrez Segales commented on ZOOKEEPER-2080:
---
[~hanm]: thanks for the updated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403173#comment-15403173
]
Hadoop QA commented on ZOOKEEPER-2080:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403146#comment-15403146
]
Michael Han commented on ZOOKEEPER-2080:
[~rgs] Thanks for your feedback :)
bq. Do we really
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401425#comment-15401425
]
Raul Gutierrez Segales commented on ZOOKEEPER-2080:
---
[~hanm]: thanks for tracking
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396091#comment-15396091
]
Michael Han commented on ZOOKEEPER-2080:
Hi Alex, thanks for the review :)
bq. do you think
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394813#comment-15394813
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
Hi Michael, thanks for the patch, it looks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392825#comment-15392825
]
Michael Han commented on ZOOKEEPER-2080:
[~shralex] Thanks for all the feedback so far:). I am
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392817#comment-15392817
]
Michael Han commented on ZOOKEEPER-2080:
ZOOKEEPER-2488 to track this.
> ReconfigRecoveryTest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392565#comment-15392565
]
Michael Han commented on ZOOKEEPER-2080:
bq. Which isn't synchronized now, but probably should
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391189#comment-15391189
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
On second thought, this may not work. There
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391182#comment-15391182
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
Michael, thanks for the patch! I was
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390256#comment-15390256
]
Michael Han commented on ZOOKEEPER-2080:
Friendly nudge [~shralex], [~rgs] - not sure if you
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345538#comment-15345538
]
Michael Han commented on ZOOKEEPER-2080:
Both failed tests on hudson bot might be flaky as
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345469#comment-15345469
]
Hadoop QA commented on ZOOKEEPER-2080:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345456#comment-15345456
]
Michael Han commented on ZOOKEEPER-2080:
The root cause of FLE shutdown never returns is a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334720#comment-15334720
]
Michael Han commented on ZOOKEEPER-2080:
I've been trying reproduce the failure cases and
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321959#comment-15321959
]
Raul Gutierrez Segales commented on ZOOKEEPER-2080:
---
[~hanm]: sure — go for it.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321770#comment-15321770
]
Michael Han commented on ZOOKEEPER-2080:
I'd like to take a stab here and assign this issue to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14747006#comment-14747006
]
Akihiro Suda commented on ZOOKEEPER-2080:
-
We don't need to use
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740513#comment-14740513
]
Akihiro Suda commented on ZOOKEEPER-2080:
-
Looking at JaCoCo reports, I also noticed that
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696525#comment-14696525
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
Thanks for continuing to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698003#comment-14698003
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698002#comment-14698002
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
I looked at the logs from
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575180#comment-14575180
]
Chris Nauroth commented on ZOOKEEPER-2080:
--
We've also seen some intermittent
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526264#comment-14526264
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
I also couldn't reproduce,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526245#comment-14526245
]
Raul Gutierrez Segales commented on ZOOKEEPER-2080:
---
It passes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526269#comment-14526269
]
Raul Gutierrez Segales commented on ZOOKEEPER-2080:
---
Actually, it's
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526266#comment-14526266
]
Raul Gutierrez Segales commented on ZOOKEEPER-2080:
---
Hmmm,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526272#comment-14526272
]
Alexander Shraer commented on ZOOKEEPER-2080:
-
I see. thanks for looking
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369593#comment-14369593
]
Ted Yu commented on ZOOKEEPER-2080:
---
Looks like the test doesn't fail recently.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14209836#comment-14209836
]
Flavio Junqueira commented on ZOOKEEPER-2080:
-
I think this is the same
76 matches
Mail list logo