[jira] [Commented] (ZOOKEEPER-2870) Improve the efficiency of AtomicFileOutputStream
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122276#comment-16122276 ] Hudson commented on ZOOKEEPER-2870: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3493 (See [https://builds.apache.org/job/ZooKeeper-trunk/3493/]) ZOOKEEPER-2870: Improve the efficiency of AtomicFileOutputStream (hanm: rev 0c5b320060bdda854b530dc8a22993ba8cbbd655) * (edit) src/java/main/org/apache/zookeeper/common/AtomicFileOutputStream.java > Improve the efficiency of AtomicFileOutputStream > > > Key: ZOOKEEPER-2870 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2870 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.10, 3.5.3, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv > Fix For: 3.5.4, 3.6.0, 3.4.11 > > > The AtomicFileOutputStream extends from FilterOutputStream, where the write > function writes data to underlying stream byte by byte: > https://searchcode.com/codesearch/view/17990706/, which is very inefficient. > Currently, we only this this class to write the dynamic config, because it's > quite small it won't be a big problem. But in the future we may want to use > this class to write the snapshot file, which will take much longer time, > tested inside, writing 600MB snapshot will take more than 10 minutes, while > using FileOutputStream directly only takes 6s. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2870) Improve the efficiency of AtomicFileOutputStream
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122255#comment-16122255 ] ASF GitHub Bot commented on ZOOKEEPER-2870: --- Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/331 Committed to master: https://github.com/apache/zookeeper/commit/0c5b320060bdda854b530dc8a22993ba8cbbd655 3.5: https://github.com/apache/zookeeper/commit/c815380191ac300410d5f017cb4946b442e1dd65 3.4: https://github.com/apache/zookeeper/commit/9959b0e4387c02e82fadb0aee8d59f6212a2757e > Improve the efficiency of AtomicFileOutputStream > > > Key: ZOOKEEPER-2870 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2870 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.10, 3.5.3, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv > Fix For: 3.5.4, 3.6.0, 3.4.11 > > > The AtomicFileOutputStream extends from FilterOutputStream, where the write > function writes data to underlying stream byte by byte: > https://searchcode.com/codesearch/view/17990706/, which is very inefficient. > Currently, we only this this class to write the dynamic config, because it's > quite small it won't be a big problem. But in the future we may want to use > this class to write the snapshot file, which will take much longer time, > tested inside, writing 600MB snapshot will take more than 10 minutes, while > using FileOutputStream directly only takes 6s. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2870) Improve the efficiency of AtomicFileOutputStream
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122251#comment-16122251 ] ASF GitHub Bot commented on ZOOKEEPER-2870: --- Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/331 > Improve the efficiency of AtomicFileOutputStream > > > Key: ZOOKEEPER-2870 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2870 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.10, 3.5.3, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv > > The AtomicFileOutputStream extends from FilterOutputStream, where the write > function writes data to underlying stream byte by byte: > https://searchcode.com/codesearch/view/17990706/, which is very inefficient. > Currently, we only this this class to write the dynamic config, because it's > quite small it won't be a big problem. But in the future we may want to use > this class to write the snapshot file, which will take much longer time, > tested inside, writing 600MB snapshot will take more than 10 minutes, while > using FileOutputStream directly only takes 6s. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2870) Improve the efficiency of AtomicFileOutputStream
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120593#comment-16120593 ] Hadoop QA commented on ZOOKEEPER-2870: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/933//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/933//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/933//console This message is automatically generated. > Improve the efficiency of AtomicFileOutputStream > > > Key: ZOOKEEPER-2870 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2870 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.10, 3.5.3, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv > > The AtomicFileOutputStream extends from FilterOutputStream, where the write > function writes data to underlying stream byte by byte: > https://searchcode.com/codesearch/view/17990706/, which is very inefficient. > Currently, we only this this class to write the dynamic config, because it's > quite small it won't be a big problem. But in the future we may want to use > this class to write the snapshot file, which will take much longer time, > tested inside, writing 600MB snapshot will take more than 10 minutes, while > using FileOutputStream directly only takes 6s. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2870) Improve the efficiency of AtomicFileOutputStream
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120565#comment-16120565 ] ASF GitHub Bot commented on ZOOKEEPER-2870: --- GitHub user lvfangmin opened a pull request: https://github.com/apache/zookeeper/pull/331 [ZOOKEEPER-2870] Improve the efficiency of AtomicFileOutputStream You can merge this pull request into a Git repository by running: $ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-2870 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #331 commit 7154ccd9c0fa489b070645ba3bcfc4c9e25d4683 Author: Fangmin Lyu Date: 2017-08-09T20:01:02Z [ZOOKEEPER-2870] Improve the efficiency of AtomicFileOutputStream > Improve the efficiency of AtomicFileOutputStream > > > Key: ZOOKEEPER-2870 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2870 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.10, 3.5.3, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv > > The AtomicFileOutputStream extends from FilterOutputStream, where the write > function writes data to underlying stream byte by byte: > https://searchcode.com/codesearch/view/17990706/, which is very inefficient. > Currently, we only this this class to write the dynamic config, because it's > quite small it won't be a big problem. But in the future we may want to use > this class to write the snapshot file, which will take much longer time, > tested inside, writing 600MB snapshot will take more than 10 minutes, while > using FileOutputStream directly only takes 6s. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
