Re: Version.getRevision gone in 3.5.6
I was just working on it, you already reviewed it. I fixed the javadoc comment you mentioned, please check again :) Thanks! - Norbert On Thu, Apr 2, 2020 at 10:42 AM Enrico Olivelli wrote: > I would like to release 3.6.1 soon. > Can you send a patch? > > Enrico > > Il Mer 1 Apr 2020, 13:09 Norbert Kalmar ha > scritto: > > > I'll create a jira and the PR. I guess we should just return -1, that's > > what 3.5.5 did anyway: > > > > > https://github.com/apache/zookeeper/blob/branch-3.5.5/zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java#L87 > > > > And keep it on 3.6 as well? Fine by me. So put this function back in > 3.5.8 > > and 3.6.1 only, leave master (3.7 or 4.0? :) ) out of it? > > > > On Wed, Apr 1, 2020 at 12:52 PM Szalay-Bekő Máté < > > szalay.beko.m...@gmail.com> > > wrote: > > > > > I agree with you. > > > Also as far as I can remember on some of my leader election bug jira > > > tickets people asked when the next 3.5.x release would happen. > > > > > > Kind regards, > > > Mate > > > > > > On Wed, Apr 1, 2020 at 12:18 PM Enrico Olivelli > > > wrote: > > > > > > > We should restore it as we did for ZKUtils#delete > > > > > > > > Both in 3.5x and in 3.6 > > > > We just ensure smooth upgrade > > > > > > > > > > > > Enrico > > > > > > > > Il Mer 1 Apr 2020, 12:06 Norbert Kalmar > > > > ha > > > > scritto: > > > > > > > > > Hi all, > > > > > > > > > > We removed the getRevision() [1] function in 3.5.6 [2]. > > > > > I just tried updating to ZooKeeper 3.5.7 in our system, but HBase > is > > > not > > > > > happy with this. It gets ZooKeeper's revision using this method. It > > is > > > > true > > > > > HBase could just move to using getRevisionHash, but they are still > > > using > > > > > 3.4.x, and getRevisionHash is not available there. So I can't just > > move > > > > the > > > > > the new function to be both compatible with 3.4 and 3.5.6+, > > > > unfortunately. > > > > > > > > > > Long story short, we removed a public function in a bugfix release > > (in > > > > > 3.5.5 it is still there). > > > > > With 3.5.5 our internal system works fine, but can't build with > 3.5.7 > > > (or > > > > > 3.5.6) because of this change. > > > > > > > > > > My question: should we reinstate this function, and maybe do a > 3.5.8 > > > > > release? Who knows who else runs into this problem. > > > > > Any thoughts? > > > > > > > > > > - Norbert > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://github.com/apache/zookeeper/commit/41da3c8e3c39f81aa0f667199c5f4eb3d5a28adc#diff-12bf6d03d211704a4f04cb234a20bf2aL23 > > > > > [2] > > > > > > > > > > > > > > > > > > > > https://github.com/apache/zookeeper/commit/96880c0b2ba39f1841f8bdc4a0119a467b462d03#diff-1d42dde48d42e3baf819e22b56a880a7 > > > > > > > > > > > > > > >
Re: Version.getRevision gone in 3.5.6
I would like to release 3.6.1 soon. Can you send a patch? Enrico Il Mer 1 Apr 2020, 13:09 Norbert Kalmar ha scritto: > I'll create a jira and the PR. I guess we should just return -1, that's > what 3.5.5 did anyway: > > https://github.com/apache/zookeeper/blob/branch-3.5.5/zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java#L87 > > And keep it on 3.6 as well? Fine by me. So put this function back in 3.5.8 > and 3.6.1 only, leave master (3.7 or 4.0? :) ) out of it? > > On Wed, Apr 1, 2020 at 12:52 PM Szalay-Bekő Máté < > szalay.beko.m...@gmail.com> > wrote: > > > I agree with you. > > Also as far as I can remember on some of my leader election bug jira > > tickets people asked when the next 3.5.x release would happen. > > > > Kind regards, > > Mate > > > > On Wed, Apr 1, 2020 at 12:18 PM Enrico Olivelli > > wrote: > > > > > We should restore it as we did for ZKUtils#delete > > > > > > Both in 3.5x and in 3.6 > > > We just ensure smooth upgrade > > > > > > > > > Enrico > > > > > > Il Mer 1 Apr 2020, 12:06 Norbert Kalmar > > ha > > > scritto: > > > > > > > Hi all, > > > > > > > > We removed the getRevision() [1] function in 3.5.6 [2]. > > > > I just tried updating to ZooKeeper 3.5.7 in our system, but HBase is > > not > > > > happy with this. It gets ZooKeeper's revision using this method. It > is > > > true > > > > HBase could just move to using getRevisionHash, but they are still > > using > > > > 3.4.x, and getRevisionHash is not available there. So I can't just > move > > > the > > > > the new function to be both compatible with 3.4 and 3.5.6+, > > > unfortunately. > > > > > > > > Long story short, we removed a public function in a bugfix release > (in > > > > 3.5.5 it is still there). > > > > With 3.5.5 our internal system works fine, but can't build with 3.5.7 > > (or > > > > 3.5.6) because of this change. > > > > > > > > My question: should we reinstate this function, and maybe do a 3.5.8 > > > > release? Who knows who else runs into this problem. > > > > Any thoughts? > > > > > > > > - Norbert > > > > > > > > [1] > > > > > > > > > > > > > > https://github.com/apache/zookeeper/commit/41da3c8e3c39f81aa0f667199c5f4eb3d5a28adc#diff-12bf6d03d211704a4f04cb234a20bf2aL23 > > > > [2] > > > > > > > > > > > > > > https://github.com/apache/zookeeper/commit/96880c0b2ba39f1841f8bdc4a0119a467b462d03#diff-1d42dde48d42e3baf819e22b56a880a7 > > > > > > > > > >
Re: Version.getRevision gone in 3.5.6
I'll create a jira and the PR. I guess we should just return -1, that's what 3.5.5 did anyway: https://github.com/apache/zookeeper/blob/branch-3.5.5/zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java#L87 And keep it on 3.6 as well? Fine by me. So put this function back in 3.5.8 and 3.6.1 only, leave master (3.7 or 4.0? :) ) out of it? On Wed, Apr 1, 2020 at 12:52 PM Szalay-Bekő Máté wrote: > I agree with you. > Also as far as I can remember on some of my leader election bug jira > tickets people asked when the next 3.5.x release would happen. > > Kind regards, > Mate > > On Wed, Apr 1, 2020 at 12:18 PM Enrico Olivelli > wrote: > > > We should restore it as we did for ZKUtils#delete > > > > Both in 3.5x and in 3.6 > > We just ensure smooth upgrade > > > > > > Enrico > > > > Il Mer 1 Apr 2020, 12:06 Norbert Kalmar > ha > > scritto: > > > > > Hi all, > > > > > > We removed the getRevision() [1] function in 3.5.6 [2]. > > > I just tried updating to ZooKeeper 3.5.7 in our system, but HBase is > not > > > happy with this. It gets ZooKeeper's revision using this method. It is > > true > > > HBase could just move to using getRevisionHash, but they are still > using > > > 3.4.x, and getRevisionHash is not available there. So I can't just move > > the > > > the new function to be both compatible with 3.4 and 3.5.6+, > > unfortunately. > > > > > > Long story short, we removed a public function in a bugfix release (in > > > 3.5.5 it is still there). > > > With 3.5.5 our internal system works fine, but can't build with 3.5.7 > (or > > > 3.5.6) because of this change. > > > > > > My question: should we reinstate this function, and maybe do a 3.5.8 > > > release? Who knows who else runs into this problem. > > > Any thoughts? > > > > > > - Norbert > > > > > > [1] > > > > > > > > > https://github.com/apache/zookeeper/commit/41da3c8e3c39f81aa0f667199c5f4eb3d5a28adc#diff-12bf6d03d211704a4f04cb234a20bf2aL23 > > > [2] > > > > > > > > > https://github.com/apache/zookeeper/commit/96880c0b2ba39f1841f8bdc4a0119a467b462d03#diff-1d42dde48d42e3baf819e22b56a880a7 > > > > > >
Re: Version.getRevision gone in 3.5.6
I agree with you. Also as far as I can remember on some of my leader election bug jira tickets people asked when the next 3.5.x release would happen. Kind regards, Mate On Wed, Apr 1, 2020 at 12:18 PM Enrico Olivelli wrote: > We should restore it as we did for ZKUtils#delete > > Both in 3.5x and in 3.6 > We just ensure smooth upgrade > > > Enrico > > Il Mer 1 Apr 2020, 12:06 Norbert Kalmar ha > scritto: > > > Hi all, > > > > We removed the getRevision() [1] function in 3.5.6 [2]. > > I just tried updating to ZooKeeper 3.5.7 in our system, but HBase is not > > happy with this. It gets ZooKeeper's revision using this method. It is > true > > HBase could just move to using getRevisionHash, but they are still using > > 3.4.x, and getRevisionHash is not available there. So I can't just move > the > > the new function to be both compatible with 3.4 and 3.5.6+, > unfortunately. > > > > Long story short, we removed a public function in a bugfix release (in > > 3.5.5 it is still there). > > With 3.5.5 our internal system works fine, but can't build with 3.5.7 (or > > 3.5.6) because of this change. > > > > My question: should we reinstate this function, and maybe do a 3.5.8 > > release? Who knows who else runs into this problem. > > Any thoughts? > > > > - Norbert > > > > [1] > > > > > https://github.com/apache/zookeeper/commit/41da3c8e3c39f81aa0f667199c5f4eb3d5a28adc#diff-12bf6d03d211704a4f04cb234a20bf2aL23 > > [2] > > > > > https://github.com/apache/zookeeper/commit/96880c0b2ba39f1841f8bdc4a0119a467b462d03#diff-1d42dde48d42e3baf819e22b56a880a7 > > >
Re: Version.getRevision gone in 3.5.6
We should restore it as we did for ZKUtils#delete Both in 3.5x and in 3.6 We just ensure smooth upgrade Enrico Il Mer 1 Apr 2020, 12:06 Norbert Kalmar ha scritto: > Hi all, > > We removed the getRevision() [1] function in 3.5.6 [2]. > I just tried updating to ZooKeeper 3.5.7 in our system, but HBase is not > happy with this. It gets ZooKeeper's revision using this method. It is true > HBase could just move to using getRevisionHash, but they are still using > 3.4.x, and getRevisionHash is not available there. So I can't just move the > the new function to be both compatible with 3.4 and 3.5.6+, unfortunately. > > Long story short, we removed a public function in a bugfix release (in > 3.5.5 it is still there). > With 3.5.5 our internal system works fine, but can't build with 3.5.7 (or > 3.5.6) because of this change. > > My question: should we reinstate this function, and maybe do a 3.5.8 > release? Who knows who else runs into this problem. > Any thoughts? > > - Norbert > > [1] > > https://github.com/apache/zookeeper/commit/41da3c8e3c39f81aa0f667199c5f4eb3d5a28adc#diff-12bf6d03d211704a4f04cb234a20bf2aL23 > [2] > > https://github.com/apache/zookeeper/commit/96880c0b2ba39f1841f8bdc4a0119a467b462d03#diff-1d42dde48d42e3baf819e22b56a880a7 >
