Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

Leif, thanks for reviewing, a question inlined. > -Original Message- > From: Leif Lindholm > Sent: Wednesday, May 29, 2019 10:43 PM > To: Loh, Tien Hock > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel > ; Kinney, Michael D > > Subject: Re: [[edk2-platforms]PATCH v4 1/1]

Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei

> -Original Message- > From: Gao, Zhichao > Sent: Thursday, May 30, 2019 11:21 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Bret Barkelew; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean > Brogan; > Michael Turner > Subject: RE: [PATCH] MdeModulePkg/CapsulePei: Optimize the

Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

> -Original Message- > From: Wu, Hao A > Sent: Thursday, May 30, 2019 9:03 AM > To: devel@edk2.groups.io; Loh, Tien Hock ; > thlo...@gmail.com > Cc: Ard Biesheuvel ; Leif Lindholm > ; Kinney, Michael D > > Subject: RE: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add >

[edk2-devel] [PATCH v2] IntelFsp2Pkg/SplitFspBin.py: Support rebasing 1.x binary.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1308 Support rebasing FSP 1.x binary. FSP 1.x has single component in binary so not supported by split command and rebase can be done with the same command for rebasing FSP-T component in FSP 2.x image. Test: both FSP 2.x (Kabylake) and FSP 1.x

Re: [edk2-devel] [PATCH v2 0/5] Implement SM3 measured boot

Hi Imran, You're using non-existing api in this patch series. The openssl upgrading patch (BZ1089) won't provide them as well. Please wait for another patch. Xiaoyu is working on it. Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf

Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei

> -Original Message- > From: Wu, Hao A > Sent: Wednesday, May 29, 2019 2:55 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Bret Barkelew ; Wang, Jian J > ; Ni, Ray ; Zeng, Star > ; Gao, Liming ; Sean Brogan > ; Michael Turner > > Subject: RE: [PATCH] MdeModulePkg/CapsulePei:

Re: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache

The "entend" should be "extend", right? I can fix it when I push this patch. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi Sent: Thursday, May 30, 2019 10:31 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng,

[edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache

https://bugzilla.tianocore.org/show_bug.cgi?id=1797 Current binary cache doesn't support to save and restore the library module. If a driver module cache miss happen, all its dependency library modules need rebuild which is very time-consuming. This patch is to entend the binary cache to support

[edk2-devel] [PATCH v3 0/1] BaseTools:Extend the binary cache to support library

V3 change: Update the commit message and move the change notices in cover letter V2 change: Simplify the library cache implementation and remove CacheRestored flag based filter. Use the current CanSkipbyHash() filter in AddDependency() instead V1: Initial version to enable the library cache

Re: [edk2-devel] [PATCH v2] BaseTools:Extend the binary cache to support library cache

OK, will move the change notices from commit message to cover letter. Thanks Steven Shi > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, May 29, 2019 7:14 PM > To: devel@edk2.groups.io; Shi, Steven > Cc: Gao, Liming ; Feng, Bob C ; >

Re: [edk2-devel] [PATCH] BaseTools:Update binary cache restore time to current time

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi Sent: Tuesday, May 28, 2019 4:35 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian ; Fan, ZhijuX Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

OK. For this patch, Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, May 29, 2019 4:25 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Gao, Liming Subject: RE: [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE The Dict parameter

[edk2-devel] RFC for edk2-tools-library v2 previously known as RFC for Edk2-Library

RFC  edk2-tools-library creation Create a new tianocore owned repository to host a python library package in support of UEFI development.  This package will allow easy sharing of python library code to facilitate reuse.  Inclusion of this package and dependency management should be managed

Re: [edk2-devel] Maintainers.txt: update UEFI payload information

Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Guo Dong >Sent: Thursday, May 30, 2019 3:07 AM >To: devel@edk2.groups.io >Cc: Ma, Maurice ; You, Benjamin >; Dong, Guo ; Agyeman, >Prince >Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSplitBin.py: Support rebasing 1.x binary.

Yes. I will update the document. Thanks! Chasel > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 29, 2019 11:20 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: RE: [PATCH] IntelFsp2Pkg/FspSplitBin.py:

Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Loh, Tien Hock > Sent: Thursday, May 09, 2019 4:56 PM > To: devel@edk2.groups.io; thlo...@gmail.com > Cc: Loh, Tien Hock; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D > Subject: [edk2-devel]

[edk2-devel] Maintainers.txt: update UEFI payload information

Remove CorebootModulePkg and CorebootPayloadPkg, and add UefiPayloadPkg to reflect recently change in UEFI payload. wiki link for UefiPayloadPkg would be available soon. Signed-off-by: Guo Dong --- Maintainers.txt | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver

Since legacy PIC 8259 driver would be removed from edk2, update UEFI payload to remove 8259 driver. If required, bootloader could disable 8259. Signed-off-by: Guo Dong --- UefiPayloadPkg/UefiPayloadPkg.fdf| 1 - UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 1 -

Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/Secure96Dxe: redefine LS connector CS as platform property

On Wed, 29 May 2019 at 16:43, Leif Lindholm wrote: > > On Wed, May 29, 2019 at 03:14:48PM +0200, Ard Biesheuvel wrote: > > On Wed, 29 May 2019 at 15:06, Leif Lindholm > > wrote: > > > > > > On Wed, May 29, 2019 at 02:50:19PM +0200, Ard Biesheuvel wrote: > > > > As opposed to the Secure96's I2C

Re: [edk2-devel] [PATCH for-edk2-stable201905 5/6] OvmfPkg: raise the PCIEXBAR base to 2816 MB on Q35

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > (This is a replacement for commit 75136b29541b, "OvmfPkg/PlatformPei: > reorder the 32-bit PCI window vs. the PCIEXBAR on q35", 2019-05-16). > > Commit 7b8fe63561b4 ("OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG > / ECAM) on Q35", 2016-03-10)

[edk2-devel] [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804 Add a check to see if [Sources] section lists all the header type files of a module. Performance impact should be minimal with this patch since information is already being fetched for Makefile purposes. All other information is already

[edk2-devel] [Patch V4 0/2] BaseTools: Add a checking for Sources section and update hashing feature

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804 In V4: Update commit messages. In V3: Seperate checker and hashing into individual patches In V2: Enable check for all builds, move conditional to hash invalidation In the Edk2 INF spec 3.9, it states, All HII Unicode format files must be

[edk2-devel] [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804 After adding a check to see if [Sources] section lists all the header type files of a module, track module and library hashes for --hash feature. If above check is not in compilance for a library or module, force hash invalidation on that

Re: [edk2-devel] contribution of code licensed other than bsd+patent

Hi Liming, Yes, the license is not a problem. My concern is that third party code, regardless of license, contributed while the TianoCore Contribution agreement was used was covered by the clause: * Contributor grants a license (with the right to sublicense) under claims of

Re: [edk2-devel] [PATCH v5 0/9] Crypto: Upgrade OpenSSL to 1.1.1b

For this patch series, Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Xiaoyu Lu > Sent: Wednesday, May 29, 2019 6:40 PM > To: devel@edk2.groups.io > Cc: Lu, XiaoyuX ; Wang, Jian J ; > Ye, Ting ; Laszlo Ersek >

Re: [edk2-devel] [PATCH for-edk2-stable201905 4/6] Revert "OvmfPkg/PlatformPei: assign PciSize on both i440fx/q35 branches explicitly"

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > This reverts commit 60e95bf5094fbb9b728729ccfaf32184b3662317. > > The original fix for > triggered a bug / incorrect assumption in QEMU. > > QEMU assumes that the PCIEXBAR is below the 32-bit PCI

Re: [edk2-devel] [PATCH for-edk2-stable201905 2/6] Revert "OvmfPkg/PlatformPei: reorder the 32-bit PCI window vs. the PCIEXBAR on q35"

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > This reverts commit 75136b29541b0e093a51d2e2c2af8d19855c2b60. > > The original fix for > triggered a bug / incorrect assumption in QEMU. > > QEMU assumes that the PCIEXBAR is below the 32-bit PCI

Re: [edk2-devel] [PATCH for-edk2-stable201905 3/6] Revert "OvmfPkg/PlatformPei: hoist PciBase assignment above the i440fx/q35 branching"

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > This reverts commit 9a2e8d7c65ef7f39c6754d27e52954b616bc6628. > > The original fix for > triggered a bug / incorrect assumption in QEMU. > > QEMU assumes that the PCIEXBAR is below the 32-bit PCI

Re: [edk2-devel] [PATCH for-edk2-stable201905 1/6] Revert "OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits clear"

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > This reverts commit 39b9a5ffe6618b7870be2a54fe7725000249c33a. > > The original fix for > triggered a bug / incorrect assumption in QEMU. > > QEMU assumes that the PCIEXBAR is below the 32-bit PCI

Re: [edk2-devel] contribution of code licensed other than bsd+patent

Leif: I review Readme.md. I think we can add the additional license for SoftFloat-3e like other third party code. The change is as below. Is it OK? --- a/Readme.md +++ b/Readme.md @@ -16,6 +16,7 @@ contains the following components that are covered by additional licenses: *

Re: [edk2-devel] [PATCH for-edk2-stable201905 0/6] work around a QEMU issue triggered by the original TianoCore#1814 fix

On Wed, 29 May 2019 at 17:12, Laszlo Ersek wrote: > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1859 > Repo: https://github.com/lersek/edk2.git > Branch: exbar_mtrr_bz_1859 > > The fix (commit range 3b7a897cd8e3..39b9a5ffe661) for >

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSplitBin.py: Support rebasing 1.x binary.

Shouldn't the SplitFspBinUserManual.md also be updated? Thanks, Star > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, May 29, 2019 10:33 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg/FspSplitBin.py:

[edk2-devel] [PATCH for-edk2-stable201905 6/6] OvmfPkg/PlatformPei: set 32-bit UC area at PciBase / PciExBarBase (pc/q35)

(This is a replacement for commit 39b9a5ffe661 ("OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits clear", 2019-05-16).) Reintroduce the same logic as seen in commit 39b9a5ffe661 for the pc (i440fx) board type. For q35, the same approach doesn't work any longer, given that (a)

[edk2-devel] [PATCH for-edk2-stable201905 5/6] OvmfPkg: raise the PCIEXBAR base to 2816 MB on Q35

(This is a replacement for commit 75136b29541b, "OvmfPkg/PlatformPei: reorder the 32-bit PCI window vs. the PCIEXBAR on q35", 2019-05-16). Commit 7b8fe63561b4 ("OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / ECAM) on Q35", 2016-03-10) claimed that, On Q35 machine types that QEMU intends

[edk2-devel] [PATCH for-edk2-stable201905 3/6] Revert "OvmfPkg/PlatformPei: hoist PciBase assignment above the i440fx/q35 branching"

This reverts commit 9a2e8d7c65ef7f39c6754d27e52954b616bc6628. The original fix for triggered a bug / incorrect assumption in QEMU. QEMU assumes that the PCIEXBAR is below the 32-bit PCI window, not above it. When the firmware doesn't satisfy

[edk2-devel] [PATCH for-edk2-stable201905 4/6] Revert "OvmfPkg/PlatformPei: assign PciSize on both i440fx/q35 branches explicitly"

This reverts commit 60e95bf5094fbb9b728729ccfaf32184b3662317. The original fix for triggered a bug / incorrect assumption in QEMU. QEMU assumes that the PCIEXBAR is below the 32-bit PCI window, not above it. When the firmware doesn't satisfy

[edk2-devel] [PATCH for-edk2-stable201905 1/6] Revert "OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits clear"

This reverts commit 39b9a5ffe6618b7870be2a54fe7725000249c33a. The original fix for triggered a bug / incorrect assumption in QEMU. QEMU assumes that the PCIEXBAR is below the 32-bit PCI window, not above it. When the firmware doesn't satisfy

[edk2-devel] [PATCH for-edk2-stable201905 2/6] Revert "OvmfPkg/PlatformPei: reorder the 32-bit PCI window vs. the PCIEXBAR on q35"

This reverts commit 75136b29541b0e093a51d2e2c2af8d19855c2b60. The original fix for triggered a bug / incorrect assumption in QEMU. QEMU assumes that the PCIEXBAR is below the 32-bit PCI window, not above it. When the firmware doesn't satisfy

[edk2-devel] [PATCH for-edk2-stable201905 0/6] work around a QEMU issue triggered by the original TianoCore#1814 fix

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1859 Repo: https://github.com/lersek/edk2.git Branch: exbar_mtrr_bz_1859 The fix (commit range 3b7a897cd8e3..39b9a5ffe661) for is technically correct, but it tickles an (arguably

Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei

On Wed, May 29, 2019 at 03:01:12PM +, Gao, Zhichao wrote: > I just update the date of copyright. And the code in Mu project didn't add > its own copyright. > If it is required, I would add it for them. Well, hopefully Microsoft will add their own copyright to the original :) Although it

Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei

No. Please don't touch copyright if you doesn't change the file. > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, May 29, 2019 11:01 PM > To: Leif Lindholm ; devel@edk2.groups.io > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ;

Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/Secure96Dxe: redefine LS connector CS as platform property

On Wed, May 29, 2019 at 03:14:48PM +0200, Ard Biesheuvel wrote: > On Wed, 29 May 2019 at 15:06, Leif Lindholm wrote: > > > > On Wed, May 29, 2019 at 02:50:19PM +0200, Ard Biesheuvel wrote: > > > As opposed to the Secure96's I2C peripherals, whose bus addresses are > > > properties of the

Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

Urgh, sorry, saw this was still stuck in my review queue. Mike, one question for you inline below. Oh, and one here - what's your take on maintainership for ARM-based Intel platforms? Fall back to top-level maintainers and add Tien Hock as reviewer? On Thu, May 09, 2019 at 04:55:47PM +0800,

[edk2-devel] [PATCH] IntelFsp2Pkg/FspSplitBin.py: Support rebasing 1.x binary.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1308 Support rebasing FSP 1.X binary. Test: both FSP 2.X (Kabylake) and FSP 1.X (BroadwellDE) binary can be rebased successfully. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu ---

Re: [edk2-devel] [Patch V3 0/2] BaseTools: Add a checking for Sources section in INF file [Part 0/2]

Christian: I have two comments on the commit messages. 1. List the change version only in the cover letter. There is no V2, V3 in patch commit message. 2. Update patch commit message for this patch change. Don't use Part1, Part2. Thanks Liming > -Original Message- > From:

Re: [edk2-devel] [Patch V3 2/2] BaseTools: Add a checking for Sources section in INF file [Part 2/2]

Please review. Bump. >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Christian Rodriguez >Sent: Friday, May 24, 2019 7:40 AM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >; Zhu, Yonghong >Subject: [edk2-devel] [Patch V3 2/2]

Re: [edk2-devel] [Patch V3 1/2] BaseTools: Add a checking for Sources section in INF file [Part 1/2]

Please review. Bump. >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Christian Rodriguez >Sent: Friday, May 24, 2019 7:40 AM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >; Zhu, Yonghong >Subject: [edk2-devel] [Patch V3 1/2]

Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/Secure96Dxe: redefine LS connector CS as platform property

On Wed, May 29, 2019 at 02:50:19PM +0200, Ard Biesheuvel wrote: > As opposed to the Secure96's I2C peripherals, whose bus addresses are > properties of the peripherals themselves, the SPI CS address of the > TPM is a property of the platform that incorporates the LS connector. > > So tweak the

[edk2-devel] [PATCH edk2-platforms 3/5] Platform/Secure96Dxe: redefine LS connector CS as platform property

As opposed to the Secure96's I2C peripherals, whose bus addresses are properties of the peripherals themselves, the SPI CS address of the TPM is a property of the platform that incorporates the LS connector. So tweak the macros that emit the CS values and related properties to put it under the

[edk2-devel] [PATCH edk2-platforms 2/5] Silicon/SynQuacer: add ACPI description of second SPI controller

The primary SPI controller on SynQuacer is reserved for the NOR flash, and is not exposed to the OS. The second SPI controller is wired to the low speed 96boards connector on DeveloperBox, and so in order to use it, we must describe it to the OS (like we already do in the device tree). So add the

[edk2-devel] [PATCH edk2-platforms 4/5] Platform/Secure96Dxe: add TPM description to SSDT

Add a description of the Secure96's TPM over SPI to the SSDT that is exposed to the OS by the Secure96Dxe driver. Signed-off-by: Ard Biesheuvel --- Platform/96Boards/Secure96Dxe/Secure96.asl | 12 Platform/96Boards/Secure96Dxe/Secure96.h | 4 2 files changed, 16

[edk2-devel] [PATCH edk2-platforms 0/5] SynQuacer SPI/TPM support

This is the first part of a set of changes to support the Secure96 TPM on SynQuacer. This part only concerns usage by the OS of the TPM, i.e., exposing the SPI controller and TPM peripherals correctly via DT and ACPI. Wiring up the TPM into UEFI requires more intrusive changes, and this is a work

[edk2-devel] [PATCH edk2-platforms 1/5] Silicon/SynQuacer: add missing SPI controller interrupt lines to DT

Update the DT description of the second SPI controller with the TX, RX and fault interrupt lines as they are assigned on SynQuacer. Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git

[edk2-devel] [PATCH 1/4] MdeModulePkg: Add SERIAL_DXE_FILE_GUID

SERIAL_DXE_FILE_GUID is used in different places, create a single define that other can use. Suggested-by: Laszlo Ersek Signed-off-by: Anthony PERARD --- Notes: Suggested in: Message-ID: <7d6adf5d-baca-7e9c-68ef-2f8479bbd...@redhat.com> MdeModulePkg/MdeModulePkg.dec | 3 +++

[edk2-devel] [PATCH 4/4] UefiPayloadPkg/PlatformBootManagerLib: Use SERIAL_DXE_FILE_GUID from MdeModulePkg

SERIAL_DXE_FILE_GUID is now defined in MdeModulePkg, simply use it. Signed-off-by: Anthony PERARD --- .../Library/PlatformBootManagerLib/PlatformConsole.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH 2/4] ArmVirtPkg/PlatformBootManagerLib: Use SERIAL_DXE_FILE_GUID from MdeModulePkg

SERIAL_DXE_FILE_GUID is now defined in MdeModulePkg, simply use it. Signed-off-by: Anthony PERARD --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c

[edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

The macro SERIAL_DXE_FILE_GUID is already been defined twice and the GUID is been used once without defining the macro. This patch series define the macro in MdeModulePkg where the SerialDxe is, and replace all other use by this new one. Note that I haven't build/test those changes, but I have

Re: [edk2-devel] [PATCH] Maintainers.txt: update mailing list information

On Tue, May 28, 2019 at 02:03:26PM +0200, Laszlo Ersek wrote: > On 05/28/19 12:22, Leif Lindholm wrote: > > The devel mailing list has moved from 01.org to groups.io - update > > the mailing list information to reflect this. > > > > Signed-off-by: Leif Lindholm > > --- > > Maintainers.txt | 2

Re: [edk2-devel] [PATCH v2] BaseTools:Extend the binary cache to support library cache

On Wed, May 29, 2019 at 09:46:54AM +0800, Steven Shi wrote: > V2 change: > Simplify the library cache implementation and remove > CacheRestored flag based filter. Use the current > CanSkipbyHash() filter in AddDependency() instead. > > V1 change: Please don't put change notices in the commit

Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei

On Wed, May 29, 2019 at 08:45:55AM +0800, Gao, Zhichao wrote: > From: Bret Barkelew If this code is from Microsoft... > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 > > Sperate the capsule check function from GetCapsuleDescriptors > and name it to AreCapsulesStaged. > Rename

Re: [edk2-devel] [PATCH] Marvell/Armada80x0McBin: Enable usb keyboard, nvme boot

On Tue, May 28, 2019 at 06:43:13PM -0500, Jeremy Linton wrote: > Add a USB keyboard flag, which is needed when a graphical console > is enabled. Also add a nvme boot option for users that choose > that instead of sata or mmc. > > Contributed-under: TianoCore Contribution Agreement 1.1 Just a

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Maintainers.txt: add reviewer for Marvell platforms

On Tue, 28 May 2019 at 11:24, Marcin Wojtas wrote: > > Hi Leif, > > wt., 28 maj 2019 o 12:20 Leif Lindholm napisał(a): > > > > Marcin is the author of the majority of the Marvell platform support in > > the tree, so clarify that he should be cc:d on patches to Marvell Armada > > SoC/Boards and

[edk2-devel] [PATCH v5 9/9] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL internally redefines the size of HMAC_CTX at crypto/hmac/hmac_lcl.h(OpenSSL commit e0810e35). Ref: https://github.com/openssl/openssl/pull/4338 We should not use it directly and should remove relevant

[edk2-devel] [PATCH v5 7/9] CryptoPkg/OpensslLib: Add functions for upgrading OpenSSL1_1_1b

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 * From OpenSSL_1_1_0i(97c0959f27b294fe1eb10b547145ebef2524b896) to OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687), OpenSSL updated DRBG / RAND to request nonce and additional low entropy randomness from system(line 229

[edk2-devel] [PATCH v5 3/9] CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 This is for the upcoming upgrade to OpenSSL_1_1_1b Compiler optimization(Visual Studio) may automatically use _ftol2 instead of some type conversion. For example: OpensslLib.lib(drbg_lib.obj) : error LNK2001: unresolved external

[edk2-devel] [PATCH v5 5/9] CryptoPkg/OpensslLib: Fix cross-build problem for AARCH64

From: Laszlo Ersek BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Thanks Laszlo Ersek . Ref: https://edk2.groups.io/g/devel/message/40375 Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu Reviewed-by: Laszlo Ersek --- CryptoPkg/Library/Include/sys/syscall.h | 11 +++ 1

[edk2-devel] [PATCH v5 8/9] CryptoPkg: Upgrade OpenSSL to 1.1.1b

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 * Update OpenSSL submodule to OpenSSL_1_1_1b OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687) * Run process_files.pl script to regenerate OpensslLib[Crypto].inf and opensslconf.h * Remove -DNO_SYSLOG from OPENSSL_FLAGS in

[edk2-devel] [PATCH v5 2/9] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 When running process_files.py to configure OpenSSL, we can exclude some unnecessary files. This can reduce porting time, compiling time and library size. Upstream OpenSSL commit 71a5516dcc8a which was as part of OpenSSL_1_1_1b, Add the

[edk2-devel] [PATCH v5 6/9] CryptoPkg: Fix possible build problem with Clang

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 When building CryptoPkg with Clang, blow error may result * /usr/lib/llvm-3.8/lib/clang/3.8.0/include/stdatomic.h:105:17: error: unknown type name 'wchar_t' Since the C native atomics are C11 feature we can explicitly use C99 to work

[edk2-devel] [PATCH v5 4/9] CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Disable warning for building OpenSSL_1_1_1b add /wd4132 /wd4700 /wd4310 for Visual Studio in OpensslLib[Crypto].inf add -Wno-error=unused-but-set-variable for GCC in OpensslLib[Crypto].inf Although this option is set in some build

[edk2-devel] [PATCH v5 0/9] Crypto: Upgrade OpenSSL to 1.1.1b

This series is also avaiable at: https://github.com/xiaoyuxlu/edk2/commits/bz_1089_upgrade_to_openssl_1_1_1b_v5 Change since v4: 1. Split "[PATCH v4 6/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b" patch into two. a. CryptoPkg/OpensslLib: Add functions for upgrading OpenSSL1_1_1b b. CryptoPkg:

[edk2-devel] [PATCH v5 1/9] CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL configure mechanism use --with-rand-seed=xxx option to configure random number generation. OpenSSL_1_1_0j(74f2d9c1ec5f5510e1d3da5a9f03c28df0977762) we use default --with-rand-seed=os option to for building it. But

Re: [edk2-devel] OVMF and SMBIOS

On 28/05/2019 18:06, Laszlo Ersek wrote: > On 05/28/19 17:18, Tomas Pilar (tpilar) wrote: >> Hi, >> >> I am trying to create kvm instance using libvirt and Qemu and OVMF that also >> has SMBIOS included. My current version of Qemu only supports type 0 and >> type 1 SMBIOS tables so I specify

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

The Dict parameter is not used in this function, I will enter an BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1858 to clean up the unused parameters Any question, please let me know. Thanks. Best Regards Fan Zhiju > -Original Message- > From: Feng, Bob C > Sent: Wednesday,

[edk2-devel] [PATCH V2] BaseTools:add UniTool.py to Edk2\BaseTools\Scripts

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files

[edk2-devel] [Patch v2 1/3] [edk2-platforms] Platform/Intel/DebugFeaturePkg: Add DebugFeaturePkg

Add new package DebugFeaturePkg in Platform/Intel/ folder. It will keep debug related features in this package. Signed-off-by: Eric Dong Cc: Liming Gao --- Maintainers.txt | 4 .../Intel/DebugFeaturePkg/DebugFeaturePkg.dec | 19 +++

[edk2-devel] [Patch v2 3/3] [edk2-platforms] Platform/Intel/DebugFeaturePkg/AcpiDebug: Change AcpiDebug module location.

Move AcpiDebug module from AdvancedFeaturePkg to DebugFeaturePkg. Signed-off-by: Eric Dong Cc: Liming Gao --- .../Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec | 6 -- .../Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 --- .../AcpiDebug/AcpiDebug.asl |

[edk2-devel] [Patch v2 0/3] [edk2-platforms] Add DebugFeaturePkg to keep debug related modules.

Add new package in Platform/Intel/ folder to keep debug related modules. V2 change: Use one gDebugFeaturePkgTokenSpaceGuid for all PCDs in this package. Make PCD TokenNumber continuous. Signed-off-by: Eric Dong Cc: Liming Gao Eric Dong (3): Platform/Intel/DebugFeaturePkg: Add

Re: [edk2-devel] [FdfSpecification Patch] FDF spec: Fix the issue in Rule section for RAW Type File

Patch looks fine. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao Sent: Tuesday, May 28, 2019 11:24 PM To: devel@edk2.groups.io Subject: [edk2-devel] [FdfSpecification Patch] FDF spec: Fix the issue in Rule

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

Hi Zhiju, For the changes, -def __InfParse__(self, Dict = {}): +def __InfParse__(self, Dict = None, IsGenFfs=False): and -def GetFileList(FfsInf, FileType, FileExtension, Dict = {}, IsMakefile=False): +def GetFileList(FfsInf, FileType, FileExtension, Dict = None,

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

Tested-by: Liming Gao >-Original Message- >From: Fan, ZhijuX >Sent: Wednesday, May 29, 2019 1:30 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [PATCH V5] BaseTools:Make BaseTools support new rules to >generate RAW FFS FILE >

Re: [edk2-devel] [Patch 0/3] [edk2-platforms] Add DebugFeaturePkg to keep debug related modules.

Eric: I have some comments. 1. DebugFeaturePkg DEC/DSC header description should be DebugFeaturePkg instead of DebugAdvancedFeaturePkg 2. DebugFeaturePkg can have one gDebugFeaturePkgTokenSpaceGuid for all PCDs . You don't need to add another gEfiUsb3DebugPortTokenSpaceGuid. 3. Please make

Re: [edk2-devel] [PATCH] BaseTools/Capsule: Tool to Generate Windows Firmware Update Driver

Hi Eric, Please use "with" statement for the open() calls. For example, Replace: Fd = open("file","w") Do something Fd.close To: With open("file","w") as fd: Do something Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]

Re: [edk2-devel] [PATCH] BaseTools:add UniTool.py to Edk2\BaseTools\Scripts

Zhiju, Please use with statement for the open() calling. Thanks, Bob -Original Message- From: Fan, ZhijuX Sent: Wednesday, May 29, 2019 2:09 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:add UniTool.py to Edk2\BaseTools\Scripts

[edk2-devel] [PATCH] BaseTools:add UniTool.py to Edk2\BaseTools\Scripts

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. This script can be run in both Py2 and Py3. Cc: Bob Feng Cc: