Re: [edk2-devel] [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-08 Thread Loh, Tien Hock
> -Original Message- > From: Kinney, Michael D > Sent: Friday, August 9, 2019 3:50 AM > To: Leif Lindholm ; Loh, Tien Hock > ; Kinney, Michael D > > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel > > Subject: RE: [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform

[edk2-devel] [PATCH] SourceLevelDebugPkg DebugCommLibUsb3: Address NULL ptr dereference case

2019-08-08 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2051 Original code GetConfigTable for AddrPtr first, if failed, InstalConfigTable with allocated AddrPtr. So the AddrPtr should not be NULL and the NULL pointer dereference case should be false positive. This patch is just to address the case

Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg/BaseCryptLib: Wrap OpenSSL HKDF algorithm

2019-08-08 Thread Wang, Jian J
Pushed at 4b1b7c1913092d73d689d8086dcfa579c0217dc8 Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Tuesday, August 06, 2019 10:02 AM > To: West, Gary ; devel@edk2.groups.io > Cc: Ye, Ting > Subject: Re:

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Bob Feng
Thanks for your response. I'm going to push this patch set late today, if there is no more comments. Thanks, Bob -Original Message- From: Gao, Liming Sent: Friday, August 9, 2019 8:50 AM To: devel@edk2.groups.io; ler...@redhat.com; Feng, Bob C ; leif.lindh...@linaro.org Cc: Andrew

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Liming Gao
Bob: I have no comments for this patch set. I am OK to add it for 201908 stable tag. Ack-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Friday, August 9, 2019 7:29 AM > To: Feng,

[edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.

2019-08-08 Thread Nate DeSimone
The build for KabylakeOpenBoardPkg is presently broken due to WORKSPACE_PLATFORM_BIN being defined to a marco of the same name in KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg Setting this macro to an empty string resolves the issue. Cc: Chasel Chiu Cc: Michael Kubacki Signed-off-by: Nate

[edk2-devel] [edk2-platforms: PATCH v2 0/1] Platform/RPi3: Report device tree

2019-08-08 Thread Michael Brown
On 06/08/2019 18:07, Leif Lindholm wrote: > Happy with all of this, except for the use of EFI_DEVICE_ERROR. > > Generally, EFI_DEVICE_ERROR is used as an i/o error type status. > Either EFI_NOT_FOUND, EFI_INVALID_PARAMETER or EFI_OUT_OF_RECOURCES > would be more appropriate when referring to

[edk2-devel] [edk2-platforms: PATCH v2 1/1] Platform/RPi3: Report device tree modification errors using Print()

2019-08-08 Thread Michael Brown
Most functions in FdtDxe currently return VOID and report errors using only DEBUG. Update functions to return EFI_STATUS and report errors using Print() so that errors are at least visible in non-debug builds. Signed-off-by: Michael Brown --- .../RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 102

Re: [edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Thursday, 8 August 2019 #cal-cancelled

2019-08-08 Thread Stephano Cetola
No submissions this week. We took any 'open items' in Bug Triage, so ping me if you missed it and have anything you'd like to discuss. Cheers, Stephano On Thu, Aug 8, 2019 at 5:44 PM devel@edk2.groups.io Calendar wrote: > > Cancelled: TianoCore Design Meeting - APAC/NAMO > > This event has

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Thursday, 8 August 2019 #cal-cancelled

2019-08-08 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.14...@groups.io DTSTAMP:20190809T004426Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@intel.com

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style

2019-08-08 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, August 8, 2019 3:55 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style > > 1. Update CPUStatus to CpuStatus in

Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch

2019-08-08 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Nate DeSimone > Sent: Thursday, August 8, 2019 2:31 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Laszlo Ersek ; > Leif Lindholm ; Kinney, Michael D > ;

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 08/08/2019 5:00pm-5:30pm #cal-reminder

2019-08-08 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 8 August 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/251103409 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=460285 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Laszlo Ersek
On 08/09/19 00:18, Laszlo Ersek wrote: > On 08/08/19 17:38, Feng, Bob C wrote: >> Hi Laszlo and Leif, >> >> Thanks for you detailed testing and comments. >> >> I'd like to explain the failure of the test 3#. I can reproduce the failure >> with your steps and I found this failure can also be

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-08 Thread Laszlo Ersek
On 08/08/19 23:15, Andrew Fish wrote: > > >> On Aug 8, 2019, at 2:08 PM, Michael D Kinney >> wrote: >> >> Laszlo, >> >> This sounds like a good improvement. >> >> Do you have a recommended set of settings you would like >> to see checked in to the root of each EDK II related >> repository

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Laszlo Ersek
On 08/08/19 17:38, Feng, Bob C wrote: > Hi Laszlo and Leif, > > Thanks for you detailed testing and comments. > > I'd like to explain the failure of the test 3#. I can reproduce the failure > with your steps and I found this failure can also be reproduced without > multiple process autogen

[edk2-devel] [PATCH] IntelSiliconPkg-Vtd: A new PMR interface

2019-08-08 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Platforms may request no overlap between PMR regions and system reserve memory. Create an interface to control PLMR/PHMR regions. It allows silicon code to

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-08 Thread Andrew Fish via Groups.Io
> On Aug 8, 2019, at 2:08 PM, Michael D Kinney > wrote: > > Laszlo, > > This sounds like a good improvement. > > Do you have a recommended set of settings you would like > to see checked in to the root of each EDK II related > repository that would be required settings for all EDK II >

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-08 Thread Michael D Kinney
Laszlo, This sounds like a good improvement. Do you have a recommended set of settings you would like to see checked in to the root of each EDK II related repository that would be required settings for all EDK II developers. Do you want to enter a BZ and prepare a patch with this new file for

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-08 Thread Laszlo Ersek
On 08/07/19 21:42, Jordan Justen wrote: > I thought adding Laszlo's settings > to .gitattributes might amount to solving two issues with one change. Independently of the present patch, I would be very much in favor of tracking a .gitattributes file in the project root dir, *if* we could also

Re: [edk2-devel] [PATCH 4/4] MdeModulePkg/UfsPassThruDxe: Implement EDKII_UFS_HC_PLATFORM_PROTOCOL

2019-08-08 Thread Albecki, Mateusz
Hi, Yes that is bug. It should be placed before return EFI_SUCCESS. I will fix it in v2. Thanks, Mateusz > -Original Message- > From: Wu, Hao A > Sent: Thursday, August 8, 2019 4:37 AM > To: Albecki, Mateusz ; devel@edk2.groups.io > Subject: RE: [PATCH 4/4] MdeModulePkg/UfsPassThruDxe:

Re: [edk2-devel] [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

2019-08-08 Thread Nate DeSimone
Agreed with Chasel and Star. Once copyright is extended: Reviewed-by: Nate DeSimone -Original Message- From: Zeng, Star Sent: Thursday, August 8, 2019 7:56 AM To: Chiu, Chasel ; Zhang, Shenglei ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: RE: [PATCH 3/3]

Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template

2019-08-08 Thread Laszlo Ersek
On 08/08/19 11:55, Leif Lindholm wrote: > Hi Shenglei, > > On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote: >> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35 >> in tools_def.template. These tool chains are for ARM and AARCH64 only. >> There is no change recently and

Re: [edk2-devel] [PATCH 3/4] MdeModulePkg/UfsPassThruDxe: Refactor private data to use EDKII_UFS_HC_INFO

2019-08-08 Thread Albecki, Mateusz
Hi, Sure I agree. That was my original intention and then I forgot to add goto Error. Thanks, Mateusz > -Original Message- > From: Wu, Hao A > Sent: Thursday, August 8, 2019 4:37 AM > To: devel@edk2.groups.io; Albecki, Mateusz > Subject: RE: [edk2-devel] [PATCH 3/4]

Re: [edk2-devel] [PATCH 0/4] Build cache enhancement

2019-08-08 Thread Laszlo Ersek
On 08/08/19 14:25, Steven Shi wrote: > From: "Shi, Steven" > > Enhance the edk2 build cache with below patches: > Patch 01/04: Improve the cache hit rate through new cache checkpoint and hash > algorithm > Patch 02/04: Print more info to explain why a module build cache miss > Patch 03/04: Fix

Re: [edk2-devel] [PATCH V3 03/15] ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file

2019-08-08 Thread Leif Lindholm
On Thu, Aug 08, 2019 at 10:21:16PM +0200, Laszlo Ersek wrote: > On 08/08/19 03:08, Zhichao Gao wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 > > > > ResetUtilityLib would be consumed by CapsuleRuntimeDxe. > > So add it for the platform dsc file. > > > > Cc: Laszlo Ersek >

Re: [edk2-devel] [Patch] MdeModulePkg RegularExpressionDxe: Update Oniguruma from v6.9.0 to v6.9.3

2019-08-08 Thread Laszlo Ersek
On 08/08/19 15:52, Gao, Liming wrote: > Hi, all > This patch is big. I upload it into > https://github.com/lgao4/edk2/tree/Oniguruma6.9.3 for your review. > > Hi, Stewards: >Oniguruma version v6.9.3 is released for security fix. So, I plan to > include this update for 201908 stable tag.

Re: [edk2-devel] [PATCH v4 29/35] OvmfPkg/OvmfXen: Override PcdFSBClock to Xen vLAPIC timer frequency

2019-08-08 Thread Laszlo Ersek
On 08/08/19 15:44, Roger Pau Monné wrote: > On Thu, Aug 08, 2019 at 02:28:32PM +0100, Anthony PERARD wrote: >> On Wed, Aug 07, 2019 at 05:54:51PM +0200, Roger Pau Monné wrote: >>> On Mon, Jul 29, 2019 at 04:39:38PM +0100, Anthony PERARD wrote: PcdFSBClock is used by SecPeiDxeTimerLibCpu, the

Re: [edk2-devel] [edk2-platforms][PATCH V1 2/2] KabylakeOpenBoardPkg: Fix duplicate GUID in DSC

2019-08-08 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Wednesday, August 7, 2019 2:15 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms][PATCH V1 2/2] KabylakeOpenBoardPkg: Fix duplicate GUID in DSC

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] ClevoOpenBoardPkg: Fix duplicate GUID in DSC

2019-08-08 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Wednesday, August 7, 2019 2:15 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms][PATCH V1 1/2] ClevoOpenBoardPkg: Fix duplicate GUID in DSC

Re: [edk2-devel] [PATCH V3 03/15] ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file

2019-08-08 Thread Laszlo Ersek
On 08/08/19 03:08, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 > > ResetUtilityLib would be consumed by CapsuleRuntimeDxe. > So add it for the platform dsc file. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Liming Gao > Signed-off-by:

Re: [edk2-devel] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Clean up useless parameter.

2019-08-08 Thread Laszlo Ersek
On 08/08/19 15:24, Eric Dong wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060 > > Remove the useless parameter. > > Signed-off-by: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > --- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [edk2-devel] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Clean up useless parameter.

2019-08-08 Thread Laszlo Ersek
On 08/08/19 15:24, Eric Dong wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060 > > Remove the useless parameter. > > Signed-off-by: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > --- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 1 - >

Re: [edk2-devel] [Patch v6 1/9] OvmfPkg/PlatformPei: Change referenced MSR name.

2019-08-08 Thread Laszlo Ersek
On 08/08/19 08:24, Dong, Eric wrote: > Change referenced MSR name to avoid later build failure. > > Signed-off-by: Eric Dong > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > --- > OvmfPkg/PlatformPei/FeatureControl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [edk2-devel] [PATCH 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers

2019-08-08 Thread Laszlo Ersek
On 08/08/19 04:37, Wu, Hao A wrote: > Dear stewards and Liming, > > Sorry for top-posting. > > I plan to add the below new feature which is targeting for the upcoming > edk2-stable201908 tag: > > * Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming > of UFS host

Re: [edk2-devel] [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-08 Thread Michael D Kinney
Tien Hock, I have a few comments: 1) Recommend change name of directory Platform/Intel/Startix10 -> Platform/Intel/Startix10SocPkg. 2) S10ClockManager.c is missing file header with license and copyright 3) S10ClockManager.h is missing file header with license and copyright 4)

Re: [edk2-devel] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message.

2019-08-08 Thread Laszlo Ersek
On 08/07/19 19:17, Rebecca Cran wrote: > On 2019-08-05 00:43, Dong, Eric wrote: >> This debug message may be called by BSP and APs. It may >> caused ASSERT when APs call this debug code. >> >> In order to avoid system boot assert, Remove this debug >> message. >> >> Signed-off-by: Eric Dong >>

Re: [edk2-devel] [tianocore-docs EDK_II_Secure_Coding_Guide PATCH] Add Appendix: Threat Mode for EDK II.

2019-08-08 Thread Laszlo Ersek
On 08/07/19 19:59, Zimmer, Vincent wrote: > Laurie created > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Security-White-Papers > for the security collateral. Awesome, thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH] Extened PMR feature: allow silicon code to adjust PLMR/PHMR region base on the project needs

2019-08-08 Thread Wang, Iwen Evelyn
Hi Jiewen, 1) We updated the license header. Evelyn: I'm aware of this license header change, and I think I already follow the new format. I will confirm it again. 2) We moved the IntelSiliconPkg from edkii repo to edkii-platform repo. Evelyn: I'm aware of it as well, and before

[edk2-devel] [PATCH] Extened PMR feature: allow silicon code to adjust PLMR/PHMR region base on the project needs

2019-08-08 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Some platforms may request no overlap between PMR regions and system reserve memory regions. Create an interface to control PLMR/PHMR regions. 2)

[edk2-devel] [PATCH] Extended PMR feature: allow silicon code to adjust PLMR/PHMR region base on the project needs

2019-08-08 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Some platforms may request no overlap between PMR regions and system reserve memory regions. Create an interface to control PLMR/PHMR regions. 2)

[edk2-devel] [PATCH] Extened PMR feature: allow silicon code to adjust PLMR/PHMR region base on the project needs

2019-08-08 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Some platforms may request no overlap between PMR regions and system reserve memory regions. Create an interface to control PLMR/PHMR regions. 2)

[edk2-devel] [PATCH] Extened PMR feature: allow platfrom code to adjust PLMR/PHMR region base on the project needs

2019-08-08 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Some platforms may request no overlap between PMR regions and system reserve memory regions. Create an interface to control PLMR/PHMR regions. 2)

Re: [edk2-devel] [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support

2019-08-08 Thread Leif Lindholm
On Thu, Aug 08, 2019 at 07:05:29PM +0200, Marcin Wojtas wrote: > > On a higher level, I confess to not being entirely convinced about the > > triplicate .dsc/.dsc.inc/.fdf.inc setup. (Of the three, the .dsc.inc > > is the one I object the least to.) > > For the .dscs, I understand the desire to

Re: [edk2-devel] static data in dxe_runtime modules

2019-08-08 Thread Laszlo Ersek
On 08/07/19 19:41, Andrew Fish wrote: > > >> On Aug 7, 2019, at 10:29 AM, Laszlo Ersek wrote: >> >> ummm... not sure why, but I never got this email in my inbox. I only see >> it in my list folder. I see myself addressed on it as: >> >> Laszlo Ersek via Groups.Io >

Re: [edk2-devel] [[edk2-platforms]PATCH v5 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-08 Thread Michael D Kinney
Leif, Please add you and I as Maintainers and Tien Hock as a Reviewer. Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, July 19, 2019 6:35 AM > To: Loh, Tien Hock > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard > Biesheuvel ; Kinney,

Re: [edk2-devel] [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support

2019-08-08 Thread Marcin Wojtas
czw., 8 sie 2019 o 18:48 Leif Lindholm napisał(a): > > Hi Marcin. > > On Thu, Aug 08, 2019 at 03:51:15PM +0200, Marcin Wojtas wrote: > > > > This patchset adds all necessary components (.dsc/.fdf, > > > > libraries, ACPI, DT) to support all 3 variants, which > > > > are available on a modular

Re: [edk2-devel] [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support

2019-08-08 Thread Leif Lindholm
Hi Marcin. On Thu, Aug 08, 2019 at 03:51:15PM +0200, Marcin Wojtas wrote: > > > This patchset adds all necessary components (.dsc/.fdf, > > > libraries, ACPI, DT) to support all 3 variants, which > > > are available on a modular CN913x Development Board. > > > > Thanks for this contribution. > >

Re: [edk2-devel] [PATCH edk2-platforms v3 0/3] Robust Netsec Initialiation

2019-08-08 Thread Leif Lindholm
On Thu, Aug 08, 2019 at 09:23:32PM +0900, Masahisa Kojima wrote: > This patch series is bugfix for the hang-up issue in Netsec driver. > > Some linux distributions such as Ubuntu power down the ethernet phy > in reboot. In this case, Netsec initialization fails and > system hungs. > > This patch

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Bob Feng
Hi Laszlo and Leif, Thanks for you detailed testing and comments. I'd like to explain the failure of the test 3#. I can reproduce the failure with your steps and I found this failure can also be reproduced without multiple process autogen patch set. I debugged and found this failure is due

Re: [edk2-devel] [PATCH v4 35/35] OvmfPkg/OvmfXen: use RealTimeClockRuntimeDxe from EmbeddedPkg

2019-08-08 Thread Roger Pau Monné
On Thu, Aug 08, 2019 at 03:03:48PM +0100, Anthony PERARD wrote: > On Wed, Aug 07, 2019 at 06:09:57PM +0200, Roger Pau Monné wrote: > > On Mon, Jul 29, 2019 at 04:39:44PM +0100, Anthony PERARD wrote: > > > A Xen PVH guest doesn't have a RTC that OVMF would expect, so > > >

Re: [edk2-devel] [PATCH v4 29/35] OvmfPkg/OvmfXen: Override PcdFSBClock to Xen vLAPIC timer frequency

2019-08-08 Thread Roger Pau Monné
On Thu, Aug 08, 2019 at 03:26:41PM +0100, Anthony PERARD wrote: > On Thu, Aug 08, 2019 at 03:44:23PM +0200, Roger Pau Monné wrote: > > On Thu, Aug 08, 2019 at 02:28:32PM +0100, Anthony PERARD wrote: > > > On Wed, Aug 07, 2019 at 05:54:51PM +0200, Roger Pau Monné wrote: > > > > On Mon, Jul 29, 2019

Re: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard

2019-08-08 Thread Michael D Kinney
Hi Gary, Thanks for the additional information. I will investigate when it was introduced. The patch series looks good. Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of Gary Lin > Sent: Thursday, August

Re: [edk2-devel] [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

2019-08-08 Thread Zeng, Star
Same with Chasel. Reviewed-by: Star Zeng . > -Original Message- > From: Chiu, Chasel > Sent: Thursday, August 8, 2019 2:59 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header

Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF

2019-08-08 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Gao, Zhichao > Sent: Thursday, August 08, 2019 1:59 AM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: Carsey, Jaben ; Ni, Ray > Subject: RE: [edk2-devel] [PATCH 2/3] > ShellPkg/UefiShellAcpiViewCommandLib: Add

Re: [edk2-devel] [Patch] MdeModulePkg RegularExpressionDxe: Update Oniguruma from v6.9.0 to v6.9.3

2019-08-08 Thread Leif Lindholm
On Thu, Aug 08, 2019 at 01:52:36PM +, Gao, Liming wrote: > Hi, all > This patch is big. I upload it into > https://github.com/lgao4/edk2/tree/Oniguruma6.9.3 for your review. > > Hi, Stewards: >Oniguruma version v6.9.3 is released for security fix. So, I plan to > include this update

Re: [edk2-devel] [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse should be checked

2019-08-08 Thread Carsey, Jaben
That looks good, but I think it would be easier to just do the logic opposite. Cant we just add the ~"if it is NULL, then return" and not have to change anything else? No real need for else in that case since there is a return statement... Hand written pseudo-patch follows: if

Re: [edk2-devel] [PATCH v4 33/35] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

2019-08-08 Thread Anthony PERARD
On Wed, Aug 07, 2019 at 06:07:03PM +0200, Roger Pau Monné wrote: > On Mon, Jul 29, 2019 at 04:39:42PM +0100, Anthony PERARD wrote: > > XenIoPvhDxe use XenIoMmioLib to reserve some space to be use by the > > Grant Tables. > > > > The call is only done if it is necessary, we simply detect if the >

Re: [edk2-devel] [PATCH v4 35/35] OvmfPkg/OvmfXen: use RealTimeClockRuntimeDxe from EmbeddedPkg

2019-08-08 Thread Anthony PERARD
On Wed, Aug 07, 2019 at 06:09:57PM +0200, Roger Pau Monné wrote: > On Mon, Jul 29, 2019 at 04:39:44PM +0100, Anthony PERARD wrote: > > A Xen PVH guest doesn't have a RTC that OVMF would expect, so > > PcatRealTimeClockRuntimeDxe fails to initialize and prevent the > > firmware from finish to boot.

Re: [edk2-devel] [PATCH v4 29/35] OvmfPkg/OvmfXen: Override PcdFSBClock to Xen vLAPIC timer frequency

2019-08-08 Thread Anthony PERARD
On Thu, Aug 08, 2019 at 03:44:23PM +0200, Roger Pau Monné wrote: > On Thu, Aug 08, 2019 at 02:28:32PM +0100, Anthony PERARD wrote: > > On Wed, Aug 07, 2019 at 05:54:51PM +0200, Roger Pau Monné wrote: > > > On Mon, Jul 29, 2019 at 04:39:38PM +0100, Anthony PERARD wrote: > > > > PcdFSBClock is used

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] MinPlatformPkg: Fix duplicate GUID

2019-08-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Wednesday, August 7, 2019 4:34 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] ClevoOpenBoardPkg: Fix duplicate GUID in DSC

2019-08-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Thursday, August 8, 2019 5:15 AM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Gao, Liming > Subject:

Re: [edk2-devel] [Patch] MdeModulePkg RegularExpressionDxe: Update Oniguruma from v6.9.0 to v6.9.3

2019-08-08 Thread Liming Gao
Hi, all This patch is big. I upload it into https://github.com/lgao4/edk2/tree/Oniguruma6.9.3 for your review. Hi, Stewards: Oniguruma version v6.9.3 is released for security fix. So, I plan to include this update for 201908 stable tag. If you have any comments, please let me know.

Re: [edk2-devel] [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support

2019-08-08 Thread Marcin Wojtas
Hi Leif, czw., 8 sie 2019 o 13:51 Leif Lindholm napisał(a): > > Hi Marcin, > > On Thu, Aug 08, 2019 at 01:30:21AM +0200, Marcin Wojtas wrote: > > Hi, > > > > Marvell Octeon CN913X SoC is a new device, which is built of > > upgraded hardware blocks known from previously supported line > > of

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Leif Lindholm
Hi Laszlo, Thanks for looping me in. On Thu, Aug 08, 2019 at 03:08:22PM +0200, Laszlo Ersek wrote: > (+ Andrew, Leif, Mike; Liming) > > On 08/07/19 06:25, Bob Feng wrote: > (3) In my normal edk2 clone, I cleaned the tree, applied your patches > (again on top of commit 96603b4f02b9), and started

Re: [edk2-devel] [PATCH v4 29/35] OvmfPkg/OvmfXen: Override PcdFSBClock to Xen vLAPIC timer frequency

2019-08-08 Thread Roger Pau Monné
On Thu, Aug 08, 2019 at 02:28:32PM +0100, Anthony PERARD wrote: > On Wed, Aug 07, 2019 at 05:54:51PM +0200, Roger Pau Monné wrote: > > On Mon, Jul 29, 2019 at 04:39:38PM +0100, Anthony PERARD wrote: > > > PcdFSBClock is used by SecPeiDxeTimerLibCpu, the TimerLib > > > implementation. It will also

Re: [edk2-devel] [PATCH] Extened PMR feature: allow silicon code to adjust PLMR/PHMR region base on the project needs

2019-08-08 Thread Yao, Jiewen
Hi Evelyn Thanks for the enhancement. However, I fail to apply the patch to the latest tree. Please be aware that: 1) We updated the license header. 2) We moved the IntelSiliconPkg from edkii repo to edkii-platform repo. Would you please pull the latest tree and apply the patch, then send it

Re: [edk2-devel] [PATCH v4 29/35] OvmfPkg/OvmfXen: Override PcdFSBClock to Xen vLAPIC timer frequency

2019-08-08 Thread Anthony PERARD
On Wed, Aug 07, 2019 at 05:54:51PM +0200, Roger Pau Monné wrote: > On Mon, Jul 29, 2019 at 04:39:38PM +0100, Anthony PERARD wrote: > > PcdFSBClock is used by SecPeiDxeTimerLibCpu, the TimerLib > > implementation. It will also be used by XenTimerDxe. Override > > PcdFSBClock to match Xen vLAPIC

[edk2-devel] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Clean up useless parameter.

2019-08-08 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060 Remove the useless parameter. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 1 - .../Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 1 - 2

[edk2-devel] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Clean up useless parameter.

2019-08-08 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060 Remove the useless parameter. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c

[edk2-devel] [Patch 0/2] Clean up useless parmeter.

2019-08-08 Thread Dong, Eric
After commit 02031cfc920e ("UefiCpuPkg/PiSmmCpuDxeSmm: Remove debug message.", 2019-08-06), RegisterCpuFeaturesLib and PiSmmCpuDxeSmm are each left with a useless spinlock called "ConsoleLogLock". This patch serial remove this useless parameter. Eric Dong (2):

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Laszlo Ersek
(+ Andrew, Leif, Mike; Liming) On 08/07/19 06:25, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > In order to improve the build performance, we implemented > multiple-processes AutoGen. This change will reduce 20% time > for AutoGen phase. > > The design document can

[edk2-devel] [PATCH] BaseTools/Scripts: Add GetUtcDateTimer script.

2019-08-08 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067 A script that can return UTC date and time in ascii format which is convenient for patching build time information in any binary. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Chasel Chiu --- BaseTools/Scripts/GetUtcDateTime.py | 47

[edk2-devel] [edk2-platforms: PATCH v3 0/1] Platform/RPi3: Add Debian 10 installation in Systems.md

2019-08-08 Thread Pete Batard
Changes from v2: - Use "on-CPU" rather than "ondie". - Make sure the options to force FAT16 are provided for both Windows and Linux. - Provide a maximum size for FAT16 and add a forward references to the additional notes and the `fdisk` fixup, for people who might still choose FAT32. Pete

[edk2-devel] [edk2-platforms: PATCH v3 1/1] Platform/RPi3: Add Debian 10 installation in Systems.md

2019-08-08 Thread Pete Batard
This documents the installation of vanilla Debian 10.0 ARM64 (netinst), which we validated for both Model B and Model B+. Also fix an erroneous reference in an RPi3.fdf comment. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- Platform/RaspberryPi/RPi3/Readme.md |

[edk2-devel] [PATCH 4/4] BaseTools: Add GenFds multi-thread support in build cache

2019-08-08 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1923 Fix the issue that the GenFds multi-thread will build fail if enable the build cache together. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 23

[edk2-devel] [PATCH 3/4] BaseTools: Change the [Arch][Name] module key in Build cache

2019-08-08 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1951 Current build cache use the module's [self.Arch][self.Name] info as the ModuleAutoGen object key in hash list and dictionary. The [self.Arch][self.Name] is not safe as the module key because there could be two modules

[edk2-devel] [PATCH 2/4] BaseTools: Print first cache missing file for build cachle

2019-08-08 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1925 When a module build cache miss, add support to print the first cache missing file path and name. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 2 ++

[edk2-devel] [PATCH 0/4] Build cache enhancement

2019-08-08 Thread Steven Shi
From: "Shi, Steven" Enhance the edk2 build cache with below patches: Patch 01/04: Improve the cache hit rate through new cache checkpoint and hash algorithm Patch 02/04: Print more info to explain why a module build cache miss Patch 03/04: Fix the unsafe [self.Arch][self.Name] key usage in

[edk2-devel] [PATCH edk2-platforms v3 1/3] NetsecDxe: embed phy address into NETSEC SDK internal structure

2019-08-08 Thread Masahisa Kojima
From: Satoru Okamoto This is a refactoring of phy address handling in Netsec driver. NETSEC SDK, low level driver for NetsecDxe, did not store phy address. User should specify the phy address as an argument to the SDK public functions. It prevented NETSEC SDK from internally controlling phy, and

[edk2-devel] [PATCH edk2-platforms v3 3/3] NetsecDxe: SnpInitialize() waits for media linking up

2019-08-08 Thread Masahisa Kojima
From: Satoru Okamoto The latest NetsecDxe requires issueing phy reset at the last stage of initialization to safely exit loopback mode. However, as a result, it takes a couple of seconds for link state to get stable, which could cause auto-chosen pxeboot to fail due to MediaPresent check error.

[edk2-devel] [PATCH edk2-platforms v3 2/3] NetsecDxe: put phy in loopback mode to guarantee stable RXCLK input

2019-08-08 Thread Masahisa Kojima
From: Satoru Okamoto NETSEC hardware requires stable RXCLK input upon initialization triggered with DISCORE = 0. However, RXCLK input could be unstable depending on phy chipset and deployed network environment, which could cause NETSEC to hang up during initialization. We solve this

[edk2-devel] [PATCH edk2-platforms v3 0/3] Robust Netsec Initialiation

2019-08-08 Thread Masahisa Kojima
This patch series is bugfix for the hang-up issue in Netsec driver. Some linux distributions such as Ubuntu power down the ethernet phy in reboot. In this case, Netsec initialization fails and system hungs. This patch series add the robust netsec initialization, set ethernet phy as loopback mode

Re: [edk2-devel] [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support

2019-08-08 Thread Leif Lindholm
Hi Marcin, On Thu, Aug 08, 2019 at 01:30:21AM +0200, Marcin Wojtas wrote: > Hi, > > Marvell Octeon CN913X SoC is a new device, which is built of > upgraded hardware blocks known from previously supported line > of SoCs. It is avaialble in 3 variants - CN9130/CN9131/CN9132. > > CN9130 is made of

Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template

2019-08-08 Thread Leif Lindholm
On Thu, Aug 08, 2019 at 10:51:54AM +, Gao, Liming wrote: > Leif: > > >-Original Message- > >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > >Sent: Thursday, August 08, 2019 5:55 PM > >To: devel@edk2.groups.io; Zhang, Shenglei > >Cc: Feng, Bob C ; Gao, Liming > >; Ard

Re: [edk2-devel] [PATCH v4 23/35] OvmfPkg/XenPlatformPei: Rework memory detection

2019-08-08 Thread Anthony PERARD
On Wed, Aug 07, 2019 at 05:34:32PM +0200, Roger Pau Monné wrote: > On Mon, Jul 29, 2019 at 04:39:32PM +0100, Anthony PERARD wrote: > > When running as a Xen PVH guest, there is no CMOS to read the memory > > size from. Rework GetSystemMemorySize(Below|Above)4gb() so they can > > work without CMOS

Re: [edk2-devel] [edk2-platforms: PATCH v2] Marvell/Drivers: XenonDxe: Explicitly disable HS400

2019-08-08 Thread Leif Lindholm
On Wed, Aug 07, 2019 at 09:46:12PM +0200, Marcin Wojtas wrote: > On another SoC revision, the capability register marks HS400 support > as enabled. However in case the interface itself is powered with 3.3V > this flag must be unset by the SdMmcOverride protocol callback - > otherwise the generic

Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template

2019-08-08 Thread Liming Gao
Leif: >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Thursday, August 08, 2019 5:55 PM >To: devel@edk2.groups.io; Zhang, Shenglei >Cc: Feng, Bob C ; Gao, Liming >; Ard Biesheuvel ; >Eugene Cohen >Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove

Re: [edk2-devel] [PATCH v4 22/35] OvmfPkg/XenPlatformPei: no hvmloader: get the E820 table via hypercall

2019-08-08 Thread Roger Pau Monné
On Thu, Aug 08, 2019 at 11:41:18AM +0100, Anthony PERARD wrote: > On Wed, Aug 07, 2019 at 05:14:33PM +0200, Roger Pau Monné wrote: > > On Mon, Jul 29, 2019 at 04:39:31PM +0100, Anthony PERARD wrote: > > > When the Xen PVH entry point has been used, hvmloader hasn't run and > > > hasn't prepared an

Re: [edk2-devel] [PATCH v4 20/35] OvmfPkg/XenPlatformPei: Introduce XenPvhDetected

2019-08-08 Thread Roger Pau Monné
On Thu, Aug 08, 2019 at 11:38:13AM +0100, Anthony PERARD wrote: > On Wed, Aug 07, 2019 at 05:03:46PM +0200, Roger Pau Monné wrote: > > On Mon, Jul 29, 2019 at 04:39:29PM +0100, Anthony PERARD wrote: > > > +BOOLEAN > > > +XenPvhDetected ( > > > + VOID > > > + ) > > > +{ > > > + // > > > + //

Re: [edk2-devel] [PATCH v4 22/35] OvmfPkg/XenPlatformPei: no hvmloader: get the E820 table via hypercall

2019-08-08 Thread Anthony PERARD
On Wed, Aug 07, 2019 at 05:14:33PM +0200, Roger Pau Monné wrote: > On Mon, Jul 29, 2019 at 04:39:31PM +0100, Anthony PERARD wrote: > > When the Xen PVH entry point has been used, hvmloader hasn't run and > > hasn't prepared an E820 table. The only way left to get an E820 table > > is to ask Xen

Re: [edk2-devel] [PATCH v4 12/35] OvmfPkg/XenPlatformPei: Grab RSDP from PVH guest start of day struct

2019-08-08 Thread Roger Pau Monné
On Thu, Aug 08, 2019 at 11:26:41AM +0100, Anthony PERARD wrote: > On Wed, Aug 07, 2019 at 04:35:58PM +0200, Roger Pau Monné wrote: > > On Mon, Jul 29, 2019 at 04:39:21PM +0100, Anthony PERARD wrote: > > > Check if there's a start of the day struct provided to PVH guest, save > > > the ACPI RSDP

Re: [edk2-devel] [PATCH v4 12/35] OvmfPkg/XenPlatformPei: Grab RSDP from PVH guest start of day struct

2019-08-08 Thread Anthony PERARD
On Wed, Aug 07, 2019 at 04:35:58PM +0200, Roger Pau Monné wrote: > On Mon, Jul 29, 2019 at 04:39:21PM +0100, Anthony PERARD wrote: > > Check if there's a start of the day struct provided to PVH guest, save > > the ACPI RSDP address for later. > > > > This patch import import

Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template

2019-08-08 Thread Leif Lindholm
Hi Shenglei, On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote: > Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35 > in tools_def.template. These tool chains are for ARM and AARCH64 only. > There is no change recently and they are not used. >

Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF

2019-08-08 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Thursday, August 8, 2019 2:25 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject:

[edk2-devel] Capsule PCI device firmware update, could capsule embedded driver override PCI option ROM driver?

2019-08-08 Thread Lin, Derek (HPS SW)
Hi, I have searched EDK2 devel discussion and Mantis but I couldn't find answer. Recently we found some PCI card vendor release capsule to update device firmware. Background: The PCI card has option ROM which provide FMP service. The capsule has a firmware payload and device driver which also

Re: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard

2019-08-08 Thread Gary Lin
On Thu, Aug 08, 2019 at 07:26:04AM +, Michael D Kinney wrote: > Hi Gary, > Hi Michael, > Thank you for these patches. > > I am seeing one behavior change in the setup forms. > The following 2 forms are missing information that > used to be filled in. I will help look into this >

[edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template

2019-08-08 Thread Zhang, Shenglei
Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35 in tools_def.template. These tool chains are for ARM and AARCH64 only. There is no change recently and they are not used. https://bugzilla.tianocore.org/show_bug.cgi?id=1750 Cc: Bob Feng Cc: Liming Gao Cc: Ard Biesheuvel Cc: Leif

Re: [edk2-devel] [PATCH 00/14] Multiple Controllers Support solution

2019-08-08 Thread Eric Jin
Liming and Dandan, Thank you for the comments. Will follow up. Best Regards Eric -Original Message- From: Gao, Liming Sent: Thursday, August 8, 2019 2:35 PM To: devel@edk2.groups.io; Bi, Dandan ; Jin, Eric Subject: RE: [edk2-devel] [PATCH 00/14] Multiple Controllers Support solution

[edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style

2019-08-08 Thread Zhang, Shenglei
1. Update CPUStatus to CpuStatus in comments to align comments with code. 2. Add "OUT" attribute for "ProcedureArguments" parameter in function header. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang --- v2: Add "OUT" attribute for "ProcedureArguments" parameter

  1   2   >